hugok
/
e16
forked from e16/e16
1
0
Fork 0
Code Pull Requests Activity

Apply double_condition_check.cocci 

The offending projects were:

 E16/e/src/backgrounds.c                 |   10 ++++------
 PROTO/eon/src/lib/layout/eon_stack.c    |    4 +---
 ecore/src/lib/ecore_win32/ecore_win32.c |    3 +--
 ecore/src/lib/ecore_wince/ecore_wince.c |    3 +--
 edje/src/lib/edje_edit.c                |    3 +--
 evas/src/lib/cache/evas_cache_image.c   |    2 +-
 exalt/src/lib/libexalt_private.c        |    2 +-


This patch assumes code in these places were insane and the fix is to remove
one condition check. Most likely this is not true, but there's no automatic fix
for that.

Looking at the patch, it seems that some places should use "x" and "y" vars but
used just one of them and therefore they were caught by coccinelle.




SVN revision: 51666
This commit is contained in:
Lucas De Marchi 2010-08-26 20:45:09 +00:00
parent c7b7bb107e
commit ed721d79ca
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/backgrounds.c
View File

@ -350,8 +350,8 @@ BackgroundCmp(const Background * bg, const Background * bgx)
{
if ((strcmp(bg->bg.file, bgx->bg.file)) ||
(bg->bg.keep_aspect != bgx->bg.keep_aspect) ||
(bg->bg.xjust != bgx->bg.xjust || bg->bg.xjust != bgx->bg.xjust) ||
(bg->bg.xperc != bgx->bg.xperc || bg->bg.xperc != bgx->bg.xperc))
(bg->bg.xjust != bgx->bg.xjust) ||
(bg->bg.xperc != bgx->bg.xperc))
return 1;
}
else if (bg->bg.file || bgx->bg.file)
@ -361,10 +361,8 @@ BackgroundCmp(const Background * bg, const Background * bgx)
{
if ((strcmp(bg->top.file, bgx->top.file)) ||
(bg->top.keep_aspect != bgx->top.keep_aspect) ||
(bg->top.xjust != bgx->top.xjust ||
bg->top.xjust != bgx->top.xjust) ||
(bg->top.xperc != bgx->top.xperc ||
bg->top.xperc != bgx->top.xperc))
(bg->top.xjust != bgx->top.xjust) ||
(bg->top.xperc != bgx->top.xperc))
return 1;
}
else if (bg->top.file || bgx->top.file)