adjust todo - working on fm_main - can't seem to get hal to mount removable

devices with uid=X (X == the users uid) so the user can modify their
removable devices.


SVN revision: 31188
This commit is contained in:
Carsten Haitzler 2007-08-05 23:30:40 +00:00
parent a9ad787fe2
commit 6372896d9d
2 changed files with 29 additions and 24 deletions

3
TODO
View File

@ -44,7 +44,8 @@ Some of the things (in very short form) that need to be done to E17...
* after creating a background with the bg config dialog, we need to be able * after creating a background with the bg config dialog, we need to be able
to change its properties (stretch, tile, center, etc...) to change its properties (stretch, tile, center, etc...)
* fm2 removable devices seem to be mounted as root, not user, thus no write * fm2 removable devices seem to be mounted as root, not user, thus no write -
why don't mount options work?
* fm2 theme needs to not suck * fm2 theme needs to not suck
* fwin initial placement needs to be near icon that spawned the fwin * fwin initial placement needs to be near icon that spawned the fwin
* fm2 custom icon view mode needs to have cleanup, align etc. * fm2 custom icon view mode needs to have cleanup, align etc.

View File

@ -215,26 +215,26 @@ main(int argc, char **argv)
e_dbus_init(); e_dbus_init();
_e_dbus_conn = e_dbus_bus_get(DBUS_BUS_SYSTEM); _e_dbus_conn = e_dbus_bus_get(DBUS_BUS_SYSTEM);
if (_e_dbus_conn) if (_e_dbus_conn)
{ {
e_hal_manager_get_all_devices(_e_dbus_conn, _e_dbus_cb_dev_all, NULL); e_hal_manager_get_all_devices(_e_dbus_conn, _e_dbus_cb_dev_all, NULL);
e_hal_manager_find_device_by_capability(_e_dbus_conn, "storage", e_hal_manager_find_device_by_capability(_e_dbus_conn, "storage",
_e_dbus_cb_dev_store, NULL); _e_dbus_cb_dev_store, NULL);
e_hal_manager_find_device_by_capability(_e_dbus_conn, "volume", e_hal_manager_find_device_by_capability(_e_dbus_conn, "volume",
_e_dbus_cb_dev_vol, NULL); _e_dbus_cb_dev_vol, NULL);
e_dbus_signal_handler_add(_e_dbus_conn, "org.freedesktop.Hal", e_dbus_signal_handler_add(_e_dbus_conn, "org.freedesktop.Hal",
"/org/freedesktop/Hal/Manager", "/org/freedesktop/Hal/Manager",
"org.freedesktop.Hal.Manager", "org.freedesktop.Hal.Manager",
"DeviceAdded", _e_dbus_cb_dev_add, NULL); "DeviceAdded", _e_dbus_cb_dev_add, NULL);
e_dbus_signal_handler_add(_e_dbus_conn, "org.freedesktop.Hal", e_dbus_signal_handler_add(_e_dbus_conn, "org.freedesktop.Hal",
"/org/freedesktop/Hal/Manager", "/org/freedesktop/Hal/Manager",
"org.freedesktop.Hal.Manager", "org.freedesktop.Hal.Manager",
"DeviceRemoved", _e_dbus_cb_dev_del, NULL); "DeviceRemoved", _e_dbus_cb_dev_del, NULL);
e_dbus_signal_handler_add(_e_dbus_conn, "org.freedesktop.Hal", e_dbus_signal_handler_add(_e_dbus_conn, "org.freedesktop.Hal",
"/org/freedesktop/Hal/Manager", "/org/freedesktop/Hal/Manager",
"org.freedesktop.Hal.Manager", "org.freedesktop.Hal.Manager",
"NewCapability", _e_dbus_cb_cap_add, NULL); "NewCapability", _e_dbus_cb_cap_add, NULL);
} }
#endif #endif
if (_e_ipc_init()) ecore_main_loop_begin(); if (_e_ipc_init()) ecore_main_loop_begin();
@ -709,7 +709,7 @@ e_volume_mount(E_Volume *v)
static int mount_id = 1; static int mount_id = 1;
char buf[4096]; char buf[4096];
char *mount_point; char *mount_point;
Ecore_List *opt; Ecore_List *opt = NULL;
if (v->mount_point && v->mount_point[0]) if (v->mount_point && v->mount_point[0])
mount_point = v->mount_point; mount_point = v->mount_point;
@ -730,9 +730,13 @@ e_volume_mount(E_Volume *v)
printf("mount %s %s\n", v->udi, v->mount_point); printf("mount %s %s\n", v->udi, v->mount_point);
// FIXME; need to mount AS the USER - not root!!! seems it mounts as root // FIXME; need to mount AS the USER - not root!!! seems it mounts as root
// opt = ecore_list_new(); // opt = ecore_list_new();
// ecore_list_append(opt, "user"); // snprintf(buf, sizeof(buf), "uid=%i", (int)getuid());
//// hmmm - so how do these work?
// ecore_list_append(opt, buf);
//// ecore_list_append(opt, "user");
//// ecore_list_append(opt, "utf8");
e_hal_device_volume_mount(_e_dbus_conn, v->udi, v->mount_point, e_hal_device_volume_mount(_e_dbus_conn, v->udi, v->mount_point,
v->fstype, NULL, _e_dbus_cb_vol_mounted, v); v->fstype, opt, _e_dbus_cb_vol_mounted, v);
// ecore_list_destroy(opt); // ecore_list_destroy(opt);
} }