Commit Graph

10930 Commits

Author SHA1 Message Date
ChunEon Park 1b2401849a gelnist: unswallow makes sense. not smart member del. 2015-01-06 15:46:35 +09:00
Chris Michael 4be7250569 elementary: Fix issue with event data causing an invalid free
Summary: Since we end up calling free on the event->data parameter
after a drop is completed, we should actually be allocating a string
for this data (to be free'd later). This also fixes an issue where the
event length was not being set.

@fix

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2015-01-05 13:48:45 -05:00
Chris Michael 4a07808590 elementary: Fix return values to use Eina_Bool
Summary: This function is expecting Eina_Bool as the return value, not
ints so let's use EINA_FALSE here.

NB: this just fixes a copy/paste issue

@fix

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2015-01-05 12:17:03 -05:00
Chris Michael 5f325de444 elementary: Fix DnD to work again in wayland
Summary: In order for ecore_wl to start a drag, we need to send the
parent window of the object being dragged. Previous code was not
getting the parent window properly.

NB: This patch also fixes an issue where the data being sent to the
drop callback was being incorrectly sent.

@fix

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2015-01-05 12:05:50 -05:00
ChunEon Park fa6e06a450 genlist: keep the item class as given argument. 2015-01-05 22:17:12 +09:00
ChunEon Park b79e3e4ffa genlist: Fix genlist index get bug
Because not all item block have "max_items_per_block" number of items in it's block.
So the calculation is not correct when items are added & removed in each block.

Anyhow, we need more efficient way for this API because genlist uses inlinst.
2015-01-05 20:43:58 +09:00
ChunEon Park 3695c3c0b3 genlist: add some comment in code. 2015-01-05 20:21:26 +09:00
ChunEon Park a898ca295f genlist: use macro as possible. 2015-01-05 15:56:27 +09:00
ChunEon Park a831b625b9 genlist: use ELM_NEW 2015-01-05 15:55:39 +09:00
ChunEon Park e608c88448 genilst: unselect items if the genlist select mode is display only or none.
make it behavior same with elm_genlist_item_select_mode_set()

@fix
2015-01-05 15:42:22 +09:00
ChunEon Park a0b170c2a3 genlist: unselect item if the select mode is display only or none.
@fix
2015-01-05 15:37:41 +09:00
ChunEon Park 28ac4ffe65 ggenlist: code refactoring.
don't do anything if same mode is applied.
2015-01-05 15:03:37 +09:00
Davide Andreoli 9981b19303 Improve win dialog test to also include a test for standard_win 2015-01-04 15:38:51 +01:00
Daniel Hirt e3baf4d3c1 Elm_Entry: Fix dropped text data insertion
Fixes bad drag&drop into entry widgets, since the drop callback
assumed that the dropped text ends with a NULL character.

How to reproduce:
1. Open 'elementary_test -to Entry'
2. Open some application (e.g. Firefox)
3. Select some (preferably short) text, and drag&drop it to the entry
widget. This sometimes pastes additional corrupted text (better try
with a 1-3 characters text).

@fix
2015-01-04 14:14:54 +02:00
Davide Andreoli d4f5df772d Added the elm_win_util_dialog_add() API function
This new @feature is just a convenient way to create dialogs, It
mimic the elm_win_util_standard_add() function but crete a
standard dialog, with background and the parent set.

WinDialog test changed to use the new function.
2015-01-03 14:13:35 +01:00
Davide Andreoli 62ef7d3465 Icon: added documentation for the new fdo icon names 2015-01-03 12:49:21 +01:00
ChunEon Park f3efe45e5e genlist: remove useless deco texts. 2015-01-02 20:18:24 +09:00
ChunEon Park 30a74e27da genlist: + null check 2015-01-02 20:04:55 +09:00
ChunEon Park 2ede0112bd genlist: code refactoring
refactor _item_content_realize() prototype to keep the consistency with state,text_realize()
2015-01-02 19:59:39 +09:00
ChunEon Park e89125754e genlist: code refactoring.
apply facade at _view_inflate() for simple item realization.
2015-01-02 19:45:48 +09:00
ChunEon Park a1b36ae6ee genlist: code refactoring.
remove contents_obj but use contents instead.
2015-01-02 19:04:34 +09:00
ChunEon Park 4cdcfac116 genlist: code refactoring.
remove target states strings in the widget item.
2015-01-02 17:34:05 +09:00
ChunEon Park 1470572cef genlist: code refactoring.
just clean up code. no logic change.
2015-01-02 16:54:01 +09:00
ChunEon Park a41e9d8044 genlist: refactoring code.
removed invalid content string free call.
and renamed flip_content_objs -> flip_contents.
2015-01-02 16:48:29 +09:00
ChunEon Park 60202b7f0a genlist: code refactoring.
remove contents string list that doesn't needed to keep in widget data.

next code refactoring based on this patch will be coming.
2015-01-02 16:17:16 +09:00
ChunEon Park 67e4baf1df genlist: exceptional handling.
just be hidden if contents are failed to swallow.
2015-01-02 12:14:41 +09:00
Mike Blumenkrantz 8265a01c2a box layout should not silently fail when size is less than min size hint
this broke box display in any case where the user had manually changed size hints, eg. when using box align

@fix
2014-12-31 15:32:29 -05:00
ChunEon Park 2dd05e1580 genlist: free selected items when genlist is cleared. 2014-12-31 19:55:09 +09:00
ChunEon Park ff9de8bea8 genlist: send reorder signal to decoration item and views.
Previous logic was too much stick to special case for *tizen*
let decide item styles in theme as possible.

This might break reorder group item ui, but it won't be critical.
because tizen ui only depeneded on the scenario and they don't use them anymore.

This will be much better for multiple scenario in the future.
2014-12-31 19:10:40 +09:00
ChunEon Park 4f1b1bcb9f genlist: let group item set reorder style as it needs.
we don't need to limit the group item it's reorder style.
2014-12-31 18:59:28 +09:00
woochan lee c45739d0bf test_gengrid.c: Fixed Item_Data array size for prevent buffer overflow.
Summary:
Item_Data size set as 144 before. but test_gengrid_speed function called create_gengrid function with 5000 items.
it makes crash.

@fix

Test Plan:
1. run elementary_test.
2. click Gengrid update Speed.
3. crash.

Reviewers: seoz, Hermet

Reviewed By: Hermet

Differential Revision: https://phab.enlightenment.org/D1834
2014-12-31 17:38:28 +09:00
Amitesh Singh 2ba1640a00 test_glview_simple: opimize draw code.
Summary:
There is no need to call glVertexAttribPointer &
glEnableVertexAttribArray() while rendering.

Reviewers: seoz, jpeg, Hermet

Reviewed By: Hermet

Subscribers: seoz

Differential Revision: https://phab.enlightenment.org/D1827
2014-12-31 17:33:32 +09:00
Davide Andreoli 19d6ed361c Icon theme: added standard freedesktop names.
OK, this  commit try to fix the mess we have done with icon names in elm.
I just added standard names to icons yet existing in the elm theme, the
old name are, of course, preserved. But I marked them as -deprecated-.

Also added a new test: Icon Standard. It show all the icon that have standard
fdo names. This can be really usefull for user that need to choose icons to use.

I put some guidelines comment in the icons.edc files, I hope people will follow
the rules from now on... or will recive my personal spanking :D

I will work on those icons more in the next days: will add the new names to
elm docs, will try to match better fdo icon names, and maybe also add some
new icons...

Suggestions are always welcome.
@feature (maybe)
2014-12-30 23:03:12 +01:00
Daniel Juyung Seo 8db407f89c Revert "gesture_layer: Remove unnecessary value assignment."
This reverts commit d389a44b42d482414d1bfb2f4d0ccebbda510d7b.

Tasn said this value needs to be used. Let's fix it correctly later.
Thanks Tom.
2014-12-31 01:05:11 +09:00
Daniel Juyung Seo 27a8502959 gesture_layer: Remove unnecessary value assignment.
This fixes coverity CID 1261280.
But this is not critical.
2014-12-31 00:13:01 +09:00
ChunEon Park 66d78a4512 genlist: + warning msg for user notice
don't unrealize reordering item.
2014-12-30 17:56:24 +09:00
ChunEon Park 7dc5c3863c genlist: use convenient macro. 2014-12-30 17:36:14 +09:00
ChunEon Park 0e5b3f32d5 Revert "genlist: return as possible as soon."
This reverts commit ef56ed167206612f146d2c70f5b35a7bcd62c4c6.

This caused logic change. should not be changed.
2014-12-30 15:44:46 +09:00
ChunEon Park 10ac198400 Revert "genlist: return as possible as soon"
This reverts commit 1e6736c3a13d58c4e1a01d7e23983c721051be08.

This caused logic. should not be changed.
2014-12-30 15:43:20 +09:00
ChunEon Park 65de16477c genlist: return as possible as soon 2014-12-30 15:32:41 +09:00
Jee-Yong Um c890310c01 elm_colorselector: Fixed to get proper min size with picker only mode
Summary:
Fixed to make colorselector have proper min size
when colorselector is in ELM_COLORSELECTOR_PICKER mode

@fix

Reviewers: Hermet

Subscribers: Hermet

Differential Revision: https://phab.enlightenment.org/D1832
2014-12-30 13:11:50 +09:00
ChunEon Park f86dbe4854 genlist: removed unnecessary check 2014-12-30 11:17:46 +09:00
Daniel Juyung Seo f14fa87c84 genlist: Fix internal comments. 2014-12-30 01:31:43 +09:00
Daniel Juyung Seo 6d13e4e2bf test_genlist: Add clicked,right test case. 2014-12-30 00:35:24 +09:00
ChunEon Park f9cc9863a3 genlist: return as possible as soon. 2014-12-29 22:58:38 +09:00
ChunEon Park f2b7e575f0 genlist: clean up code.
repositioned function and remove unnecessary prototype declaration.
2014-12-29 22:51:39 +09:00
ChunEon Park fb8af1004c genlist: remove duplicated signal registration. 2014-12-29 22:34:45 +09:00
ChunEon Park 1f73409844 genlist: send an additional signal
send flip disabled signal when it's state is switched.
2014-12-29 22:27:28 +09:00
ChunEon Park cce9511130 genlist: send a signal internally.
send a signal so that item set it's style according to it's depth
2014-12-29 22:16:34 +09:00
Davide Andreoli 02b5c7065d Fileselector: beautify the search entry
Entry moved to the top-right corner and added the guide text
2014-12-29 13:47:31 +01:00