Summary:
When layout clicked, "elm_widget_on_focus()" called with "entry_focus_in()" callback.
The "view update" and "focus set to entry" already call in those callbacks, so i deleted duplicate code and it also make focus issue when user click the entry to add item.
@fix
Test Plan:
Run elementary_test.
1. excute multibuttonentry.
2. click the entry area.
3. see the elm_widget_on_focus called twice.
(layout callback function called view update -> elm_box_unpack called in view update ->
entry lose focus -> on_focus_callback call again)
Reviewers: Hermet, seoz, Jaehyun_Cho, JackDanielZ
Differential Revision: https://phab.enlightenment.org/D1902
Summary: The API must return ELM_WIN_UNKNOWN (-1) when the given object is improper.
Test Plan: None.
Reviewers: woohyun, JackDanielZ, seoz
Differential Revision: https://phab.enlightenment.org/D1907
Use the min between w and h of the evas object to
request the size in the icon theme. Fdo icon are always
square (1:1) so min seems correct.
Also improved the test to include a test that do
not relay on the size_hint_min of the icon.
Now in all the test I have done always the correct
fdo icon are used.
This reverts commit 75176a789981bd6b1ef0bfcc95793c896b5bde07.
Was not the correct solution, as min_size can be smaller than
the real wanted size. Need to find another solution.
Thanks TAsn to spot this
This @fix fdo icons to load the correct image for the requested size.
Whitout this the small images (16x16) was never used, because once a big
(64x64 for example) image was loaded, that size was used as min.
See the Icon Standard test for a better explanation
The code there was trying to reload the icon to have an
image that should match the requested size, this was totally
wrong, the calculation was always resulting in an image bigger
than the needed.
It was also useless as this logic is yet handled in the resize
callback.
You can now select the size of the icons in the list and
also added a single icon that you can resize.
The size of the icons is important as icon themes usually
provide different images for different sizes.
This test now spot out some errors in elm_icon wrt icon
sizing, will fix soon
This fixes the side effect that introduced from 1e06309be42fd2b5d0900b16da0178215c111681
Since transit has supported adding a map effect on the previous map status,
transit tried to access object-state map pointer.
but theses map pointer won't be valid if the transit keeps the last state
because it doesn't back up any object-state data.
- Do not set unnecessary min size for the icons. Just follow list's item
size naturally.
- Do not free unnecessary list which was already freed by
EINA_LIST_FREE.
- Do not set align for the window resize object which is not required to
be set.
- Follow conventional way of pointer declaration.
Previously, entry set handlers' style as default when they are created
and changed style on theme_apply function. But in usual scenario, users create
entry and set style before handlers are created, so when they are created
the style is set as default regardless of the style users already set.
This patch fixes it.
@fix
This reverts commit f99be3a1d6bdc63153598b592b5437c33da44bf0.
The API is not ready to be released. Please see the thread on the e-devel
mailing list under this subject. This can get another try in the 1.14
release cycle.
Conflicts:
src/lib/elm_genlist.c
Summary:
Fix crach issue caused by multiple transit effects on a single object.
This patch prevents deleting obj_data while the obj_data is still used by other transit objects.
This fix is related to commits "Support zoom keeping current map effect."(60214e6a172e42303fdfc69ef3d1996b25132242)
and "Support rotation keeping current map effect."(1e06309be42fd2b5d0900b16da0178215c111681).
@fix
Reviewers: Hermet
Differential Revision: https://phab.enlightenment.org/D1878
user request was ignored if they calls the genlist_item_selected_set(true)
to another item in an item selected callback. because genlist made
the selected item highlighted after user "selected" callback.
The behavior had been changed on my genlist refactoring,
so the behavior was actually just restored.
This issue resolves T2020
Summary:
Fix to support zoom rate zero by using evas_map_util_zoom() instead of evas_map_util_3d_perspective().
@fix
Reviewers: Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D1877
Note that the iterate function will never trigger the idler that are registered
in Ecore. That's by definition. I changed the code to actually use the full
main loop and trigger the change detection on idle enterer. That should be enough
for Elementary as all idler should logically affect the visual aspect of something
at some point and exit idle.
Thanks marcel-hollerbach@t-online.de for helping me debug this issue.
This reverts commit c80b24baf815e35c160bf0dbe8ecae6ea247aef8.
this broke the selection callback completely and makes every genlist app unusable.
please, please, please, please, I'm seriously begging you hermet, do ANY amount of testing before making further genlist commits.
Summary: This fixes Coverity CID1261370. strrchr can return NULL here,
so we need to check that 'p' is valid.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Internal hacks should not affect user facing API. This commit adds a new
API to do the internal hack. This is still bad, but it's much less than
what was there before.
This fixes the main issue introduced by commit:
63a5cdf0f8516c16a62233da0c2af0e10a13264b
During deletion of a window, widgets considered as droppable targets
have to remove their DnD callbacks. To achieve this, elm_drop_target_del
is called from the DEL callback (destructor). This function has to
determine if X11 or Wayland is used. Since the parent is already unknown
at this stage, only checking the engine name can give this
information.
On a regular window, the engine name is related to the target display.
The problem happens when an inline window is used. The engine is a
buffer and no information is given regarding the target display.
The patch fixes it by checking the nature of the Ecore Evas parents. It
supports nested windows (inline inside inline... inside XWin).
@fix
Summary:
palette_box had stretched height exceeding its items size.
Now it will have proper height fitting to own items.
Reviewers: Hermet, Jaehyun, raster
Reviewed By: raster
Subscribers: raster, Hermet
Differential Revision: https://phab.enlightenment.org/D1840
Summary:
When first page is last page, elm_scroller_last_page_get need to return 0.
But if pagesize is bigger then current content height or width, value will be returned -1.
So fix this cases to return 0.
Test Plan: If set elm_scroller_page_set bigger then current content size, then issue is occurred.
Reviewers: seoz, jaehwan, raster
Reviewed By: raster
Subscribers: eagleeye
Differential Revision: https://phab.enlightenment.org/D1860
@fix
The elm image orient_set api looks like it is a state, and it is
documented to SET the orietnation, but the code actually DOEs that
orientation when you set it. so docs and api name didnt match
functionality at all. this was bad an an oversight. you didn't notice
until you set orientation multiple times to an image. this fixes the
implementation to be as documented - a state that is applied and
remains that way until set to something else. setting to the same
orientation has no efect as with color, size, etc. etc. in evas.
you could look on this as an api break, but then either the docs
change AND api name changes to match the code, or code changes to
match the docs. we don't keep bug compatibility in efl and in this
case i'm making the call to break the behavior of a function as it
was broken already with respect to name and docs.
This reverts commit 1879cc39258c63c24f0abcff56558b1f1b60167a.
Hermet, please check this commit it makes Fileselector crash,
looks like you inverted the values: 1 should be EINA_TRUE.
I recommend you to use Exactness to run all the tests automatically.
this is a giant hack to provide widget parenting in e. do not use this function, do not use this type, do not even read the related documentation.
@feature
Summary:
On some systems (e.g. OS X), both Apple's windows manager and X11 can cohabit,
therefore we need to check for the DISPLAY environment variable only when ELM_DISPLAY
is not specified.
Reviewers: cedric, devilhorns, seoz, raster
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D1721
delete genlist item directly.
instead, remove the bunch of code that was related to lazy deletion.
we can success, if we clean up the resources and callback calls properly.
here i only found item focus callback that (may) required the lazy deletion.
This reverts commit fd71874024d14e5374aef93eae7d4cfbc0ea4521.
As the commit message says, the test crashes now. The ticket 1973 is
related to that issue.
Now, I understand there could be a bug inside inline stuff but it doesn't
mean that you have to push it and screw up all the test. You could just
attach a patch to the ticket and that's all folks!
Summary: When gengrid reordering by thumb scroll, some items disapear on screan.
Test Plan:
1. Enabled thumb scroll in elm config
2. Launch gengrid test in elementary_test
3. Check reorder mode enabled
4. Try to move reordering item to upon or lower area by thumb scrolling,
items disapear.
Reviewers: seoz, raster
Reviewed By: raster
Subscribers: bluezery
Differential Revision: https://phab.enlightenment.org/D1852
Summary: Use strncpm, not strcmp to support styles starting with vertical
Test Plan: Define spinner style which has 'vertcial' as a prefix
Reviewers: raster, cedric, seoz, woohyun, jaehwan, Hermet, jpeg
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D1839
Summary:
When elm_object_disabled_set API is called on any widget, All the
subobjects of the widget also has to be disabled issue fix.
@fix
Test Plan:
Call the API elm_object_disabled_set on any container widget like box,
layout etc:-, fix can be tested with test_box.c and test_layout.c test
codes.
Reviewers: Hermet, seoz, raster
Subscribers: govi, rajeshps
Differential Revision: https://phab.enlightenment.org/D1778
Summary:
There was a problem that image is stretched over its size
when elm_image_fill_outside_set() is applied.
This patch fixed that.
@fix
Reviewers: Hermet
Subscribers: Hermet
Differential Revision: https://phab.enlightenment.org/D1854
Summary:
fileselector: redirect keystrokes to the searchbar
Keystrokes like a-z A-Z 0-9 are redirected to the searchbar, so you dont
need to click arround to search files in the fileselector.
The search icon is from ApB (Apostolos B.), thx for that! :)
@feature Improved the searchbar
Reviewers: raster, seoz
Subscribers: ryuan.choi, cedric, seoz
Differential Revision: https://phab.enlightenment.org/D1237
Conflicts:
src/lib/elc_fileselector.c
Summary:
this function is called at least twice: in _smart_add and every time _theme_apply is called.
so we need either correctly free sd->cb_data or reuse it
@fix
Reviewers: seoz, cedric, raster, Hermet
Subscribers: reutskiy.v.v
Projects: #elementary
Differential Revision: https://phab.enlightenment.org/D1841
Summary:
Cause : When part name is NULL, edje_object_part_text_escaped_set is not called.
Measure : Add code for each conditions.
@fix
Reviewers: Hermet
Subscribers: Hermet
Differential Revision: https://phab.enlightenment.org/D1847
Summary:
The idle enterer added even after deleted sd for diskselector.
it makes crash.
@fix
Test Plan:
1. Run elementary_test
2. Execution diskselector.
3. Close diskselector sample window.
4. Crash occured.
Reviewers: Hermet, seoz, Jaehyun
Differential Revision: https://phab.enlightenment.org/D1843
Summary: Since we end up calling free on the event->data parameter
after a drop is completed, we should actually be allocating a string
for this data (to be free'd later). This also fixes an issue where the
event length was not being set.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Summary: This function is expecting Eina_Bool as the return value, not
ints so let's use EINA_FALSE here.
NB: this just fixes a copy/paste issue
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Summary: In order for ecore_wl to start a drag, we need to send the
parent window of the object being dragged. Previous code was not
getting the parent window properly.
NB: This patch also fixes an issue where the data being sent to the
drop callback was being incorrectly sent.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Because not all item block have "max_items_per_block" number of items in it's block.
So the calculation is not correct when items are added & removed in each block.
Anyhow, we need more efficient way for this API because genlist uses inlinst.
Fixes bad drag&drop into entry widgets, since the drop callback
assumed that the dropped text ends with a NULL character.
How to reproduce:
1. Open 'elementary_test -to Entry'
2. Open some application (e.g. Firefox)
3. Select some (preferably short) text, and drag&drop it to the entry
widget. This sometimes pastes additional corrupted text (better try
with a 1-3 characters text).
@fix
This new @feature is just a convenient way to create dialogs, It
mimic the elm_win_util_standard_add() function but crete a
standard dialog, with background and the parent set.
WinDialog test changed to use the new function.
Amitesh Singh
woochan lee
Youngbok Shin
Daniel Juyung Seo
kabeer khan
Stefan Schmidt
Davide Andreoli
Mike Blumenkrantz
ChunEon Park
Jaeun Choi
Jaehyun Cho
WooHyun Jung
Cedric BAIL
maxerba
Lukasz Stanislawski
Carsten Haitzler
Chris Michael
Tom Hacohen
Daniel Zaoui
Jee-Yong Um
VBS
Yakov Goldberg
Jean Guyomarc'h
vivek
Shinwoo Kim
shilpa.singh
Nibha Sharma
Marcel Hollerbach
Nak-Gyeong Kim
Stephen Houston
Daniel Hirt