Summary: This fixes Coverity CID1261370. strrchr can return NULL here,
so we need to check that 'p' is valid.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Internal hacks should not affect user facing API. This commit adds a new
API to do the internal hack. This is still bad, but it's much less than
what was there before.
This fixes the main issue introduced by commit:
63a5cdf0f8516c16a62233da0c2af0e10a13264b
During deletion of a window, widgets considered as droppable targets
have to remove their DnD callbacks. To achieve this, elm_drop_target_del
is called from the DEL callback (destructor). This function has to
determine if X11 or Wayland is used. Since the parent is already unknown
at this stage, only checking the engine name can give this
information.
On a regular window, the engine name is related to the target display.
The problem happens when an inline window is used. The engine is a
buffer and no information is given regarding the target display.
The patch fixes it by checking the nature of the Ecore Evas parents. It
supports nested windows (inline inside inline... inside XWin).
@fix
Summary:
palette_box had stretched height exceeding its items size.
Now it will have proper height fitting to own items.
Reviewers: Hermet, Jaehyun, raster
Reviewed By: raster
Subscribers: raster, Hermet
Differential Revision: https://phab.enlightenment.org/D1840
Summary:
When first page is last page, elm_scroller_last_page_get need to return 0.
But if pagesize is bigger then current content height or width, value will be returned -1.
So fix this cases to return 0.
Test Plan: If set elm_scroller_page_set bigger then current content size, then issue is occurred.
Reviewers: seoz, jaehwan, raster
Reviewed By: raster
Subscribers: eagleeye
Differential Revision: https://phab.enlightenment.org/D1860
@fix
The elm image orient_set api looks like it is a state, and it is
documented to SET the orietnation, but the code actually DOEs that
orientation when you set it. so docs and api name didnt match
functionality at all. this was bad an an oversight. you didn't notice
until you set orientation multiple times to an image. this fixes the
implementation to be as documented - a state that is applied and
remains that way until set to something else. setting to the same
orientation has no efect as with color, size, etc. etc. in evas.
you could look on this as an api break, but then either the docs
change AND api name changes to match the code, or code changes to
match the docs. we don't keep bug compatibility in efl and in this
case i'm making the call to break the behavior of a function as it
was broken already with respect to name and docs.
This reverts commit 1879cc39258c63c24f0abcff56558b1f1b60167a.
Hermet, please check this commit it makes Fileselector crash,
looks like you inverted the values: 1 should be EINA_TRUE.
I recommend you to use Exactness to run all the tests automatically.
this is a giant hack to provide widget parenting in e. do not use this function, do not use this type, do not even read the related documentation.
@feature
Summary:
On some systems (e.g. OS X), both Apple's windows manager and X11 can cohabit,
therefore we need to check for the DISPLAY environment variable only when ELM_DISPLAY
is not specified.
Reviewers: cedric, devilhorns, seoz, raster
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D1721
delete genlist item directly.
instead, remove the bunch of code that was related to lazy deletion.
we can success, if we clean up the resources and callback calls properly.
here i only found item focus callback that (may) required the lazy deletion.
This reverts commit fd71874024d14e5374aef93eae7d4cfbc0ea4521.
As the commit message says, the test crashes now. The ticket 1973 is
related to that issue.
Now, I understand there could be a bug inside inline stuff but it doesn't
mean that you have to push it and screw up all the test. You could just
attach a patch to the ticket and that's all folks!
Summary: When gengrid reordering by thumb scroll, some items disapear on screan.
Test Plan:
1. Enabled thumb scroll in elm config
2. Launch gengrid test in elementary_test
3. Check reorder mode enabled
4. Try to move reordering item to upon or lower area by thumb scrolling,
items disapear.
Reviewers: seoz, raster
Reviewed By: raster
Subscribers: bluezery
Differential Revision: https://phab.enlightenment.org/D1852
Summary: Use strncpm, not strcmp to support styles starting with vertical
Test Plan: Define spinner style which has 'vertcial' as a prefix
Reviewers: raster, cedric, seoz, woohyun, jaehwan, Hermet, jpeg
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D1839
Summary:
When elm_object_disabled_set API is called on any widget, All the
subobjects of the widget also has to be disabled issue fix.
@fix
Test Plan:
Call the API elm_object_disabled_set on any container widget like box,
layout etc:-, fix can be tested with test_box.c and test_layout.c test
codes.
Reviewers: Hermet, seoz, raster
Subscribers: govi, rajeshps
Differential Revision: https://phab.enlightenment.org/D1778
Summary:
There was a problem that image is stretched over its size
when elm_image_fill_outside_set() is applied.
This patch fixed that.
@fix
Reviewers: Hermet
Subscribers: Hermet
Differential Revision: https://phab.enlightenment.org/D1854
Summary:
fileselector: redirect keystrokes to the searchbar
Keystrokes like a-z A-Z 0-9 are redirected to the searchbar, so you dont
need to click arround to search files in the fileselector.
The search icon is from ApB (Apostolos B.), thx for that! :)
@feature Improved the searchbar
Reviewers: raster, seoz
Subscribers: ryuan.choi, cedric, seoz
Differential Revision: https://phab.enlightenment.org/D1237
Conflicts:
src/lib/elc_fileselector.c
Summary:
this function is called at least twice: in _smart_add and every time _theme_apply is called.
so we need either correctly free sd->cb_data or reuse it
@fix
Reviewers: seoz, cedric, raster, Hermet
Subscribers: reutskiy.v.v
Projects: #elementary
Differential Revision: https://phab.enlightenment.org/D1841
Summary:
Cause : When part name is NULL, edje_object_part_text_escaped_set is not called.
Measure : Add code for each conditions.
@fix
Reviewers: Hermet
Subscribers: Hermet
Differential Revision: https://phab.enlightenment.org/D1847
Summary:
The idle enterer added even after deleted sd for diskselector.
it makes crash.
@fix
Test Plan:
1. Run elementary_test
2. Execution diskselector.
3. Close diskselector sample window.
4. Crash occured.
Reviewers: Hermet, seoz, Jaehyun
Differential Revision: https://phab.enlightenment.org/D1843
Summary: Since we end up calling free on the event->data parameter
after a drop is completed, we should actually be allocating a string
for this data (to be free'd later). This also fixes an issue where the
event length was not being set.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Summary: This function is expecting Eina_Bool as the return value, not
ints so let's use EINA_FALSE here.
NB: this just fixes a copy/paste issue
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Summary: In order for ecore_wl to start a drag, we need to send the
parent window of the object being dragged. Previous code was not
getting the parent window properly.
NB: This patch also fixes an issue where the data being sent to the
drop callback was being incorrectly sent.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Because not all item block have "max_items_per_block" number of items in it's block.
So the calculation is not correct when items are added & removed in each block.
Anyhow, we need more efficient way for this API because genlist uses inlinst.
Fixes bad drag&drop into entry widgets, since the drop callback
assumed that the dropped text ends with a NULL character.
How to reproduce:
1. Open 'elementary_test -to Entry'
2. Open some application (e.g. Firefox)
3. Select some (preferably short) text, and drag&drop it to the entry
widget. This sometimes pastes additional corrupted text (better try
with a 1-3 characters text).
@fix
This new @feature is just a convenient way to create dialogs, It
mimic the elm_win_util_standard_add() function but crete a
standard dialog, with background and the parent set.
WinDialog test changed to use the new function.
Previous logic was too much stick to special case for *tizen*
let decide item styles in theme as possible.
This might break reorder group item ui, but it won't be critical.
because tizen ui only depeneded on the scenario and they don't use them anymore.
This will be much better for multiple scenario in the future.
Summary:
Item_Data size set as 144 before. but test_gengrid_speed function called create_gengrid function with 5000 items.
it makes crash.
@fix
Test Plan:
1. run elementary_test.
2. click Gengrid update Speed.
3. crash.
Reviewers: seoz, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D1834
Summary:
There is no need to call glVertexAttribPointer &
glEnableVertexAttribArray() while rendering.
Reviewers: seoz, jpeg, Hermet
Reviewed By: Hermet
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D1827
OK, this commit try to fix the mess we have done with icon names in elm.
I just added standard names to icons yet existing in the elm theme, the
old name are, of course, preserved. But I marked them as -deprecated-.
Also added a new test: Icon Standard. It show all the icon that have standard
fdo names. This can be really usefull for user that need to choose icons to use.
I put some guidelines comment in the icons.edc files, I hope people will follow
the rules from now on... or will recive my personal spanking :D
I will work on those icons more in the next days: will add the new names to
elm docs, will try to match better fdo icon names, and maybe also add some
new icons...
Suggestions are always welcome.
@feature (maybe)
Summary:
Fixed to make colorselector have proper min size
when colorselector is in ELM_COLORSELECTOR_PICKER mode
@fix
Reviewers: Hermet
Subscribers: Hermet
Differential Revision: https://phab.enlightenment.org/D1832
Summary:
Added a function print_glerror_log to handle both shaders and programs
logs.
Test Plan: elementary_test -> glview
Reviewers: raster, jpeg, seoz
Reviewed By: seoz
Subscribers: anand.km, seoz
Differential Revision: https://phab.enlightenment.org/D1826
Too much in this case is a fixed 4px. As fingers do not have a right button I think
that taking into account finger size is not needed here.
Also someone argued about the signal name is not really correct...
should I change it to somethig like: clicked,secondary ?
When the genlist item is selected it change the text effect from
shadow to glow, this has 2 side effects:
1. the text gets an unwanted 2px offset (because glow require more space, I think)
2. the text color the user has set usually looks ugly with the glow color
This commit change the style to always use a normal shadow, whenever the item
is selected or not. Only apply to the default_style item style.
Summary:
A sample for elm_transit_tween mode which can be executed via
"Effects"-"Transit Tween Mode" button in elementary_test
Reviewers: Hermet
Subscribers: Hermet
Differential Revision: https://phab.enlightenment.org/D1817
Summary:
After applying clipping patch about image on outside,
the width or height of the image be decreased
if x or y of an image is less than zero.
The way to calculate width/height has changed.
This fixes a side effect added in 2839881f37ea85b3469d8fd37cfaa4f9d67458fa
Reviewers: Hermet
Differential Revision: https://phab.enlightenment.org/D1810
Summary:
Fix layout broken in ELM_COLORSELECTOR_ALL mode
due to missing part for layout sizing evaluation
@fix
Reviewers: Hermet
Subscribers: Hermet
Differential Revision: https://phab.enlightenment.org/D1802
Summary:
When colorselector widget is added, there are two align set command on palette_box part,
but that for picker part is omitted.
Apply elm_box_align_set function to picker part correctly.
@fix
Reviewers: Hermet
Reviewed By: Hermet
Subscribers: Hermet
Differential Revision: https://phab.enlightenment.org/D1790
Summary:
When resizes an image
if "fill_inside" and "aspect_fixed" in Elm_Image_Data struct are "TRUE",
extra width or height go outside of the object area.
The width or height on outside will be clipped.
@fix
Reviewers: Hermet
Differential Revision: https://phab.enlightenment.org/D1794
Summary:
Pass Elm_Object_Item *item instead of Elm_Widget_Item_Data *item as
*event_info in item->del_func to let *event_info be used.
@fix
Reviewers: Hermet
Differential Revision: https://phab.enlightenment.org/D1788
Summary:
Label widget example that handles "slide,end" signal
When each label ends its slide, it stops and makes next one slide.
Reviewers: Hermet
Subscribers: Hermet
Differential Revision: https://phab.enlightenment.org/D1787
Summary:
As mentioned in TODO replaced expressions in if statement with macros in elm_macros.
Signed-off-by: kabeer khan <kabeer.khan@samsung.com>
Reviewers: seoz, raster
Reviewed By: raster
Subscribers: raster
Differential Revision: https://phab.enlightenment.org/D1424
Summary:
Originally, key "Left" is mapped elm_gengrid_item_prev_get. But when gengrid is mirrored, key "Left" should remap elm_gengrid_item_next_get.
So I add more condition for checking mirroring.
1. reverse Left and Right key event
2. fix _elm_gengrid_item_edge_check logic
3. fix _item_show_region logic
Test Plan: elementary_test -> gengrid
Reviewers: SanghyeonLee
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D1381
Conflicts:
src/lib/elm_gengrid.c
Summary:
Naviframe: modify elm_naviframe_item_pop_to api's document guide more specific to avoid confusion.
the elm_naviframe_item_pop_to api does not pop all items from the top to the target item.
It destory the items between the top and the target item, after that pop and destory the top item.
so, the descriptions of elm_naviframe_item_pop_to() is modified to avoid cunfusion like above.
Reviewers: Hermet, woohyun, seoz
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D1780
Summary:
in this test sample, evas object size hint weight, align set API doesn't need to make view.
and line changed to code consistency.
Test Plan:
1. run elementary_test.
2. execution check test.
3. window resize.
- some objects align to left side of window. in the other hands, some objects align to center of window.
Reviewers: seoz, Hermet
Differential Revision: https://phab.enlightenment.org/D1781
Summary:
If item_loop is not enabled, the focus highlight should move to nearest visible object
with key events.
Test Plan: elementary_test -to "gengrid 2"
Reviewers: seoz, raster
Subscribers: sachin.dev, seoz
Differential Revision: https://phab.enlightenment.org/D1261
Once the window alpha is on, it would not go back to non-alpha window
automatically.
- non-alpha theme -> alpha theme: switch to alpha window
- alpha theme -> non-alpha theme: stay in alpha window
@feature
Summary: pulsing mode doen't work even though called elm_progressbar_pulse function in code , if pulse value is not true.
Test Plan:
1. run elementary_test
2. execution ExtProgressBar sample.
3. click 3rd button to start progressbar.
@fix
Reviewers: seoz, Hermet, woohyun, cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1770
A leave callback is invoked on the drop target of the previous DnD
operation, leading to inconsistency for applications.
The state of the dropable target was not resetted during drop.
This patch fixes that.
- Add more sample items.
- Clear genlist on focus callback only for the specified item.
- Fix broken item index handling
- Remove unnecessary app data structure members.
- Free unused item class.
DISPLAY environment variable may set regardless of Elementary/EFL.
Mostly user has no way to switch their intent engine such as "buffer"
Guarantee work application engine with their intended engine first.
@fix
We have the version in configure.ac and NEWS where it gets updated for
releases. This occurrence gets forgotten to often on the other hand. Its
not needed here so we remove it.
Summary:
Summary: after popup layout refactoring, the popup object cant get evas event.
when popup using notify object block layout object will be covered with edje object.
it breaks evas smart member relationship.
Test Plan:
Test Plan:
1. added popup object.
2. key down event callback add for popup object.
3. run the elementary_test.
4. input some key on popup and check whether the registered function is executed or not.
Reviewers: eunue, Hermet, seoz
Differential Revision: https://phab.enlightenment.org/D1706
- Remove shadow variable.
- Don't call elm_init() twice. It is called automatically when you use
ELM_MAIN() macro.
- Don't set weight/align to swallowed objects.
- Set weight first before adding the object to window's resize object.
- Show window after creating all of its content.
ChunEon Park
Lukasz Stanislawski
Cedric BAIL
Carsten Haitzler
Chris Michael
Stefan Schmidt
Tom Hacohen
Daniel Zaoui
Jee-Yong Um
VBS
Mike Blumenkrantz
Yakov Goldberg
Jean Guyomarc'h
vivek
Shinwoo Kim
shilpa.singh
Nibha Sharma
Marcel Hollerbach
Nak-Gyeong Kim
woochan lee
Stephen Houston
Davide Andreoli
Daniel Hirt
Amitesh Singh
Daniel Juyung Seo
Andrii Kroitor
jiin.moon
Jaehyun Cho
kabeer khan
Kairong Yin
Hosang Kim
Jyotiprakash Sahoo
taehyub
Chinmaya
Sanjeev BA
Anand