Commit Graph

203 Commits

Author SHA1 Message Date
Tom Hacohen efa41c7d75 Elm: Update code to use the new class names generated by eolian. 2014-06-03 11:54:44 +01:00
Anil Kumar Nahak c72174031d fileselector: Added focus cycle feature.
Summary:
Previously there was no focus_direction & focus_next.
These functions are added in filesector winset for currect focus movement inside the winset.

Test Plan: elementary_test->"fileselector"

Reviewers: raster, seoz, nirajkr, singh.amitesh

Differential Revision: https://phab.enlightenment.org/D913
2014-05-29 11:35:46 +09:00
Vorobiov Vitalii 39e1971472 [Fileselector] Fix double-call of callback function on clicking "Enter" key.
Summary:
This feature (Clicking on "Enter" key) was previously implemented by using "activate" signal of entry (the one for entering name of the file),
so it was looking like "ok" button was clicked by pushing "Enter" key on the keyboard.
This little feature was added in commit 4d761f3a63270c88fa516764d9288f8bf0ff4a11.

Later the huge feature that adds key binding was implemented (commit 820f3dc907250c0c08ed8431b50567e58d6dab5c for ex).
It allows to bind widgets with keys (certain function calls when certain keys is pressed on keyboard).
This feature also adds same functionality to fileselecter, doing the same as previous (with "activate" signal) one.

Because of that it was looks like "ok" button was clicked twice.
This commit fixes this behavior and removes old and outdated method of "ok" button clicking processing.
@fix

Reviewers: cedric, seoz, raster

CC: reutskiy.v.v

Differential Revision: https://phab.enlightenment.org/D864
2014-05-19 15:41:32 +09:00
Daniel Juyung Seo 8ffbf246f4 elm: fixed trivial formattings.
Just found them while reading codes.
2014-05-10 23:44:27 +09:00
Daniel Juyung Seo af92b3e6f9 elm: call elm_widget_item_del instead of elm_object_item_del inside elementary.
This reduces only one more function call but this makes the elm code
more consistent between widgets.
2014-05-10 23:44:27 +09:00
Daniel Zaoui 1303a6dbec Eolian: fix names for elc widgets.
Even if the file names are elc_..., the class names are supposed to be
elm_...
2014-04-22 16:39:35 +03:00
ChunEon Park 5ab6a7739f widgets - don't handle the events(key,mouse) if the object is disabled.
we can prevent to handle the widget events from the widget infra,
if the object is disabled.

conceptually, disabled object should not be interacted to user input(key, mouse)
2014-04-16 10:59:43 +09:00
Jaeun Choi 530fcf2d8c fileselector: apply key binding
Summary: This patch applies key binding to elm_fileselector.

Test Plan: elementary_test > fileselector > check key events

Reviewers: Hermet, raster

Differential Revision: https://phab.enlightenment.org/D728
2014-04-15 13:58:01 +09:00
Tom Hacohen a7ac744f37 fileselector: Adjusted to Eo2. 2014-04-10 09:34:59 +01:00
Daniel Zaoui 038cfe9d3f Eolian: Integration of File Selector 2014-03-31 13:48:26 +03:00
Daniel Zaoui 2c24e9899d Eolian: Integration of File Selector Interface 2014-03-31 13:48:25 +03:00
Daniel Zaoui e2206a1a22 Eolian: Integration of Elm Widget 2014-03-17 09:03:56 +02:00
WooHyun Jung 0a1179dde4 elm_layout now supports focused/unfocused smart callback
by itself for widgets that inherit layout class.
If it uses elm_widget's, smart callback will be called at the
beginning or smart_on_focus function.
2014-02-06 16:18:57 +09:00
Ryuan Choi a1a87c102e fileselector: Fixed that data of "done" signal may start with two slash
When moved to root(/) and typed something in name_entry,
ok button sent //something as as data of "done" signal.

This patch checked current path string not to concatenate two slash.
2014-01-29 23:19:46 +09:00
Ryuan Choi 70782a358b fileselector: Fixed that does not navigate / on path_entry
href=/> are not working because /> is considered to self closing tag.

Instead. href='/'> is fine since rEFL2d4ba9e8d
2014-01-28 16:30:06 +09:00
ChunEon Park 9b9a3ccc40 fileselector - use the internal widget apis as possible.
We already know some apis are just wrapping the internal widget apis.
Iternally we don't need to call the external apis that have additional object validation checking.
2014-01-26 02:19:23 +09:00
ChunEon Park aebdcff513 elementary - use the focused/unfocused string in widget defined.
Now, it will share the strings so that reduce the binary size also user uses it in one way.
2014-01-23 17:27:17 +09:00
Daniel Juyung Seo 8298782bdc fileselector: Make fileselector focusable. Ok on Enter key and Cancel on Escape key.
Now fileselector accepts the key event on Enter and Escape.
2014-01-22 18:43:18 +09:00
Daniel Juyung Seo db5fe2581d elm: Removed unnecessary null check for evas_object_del. 2014-01-22 10:54:52 +09:00
Daniel Juyung Seo c066009c49 elm: Removed unnecessary null check for ecore_idler_del, ecore_idle_enterer_del. 2014-01-22 10:54:28 +09:00
Ryuan Choi 26dd1db99c Introduce fileselector interface and applied to elm_fileselector.
Summary:
fileselector_button and fileselector_entry should have almost same interfaces with fileselector.
Previously , we exposed them individually such as elm_fileselector_is_save_set().

Instead of adding the same APIs three times, we can reuse one fileselector's API using Eo interface.

This patch introduced fileselector interface and applied it to elm_fileselector.

Reviewers: seoz, raster

Reviewed By: raster

Differential Revision: https://phab.enlightenment.org/D475
2014-01-21 22:50:35 +09:00
Yakov Goldberg 3379c124df all widgets: change Eo API for "elm_widget_theme()" to "theme_apply"
There are elm_widget_theme/theme_set/theme_get functions.
    In Eolian these functions will be described as "theme" method and
    "theme" property. There is clash here.
    So add suffix "_apply" to Eo API for "elm_widget_theme".
2014-01-21 11:08:29 +02:00
Ryuan Choi dbb92436a2 fileselector: Fix that folder only mode shows only files instead of only folders
Issues: T756

It's regression of rELM4693736bb028
2014-01-14 18:14:52 +09:00
Ryuan Choi 34c5efeb36 fileselector: Fix that the enter key does not navigate directory
Moved the navigation logic from callback of "clicked,double" to callback of "activated".
2014-01-13 17:34:36 +09:00
Daniel Juyung Seo fd5c046dfe elm: Changed __UNUSED__ to EINA_UNUSED. 2014-01-06 23:33:57 +09:00
Ryuan Choi 9c84f2b1b5 fileselector: Fix dereference before null check
Reported as CID:1147525 by Coverity Scan
2014-01-01 15:32:35 +09:00
Ryuan Choi b379b8c409 fileselector: Fixed wrong allocation in _custom_filter_append
Reported as CID:1147526 by Coverity Scan
2014-01-01 15:32:32 +09:00
Jihoon Kim e3faaa250a fileselector: add NULL check 2013-12-31 11:22:20 +09:00
Ryuan Choi e26c97d55c fileselector : Add elm_fileselector_custom_filter_append to support custom filter
Summary:
Now, application developers can decide whether files and directories to show in
fileselector view.

Reviewers: seoz, raster

Reviewed By: raster

Differential Revision: https://phab.enlightenment.org/D416
2013-12-29 13:23:17 +09:00
Ryuan Choi 974f30f558 fileselector: Fixed simple typo 2013-12-26 21:08:41 +09:00
Daniel Juyung Seo e63dd3110a elm: Unified eina critical manro to CRI.
Being annoyed by different types of eina critical macros - CRI, CRIT,
 CRITICAL -, I concluded to unify them to one. Discussed on IRC and
 finally, CRI was chosen to meet the consistency with other macros -
 ERR, WRN, INF, DBG - in terms of the number of characters.
If there is any missing bits, please let me know.
2013-12-26 13:03:55 +09:00
Daniel Juyung Seo 106db03a94 fileselector: enter key press in name entry acts like ok button click.
- I used "activate" signal of entry and this will call ok button clicked function directly.
- This is very useful when the fileselector is used in desktop with keyboard.
2013-12-20 18:54:57 +09:00
Ryuan Choi a20c209079 fileselector: Add elm_fileselector_sort_method_get/set to select order of file/directory list.
Summary:
From now, the list of files/directories can be ordered by filename,
type, size, modified time with both ascent and descent.

Reviewers: seoz

Differential Revision: https://phab.enlightenment.org/D367
2013-12-18 20:05:35 +09:00
Ryuan Choi c5196bfcda fileselector: Add support to change the size of thumbnails in grid view.
Reviewers: seoz, raster

Reviewed By: raster

CC: raster

Differential Revision: https://phab.enlightenment.org/D276
2013-12-03 18:28:52 +09:00
Carsten Haitzler 9d4a9900cc option build deps that efl guarantees... now just are assumed and not ifdef'd 2013-11-12 22:56:05 +09:00
Tom Hacohen 2f1e1554e5 Changed Eo class names to be consistent.
All the class names are now of the format: Elm_Type_Subtype_Extra
2013-11-07 11:44:22 +00:00
Ryuan Choi cc6fb00c62 fileselector: Remove invalid or unnecessary comment 2013-11-06 19:28:19 +09:00
Ryuan Choi 75ae20a30d elc_fileselector: Update items of file_view to follow changes of selected path
This patch implmented for fileselector to monitor and update changes of selected
path. So, changes of selected path from other applications such as mkdir will be
applied to the file_view without refresh.

This feature is only available with EIO.
2013-10-21 14:06:04 +09:00
Daniel Juyung Seo 8ec25b69fb elm: Added missing undefs. 2013-10-19 02:20:34 +09:00
Ryuan Choi 9bd1c3ae5a elc_fileselector: Refactor not to keep two instances(genlist/gengrid) for file list.
Consolidates and rename files_list and files_grid to files_view.
2013-10-18 15:14:10 +09:00
Ryuan Choi d5c6eaa50e elc_fileselector: Added support to show/hide hidden files/directories.
Added elm_fileselector_hidden_visible_set/get to show or hide hidden resources.
2013-10-18 12:30:28 +09:00
Ryuan Choi 024ee1241e elc_fileselector: Moved some initialization of list_itc/grid_itc from smart_add to constructor.
Since a305c127, list_itc and grid_itc initialization was moved to constructor of file selector class.
But some parts of them are remained in _elm_fileselector_smart_add() by my mistake.
2013-10-18 08:11:10 +09:00
Ryuan Choi 2fb023ea21 Multiple selection support in fileselector
Summary: Multiple selection support in fileselector

Reviewers: seoz

Reviewed By: seoz

CC: seoz

Differential Revision: https://phab.enlightenment.org/D207
2013-10-17 11:05:45 +09:00
Daniel Juyung Seo 38fb57719c elc_fileselector.c: adopted ELM_WIDGET_DATA_GET_OR_RETURN macro. 2013-10-05 17:12:11 +09:00
Ryuan Choi dd763025d8 fileselector: fileselector: Add "activated" smart callback
It can be used to execute a file activated by double-clicking or
pressing Enter key.
2013-10-02 12:36:08 +09:00
Ryuan Choi 9368d61549 elc_fileselector: Add fileselector_double_tap_navigation_enable configuration
elm_filechooser used single tap not only for selection of file but also for
navigation of directory.
So it did not provide a way to select directory without navigation.

With fileselector_double_tap_navigation_enable option, single tap will be used
only for selection and double tap will be used for navigation of file or
directory.
2013-10-01 01:46:39 +09:00
Ryuan Choi 6e07a4c457 elc_fileselector: support ui-mirroring for files_grid.
All fileselector widgets support ui-mirroring except files_grid.
2013-09-26 17:43:19 +09:00
Ryuan Choi ea5a6f7345 elc_fileselector: restore name_entry.
(file)name_entry was removed after r82105 but it is necessary.
name_entry can keep the selected file/folder name(s for multiple selection)
or new file/folder name for save.
Instead, path_entry will focus only navigation with anchor.

I renamed it to name_entry because it can keep both file name and folder name.

you can see more information at
http://sourceforge.net/mailarchive/message.php?msg_id=31441811
2013-09-26 07:10:32 +09:00
Cedric Bail 29af5e1e43 elementary: update to new eo_parent_get/set API. 2013-09-25 13:34:27 +09:00
Ryuan Choi 5a6f5b770b fileselector: Added "selected,invalid" signal for wrong path on the path_entry.
If user typed wrong path on the path entry,
"selected,invalid" will be emitted with "selected" for legacy.

In addition, send "selected" signal when folder is changed in only folder mode.
It's regression of 74f308df9.

See more information from
http://sourceforge.net/mailarchive/message.php?msg_id=31394571
2013-09-12 22:37:10 +09:00