Summary:
In fileselector, user can write directory path or file path which they want.
If then, fileselector navigates path when directory path is given,
but just send a "selected" signal without real selection when file path or wrong path is given.
With this path,
- fileselector will navigate (if needed) and select file with signal when file path is given.
- no action when wrong path is given.
- _anchors_do() receive fileselector object as first parameter,
in _on_text_unfocused cb fileselector passed as 'data' and not as
'obj';
- when entry is unfocused, it can contain usual text or anchor-styled text,
so the only secure way to pass path is to pass sd->path.
This commit is invalid.
It just use strdup and strdup may return NULL when memory is not enough.
This reverts commit f579f7fd4b5e863f01a001876e536f5becc40811.
https://phab.enlightenment.org/T133
list_itc and grid_itc are static variables, but they were managed by file_selector instance.
For example, they are allocated two times and first allocated classes are dangling
when two file selector are created.
This patch moves their init/deinit logic to constructor/destructor of file selector class.
1. Do not need to print the same error message from all the widget codes.
2. Even though elm_widget_sub_object_add() can be used internally, there should be no error message at all.
Elm devs should fix it beforehand.
So it looks ok to print the error message in elm_widget_sub_object_add() to force elm devs to fix it.
3. Got additional code cleanups.
* Fileselector test: add a check to enable/disable buttons
Updated Changelog and NEW, also add myself as authors...
btw: the EIO code in the Fileselector is crazy-complex, about 200
lines of code just to have the list of files ina dir... :/
SVN revision: 70965
Subject: [E-devel] [patch] elm_gengrid - add item class management api
(1/3)
As like genlist item class management api, I added 4 apis to
elm_gengrid.
+EAPI Elm_Gengrid_Item_Class *elm_gengrid_item_class_new(void);
+EAPI void elm_gengrid_item_class_free(Elm_Gengrid_Item_Class *itc);
+EAPI void elm_gengrid_item_class_ref(Elm_Gengrid_Item_Class *itc);
+EAPI void elm_gengrid_item_class_unref(Elm_Gengrid_Item_Class *itc);
gengrid item class is maintained by gengrid in automatic manner.
it maintains its reference count. and item_class_free api marks
"delete_me".
Unless item_class_free, item class will not be freed.
SVN revision: 68308
Subject: [E-devel] [patch] elm_genlist - add item_class management
functions
I make controversial apis for item class management.
As raster and other guys suggest, I simplify APIs and its behaviors.
First, Two public apis and two internal apis are introduced
+EAPI Elm_Genlist_Item_Class *
+elm_genlist_item_class_new(void)
+EAPI void
+elm_genlist_item_class_free(Elm_Genlist_Item_Class *itc)
+void
+_elm_genlist_item_class_ref(Elm_Genlist_Item_Class *itc)
+void
+_elm_genlist_item_class_unref(Elm_Genlist_Item_Class *itc)
genlist item class is maintained by genlist in automatic manner.
And three fields are introduced in genlist item class.
+ int version;
+ unsigned int refcount;
+ Eina_Bool delete_me;
Normally a user add a elm_genlist_item_class by
elm_genlist_item_class_new().
Then its reference counter is automatic maintained.
If the user wanna to remove the elm_genlist_item_class, then call
elm_genlist_item_class_free()
After refcount reaches to 0, it will be removed.
SVN revision: 68147
but please use elm_object_item_data_set/get instead.
and what was purpose of this double casting?
(int)(long) elm_genlist_item_data_get(gli);
these calls are used in some places.
I removed the (long) casting because it looks useless.
SVN revision: 67546
Hi,
On behalf of Rajeev Ranjan, I am submitting the elc_fileselector patch.
Change Log:
Fix for the memory leak in function elm_fileselector_selected_get. Memory allocated by ecore_file_dir_get() internally using strdup was not freed.
Introduced a char *dir variable to store the memory returned by ecore_file_dir_get() function and releasing the memory before returning to caller.
Please review it.
I'd appreciate any comments on this.
Thank you,
Prince
Signed-Off-By: Rajeev Ranjan (rajeev.r@samsung.com)
Signed-Off-By: Prince Kumar Dubey (prince.dubey@samsung.com)
Signed-Off-By: ChunEon Park (hermet@hermetpe.kr)
SVN revision: 65950
recent elementary api corrections.
I changed item class's 'label_get' to 'text_get'. But 'label_get' is still
supported by union structure. So 'label_get' will just give you
deprecated warnings while compiling but it's recommended to fix your
apps to 'text_get'. Sometimes when you initialize item class using
braces, you will get 'missing braces around initializer' but ignore
this. That warning will be gone after I remove 'label_get' backport. I
will remove this 'label_get' backport after I finish below
jobs.
[TODO]
1. Fix all apps in trunk.
2. Change edc "labels" to "texts" as well. I haven't done this yet.
SVN revision: 65751
deprecate all elm_gen APIs.
We will merge gengrid into genlist later and remove elm_gen.
I updated http://trac.enlightenment.org/e/wiki/ElementaryChanges
I will fix other libraries/programs in trunk soon.
SVN revision: 65700
Previous part names are just the swallow part names
but in modified version, the part names chaned to simpler meaning names to use.
i.e for button
elm_object_content_part_set(button, "elm.swallow.icon", icon);
-> elm_object_content_part_set(button, "icon", icon);
SVN revision: 65295
Do not limit the swallowed objects to icon. This had to be done before
elm 1.0 and now it's time to break. This will break all applications
which are using gengrid/genlist. Please fix it icon_get -> content_get.
TODO
1. fix theme as well.
2. fix documents.
SVN revision: 64344
First things first, I'm not sure I'm setting the right variable on
the setlocale() call, so someone more knowledgeable can look at it and fix it.
How this works, you say? Just like elm_object_text_part_set(), except now it
will pass the string given through dgettext() with the given domain (NULL
means it uses whatever the app set with textdomain()), and when changing
language with elm_language_set(), it will re-set the strings with a new
translation.
SVN revision: 64179
Using #include <elementary_config.h> will fail if
elementary has never been installed.
Signed-off-by: Mike McCormack <mj.mccormack@samsung.com>
SVN revision: 61220
Subject: [E-devel] [patch] elementary - elc_fileselector
Date: Sun, 26 Jun 2011 11:55:55 +0900
Dear elementary developers
When I compiled svn elementary, it seems a define(HAVE_EIO) is omitted.
I sending a patch, check about it please.
Thanks.
SVN revision: 60697
can be scrollable or not. scrolled entry now just calls entry calls
and is marked as dperecated to be killed off in the future so no need
to document it etc. edje external also goes.
SVN revision: 60438
Ryuan Choi
Daniel Juyung Seo
ChunEon Park
Daniel Juyung Seo
Yakov Goldberg
Stefan Schmidt
Cedric Bail
Daniel Zaoui
Tom Hacohen
Gustavo Lima Chaves
Flavio Vinicius Alvares Ceolin
Carsten Haitzler
Michael BOUCHAUD
Davide Andreoli
Sanjeev BA
Hyoyoung Chang
Boris Faure
Mike Blumenkrantz
Iván Briano
Cedric BAIL
Mike McCormack
Vincent Torri
David Walter Seikel