Subject: [E-devel] [patch] elm_cnp_helper - bugfix duplicated drag objs
Date: Tue, 3 Jan 2012 13:41:09 +0900
Dear all.
Currently, dragging is only supported in elm_photo.
Normally it works well but in overlapped region, elm_photo makes
multiple drag events.
However multiple objs dragging isn't supported by elm_cnp_helper(also
in xdnd specs)
It better to block multiple dragging events.
Also I fixed dragdonecb's data argument position.
Thank you.
SVN revision: 66773
Wayland Engine. Give elm window some 'framespace' and borders for
wayland_shm.
NB: This means that you can now build & run elm apps for Wayland :)
SVN revision: 66767
Subject: [E-devel] [patch] elm_cnp_helper - bugfix that dnd won't start
Date: Mon, 2 Jan 2012 16:52:05 +0900
Dear all.
elementary supports ecore_x dnd feature.
But currently eocre_x_dnd_aware_set isn't set by default
Its patch fixes this bug.
Thank you
SVN revision: 66740
codes are for the feature that "mouse down on slider bar" -> "button move to
the down position" -> "button will be dragged by mouse move".
SVN revision: 66733
auto-formatting scripts and i just spent a long time fixing the
results of one. the actual value of these macros is minimal at best
SVN revision: 66680
Subject: [E-devel] [Patch][elm_map] Smooth stepping of wheel & pinch
gesture
When elm_map doing zooming by using wheel gesture, scroller is resized
if it exceeds certain limit.
But current limit value is 2.0 & 1.0, actually those should be below
2.0 and above 1.0.
The reason is that resizing means exactly 2.0 or 1.0. So if it is
above 1.99x, it can be 2.0 and can be resized.
In addition, pinch.level & pinch.diff values should not be 1.0 or 2.0
for more accuracy. It should be half of previous pinch level or two
times of that.
SVN revision: 66658
Subject: [E-devel] [patch] add copy&paste example to elementary_test
Date: Thu, 29 Dec 2011 18:08:48 +0900
Dear all,
It's a patch to add copy&paste example to elm test in misc section.
In this time, it contains only simple copying and paste, but i'll more extend.
Thank you
SVN revision: 66629
Subject: [E-devel] [patch] elm_cnp_helper - code clean up
Date: Wed, 28 Dec 2011 19:29:39 +0900
Dear all,
it's a small patch which removes some needless compare and cleans up
code in elm_cnp_helper.
Thank you.
SVN revision: 66598
Subject: [E-devel] [Patch] elm_conform patch
Change Description:
When no geometry information of ind/sft/kbd, resetting the geometry.
SVN revision: 66586
Subject: [E-devel] [Patch][elm_map] Pause progressbar animator when
map is paused
When map is paused by using elm_map_paused_set(), all existing
animations is stopped.
(ref:
http://docs.enlightenment.org/auto/elementary/group__Map.html#ga6ab43ef6429140f8cccbd3669c5ed52e)
But progress bar can be still running before all download requests are
completed. It is equal to user expectations.
I have fixed this.
if paused is TRUE, stop progress bar.
If paused is FALSE, start progress bar if download requests are
remained.
SVN revision: 66585
The ctxpopup had used elm_ojbect_scroll_freeze_push(), pop() for the
scroll-freeze-on,of callback.
If user calls elm_object_scroll_freeze_pop() only after
elm_ojbect_scroll_freeze_push(), then it will be fine.
But sometimes user calls elm_object_scroll_freeze_pop() two times in a
row.. Then you can find there is infinite loop in following..
Signed-Off-By: cnook <kimcinoo@gmail.com>
SVN revision: 66584
Subject: [E-devel] [patch] elm_cnp_helper - change elm_cnp_selection_set and code cleanup
Date: Tue, 27 Dec 2011 20:15:14 +0900
Dear all.
As discomfitor suggested, I cleanup some codes.
elm_cnp_selection_set : add buffer length argument and check for image type.
(i think it's urgent issue before elm_cnp_selection_set api is widely used.)
enum defines : add 'type' prefix.
Thanks
SVN revision: 66566
Dear all,
I have found a bug that calculation fails when view port size is
bigger than map size.
For example, if map size is 256x256 but view port size is 798x798
(when zoom level is a 1), center longitude & latitude is out bound
from normal longitude & latitude.
I have fixed it.
Please review this patch.
Signed-Off-By: Bluezery <ohpowel@gmaill.com>
Signed-Off-By: ChunEon Park <hermet@hermet.pe.kr>
SVN revision: 66526
Subject: [E-devel] [Patch] [genlist] modified _item_block_unrealize
postion in calc_job
Previously, group item did not unrealized at rotate.
SVN revision: 66510
Subject: [E-devel] [patch] elm_cnp_helper - make some cnp apis as
public EAPI
As I suggested, I made a patch for some cnp apis.
I think copying and pasting APIs are pretty mature to be public
Those are elm_selection_set, elm_selection_clear, elm_selection_get.
And adding cnp prefix for distinction from word, or char selections.
elm_selection_set --> elm_cnp_selection_set
elm_selection_clear --> elm_cnp_selection_clear
elm_selection_get --> elm_cnp_selection_get
And drag and drop APIs should be remained as private.
It has many flaws.
SVN revision: 66505
Subject: [E-devel] [patch] elc_multibuttonentry - clean unused vars
I just clean unused vars of elc_multibuttonentry.
It made that gcc complains :P
SVN revision: 66504
Subject: [E-devel] [Patch][elm_map] Fix mouse down event propagation
It's simple bug fix for propagate mouse down event via long press
event properly.
SVN revision: 66503
2011/12/23 Chan-Wook Jung <joey.jung@samsung.com>:
>
> I attached 2nd patch. There are some changes about auto scroll.
> In previous version did not support various bring_in mode in calc_job. So I added scrollto_type value.
> I changed the code to fix this promblem,
> If the bring_in item is in the queue and did not changed pan size, Bring_in function is not working properly.
> When using expandable list, If the last item is in the screen, The last item is located at the bottom and
> If the last item is out of the screen, the expanded_item is located at the top.
>
> Thanks
> Chanwook Jung
SVN revision: 66488
Jeonghyun Yoon <jh0506.yun@samsung.com>
2011/12/23 윤정현 <jh0506.yun@samsung.com>:
> Dear All.
>
> I found a bug in elm_gengrid.c
>
> Gengrid will be crashed if input “Enter” key when selected is null.
>
> I fixed code, please review this small patch.
>
> Thanks.
SVN revision: 66471
Subject: [E-devel] [patch] elc_multibuttonentry - delayed reset string
I was sent email about elc_multibuttonentry's bug. It reviewed by seoz.
And he found some path can make segfault.
So I changed reset string position in the widget.
I patched resetting internal entry's position, before that some label
are broken by too early resetting.
SVN revision: 66461
Subject: [E-devel] [Patch][elm_map] Mouse wheel bug fix
There is mouse wheel bug. Actually I have made it in previous patch :p
When using mouse wheel, tile size was changed between 0.5 ~ 2.0 before
zoom level is changed. But actually it should be changed between
1.0 ~ 2.0. I have fixed it. If tile size is below 1.0, it does zoom-out.
And if tile size is above 2.0, it does zoom-in.
SVN revision: 66459
Subject: [E-devel] [Patch][elm_map] Mouse wheel bug fix
There is mouse wheel bug. Actually I have made it in previous patch :p
When using mouse wheel, tile size was changed between 0.5 ~ 2.0 before
zoom level is changed. But actually it should be changed between
1.0 ~ 2.0. I have fixed it. If tile size is below 1.0, it does zoom-out.
And if tile size is above 2.0, it does zoom-in.
SVN revision: 66458
Subject: [E-devel] [Patch] elc_ctxpopup, add restacking feature
I have attached two files, one is the patch(*.diff) for adding
restacking feature to the ctxpopup.
The other is test example(*.TEST_EXAMPLE). You can test on the
elementary_test > ctxpopup > "Ctxpopup with user content"
And click the button which is labeled "Enlightenment". Then label will
overlap the ctxpopup.. The ctxpopup will raise in a little time.
Please review the patch and if there is no problem, please throw the
test example away! :-)
SVN revision: 66415
Subject: [E-devel] [Patch][elm_map] Apply elm gesture
elm_map implement pinch gesture by using evas mouse event. But it made
codes too complicated and dirty.
So I have changed pinch gesture by using elm_gesture. wheel zooming is
also improved somewhat.
From now on, configuration change related elm_gesture easily applied
to elm_map and we can see more smooth zooming :D
Anyway, els_scroller have bugs when the scrolling event & the resize
event occurs at the same time.
So, some dirty codes are added for preventing jumping to strange positions.
Later it will be removed when the bugs are fixed.
SVN revision: 66413
Subject: [E-devel] [patch] elm_cnp_helper - bugfix mixing with ecore selection set apis
Date: Tue, 20 Dec 2011 18:57:25 +0900
Dear all
When ecore selection set apis(such as ecore_x_selection_clipboard_set)
used in elementary,
Some data is not pasted to elementary widgets.
It's due to mix ecore selection with elementary selection apis.
Data which by ecore doesn't have TARGETS information,
so elementary make it up with TARGETS Information for copying & pasting.
Thank you.
SVN revision: 66407
Subject: [E-devel] [patch] elm_cnp_helper - add type checking for non-elm cnp datas
Date: Fri, 16 Dec 2011 17:09:37 +0900
Dear developers
elm_cnp_helper supports rich types for copying & pasting.
but it doesn't extend like x11 way.
this patch introduces to reduce mismatch for checking selection type format.
now elm can live in harmony with non-elm cnp datas
Thanks
SVN revision: 66367
fault here again!
it would missed one case.
step 1. actual content set
step 2. NULL content set
Since it did not remove content_pair structure even NULL object as a new one set,
the dangling structure could be happened.
SVN revision: 66274
Hey dear, here is the second patch using the box for the ctxpopup's
content.
The wd->content is content which is set by
elm_object_content_set(ctxpopup, content) not the box.
Please check this and give any feedbacks, Thanks. :-)
Signed-Off-By: Kim Shinwoo <kimcinoo.efl@gmail.com>
Signed-Off-By: ChunEon Park <hermet@hermet.pe.kr>
SVN revision: 66268
Sure, I have separated the path.
The attached patch is for the using previous result which is calculated by
the _calc_base_geometry();
Thanks always.. Please review this patch first. I will send second one
based on the attached.
Sincerely,
Shinwoo Kim.
Signed-Off-By: Kim Shinwoo <kimcinoo.efl@gmail.com>
Signed-Off-By: ChunEon Park <hermet@hermet.pe.kr>
SVN revision: 66267
Subject: [E-devel] [Patch][elm_map] Bug fix for map test
This patch is for test map.
This fixes two simple bugs.
1. Max zoom level can be changed depends on the map source, not always 18.
2. $HOME can be NULL.
SVN revision: 66154
Subject: Re: [E-devel] [Patch][elm_map] Change grid management
(3) Simplify grid_load()
There exists 3 state for grid items. i.e., downloaded, downloading,
none states.
grid_load() does followings:
1. if a grid item does not exist, create it.
2. update a tile (if downloaded) or queues for download (if none) or
nothing (if downloading)
SVN revision: 66153
Subject: Re: [E-devel] [Patch][elm_map] Change grid management
(2) Revoking gi->have
I restore the gi->have values. The removal of this is my mistake.
gi->have is needed because I cannot know whether this file is
downloading (just opened and not written) or downloaded state even if
image file exists.
SVN revision: 66141
Subject: Re: [E-devel] [Patch][elm_map] Change grid management
(1) Grid Management
There are no caching mechanism in current elm_map.
So, too many network resources are wasted because elm_map keeps only
two grids and already downloaded images are downloaded again and
again. (This also slows the map loading speed)
I have changed this grid management policy.
I have done followings.
1. Create all grids (all zoom levels) when elm_map_add() is called (No
memory overhead because of sparse matrix)
2. Clear all grids when map object is deleted.
3. Loads necessary grids and unloads unused grids when zoom level is
changed.
Changed grid management have one weakness that memory and tmp size can
grow bigger while map object is live.
I think it may need API such as elm_map_cache_size_set().
SVN revision: 66140
Subject: [E-devel] [Patch] elm_genlist pan changed patch
This patch is to fix the problem that blinking is occured when
application use the ecore timer and
the rendering delay at pan resize/move using evas_object_smart_changed
instead of ecore_job_add.
SVN revision: 66132
Subject: Re: [E-devel] [Patch][elm_map] Change grid management
Grid Management
There are no caching mechanism in current elm_map.
So, too many network resources are wasted because elm_map keeps only
two grids and already downloaded images are downloaded again and
again. (This also slows the map loading speed)
I have changed this grid management policy.
I have done followings.
1. Create all grids (all zoom levels) when elm_map_add() is called (No
memory overhead because of sparse matrix)
2. Clear all grids when map object is deleted.
3. Loads necessary grids and unloads unused grids when zoom level is
changed.
Changed grid management have one weakness that memory and tmp size can
grow bigger while map object is live.
I think it may need API such as elm_map_cache_size_set().
SVN revision: 66131
As the title, attached patch has followings.
1) Using Calculated Value: The _update_arrow(); had used
evas_object_geometry_get(); internally for getting its base size.
But the _calc_base_geometry(); already got the base size which
is more accurate.
2) Getting Size From The Style Also: If the ctxpopup has content
which is composed using the style (means, the size of
content can get from *.edc file only), then ctxpopup does not
come properly. So resolving this, the patch is using a box,
and add a RESIZE callback to the box. When the box is resized,
the callback calls elm_box_recalculate();
SVN revision: 66130
elm_naviframe_event_enabled_set()
elm_naviframe_event_enabled_get()
Now, user could set events enabled/disabled when item pushing/popping.
SVN revision: 66102
Disabled is a property of Elm_Object_Item and was a property of
Elm_Toolbar_Item as well. The aforementioned commit didn't remove the
property from the latter and then used both properties in an
inconsistent manner which caused data not to be up to date.
SVN revision: 65989
happened after shilpa's refactoring patch.
it caused the elm_naviframe_item_style_set does not work properly.
more case-by-case checking added.
SVN revision: 65953
Subject: Re: [E-devel] [Patch] elm_slideshow patch
From: PRINCE KUMAR DUBEY <prince.dubey@samsung.com>
On behalf of Rajeev Ranjan, I am submitting the elm_slideshow patch
which add support for getting notification when transition completes.
Change Log:
new signal “transition,end” has been introduced to get notification
when transition completes.
Detail Description:
The actual requirement is to get user notified when the last item is
visible in the slideshow. In this case, user wants to take some
action, say updating button text to Restart if the slideshow does not
have loop.
The current implementation of slideshow has a signal called “changed”
which has current visible item as event_info parameter in the
callback. User can compare it with the last appended item and come to
know that the last item is visible if even_info is equal to the data
passed which should be the last appended item. The only problem is
that this signal is emitted by C code asynchronously to the
transition, hence if the transition involves an animation, user will
most likely get it even before the transition completes. This may look
bad to the user if the button label gets updated to Restart even
before the last transition gets over.
In order to fulfill the requirement, I have introduced another signal
“transition,end” which is emitted once the transition is over.
The same requirement could have been fulfilled by emitting “changed”
signal after the transition gets over but then this will be different
from the existing implementation for other widgets, hence I introduced
the new signal “transition,end”.
SVN revision: 65951
Hi,
On behalf of Rajeev Ranjan, I am submitting the elc_fileselector patch.
Change Log:
Fix for the memory leak in function elm_fileselector_selected_get. Memory allocated by ecore_file_dir_get() internally using strdup was not freed.
Introduced a char *dir variable to store the memory returned by ecore_file_dir_get() function and releasing the memory before returning to caller.
Please review it.
I'd appreciate any comments on this.
Thank you,
Prince
Signed-Off-By: Rajeev Ranjan (rajeev.r@samsung.com)
Signed-Off-By: Prince Kumar Dubey (prince.dubey@samsung.com)
Signed-Off-By: ChunEon Park (hermet@hermetpe.kr)
SVN revision: 65950
Sorry, I have forgotten adding comments to my patch.
OSM recommends to requesting map images distributively.
Please refere http://wiki.openstreetmap.org/wiki/Slippy_map_tilenames
I used 3 input parameters for selecting one from a, b, c or 1, 2, 3, 4
tile servers.
I attached patch with comments.
Signed-Off-By: TaeHwan Kim(ohpowel@gmail.com)
Signed-Off-By: ChunEon Park(hermet@hermet.pe.kr)
SVN revision: 65892
Subject: Re: [E-devel] [Patch][elm_map] Remove unnecessary flags
There are too may flags in elm_map. Most of them are duplicated and unnecessary.
I have removed "want", "download", "have" variables.
I use gi->job instead of "want" & "download".
I use ecore_file_exists() instead of "have" flags.
SVN revision: 65890
I have using elementary_test for testing elementary map widget.
But it use invalid object for signal callback. I have changed win --> map.
Also I have fixed invalid log message.
Signed-Off-By: TaeHwan Kim(ohpowel@gmail.com)
Signed-Off-By: ChunEon Park(hermet@hermet.pe.kr)
SVN revision: 65886
Subject: [E-devel] [patch] els_pan - bugfix gravity move
Date: Mon, 5 Dec 2011 13:29:48 +0900
Dear developers.
When gravity set on els_pan, user events are processing improperly.
Any touch event move pan to wrong position.
It's due to accumulate px, py.
So I fixed it.
Thanks
SVN revision: 65885
win_resize_object_add(win, subobj);
object_content_set(otherobj, subobj);
object_del(win);
ERR<21326>:elm-externals elm_widget.c:978 elm_widget_sub_object_del() removing sub object 0xdeadbeef (some_stupid_widget) from parent 0xRRRRRRRR (win), but elm-parent is different 0xFUCKTHIS (NOT EVEN A WIDGET)!
SVN revision: 65884
NOTE: As side fix, both genlist and gengrid now share their Widget_Data. Need
a lot more work to be clean and match our quality standard.
NOTE2: Genclear is now faster as it doesn't require to mark all item that need
to be removed, but just increase one int.
SVN revision: 65811
recent elementary api corrections.
I changed item class's 'label_get' to 'text_get'. But 'label_get' is still
supported by union structure. So 'label_get' will just give you
deprecated warnings while compiling but it's recommended to fix your
apps to 'text_get'. Sometimes when you initialize item class using
braces, you will get 'missing braces around initializer' but ignore
this. That warning will be gone after I remove 'label_get' backport. I
will remove this 'label_get' backport after I finish below
jobs.
[TODO]
1. Fix all apps in trunk.
2. Change edc "labels" to "texts" as well. I haven't done this yet.
SVN revision: 65751
deprecate all elm_gen APIs.
We will merge gengrid into genlist later and remove elm_gen.
I updated http://trac.enlightenment.org/e/wiki/ElementaryChanges
I will fix other libraries/programs in trunk soon.
SVN revision: 65700
a. Fix to handle the condition when read returns 0 and the content of buf is uninitialized in function handle_run inside file "src/bin/quicklaunch.c".
b. Indentation correction in function handle_run around the location of fix above.
Signed-Off-By: RAJEEV RANJAN <rajeev.r@samsumg.com>
Signed-Off-By: PRINCE KUMAR DUBEY <prince.dubey@samsung.com>
Signed-Off-By: ChunEon Park <hermet@hermet.pe.kr>
SVN revision: 65699
a. Handled memory allocation failure in function grid_create inside source file src/lib/elm_photocam.c of package elementary.
b. Fixed Memory leak in functiongrid_create due to return without releasing memory allocated for variable g of type Grid *.
Signed-Off-By: RAJEEV RANJAN <rajeev.r@samsung.com>
Signed-Off-By: PRINCE KUMAR DUBEY <prince.dubey@samsung.com>
Signed-Off-By: ChunEon Park <hermet@hermet.pe.kr>
SVN revision: 65698
Hi,
Attachment to the mail is elm_index patch.
Change Log:
a. Memory leak fix in function elm_index_item_append_relative due to memory allocated for item creation reamined allocated when the control returns.
b. Memory leak fix in function elm_index_item_prepend_relative due to memory allocated for item creation reamined allocated when the control returns.
Signed-Off-By: RAJEEV RANJAN <rajeev.r@samsung.com>
Signed-Off-By: PRINCE KUMAR DUBEY <prince.dubey@samsung.com>
Signed-Off-By: ChunEon Park <hermet@hermet.pe.kr>
SVN revision: 65697
Chang <hyoyoung.chang@samsung.com>
2011/10/27 Hyoyoung Chang <hyoyoung.chang@samsung.com>:
> Dear developers
>
> I made a patch to add elm_genlist_item_fields_update function.
> It can be used to updating genlist's item part without
realize/unrealize
> itself.
>
> Prototype is
> elm_genlist_item_fields_update
> (Elm_Genlist_Item *it, const char *part,
Elm_Genlist_Item_Field_Flags itf)
>
> Part supports globbing. Passing "*" to part means updating all parts.
> Item field can be one of icon, content and state.
> I think it's useful to speed up if an app updates frequently.
>
> Thanks
SVN revision: 65688
Fix to unreachable code in function elm_glview_resize_policy_set.
Signed-Off-By: RAJEEV RANJAN <rajeev.r@samsung.com>
Signed-Off-By: PRINCE KUMAR DUBEY <prince.dubey@samsung.com>
Signed-Off-By: ChunEon Park <hermet@hermet.pe.kr>
SVN revision: 65684
elc_naviframe.c: In function ‘_title_content_unset’:
elc_naviframe.c:786:17: warning: ‘content’ may be used uninitialized in this function
Signed-off-by: Mike McCormack <mj.mccormack@samsung.com>
SVN revision: 65682
Hi,
On behalf of Rajeev Ranjan, I am submitting the elm_gesture_layer patch.
Change Log:
a. Variable was used after freeing in function _remove_touched_device, now storing return value of eina_list_remove and then freeing pointer.
b. gesture pointer was dereferenced before checking it against NULL in function _rotate_test. Now dereferencing happens after NULL check.
c. Added NULL check for pointer before using it in function _event_process which is dereferenced in function _add_touched_device.
d. Memory leak fix in function elm_gesture_layer_add. Now using ELM_WIDGET_STANDARD_SETUP which takes care of NULL checks and freeing memory in case of failure.
Please review it.
I'd appreciate any comments on this.
Thank you,
Signed-Off-By: Rajeev Ranjan <rajeev.r@samsung.com>
Signed-Off-By: Prince Kumar Dubey <prince.dubey@samsung.com>
Signed-Off-By: ChunEon Park <hermet@hermet.pe.kr>
SVN revision: 65680
Hi,
On behalf of Rajeev Ranjan, I am submitting the elm_cnp_helper patch.
Change Log:
Removal of DEAD_CODE (Unreachable code statement tmppath = "/tmp").
Please review it.
I'd appreciate any comments on this.
Thank you,
SVN revision: 65666
Hi,
On behalf of Rajeev Ranjan, I am submitting the elm_flip patch.
Change Log:
a. Removed unnecessary comparison and assignment from the function _state_update inside file src/bin/test_flip_page.c. The comparison test will always be failed. Hence the assignment which was unreachable is removed.
b. Removed unnecessary comparison and assignment from the function _state_update inside file src/lib/elm_flip.c. The comparison test will always be failed. Hence the assignment which was unreachable is removed.
Please review it.
I'd appreciate any comments on this.
Thank you,
SVN revision: 65664
Hi,
On behalf of Rajeev Ranjan, I am submitting the elm_genlist patch.
Change Log:
a. Dead code removal in function _sizing_eval
b. Memory leak fix in function elm_genlist_item_insert_before due to return when wd->items is NULL and in this case, memory allocated for item was not getting free.
c. Memory leak fix in function elm_genlist_item_insert_after due to return when wd->items is NULL and in this case, memory allocated for item was not getting free.
Please review it.
I'd appreciate any comments on this.
Thank you,
SVN revision: 65662
it didn't work if orient were ELM_IMAGE_ROTATE_90_CW or CCW.
and it also make seg fault if application calls elm_image_orient_set more than twice.
for 90 or 270 rotation, we need seperate memory.
(It can be algorithm without more memory, but I selected readability than memory efficiency)
Before, els icon use file name for data2.
So it make problem, if file name was removed because of obj's data_set or size_set function.
I modified els icon code using copy data function.
SVN revision: 65634
Hi Mr. Park,
Change description: [ commit message ]
Bug: Hide signal sent twice in case of prev button, next button and icon swallow areas.
Fix: Hide signal sent only once in delete callback.
Thanks & Regards
Shilpa Singh
SVN revision: 65570
CC libelementary_la-elc_multibuttonentry.lo
elc_multibuttonentry.c: In function ‘_set_vis_guidetext’:
elc_multibuttonentry.c:309:20: warning: unused variable ‘en_width’
elc_multibuttonentry.c: In function ‘_resize_button’:
elc_multibuttonentry.c:741:16: warning: unused variable ‘button_text’
elc_multibuttonentry.c: In function ‘_add_button_item’:
elc_multibuttonentry.c:772:40: warning: unused variable ‘h_btn’
elc_multibuttonentry.c: In function ‘_entry_resized_cb’:
elc_multibuttonentry.c:1064:86: warning: unused parameter ‘event_info’
elc_multibuttonentry.c: In function ‘elm_multibuttonentry_item_select’:
elc_multibuttonentry.c:1531:12: warning: suggest explicit braces to avoid ambiguous ‘else’
elc_multibuttonentry.c: In function ‘_resize_button’:
elc_multibuttonentry.c:747:37: warning: ‘padding_inner’ is used uninitialized in this function
^Cmake: *** [libelementary_la-elc_multibuttonentry.lo] Error 1
Signed-off-by: Mike McCormack <mj.mccormack@samsung.com>
SVN revision: 65550
---------------------------------------------------
Dear Developers,
I added a new widget called “Multibuttonentry" which could be used as contact button in App
This widget allows a user to insert a text button.
text button is inserted by pressing the "Enter key"
If there is no space in the current row, the new button is entered in the next row. If the button is clicked, it will become focused.
And focused button can be removed by pressing the "backspace" key.
when items are added over 1 lines, if Multibuttonentry lost focus, it becase shrink mode (made it as 1 line)
Please review it's APIs and functionalities.
Thank you,
Goun
---------------------------------------------------
Widget was originally written by Hyunsil Park <hyunsil.park@samsung.com>.
It has been contributed to by the following people:
* Jihoon Kim <jihoon48.kim@samsung.com>
* WooHyun Jung <wh0705.jung@samsung.com>
* deasung.kim <deasung.kim@samsung.com>
* Myungjae Lee <mjae.lee@samsung.com>
* Goun Lee <gouni.lee@samsung.com>
* Mike McCormack <mj.mccormack@samsung.com>
* Daniel Juyung Seo <juyung.seo@samsung.com>
* Seunggyun Kim <sgyun.kim@samsung.com>
* sanghoon80.cho <sanghoon80.cho@samsung.com>
Signed-off-by: 이고은 <gouni.lee@samsung.com>
Signed-off-by: Mike McCormack <mj.mccormack@samsung.com>
SVN revision: 65548
elm_win.c: In function ‘elm_win_focus_get’:
elm_win.c:2182:4: warning: ‘return’ with no value, in function returning non-void
Signed-off-by: Mike McCormack <mj.mccormack@samsung.com>
SVN revision: 65527
Firstly, for efficiency, we add a Job to calculate the whole canvas. Jobs implicitly coallate work per event loop.
Calcuation of object can be a reasonably intensive set of work.
In the job callback we calculate the whole canvas with evas_smart_objects_calculate() to ensure that all objects have the correct geometry at this point.
Reviewed by Raster.
SVN revision: 65509
Previous part names are just the swallow part names
but in modified version, the part names chaned to simpler meaning names to use.
i.e for button
elm_object_content_part_set(button, "elm.swallow.icon", icon);
-> elm_object_content_part_set(button, "icon", icon);
SVN revision: 65295
This commit introduces two new API: elm_entry_textblock_get and
elm_entry_calc_force. These two APIs can be used to manipulate the
textblock object inside the entry in a safe manner. This exposes an
interface that wasn't available before letting do new and cool things
with entries.
SVN revision: 65169
Hi,
There are bugs that map removes list elements when using
EINA_LIST_FOREACH or EINA_LIST_REVERSE_FOREACH.
We should use EINA_LIST_FOREACH_SAFE or EINA_LIST_REVERSE_FOREACH_SAFE
instead for above case.
Please review belows
SVN revision: 65069
edjeobject, not elm_button. This patch will change all button
edje_objects to real elm_button. And long_press will be supported by
elm_button's autorepeat feature. (This patch was made by Shilpa. Thanks)
SVN revision: 64931
Subject: [E-devel] [elm_map] ecore_file_download_full() should be used
properly
elm_map only checked that returned job is NULL.
But ecore_file_download_full() returns EINA_FALSE when error occurred.
So return value should be checked for proper usage.
Please review this simple bug fix
SVN revision: 64794
Subject: [E-devel] [elm_map] Fix up too many connections at the same
time.
Currently, elm_map requests all visible map image tile to map server
at the
same time.
If the scene is turned off while panning or zooming, it will be
aborted on
HTTP requests.
But it already sent to map server, and it already made useless HTTP
connections.
So if you pan scrolling quickly, elm_map try to download and abort too
many
HTTP
connections repeatedly.
If you have stable and high-throughput data connection, it doesn't
matter
on your side.
However map server will get high load, It is sufficient reason to block
you.
In another case, if you have poor data connection such as 3G
connection, it
has less
throughput and it causes delay of downloading. And finally, the device
is
as full as
HTTP connections even you already aborted. It makes low-performance
issue on
your device.
I wrote a patch for solving this situation.
The idea is simple.
1. I limited number of maximum HTTP request on elm_map side.
2. If maximum HTTP request is exceed, keep requests on Eina_List.
3. If each image downloading is completed, try to download recent
request.
(Because it has strong possibility for your screen)
4. At the same time, invisible request will be removed.
(It doesn't make HTTP connection yet)
I tested many times on my desktop and device.
It works for me. And elm_map's performance is improved
appreciably on 3G
connections.
SVN revision: 64685
When the scroller is dragged repeatedly in a short time, it is accelerated.
If it reaches the edge of the content, the bouncing is started.
Sometimes because of the acceleration, the content cannot be shown in a moment.
In order to avoid that situation, the bounce animation have to be fixed
according the amount of acceleration.
SVN revision: 64642
This reverts commit 64549.
I gotta adimt, your commit looks correct to me, but hey, it breaks
elementary_test's "Window Inline" test... Please investigate it further
and make re-apply your commit afetr your solve these issues.
SVN revision: 64605
Subject: [E-devel] [Patch] elm_map: add image loading error handling
I made a bug fix for elm_map.
When a downloaded image has an error, , elm_map removes a file and goes on
just like download succeeded .
However, it is not success, so it should be marked as FALSE for later retry.
SVN revision: 64598
Avoid leak caused by not updated signal name.
Btw, Mr. Valgrind is sad with elm developers.
Lots of warnings regarding uninitialised values.
SVN revision: 64582
This is actually a pretty important thing to remember.
elm_win_resize_object_add resizes the content to the size of the window,
the size of the window is only applied when the window is shown, at least on
the ecore evas. Is that wanted? or should we take the evas-object geometry
there? The problem I'm worried about is: writing beyond buffer limits.
SVN revision: 64579
currently, only X window system undergo async problem,
but other windowing system meet same problem if it have asyncmode.
so I dont have to handle per-display specifics higher up above ecore-evas.
(use ecore_evas_request_XXX instead of ecore_evas_x11_request_XXX)
not only async windowing system but also situation wm refuse resizing request,
make request size != current size.
so I'll implement ee->req value to other windowing system.
--under this line, and those below, will be ignored--
M elm_win.c
SVN revision: 64549
Subject: [E-devel] [E-Devel][Patch] Evas GL Color Format Enum change
(and ElmGLview changes accordingly)
I'm submitting a patch that changes the color format for Evas GL.
When I first wrote Evas_GL, I just had EVAS_GL_RGB_8 and EVAS_GL_RGBA_8 and etc
but it was misleading for some people. It was more of a filler since I couldn't decide on
a name. I'm finally changing it to make it more clear.
SVN revision: 64491
Until now it was only possible for scrolled entries.
This patch is by Hyoyoung Chang, which I adjusted to conform to my previous
patch.
SVN revision: 64436
elm_entry_autocapital_type_set API is high level API to call ecore_imf_context_autocapital_type_set.
Application programmer can choose the type of autocapitalization such as
WORD, SENTENCE, ALLCHARACTER through this API.
elm_entry_input_panel_enabled_set API is for setting whether input panel
(virtual keyboard) should be appeared when entry has a focus or pressed.
It can be used by dialer or calculator application programmer because those
application prefer to use its keypad NOT virtual keyboard supported by system.
They want to use entry to show the cursor for providing the cursor handling
method but don't want to appear system keyboard.
SVN revision: 64424
Besides we free the object pointed by esd, we NEED the right pointer's
value to unregister the signal with
edje_object_signal_callback_del_full().
SVN revision: 64415
At first, try to execute elementary_test and drag down the list for bounce.
Then as soon as release the mouse, click the list continuously and fast.
The list will not be clicked because it cannot be clicked during the bounce
animation. The bounce animation time is fixed and it is reset again, when
the mouse is down and up. In the result, if we click it continuously, we can
not choose the list item. (During animation, list can not be clicked).
I changed the function "_smart_bounce_x_animator" and "_smart_bounce_
y_animator". I fixed the bounce time will be changed by remaining distance.
SVN revision: 64407
I found a problem in els_scroller. When the scroller is resized, it shows the location of
the coordination which was saved into wanted_coordination. If you don't use the page,
it is no matter. But if you use the page function, the animation of the scroller is operated
by _smart_scrollto_x_animator, not by _smart_momentum_animator.
In _smart_scrollto_x_animator, therer isn't _update_wanted_coordinates. So the value of
wanted_coordination doesn't update. I think _update_wanted_coordinates have to be added in
_smart_scrollto_x_animator and _smart_scrollto_y_animator.
Please check the attached patch file.
SVN revision: 64406