1. delete old content object
2. check whether new content object is same as old content object
3. rename internal content set hook function
4. elm_widget_sub_object_del will be followed by evas_object_del
5. added some doxygen description.
SVN revision: 69738
<hyoyoung@gmail.com>
On Thu, Mar 29, 2012 at 4:56 PM, Hyoyoung Chang <hyoyoung@gmail.com>
wrote:
> Dear all
>
> I made a patch about flip_realize.
> Currently flip feature uses content_objs, so it should keep its
content_objs.
> However it's lost at _item_flips_realize().
> So i fixed to initialize with its content_objs.
>
> Thanks
SVN revision: 69725
Attached to the mail is a patch for elm_panes.
I have a query that shall we hide the unset content in the widget itself or should application explicitly hide them after unsetting!
In case of edje_object_part_unswallow, application needs to do it explicitly and it is documented but in case of elm_object_part_content_unset, there is no documentation available.
Details of the patch:
Existing Issue before this change:
1. Panes deletes the older content while setting a new content even though both are same.
2. left and right content are being unswallowed in the content_left_set and _content_right_unset functions. So when the reparenting happens, say when the content is put inside a layout then only _sub_del gets called and
unswallowing does not happen as these functions do not get called.
e.g. @@ -253,8 +250,6 @@ _content_left_unset(Evas_Object *obj)
if (!wd->contents.left) return NULL;
Evas_Object *content = wd->contents.left;
elm_widget_sub_object_del(obj, content); //wd->contents.left already gets set to NULL in _sub_del
- edje_object_part_unswallow(wd->panes, content); // can be unswallowed in _sub_del as in case of reparenting like setting content in a layout, only _sub_del will get called, not this function
- wd->contents.left = NULL; //this instruction is redundent as it happens in _sub_del anyway
return content;
}
Change Description:
1. Unswallowing the contents now in _sub_del as this is a common function to be executed when subobject removal happens.
2. Comparing the current content with new before deleting.
Signed-Off-By: RAJEEV RANJAN<rajeev.r@samsumg.com>
Thanks.
Regards,
Rajeev
SVN revision: 69720
The string will be freed in application's callback later. So 'const' is
not appropriate.
In elm_slider_indicator_format_function_set and
elm_slider_units_format_function_set.
SVN revision: 69692
<jchanwook@gmail.com>
On Wed, Mar 28, 2012 at 3:06 PM, chanwook jung <jchanwook@gmail.com>
wrote:
> Dear all,
>
> I added one line to fix the bug at tree effect. If the item is equal
to
> expanded_next_item, expanded_next_item set to NULL in _item_del
>
> Thanks,
> Joey
SVN revision: 69691
way, is this correct? I had build warnings before.
menu_example_01.c: In function ‘_del_it’:
menu_example_01.c:17:6: warning: assignment discards qualifiers from
pointer target type
SVN revision: 69681
Daniel Juyung Seo
Carsten Haitzler
ChunEon Park
WooHyun Jung
ShilpaOnkar Singh