Commit Graph

56440 Commits

Author SHA1 Message Date
Marcel Hollerbach 56522f19ff efl_ui_focus_manager_sub: do not specify a interface as first argument
this leads in eo to the meaning that the manager.sub is giving
implementations to that interface, but leaving the ->func with NULL,
which leads on some maschines to the assumation that this is
pure_virtual, which means not composition objects will be queried, on
other maschines this will work, since there other inherits will
overwrite this entry and set ->src to NULL.

While i still dont understand why this works on some maschines and does
not on others, this is is now fixed.
2017-11-17 16:08:14 +01:00
Marcel Hollerbach b93e744e1f elm_widget: simplify code
there is now a utility function
2017-11-17 16:08:14 +01:00
Marcel Hollerbach 2ba64efe62 Eo: be a bit more detailed in the docs
this is completly not obvious. But now its documented.
2017-11-17 16:08:14 +01:00
Marcel Hollerbach 19cb57d914 efl_ui_focus_manager_calc: efl_wref_del deletes the wref
A happy thank you goes to the doc for leaving this trivial peace of
information undiscovered!

Followup commit will fix this
2017-11-17 16:08:14 +01:00
Marcel Hollerbach ffca5284ae efl_ui_focus_manager:do not followup if we have not changed candidate
_followup_previous_direction should only be called if there was a real
change to the redirect. In was happening that we have not changed the
focus but called _followup_previous_direction, which lead to weird focus
changes.
2017-11-17 16:08:14 +01:00
Marcel Hollerbach f8badf1c06 elm_widget: remove focus set
calling this function was not working at all, so its gone now
2017-11-17 16:08:14 +01:00
Marcel Hollerbach 84a6a329fe elementary: stop using elm_widget_focus_set 2017-11-17 16:08:14 +01:00
Marcel Hollerbach 6daff0e6f4 elm_main: checking the redirect chain is not neccessery
the manager is in or has no focused element
2017-11-17 16:08:14 +01:00
Marcel Hollerbach 1e5c894a1b elm_main: replace _elm_object_focus_set with efl_ui_focus_util_focus 2017-11-17 16:08:14 +01:00
Marcel Hollerbach 4086f18ebf efl_ui_focus_manager_calc: error if a element is not registered yet 2017-11-17 16:08:14 +01:00
Marcel Hollerbach 2e6a08737d efl_ui_focus_object: emit changed event after the flag gets set
otherwise new efl_ui_focus_object_focus_get calls could be confused.
2017-11-17 16:08:14 +01:00
Marcel Hollerbach 738cb8a2bb efl_ui_focus_util: add a util class
the util class is for common code that is just added again and again.
2017-11-17 16:08:14 +01:00
Andrii Kroitor c37226ef5e elm_genlist: fix rare segfault
Conditions:
- style is "double_label"
- the is some content for items (i.e elm_label)
- elm_genlist_filter set was once called after genlist creation with
  NULL data
- label_get callback uses elm_genlist_item_prev_get on its current item
- at least one item is added as a sub-item
- ~2 blocks of items are added afterwards
- items are added quickly while holding 'enter' on an elm_button

@fix
2017-11-17 10:16:41 +02:00
Amitesh Singh 35f3019a6d Efl.Ui.Slider: add default indicator format to %0.2f
This was broken in legacy code as well.
Thanks to @taxi2se for reporting.

elm_test -> slider -> check vertical slider

@fix
2017-11-17 14:55:51 +09:00
Amitesh Singh 19e70a8e1f Efl.Ui.Slider: replace default with on_drag in visible_mode enum.
Ref T6376
2017-11-17 14:38:32 +09:00
Amitesh Singh 651d9e94a0 Efl.Ui.Slider: add visible_mode() as an indicator part API
Ref T6376
2017-11-17 14:38:32 +09:00
Amitesh Singh 67996afbf6 Efl.Ui.Slider: make indicator_visible_mode() legacy APIs
Ref T6376
2017-11-17 14:38:32 +09:00
Amitesh Singh 77164413cd Efl.Ui.Slider: make indicator_show_on_focus/indicator_show() legacy APIs
Ref T6376
2017-11-17 14:38:32 +09:00
Jean-Philippe Andre 28d74624ec tests/eldbus: Use different bus for cxx and C tests
I had eldbus_suite and eldbus_cxx_suite fail quite often for some
strange reason: name already in use... yeah but by who??? Turns out both
test cases used the same name, and when ran in parallel (make -j10
check) this would often fail.
2017-11-17 11:57:15 +09:00
Jean-Philippe Andre bae51a0612 tests: Add better debugging for eldbus failure
It keeps on failing for me, but quite inconsistently (i.e. sometimes,
not always). Annoying.
2017-11-17 11:57:15 +09:00
Shilpa Singh e58e00b08a elm_index: Index item role modify
Summary:
Modified index item role to EFL_ACCESS_ROLE_RADIO_MENU_ITEM from EFL_ACCESS_ROLE_PUSH_BUTTON
as index item should maintain its current state.

Test Plan:
Query the role of index item from atspi client, ATSPI_ROLE_RADIO_MENU_ITEM role should
be returned.

Reviewers: kimcinoo

Reviewed By: kimcinoo

Subscribers: cedric, govi, rajeshps, jpeg

Differential Revision: https://phab.enlightenment.org/D5486
2017-11-17 10:18:18 +09:00
Derek Foreman 1bd513305e ecore_wl2: fix user pointer for dmabuf param listener
Proving once again that those that defeat type safety usually get what
they deserve.
2017-11-16 13:18:48 -06:00
Derek Foreman 925be86f9e ecore_wl2: Fix dmabuf test failure
We need to destroy the buffer manager on fail, since it will exist but
only be able to create buffers we can't actually use.
2017-11-16 13:18:48 -06:00
Derek Foreman c08920820b ecore_wl2: Don't try to close drm_fd if we never opened it
derp.
2017-11-16 13:13:38 -06:00
Andy Williams 63c6724f08 eina: fix docs for manage_read_only_new 2017-11-16 12:49:56 +00:00
Jean-Philippe Andre 313eb563b5 win: Rename specific APIs to avoid clashes
This renames 3 basic APIs specific to Win:
 - name
 - type
 - role

Ref T5322
2017-11-16 19:11:51 +09:00
Lukasz Stanislawski 57e0d19c45 elm: return Efl.Access.Actions only if action_area is not set
Summary:
The accessibility clients should not have a possibility
to dismiss popup in case when action area is set.

Reviewers: jpeg

Subscribers: cedric, jpeg

Differential Revision: https://phab.enlightenment.org/D5481
2017-11-16 18:17:49 +09:00
Shilpa Singh 54657b0a95 elm_index: Send selected signal to atspi client
Summary: When Index item is selected, notify atspi clients.

Test Plan:
when atspi mode is enabled, item selection notification
should be received by atspi client

Reviewers: kimcinoo

Subscribers: cedric, govi, rajeshps, jpeg

Differential Revision: https://phab.enlightenment.org/D5485
2017-11-16 18:17:49 +09:00
Lukasz Stanislawski 989f6c27d2 elm: enhance access name for spinner
Summary: Try to take access name from internal entry object or text button first.

Subscribers: cedric, jpeg

Differential Revision: https://phab.enlightenment.org/D5480
2017-11-16 12:12:04 +09:00
Lukasz Stanislawski 20c9dd1e84 elm: add Efl.Access.Value interface to progressbar
Subscribers: cedric, jpeg

Differential Revision: https://phab.enlightenment.org/D5479
2017-11-16 12:05:21 +09:00
Jean-Philippe Andre e9ebe5c676 elm: Define and rename internal atspi struct in EO
This thing is used by only 2 EO APIs that are marked as @beta. I wonder
if the @beta tag or the ptr() expression made it work for eolian,
because it simply wasn't defined in EO.

I'm renaming it just so that it's more consistent with the new names
used by atspi (and EO API in general).
2017-11-16 12:00:18 +09:00
Lukasz Stanislawski c838e30a24 elm: Rename elm_interface_atspi_widget_action mixin
Reviewers: jpeg

Subscribers: jenkins, cedric, jpeg

Differential Revision: https://phab.enlightenment.org/D5400
2017-11-16 12:00:18 +09:00
Cedric Bail 30adccd6a2 elementary: make sure that ecore shutdown match ecore init. 2017-11-15 16:29:14 -08:00
Cedric Bail babcb0f1e4 elementary: do not send a PAUSE event if not iconified. 2017-11-15 16:29:14 -08:00
Cedric Bail 1112ce2a8a ecore: should be the one triggering EFL_LOOP_EVENT_TERMINATE. 2017-11-15 16:29:14 -08:00
Cedric Bail cd1f5915d2 elementary: add an interface to enable/disable PAUSE/RESUME application state.
If you want to have EFL application behave in a more efficient way. Like dropping
memory usage or stopping unecessary network operation, this option should be on
and the application should listen on PAUSE/RESUME event on the main loop.
2017-11-15 16:28:20 -08:00
Derek Foreman fcdbc07fe3 ecore_wl2: Don't open rendernode if we're not going to use it
We should only open this when actually testing dmabuf.  Otherwise we're
just wasting time and adding an opportunity to fail shm init over
unrelated issues.
2017-11-15 11:54:37 -06:00
Derek Foreman 23f5b41176 ecore_wl2: Reset buffer_manager to NULL on failure
Calling this multiple times even after it fails the first time is a legit
thing now.  We'll be doing that when we want to test dmabuf at connection
start.
2017-11-15 11:54:37 -06:00
Derek Foreman 517f929aa5 ecore_wl2: Send a dmabuf non-immediate create at startup
We use immediate mode dmabuf creation at runtime, but this can result in
clients being killed with no option to fallback if the buffers can't be
consumed by the compositor.

This test should catch when a system can allocate a dmabuf buffer and the
compositor claims to accept dmabuf, but the buffer can't actually be used
for whatever reason.  We'll then use wl_shm at runtime instead of dmabuf.
2017-11-15 11:54:37 -06:00
Derek Foreman 3ac556f2e1 ecore_wl2: factor out part of buffer creation
So we can use it to make a non-immediate mode buffer test.
2017-11-15 11:54:37 -06:00
Derek Foreman 04cebba623 ecore_wl2: Filter buffer types by compositor capabilities
It does us no good to be able to allocate dmabuf capable memory if the
compositor can't handle it.  This should fix failures on systems where
allocation is possible but the compositor doesn't advertise dmabuf.
2017-11-15 11:54:37 -06:00
Derek Foreman 579b6d69b3 ecore_wl2: Add a second sync for dmabuf formats
While we don't yet use these, we should, so let's make sure they're
available before we start making windows.
2017-11-15 11:54:37 -06:00
Derek Foreman 054bdc870b ecore_wl2: Refcount syncs at startup
There are some binds at startup that result in additional information
being sent, so we may need to call wl_display_sync() multiple times, and
only send the client a SYNC_DONE event when the final one completes.
2017-11-15 11:54:37 -06:00
Derek Foreman e863dcaae7 ecore_wl2: Create xkb_context before compositor connection
We really need this to exist before potentially processing seat/keyboard
stuff in _ecore_wl2_display_connect()
2017-11-15 11:54:37 -06:00
Derek Foreman 9fdcf7d0eb wayland_shm/ecore_wl2: Move buffer allocation into ecore_wl2
This moves all the platform specific buffer allocation into ecore_wl2
instead of the engine.

Note that this makes an internal struct available in the header.  This
will be removed shortly.
2017-11-15 11:54:37 -06:00
Derek Foreman f6ec5b961b wayland_shm: Move wl_buffer creation function further up file
It just looks nicer when it's here and doesn't require a prototype.
2017-11-15 11:54:37 -06:00
Derek Foreman 46539ce26d wayland_shm: Make the buffer_manager static
Should always have been, oops.
2017-11-15 11:54:37 -06:00
Derek Foreman 66f85dd06c wayland_shm: Become unhoseable
Now that shm is handled through these paths the dmabuf_totally_hosed state
is nonsense.
2017-11-15 11:54:37 -06:00
Derek Foreman 2071122f01 wayland_shm: rename Surface_Type to Ecore_Wl2_Buffer_Type 2017-11-15 11:54:37 -06:00
Derek Foreman f9ff2e4fa5 wayland_shm: Remove surface_type from surface
This has become not only a write-only variable, but also incorrectly set.

Just remove it.
2017-11-15 11:54:37 -06:00