Summary:
Hoversel Widget is designed in such a way that it accepts top/bottom/left/right directions , internally it uses hover widget which does not take care if its content goes of it's parent (Elm_Win in most cases) . this patch ensures that the drop-down content remains restricted in visible hover_parent. it would fix T2965
Signed-off-by: divyesh purohit <div.purohit@samsung.com>
Signed-off-by: Jee-Yong Um <conr2d@gmail.com>
Test Plan:
Open entry widget and right click to show a hoversel widget, check if the hoversel or hover content goes out of the window.
this is what hoversel would look like after this patch {F27551}
Screenshots of top-left / top-right/ bottom-left and bottom-right corners in entry after this patch
{F27553}
{F27554}
{F27555}
{F27557}
Reviewers: shilpasingh, conr2d, raster, cedric, Hermet
Subscribers: rajeshps, govi
Projects: #elementary
Maniphest Tasks: T2965
Differential Revision: https://phab.enlightenment.org/D3513
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
The following new color classes
for scroller widget are added and changed.
Reviewers: raster, cedric, Hermet, kimcinoo, woohyun
Differential Revision: https://phab.enlightenment.org/D3493
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Apply ctxpopup color class
- ctxpopup_bg
Test Plan:
1. change ctxpopup bg color class in colorclass.edc
2. run elementary test
3. check the color of ctxpopup bg
Reviewers: Hermet, kimcinoo, woohyun, raster
Differential Revision: https://phab.enlightenment.org/D3492
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Apply popup color class
- popup bg
- popup title bg
- popup title text
- popup text
Test Plan:
1. change popup color class in colorclass.edc
2. run elementary test
3. check the color of popup
Reviewers: Hermet, kimcinoo, woohyun, raster
Differential Revision: https://phab.enlightenment.org/D3489
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
The following new color classes and text classes
for spinner widget are added.
"spinner_bg", "Spinner Background"
@feature
Reviewers: raster, cedric, Hermet, kimcinoo, woohyun
Subscribers: SanghyeonLee, eagleeye, id213sin
Differential Revision: https://phab.enlightenment.org/D3488
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Add new text classes and color classes for Entry widget according to
consistency with other widget's class.
And it removes legacy classes. If we need to support backward
compatibility, the legacy classes have to be maintained in each widget.
Test Plan: N/A
Reviewers: cedric, woohyun, jaehwan, kimcinoo, raster
Subscribers: CHAN
Differential Revision: https://phab.enlightenment.org/D3486
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
The following new color classes and text classes
for calendar widget are added.
"calendar_year_text" - Year Text in Title Area
"calendar_month_text" - Month Text in Title Area
"calendar_weekday_text" - Weekday Text
"calendar_day_text" - Day Text
"calendar_day_text_holiday" - Holiday Text
"calendar_day_text_today" - Today Text
"calendar_day_text_disabled" - Disabled Day Text
"calendar_day_selected" - Selected Day Effect
"calendar_day_highlighted" - Highlighted Day Effect
"calendar_day_checked" - Checked Day Effect
@feature
Test Plan: N/A
Reviewers: woohyun, raster, cedric, kimcinoo, jaehwan
Subscribers: CHAN
Differential Revision: https://phab.enlightenment.org/D3482
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
minw and minh are overwritten in the next line at once.
This patch removes a meaningless line.
Reviewers: cedric
Differential Revision: https://phab.enlightenment.org/D3450
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Add new scrollto type allowing to align gengrid item to bottom of viewport.
Feature compleates and closes list of all alignment types for gengrid items.
Reviewers: seoz, cedric, SanghyeonLee
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D3452
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Add new scrollto type allowing to align genlist item to bottom of viewport.
Feature compleates and closes list of all alignment types for genlist items.
@feature
Test Plan: elementary_test => Genlist Show/Bring
Reviewers: cedric, seoz, SanghyeonLee
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D3447
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
An Eo class Elm.Sys_Notify acts as a manager of notification
servers. A manager registers and unregisters notification servers.
Notification servers implement the Elm.Sys_Notify_Interface
which allows to send and close notifications.
Currently, only the DBus server is implemented (legacy code).
Even though there are many changes in the code, there should
be no API nor ABI breaks.
Reviewers: naguirre, seoz, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3172
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
If the content object of genlist item is 'elm_layout' class,
minimum size cannot get directly becuase layout do the delay calculating.
So to make proper genlist size calc, before the swallowing,
forcely do the size calc about layout class contents in genlist.
@fix
Test Plan: N/A
Reviewers: raster, cedric, singh.amitesh, Hermet
Reviewed By: Hermet
Subscribers: seoz, conr2d, eagleeye
Differential Revision: https://phab.enlightenment.org/D3478
Summary:
It is useful for changing item's state according to shrink mode.
@feature
Test Plan:
It includes a use case for the patch in toolbar default theme.
Run "elementary_test -to toolbar2".
Reviewers: jaehwan, woohyun, cedric, raster
Subscribers: eagleeye
Differential Revision: https://phab.enlightenment.org/D3481
0 is a "valid" max size, so using it as the default value
results in a box being 0x0 if there are no explicit max size
hints set on any child objects
ref aef9d23550bbcd74829a5d75d5226ba394a9da87
tl;dr: if you haven't used aspect hints on objects packed into boxes,
this commit has no effect on anything you've done
in some cases, using weight+align hints are not sufficient in order to
do a simple box packing of objects.
one example of this is when a box's size is not explicitly determined,
such as if it is packed with EXPAND into another container and contains
only objects with no min size hint, such as images. in this case, the box
will determine that its min size is extremely small, resulting in nearly-hidden
contents inside the box.
using aspect hints, this outcome is noticeably different. the expanded/filled
potential size of a box item is used to calculate the aspected size, and this
size, if it fits within min/max constraints, is then used to calculate the min
size of the box.
as a more concrete example:
* create box with maximum size 100x50
* pack 2x image into box
- set VERTICAL aspect, EXPAND, FILL
have 2x 50x50 images
also I added some docs
@feature
Previously, clicking and holding the decrease or increase button would start the drag mode, which made the buttons pretty much unusable on a touchscreen.
Now, it is only set over the text button as expected.
For the record, dragging is unusable for a small count of discrete values as the value will change for each and every pixel movement–have a go at the months spinner test.
valgrind pointed out an issue in elm cursor handling. this fixes that.
the handle was lost, yet it was still around due to it being
overwritten without deletion.
@fix
Seems these 2 functions are currently unused inside elm_calendar. For
now, let's just #if 0 them out
Signed-off-by: Chris Michael <cpmichael@osg.samsung.com>
It was a bad idea to add this test to the basic genlist test. Moving the
focus with arrow keys faced unexpected genlist clear to testers. We have
"genlist del" test so it's ok to remove this.
Summary:
This code is wrong and enforces developers to manipulate
resize_obj filed directly, instead of using elm_widget_resize_object_set.
Test Plan:
check if objects inheriting from elm_widget do not set field
directly.
Reviewers: cedric, raster, seoz
Subscribers: seoz
Projects: #elementary
Differential Revision: https://phab.enlightenment.org/D3362
Summary:
The default value of size_hint_min is 0, but in sizing_eval of
some elm widgets, default min value is set to -1.
Reviewers: cedric, Hermet
Reviewed By: Hermet
Subscribers: Hermet
Differential Revision: https://phab.enlightenment.org/D3451
Summary:
Even doing almost same thihgs in inc_XXX fucntions, dec_XXX fucntion.
It was separated up.
So i merged those functions for code size reduce.
Test Plan:
Run elementary_test
Execute spinner sample.
Reviewers: cedric, Hermet
Differential Revision: https://phab.enlightenment.org/D3455
To configure elementary sources with bindings to use in nodejs add
––with-js=nodejs in configure flags in EFL compilation to generate
node files, then compile elementary normally:
path/to/efl$ configure --with-js=nodejs
path/to/efl$ make
path/to/efl$ make install
path/to/elm$ configure
path/to/efl$ make
path/to/efl$ make install
To use, you have to require elm:
elm = require('elm')
The bindings is divided in two parts: generated and manually
written. The generation uses the Eolian library for parsing Eo files
and generate C++ code that is compiled against V8 interpreter library
to create a elm.node file that can be required in a node.js instance.
@feature
Summary:
Fix to hide magnifier when menu is disabled
@fix
Test Plan:
1. Enable magnifier
2. Disable menu
3. Long press and mouse up
4. observe magnifier is not hidden.
Reviewers: tasn, herdsman, thiepha
Subscribers: shilpasingh
Differential Revision: https://phab.enlightenment.org/D3490
Summary:
The spinner buttons in elm_calendar widget can be replaced by elm_buttons.
Then, using elm_button widgets makes it much easier to maintain.
And the buttons has to be focusable with "tab" key just like elm_spinner widget.
The lagacy callbacks for signals from edje is not removed for backward compatibility.
@feature
Test Plan: elementary_test -> calendar, calendar2, calendar3
Reviewers: seoz, Hermet, kimcinoo, cedric, woohyun
Reviewed By: woohyun
Subscribers: CHAN
Differential Revision: https://phab.enlightenment.org/D3198
Summary:
Add newline filter
Using the present filter infra
a newline or paragraph separator filter
is being added for single line entry.
@fix
Test Plan:
Copy multiline text from
and paste it to single line entry.
it will fix T2660
Reviewers: herdsman, tasn
Subscribers: thiepha, DaveMDS
Maniphest Tasks: T2660
Differential Revision: https://phab.enlightenment.org/D3109
Summary:
The use of elm_widget_type_get here is pretty harmfull, for the usecase
of inheriting a widget elm_widget_type_get is something else than
before. But the key binding should still work.
@fix T2891
Reviewers: tasn
Reviewed By: tasn
Maniphest Tasks: T2891
Differential Revision: https://phab.enlightenment.org/D3470
this is handled correctly in evas. checking load errors from
the engine/loaders is sufficient, but the printed ERR messages
for these cases have been improved
partially reverts 865383aa0da5d1eb6d29f4ed5447a73f63800a33
reverts ee7d5425628942a45e23a2cb6be253db8ec0b3fd
ref 840dcc618ead292414b0de64a7a3ae38d778311f
ref a915229dc87606472480a8b2eacce9514055ac27
fix Titalia
Clean up elm_popup actions. Move actions should not be used
from accessibility API. Only dismiss seems to be resonable
action which could be triggered.
The selection is cleared by losscb when we set it.
As result, selection is not done.
To avoid it, we should check if the new selection owner
is current selection owner or not and only call losscb
if the new selection owner is not the current one.
Test Plan:
In wayland, select text in entry (e.g double click, ctrl-a).
divyesh purohit
Sung-Taek Hong
woochan lee
Hosang Kim
taehyub
Youngbok Shin
Jee-Yong Um
Lukasz Stanislawski
Jean Guyomarc'h
SangHyeon Lee
Mike Blumenkrantz
Hermet Park
Chidambar Zinnoury
Chris Michael
Vincent Torri
Carsten Haitzler
Daniel Juyung Seo
Felipe Magno de Almeida
Subodh Kumar
Shinwoo Kim
Tom Hacohen
Marcel Hollerbach
Jaehyun Cho
Thiep Ha