fix two bugs - use elm_smart_scroller_edje_object_get in case of edje object
fix conditional statement when parameter is 0 in
elm_smart_scroller_page_show,
elm_smart_scroller_page_bring_in
SVN revision: 64010
Let's have the content_hook thing for entry actually work, and if the
icon setters use that instead of having an entirely different code it may
also be a good idea.
SVN revision: 63999
zoom, rotate - Fixed continues gesture mode issues.
momentum - Fixed un relayable values returned for this gestures.
line - Fixed line continues mode issues.
Thank to Enumi Lee for reporting.
Signed-off-by: Aharon Hillel <a.hillel@partner.samsung.com>
SVN revision: 63960
Subject: [E-devel] [Patch] elm_diskselector, set icon to added item
If the diskselector is round mode, the scroller of diskselector has
additional items for its rounding(carousel) effect.
Previously, elm_diskselector_item_icon_set(); did not care about
theses additional items.
Please review the attached patch that will care. Thanks.
SVN revision: 63957
Crappy zoom and region_show code. If anyone wants to fix it before I get
back to it, discomfitor will buy you a beer.
It's intended to mimic as much as possible photocam's zoom api, but webkit
doesn't always help with that.
SVN revision: 63936
this change resolves the transition problem also
When user set the item style again.
every time, transition signals are called,
Transition start position of the page will be reset.
SVN revision: 63869
eina_hash_pointer IS DISGUSTING! :-( It does not store the pointer,
but allocates something to hold the pointer, giving it back to you in
an unexpected way :-/
SVN revision: 63858
This contains a very simple and stupid window manager to be used in
FB, PS3 or similar single-window engines. Everybody is welcome to
improve it, particularly:
* Edje: better border decoration theme
* Edje: nice background
* C + Edje: taskbar with minimized items.
* C + Edje: find a better protocol to determine window size,
accounting border decoration without account shadow! Right now I'm
taking everything :-P
* C: window management keys (Alt+F4 and like)
How to use: export ELM_ENGINE=ews
How to configure backing store: export ECORE_EVAS_EWS=engine❌y:w:h:options
Example:
{{{
export ECORE_EVAS_EWS=software_x11:0:0:1024:768
export ELM_ENGINE=ews
elementary_test
}}}
Bugs: maybe many, but so far seems it wouldn't take mouse events for
secondary windows. Will check it later.
SVN revision: 63849
Subject: [E-devel] [Patch] els_scroller - bouncing doesn't work in
specific case
I found the bouncing of the scroller doesn't work in specific case.
When the scroller is scrolled but the animation doesn't occur,
sd->down.dy is not changed. Then in elm_smart_scroller_child_pos_set,
it's possible not to pass the below conditional sentence even if it
have to has the bounce.
if (((y < miny) && (0 <= sd->down.dy)) ||
((y > (my + miny)) && (0 >= sd->down.dy)))
So I reset the value sd->down.dx and sd->down.dy to 0 when mouse is up.
Please check patch file.
SVN revision: 63797
On Tue, Oct 4, 2011 at 7:54 AM, Benjamin Drucker
<benjamin.t.drucker@alum.mit.edu> wrote:
> Right now, signals coming from the gengrid's internal edje object are
> propagated up to the gengrid object.
> This patch enables the other direction as well: you can use the
functions
>
> elm_object_signal_callback_add(grid, ...)
> elm_object_signal_callback_del(grid, ...)
>
> to signal the gengrid's internal edje object.
>
> Please review, thanks.
> -Ben
SVN revision: 63784
Subject: Re: [E-devel] [Patch] elm_gengrid reorder bug patch
I found a gengrid bug about reordering.
It sometimes happens that some gengrid item disappear when reorder item.
SVN revision: 63783
elm_object_item_object_get() should probably be implemented at some point, but that is definitely one of the dumbest function names I have ever heard
SVN revision: 63711
when this mode is enabled, a toolbar item will always be selected. if the selected item is deleted, the next item will be selected. if there is no next item, the first item will be selected. if there is no next or first item, you can go <expletive deleted> yourself.
SVN revision: 63691
Started by glima as a thin wrapper around ewk_view to make webkit
work better integrated with Elementary, then grew up as a more complete
widget thanks to k-s' magic fingers, and now I screwed it up but it looks
like it works, so there..
Build WebKit-EFL, rebuild Elementary and enjoy elm_web.
SVN revision: 63676
Subject: [E-devel] [patch] elm_{entry, label} - add evas_event_{freeze, thaw}
This patch adds evas_event_freeze and thaw to elm_{entry,label}.
Normally it's not speed up much. But in some event storm cases, it's speed
up to 10% in my test cases (which is putting 200 entries in a box)
SVN revision: 63666
* proxy signals from evas_object_box: child,removed and child,added. Both
will carry event_info being the child element.
* elm_box_recalculate() to force recalculation of internal box, thus
applying the layout to children.
Thanks btdrucke for reporting!
SVN revision: 63630
Hi all,
I found few memory related issues in elementary package when performed static analysis on it.
These issues include:
Array indices getting out of bounds, freed memory address being passed to a function as parameter, memory not getting cleaned up because of earlier return statement.
Issues details:
1. In elm_widget.c inside function elm_widget_signal_callback_del(), it is possible that freed memory address esd is passed to the sd->callback_del_func(). I think it should be data, not esd.
Moreover what if the callback frees memory for data, then the other problem is that the return value is data from the function elm_widget_signal_callback_del() which in my opinion can be a problem.
2. Inside directory src/edje_externals for files elm_genlist.c, elm_notify.c, elm_list.c, elm_thumb.c and elm_map.c, array indices can go beyound bounary.
sizeof() operator for an array of character pointers will return [number of elements in the array * size of (char*)], basically 4 times the number of elements which has been taken care in assertion inside src/edje_extenarnals
while performing assertion but has been missed in the next statement in the loop condition.
3. In file src/lib/elm_config.c inside function _elm_config_profiles_list, freeing of file iterator has been missed out.
Please review the attached patch and let me know your opinion.
Thanks.
Regards,
Rajeev
SVN revision: 63550
From: Kim Yunhan <spbear@gmail.com>
When you test elm_map with mouse wheel, it worked abnormally because of some bug.
So I made some more patch for fixing it.
This patch file also includes a previous patch (zoom-out issue).
SVN revision: 63510
I wrote a patch that handles a bug while zooming-out in elm_map.
When I try to zoom out, some tiles are broken.
But it is hard to notice because broken frame disappears quickly.
I investigated in a few days.
And I realize that there are something wrong.
When map is zoomed out, a tile is shrunk by evas_object_resize().
But evas_map handles its texture by just its origin image size not a shrunk size.
If evas_object's width & height is shrunk, I have to handle for its texture.
SVN revision: 63509
Since the users have no idea about elm_object_item content/text parts names which are available,
added those part names in doc here.
SVN revision: 63485
<benjamin.t.drucker@alum.mit.edu>. Thanks a lot!
On Wed, Aug 31, 2011 at 1:52 PM, Benjamin Drucker
<benjamin.t.drucker@alum.mit.edu> wrote:
> Earlier this month, there was a svn commit
> (http://trac.enlightenment.org/e/changeset/62496) which added a few
> page-related APIs to the elm scroller. These should probably also be
> added to gengrid, genlist and maybe even grid and list. Right now,
> though, I need them for gengrid. So I propose this patch, based
> entirely on the change that went in before. I've built it and I'm
> using these new gengrid APIs in my code now.
On Fri, Sep 9, 2011 at 4:45 PM, Benjamin Drucker
<benjamin.t.drucker@alum.mit.edu> wrote:
> Slowly but surely....
>
> This version of the gengrid page APIs patch has the following changes:
> 1. fixed spacing issues
> 2. add const where needed
> 3. submitted a gengrid longpressed change in a separate patch
>
> I really want to try to squeak this in the upcoming release if at all
> possible. If I have an extra space in some file, I promise I'll not do
> it again for the next patch!
>
> Thanks!!
> Ben
SVN revision: 63403
Subject: [E-devel] [Patch] elm_diskselector (ticket #853)
Date: Thu, 8 Sep 2011 12:41:27 +0900
Dear All, Hello~
The attached patch for resolving the ticket #853.
(http://trac.enlightenment.org/e/ticket/853)
There is an issue when it comes to rounded item.
Anyhow, I will fix it also.
Sincerely,
Shinwoo Kim
SVN revision: 63386
On Tue, Sep 13, 2011 at 10:47 PM, Jihoon Kim <imfine98@gmail.com> wrote:
> Hello, EFL developers.
>
> At this moment, the title format of elementary calendar widget is "%B %Y".
> However, it should be displayed as "%Y년 %B" in Korea.
> This patch is implemented for supporting this feature.
>
> Would you please apply this patch?
SVN revision: 63360
On Fri, Sep 9, 2011 at 4:18 PM, Benjamin Drucker <benjamin.t.drucker@alum.mit.edu> wrote:
> gengrid already emits "longpressed" signals, but it is not currently
> documented nor demonstrated in the examples. See the attached patch,
> please.
SVN revision: 63323
TODO: Clean code (added this version to have easy way of review), and maybe add pref-var of enabling disabline continues gestures
Signed-off-by: Aharon Hillel <a.hillel@partner.samsung.com>
SVN revision: 63285
On Wed, Sep 7, 2011 at 6:51 PM, Hyoyoung Chang <hyoyoung.chang@samsung.com> wrote:
> Dear developers.
>
> This patch is fixing - hangs after using elm_diskselector_item_selected_set.
> Elm_diskselector add a idler and remove in _move_scroller with checking
> wd->idler
> But in elm_diskselector_item_selected_set, it's not use wd->idler.
> So idler is called infinite.
>
> It also registered in ticket ( http://trac.enlightenment.org/e/ticket/854 )
>
> Thank you
On Wed, Sep 7, 2011 at 7:00 PM, Hyoyoung Chang <hyoyoung.chang@samsung.com> wrote:
> I omitted about credit.
> With cnook, I can easily find this bug.
> Thanks to cnook
SVN revision: 63269
Subject: [E-devel] [PATCH] Add new API elm_diskfileselector_item_num_get()
Kindly review and provide your comments on this patch, that adds new API
elm_diskfileselector_item_num_get().
Add elm_diskselector_display_item_num_get() API.
Added required documentation in docx and Elementary.h.in files.
Updated test programs to print number of items set - as a verification.
Make input param as const. Thanks SeoZ.
SVN revision: 63107
Instead of EAPI elm_main(***), it must be EAPI_MAIN elm_main(***) so that
it also work on Windows.
If someone knows sed a bit, can he also change all the examples ?
SVN revision: 62885
Subject: [E-devel] [Patch] signal "scroll,anim,stop" in els_scroller
fix the bug which the signal "scroll,anim,stop" is not called sometimes.
SVN revision: 62789
Subject: [E-devel] [PATCH] add elm_entry_input_panel_layout_set API
elm_entry_input_panel_layout_set API is high level API to call
ecore_imf_context_input_panel_layout_set (through edje).
This API will be used to set layout of input panel (such as URL, Email,
Number layout...) by application programmer.
Would you please review this patch?
Please let me know if I have to do more.
SVN revision: 62782
Using these APIs of elm_main.c, password last show feature can be enabled or
disabled and the time out value for which character will be visible before
being masked also can be manipulated. Change description as given below.
"Change Descritption"
Four APIs have been added to elementary in order to manipulate the global settings
of show last feature of password mode of entry widget.
The settings include
1. enable/disable the show_last feature [ set and get API ].
2. Manipulate the time out value [ set and get API ].
SVN revision: 62781
Subject: [E-devel] [Patch] elm_genlist_clear
When items are added right after genlist clear, genlist is scrolled to the previous position.
If all item is deleted, the scroller have to locate 0, 0.
But scroller has wanted position to remembers the scrolled location.
So even if all item is deleted, it locate previous position.
Then I added elm_smart_scroller_child_region_show(wd->scr, 0, 0, 0, 0)
at the end of the elm_genlist_clear.
SVN revision: 62778
genlists.
When the items are made invalid, don't access rotten pointers! I think
I did it right, but it exposes a bug on genlist test 2, elementary
test. I'll let that fix to the authors of that specific code
(insert_after() and such).
SVN revision: 62763
Dear All, Hello!
The transition effect is added to the ctxpopup when it comes.
Please review the attached patch. Thanks always!
Sincerely,
Shinwoo Kim.
SVN revision: 62735
Chanwook Jung <joey.jung@samsung.com>
From: 정찬욱 [mailto:joey.jung@samsung.com]
Sent: Friday, August 19, 2011 4:40 PM
Subject: [E-devel] [Patch] bug in elm_genlist_item_insert_after
Dear developers.
I found the problem when group item is added using
elm_genlist_item_insert_after in genlist.
The new group item is refer to the group item list not item list.
Therefore
it is inserted in the wrong place.
I modified that if the new group item is inserted, refer to the last
item
of the after group item.
Thanks.
SVN revision: 62645
I always try to maintain elm with no trailing whitespaces. Please do not commit trailing whitespaces anymore.
I think maintaining a library clean is a good job. Once it gets mess, it's hard to fix them all at once.
1. Removing trailing whitespaces.
2. Fixing indentations.
3. Removing build errors and warnings.
SVN revision: 62595
as in elm manages it itself - all it needs is a module to send text
to. one is provided here that just execs espeak and handles a stream
of things for it to say. this is only a start and is still being
fleshed out.
SVN revision: 62585
I added 4 APIs for the page function of the scroller.
Those are,
EAPI void elm_scroller_current_page_get(Evas_Object *obj, int
*h_pagenumber,
int *v_pagenumber));
(Get scroll current page number.)
EAPI void elm_scroller_last_page_get(Evas_Object *obj, int
*h_pagenumber,
int *v_pagenumber);
(Get scroll last page number.)
EAPI void elm_scroller_page_show(Evas_Object *obj, int
h_pagenumber, int
v_pagenumber);
(Show a specific virtual region within the scroller content
object by page
number without animation.)
EAPI void elm_scroller_page_bring_in(Evas_Object *obj, int
h_pagenumber, int
v_pagenumber);
(Show a specific virtual region within the scroller content
object by page
number with animation.)
SVN revision: 62496
1. Enhance the document.
2. Call elm_icon_animated_xxx() when the icon supports animation.
3. Anyway, animated icon doesn't work on my machine :(
I got this error when I ran it.
>> sh: evas_image_loader.gif: not found
SVN revision: 62426
Dear All, Hi!
Previously, the ctxpopup have used only direction up or down if there is no
enough area to display.
So, there was some dead codes and TODO list for this..
By using wd->horizontal, we can decide between "up/down" and "left/right"
If elc_ctxpopup is horizontal, "up/down" is more proper than "left/right"
and vice versa.
Sincerely,
Shinwoo Kim.
SVN revision: 62420
Dear All, Hi!
There were come codes in _del_pre_hook() that just don't make sense.
Please refer to the attached patch.
Sincerely,
Shinwoo Kim.
SVN revision: 62419
ChunEon Park
Mike Blumenkrantz
Iván Briano
Shilpa Singh
Mike McCormack
Mike McCormack
Rajeev Ranjan
Aharon Hillel
cnook
Michael BOUCHAUD
Daniel Juyung Seo
Gustavo Sverzut Barbieri
Cedric BAIL
Jaehwan Kim
Jeonghyun Yun
Carsten Haitzler
Hyoyoung Chang
WooHyun Jung
Tom Hacohen
Kim Yunhan
Sangho Park
Nicolas Aguirre
Sanjeev BA
Vincent Torri
Gustavo Lima Chaves
Jihoon Kim
Jiyoun Park