Sebastian Dransfeld
7576ff00f3
Set secure file permissions for temporary file
...
From glibc mkstemp man page:
In glibc versions 2.06 and earlier, the file is created with
permissions 0666, that is, read and write for all users. This old
behavior may be a security risk, especially since other UNIX flavors
use 0600, and somebody might overlook this detail when porting
programs. POSIX.1-2008 adds a requirement that the file be created
with mode 0600.
More generally, the POSIX specification of mkstemp() does not say
anything about file modes, so the application should make sure its
file mode creation mask (see umask(2)) is set appropriately before
calling mkstemp() (and mkostemp()).
And:
http://cwe.mitre.org/data/definitions/377.html
2013-10-16 04:28:53 +02:00
ChunEon Park
eea1b83cf6
evas/map - Fixed the map surface to be updated properly.
...
By tranversing the whole of the map target's tree,
it decides to update the map surface to be redrawn if one of the objects is changed except the clipper itself.
2013-10-15 22:24:27 +09:00
Chris Michael
cf859cfacc
Fix horrid formatting
...
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-10-15 13:40:50 +01:00
Chris Michael
7c6e4a2339
Fix doxy typo
...
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-10-15 13:38:44 +01:00
Chris Michael
961c8c8684
Remove blank line
...
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2013-10-15 13:38:44 +01:00
Cedric Bail
4be4076cd4
edje: handle reallocation of pointed data properly for limits.
2013-10-15 18:15:51 +09:00
Carsten Haitzler
aba7e9892e
evas - fix textblock handling of effects for shadows and so on in some cases
2013-10-15 16:05:11 +09:00
ChunEon Park
0daa2d02c7
Edje - Fixed memory leak in the edje map color transition.
...
Some cases, It doesn't free the interpolated colors.
Now it has guaranteed to free them always.
2013-10-15 15:00:13 +09:00
Carsten Haitzler
e309967384
Revert "ecore_evas: window does not go back to normal state if you set iconified to EINA_FALSE."
...
This reverts commit 9bfb730ff5
.
wrong! on deiconify this will now FORCE a ACTIVATE request to the wm
(which asks the wm to focus the window/hilight it and make it active.
might switch desktops or whatever). this is wrong. de-icoifying a
windows does NOT mean ALSO activating it!. the log message also doesnt
say what "go back to normal state"... means.... do they expect/INSIST
windows MUSt be focused after de-iconification? that's wrong as it's a
window management FOCUS policy, not something to do in the lib.
2013-10-15 10:45:37 +09:00
Carsten Haitzler
f93329d119
Revert "eina: fix CID 1106340: Logically dead code (DEADCODE) reported by coverity."
...
This reverts commit 1c1b48ca64
.
this commit is causing all sorts of hell and crashes, hangs and what
not. like:
Thread 1 (Thread 0x7feb7389e780 (LWP 7149)):
No symbol table info available.
No symbol table info available.
at lib/eina/eina_inlist.c:422
l = 0xf38a50
__FUNCTION__ = "eina_inlist_demote"
#3 0x00007feb6a809867 in
_eina_chained_mempool_alloc_in (
pool=pool@entry=0x8650a0, p=p@entry=0xf38a50)
at modules/eina/mp/chained_pool/eina_chained_mempool.c:197
mem = 0xf3a690
#4 0x00007feb6a809dff in eina_chained_mempool_malloc
(data=0x8650a0,
size=<optimized out>)
at modules/eina/mp/chained_pool/eina_chained_mempool.c:300
pool = 0x8650a0
p = 0xf38a50
mem = <optimized out>
#5 0x00007feb6a7e451f in
eina_mempool_malloc (size=40, mp=<optimized out>)
at lib/eina/eina_inline_mempool.x:103
No locals.
#6 _eina_list_mempool_list_new (list=0x7feb5402a510)
at lib/eina/eina_list.c:199
No locals.
#7 eina_list_append (list=0x7feb5402a510, data=0xf41720)
at lib/eina/eina_list.c:534
l = <optimized out>
__FUNCTION__ = "eina_list_append"
#8 0x0000000000445d1a in
e_bindings_signal_add (ctxt=<optimized out>,
sig=0x947e6c "mouse,clicked,[12]", src=0x92248c "e.event.close",
mod=E_BINDING_MODIFIER_NONE, any_mod=1, action=0x93479c
"window_close",
params=0x0) at e_bindings.c:1036
binding = 0xf41720
#9 0x00000000004469d4 in e_bindings_init () at
e_bindings.c:68
ebs = 0x947df0
ebm = <optimized out>
ebw = <optimized out>
ebe = <optimized out>
ebk = <optimized out>
eba = <optimized out>
l = 0x9532e0
#10
0x0000000000437516 in main (argc=<optimized out>, argv=<optimized out>)
at e_main.c:941
safe_mode = 0 '\000'
after_restart = 1 '\001'
waslocked = 0 '\000'
t = <optimized out>
tstart = <optimized out>
s = <optimized out>
buff =
"1381800872.3", '\000' <repeats 19 times>
action = {__sigaction_handler = {
sa_handler = 0x4fca00 <e_sigabrt_act>,
sa_sigaction = 0x4fca00
<e_sigabrt_act>}, sa_mask = {__val = {
0 <repeats 16 times>}}, sa_flags = -1073741820,
sa_restorer = 0x0}
__FUNCTION__ = "main"
Detaching from program:
/usr/local/bin/enlightenment, process 7149
2013-10-15 10:42:26 +09:00
Cedric Bail
48b0f8515a
ecore_file: fix left over borking.
...
I think I teached raster well, my job here is done !
2013-10-15 10:21:03 +09:00
Carsten Haitzler
ea9963f469
ecore-file - remove ifdefs for HAVE_CULR since ecore-con "always" has it
...
now that it's runtime dlopen'ed etc. ecore-con "always" has url
support via curl so ecore-file needs to assume that this can always
work and this just use ecore-con-url anyway.
2013-10-15 09:16:26 +09:00
Yakov Goldberg
ed8301b8bf
eo: fix doxygen description, which is needed for parser
2013-10-14 18:12:28 +03:00
Cedric BAIL
443012dbcb
edje: typo fix.
2013-10-14 14:00:59 +02:00
Cedric BAIL
48bc51b0c7
edje: fix CID 1054522 - Logically dead code
...
The buffer is a static buffer in that scenario, so never going to be NULL indeed.
2013-10-14 13:53:06 +02:00
Cedric BAIL
12072b2217
edje: fix CID 1062226 - Dereference after null check.
...
It seems to be possible in some badly crafted edj to trigger that path.
2013-10-14 13:45:26 +02:00
Cedric BAIL
15b9a640ac
evas: fix CID 1102547 - Resource leak
...
If all rectangle are clipped out, it is perfectly possible to return
no rectangle, this would lead to a possible leak.
2013-10-14 13:37:50 +02:00
Cedric BAIL
1c1b48ca64
eina: fix CID 1106340: Logically dead code (DEADCODE) reported by coverity.
2013-10-14 13:32:46 +02:00
Sebastian Dransfeld
c7c08b0e3e
efreet: No need to set pointer value
...
CID 1039919
2013-10-14 13:22:34 +02:00
Sebastian Dransfeld
76721f4153
efreet: Check buffer size
...
CID 1039582, 1039583
2013-10-14 13:21:48 +02:00
Sebastian Dransfeld
e2dabc5d23
efreet: Set umask before creating temporary file
...
CID 1039615
2013-10-14 13:20:44 +02:00
Sebastian Dransfeld
67a8feeb08
efreet: Set umask before creating temp file
...
CID 1039616
2013-10-14 13:19:59 +02:00
Sebastian Dransfeld
cc89eb2af9
efreet: Check size of buffer and '\0' terminate
...
CID 1039595
2013-10-14 13:14:59 +02:00
Sebastian Dransfeld
6b18d7b80a
efreet: Check if count != 0
...
CID 1039434
2013-10-14 13:14:55 +02:00
Sebastian Dransfeld
7f30306031
efreet: Always '\0' terminate buf
...
CID 1039721
2013-10-14 11:54:51 +02:00
Sung W. Park
56e71e05bb
Evas: EGL-GL backends. Call eglReleaseThread() upon shutdown
...
Call proper cleanup code upon terminating egl use.
2013-10-14 14:37:36 +09:00
Carsten Haitzler
a01ba5718d
evas - small buglet. image size of up to but NOT including 32768 are valid
2013-10-14 12:41:28 +09:00
m.biliavskyi
806c81876b
edje: add getters and setter for interpolation variables 1 and 2 in transition block of program.
...
Reviewers: cedric
Differential Revision: https://phab.enlightenment.org/D253
Signed-off-by: Cedric Bail <cedric.bail@samsung.com>
2013-10-14 12:10:19 +09:00
Michal Jagiello
9bfb730ff5
ecore_evas: window does not go back to normal state if you set iconified to EINA_FALSE.
...
Reviewers: cedric, raster, Hermet
Differential Revision: https://phab.enlightenment.org/D245
Signed-off-by: Cedric Bail <cedric.bail@samsung.com>
2013-10-14 12:10:19 +09:00
Jean Guyomarc'h
dd2f6b1370
evas: fix build for Mac OS X.
...
Reviewers: cedric, michael.bouchaud
CC: cedric
Differential Revision: https://phab.enlightenment.org/D242
Signed-off-by: Cedric Bail <cedric.bail@samsung.com>
2013-10-14 12:10:19 +09:00
Jean-Philippe Andre
b143727389
evas: Add configure option to disable cserve
...
Some people might want to disable cserve2 at build time to
generate smaller packages.
2013-10-14 10:55:47 +09:00
Carsten Haitzler
6732ab15af
1 char editing messup - revert it.
2013-10-13 11:38:59 +09:00
Jérémy Zurcher
59a73bdcad
eo: enable doc generation
2013-10-13 00:00:13 +02:00
Jérémy Zurcher
9e246eadd0
eo: cover eo_class_get new behaviour
2013-10-13 00:00:13 +02:00
Jérémy Zurcher
1648b67c5b
eo: add EO_CLASS_CLASS
...
it's an empty class without operations,
used as a return value for eo_class_get() when the caller is a class
2013-10-13 00:00:13 +02:00
Carsten Haitzler
f3e3739e7c
edje_cc - CEEEEEEEEEEEEDRIIIIIIIIC! realloc+lookup bug workaround!
...
need i say more. this is a q1uick workaround a bug that is a result of
realloc moving memory around and thus lookups becoming broken.
2013-10-13 02:07:28 +09:00
Rafael Antognolli
c4f1e67686
ecore/wayland: Do not generate subsurface source files.
...
Add them to the tree, so they don't need to be generated again on each
build. Also remove the autofoo code used for generating them.
2013-10-11 14:26:34 -03:00
Stefan Schmidt
ac89c082a4
Revert "Revert "eina: use Eina_Spinlock for Eina_Chained_Mempool.""
...
Revert now that it is fixed in eina.
This reverts commit 875e7cf74d
.
2013-10-11 09:42:49 +01:00
Stefan Schmidt
ab0f7ca625
Revert "Revert "Revert "eina: use Eina_Spinlock for Eina_Chained_Mempool."""
...
Is there a title for the commiter with the longest revert of a revert list?
I screwed this one up. Had other local changes that sneaked in.
Resetting and doing it right now.
This reverts commit ee155b771d
.
2013-10-11 09:41:22 +01:00
Stefan Schmidt
ee155b771d
Revert "Revert "eina: use Eina_Spinlock for Eina_Chained_Mempool.""
...
You can bet on reverting makes people speed up the process in fixing it.
Revert the revert here now that Cedric fixed it in eina.
This reverts commit 875e7cf74d
.
2013-10-11 09:36:35 +01:00
Cedric Bail
68a4e85483
eina: that stuff was just for adding a bug in fact.
2013-10-11 17:30:35 +09:00
Stefan Schmidt
875e7cf74d
Revert "eina: use Eina_Spinlock for Eina_Chained_Mempool."
...
This patch brings in constant E crash for me. It seems to be timing
related which somehow leads to a mem corruption. Revert it for now
to allow people using E while Cedric looks into it.
This reverts commit 12d34309c7
.
2013-10-11 09:18:10 +01:00
Carsten Haitzler
69e27abdc3
eina - and e3fl in general - stop using eina_error_get/set - useless really
2013-10-11 16:50:40 +09:00
Cedric Bail
725237df0a
edje: It should never happen, but apparently it does, so assert to get a proper bt.
2013-10-11 15:15:54 +09:00
Cedric Bail
64b2b9c2b2
edje: fix a memory leak of Edje_Part_Element for any .edj using them.
2013-10-11 14:47:44 +09:00
Cedric Bail
c718a41728
eet: log size of subtype added to an Eet_Data_Descriptor.
...
This is really useful to track down a leak of a memory piece allocated by an
eet_data function. If you know the size of the leaked structure (valgrind
give you the total allocated size and the number of structure in it, so you
need to divide before having the right number), you just need to do :
EINA_LOG_LEVELS=eet:3 my_app 2>&1 | grep the_size
And there will be very few line matching reducing what you should be looking at.
2013-10-11 14:43:35 +09:00
Cedric Bail
7caef271dc
ecore: Use Eina_Spinlock for Ecore_Thread.
2013-10-11 11:08:17 +09:00
Cedric Bail
6dcffec491
evas: Use Eina_Spinlock for Evas_Scalecache, Evas_Async_Events and Image_Entry.
2013-10-11 11:08:17 +09:00
Cedric Bail
12d34309c7
eina: use Eina_Spinlock for Eina_Chained_Mempool.
2013-10-11 11:08:17 +09:00
Cedric Bail
b9d8a7af3a
eet: use Eina_Spinlock instead of Eina_Lock for Eet_Dictionary.
2013-10-11 11:08:17 +09:00