Commit Graph

64856 Commits

Author SHA1 Message Date
Felipe Magno de Almeida 3a385ccae0 Fix invalid XML comment in efl_mono.dll.config
Use <!-- and --> to comment the license files

Reviewed-by: João Paulo Taylor Ienczak Zanette <joao.tiz@expertisesolutions.com.br>
Differential Revision: https://phab.enlightenment.org/D10790
2019-12-19 18:29:44 -03:00
Marcel Hollerbach c514d3363e efl_content: equip the tests with more lifetime checks
this can be used to detect more lifetime issues, which catched errors in
efl.ui.panel and efl.ui.scroller.

ref T8536

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10921
2019-12-19 11:46:26 -08:00
Marcel Hollerbach d1480d7762 efl_ui_scroller: remove from the sub_object list on unset
this should fix lifetime issues with Efl.Ui.Scroller

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10920
2019-12-19 11:46:24 -08:00
Marcel Hollerbach 3e7424c86d efl_ui_panel: fix Efl.Content implementation
It appears that content has been deleted, even if it has been unset
before. This also fixes event emission on content_unset.

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10919
2019-12-19 11:46:23 -08:00
Cedric BAIL 0a399b3ca3 elementary: make sure Efl.Ui.Multi_Selectable_Index_Range use unsigned int for index too.
T8469

Reviewed-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D10910
2019-12-19 09:57:12 -08:00
Ali Alzyod 46fef6901d efl.text.cursor: clean eo files from comments
Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8454

Differential Revision: https://phab.enlightenment.org/D10926
2019-12-19 16:09:12 +01:00
Hermet Park 11a1fc9f2b ector software: catch up losing tasks among the threads.
This is a subsequent change after 8465904c19.

The major change is almost same but just for gradient stuff.
2019-12-19 20:30:31 +09:00
Carsten Haitzler e2887ec2aa evas textblock - use snprintf to limit buffer and have buffer big enough
the buffer wasn't big enough for all possible content anyway and it
didn't use snprintf, so large values of i could overflow... pointed to
by warning. fix that warning.
2019-12-19 10:33:37 +00:00
Hosang Kim ed7fb7ae27 scroller: add missing efl_content_unset
When efl_content_unset(scroller) is called, efl_content_unset for Efl.Ui.Pan class should be called also.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10906
2019-12-19 10:24:21 +01:00
Yeongjong Lee 1d49102bbe efl: add @since tags for stabilized classes
Summary: Add missing @since tags.

Test Plan: meson build

Reviewers: bu5hm4n, cedric, segfaultxavi

Reviewed By: segfaultxavi

Subscribers: q66, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10917
2019-12-19 09:46:07 +01:00
Hermet Park 8465904c19 ector software: catch up losing tasks among the threads.
Summary:
ector sw uses thread pool internally to process rle job parallel.

First of all, we lost task handles which allocated to each threads,
we must free the task data after thread done.

Secondly, tasks can be managed by one shape instance,
the instance can't catch upon multiple instances alive.
only last task can be attached to the shape instance.

Thus, obvisouly the instance doesn't expect to handle multiple tasks
at the same time, one instance only take care of one task on threading pool.

Reviewers: jsuya, cedric, smohanty, kimcinoo

Reviewed By: jsuya

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10916
2019-12-19 17:01:25 +09:00
Yeongjong Lee fb301eea87 csharp: remove unused code in workaround
Test Plan: meson setup -Dbindings=mono,cxx -Dmono-beta=true

Reviewers: lauromoura, Jaehyun_Cho

Reviewed By: Jaehyun_Cho

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10914
2019-12-19 16:30:54 +09:00
Yeongjong Lee a9fa8da384 eolina_mono: prevent empty ExtensionMethods class
Test Plan:
Check the code below is removed from `efl_ui_box_stack.eo.cs`.
```
#if EFL_BETA
#pragma warning disable CS1591
public static class CoreUI_UIBoxStack_ExtensionMethods {
}
#pragma warning restore CS1591
#endif
```

Reviewers: lauromoura, Jaehyun_Cho

Reviewed By: Jaehyun_Cho

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10905
2019-12-19 16:30:48 +09:00
Marcel Hollerbach 837528201f efl_ui_format: make this usable with the standard behaviour of accessors
a accessor is never delivering a value, only the pointer to a value.
This makes format working with accessors for list array carray.

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10909
2019-12-18 21:45:45 +01:00
Marcel Hollerbach 9ccc66b900 eina_accessor: make carray accessor work properly
a accessor is not really helpfull if it operates like the carray
accessor before this commit. What it was doing is to fill the content of
the "current line" into the data pointer. In a carray the
"current line" is the content of its carray-member.

However, accessors like for inarray array list or inlist do work
completly differently. They are returning the pointer to the "current
line" not the value of the current line.

The only case where this worked is efl_ui_format.c which was only tested
with this accessor, and this accessor also only worked with this
accessor.

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10908
2019-12-18 21:45:42 +01:00
Cedric BAIL 52aa2f629f efl: make sure all index for Efl_Model are unsigned int.
T8469

Reviewed-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D10869
2019-12-18 10:33:09 -08:00
Chris Michael def04c933c tests/ecore_wl2: Fix memory leak
Coverity reports that we leak 'ret_rots' here because
ecore_wl2_window_available_rotations_get allocates space for the
return, so we should free this here.

Fixes CID1408025
2019-12-18 10:28:06 -05:00
Xavi Artigas d1ffc7924e docs: Formatting issues in Efl.Text.Attribute.Factory 2019-12-18 16:10:17 +01:00
Xavi Artigas 21bb974024 docs: Fix typos and whitespace in Efl.Text_Cursor 2019-12-18 16:06:15 +01:00
Xavi Artigas 8e622e72df docs: Polish Efl.Text_Interactive docs
Ref T8521
Ref D10711
2019-12-18 15:17:28 +01:00
Xavi Artigas f1ae8e0d98 elm_test: small whitespace issue 2019-12-18 15:03:17 +01:00
Lauro Moura 81b94b3e35 csharp: Fix passing acessor with ownership
Summary:
When passing an owned acessor from a converted collection we need a way
to unpin the passed data when the accessor is freed.

This commits adds a thin wrapper around the CArray accessor that unpins
the data when freed.

Depends on D10900

Reviewers: YOhoho, felipealmeida

Reviewed By: YOhoho

Subscribers: cedric, #reviewers, #committers, jptiz, brunobelo

Tags: #efl

Maniphest Tasks: T8486

Differential Revision: https://phab.enlightenment.org/D10901
2019-12-18 10:40:53 -03:00
Lauro Moura 5befca9a10 csharp: Fix accessor IEnumerable implementation.
Summary:
Fixed after `data_get` marshalling changed (correctly) the data
parameter to `out IntPtr` instead of manually marshalling the double
pointer.

The existing test (`basic_accessor_list`) passed due to the empty
enumerable behavior, which made the `foreach` running no iterations.

Reviewers: brunobelo, jptiz, felipealmeida, YOhoho

Reviewed By: jptiz, YOhoho

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10900
2019-12-18 10:40:53 -03:00
Hermet Park 518d9b2649 evas vg: fix memory leak. 2019-12-18 21:52:42 +09:00
Stefan Schmidt 0ed64caa36 ci: refactor the early exit on specific build jobs
Should be no functional change only making all early checks a bit
shorter.

Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10866
2019-12-18 09:16:03 +01:00
Stefan Schmidt af04065067 ci: refactor configuration script
Re-factor if-else block for easier reading, update comments and check
that we are on osx when executing that part.

Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10865
2019-12-18 09:15:59 +01:00
Stefan Schmidt 3234d65b1e ci: travis: merge two if clauses
A left-over from the various works in this file. All of these commands
are under the same conditions.

Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10864
2019-12-18 09:15:57 +01:00
Stefan Schmidt 9fb1ae0d3c ci: enable benchmark target again
It only runs after efl is installed and we need to ensure running with
Elm buffer engine in our docker build for the graphical collection
benchmark.

Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10848
2019-12-18 09:15:54 +01:00
Stefan Schmidt 2bd801f859 benchmarks: increase timeout value for running elementary benchmarks
Default is 30s and I run into timeouts all the time. Increasing it to
60s for the elementary benchmarks. On my local machine its around 45s
for the slower one.

Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10847
2019-12-18 09:15:51 +01:00
Ali Alzyod 365159c5ea efl.text.format: rename methods and properties
Summary:
efl.text.format: rename methods and properties

this change will avoid conflict in the future with other interfaces or class methods.

T8533

Reviewers: woohyun, segfaultxavi, zmike, bu5hm4n

Reviewed By: segfaultxavi

Subscribers: cedric, #committers, #reviewers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10895
2019-12-17 15:57:58 +01:00
Yeongjong Lee 8e951504f5 csharp : add move tag info to EinaAccessor, EinaIterator converter
Summary:
Included commits in devs/lauromoura/remove_eina_mono-rebased
```
commit ed6679db19
Author: Lauro Moura <lauromoura@expertisesolutions.com.br>
Date:   Mon Dec 2 13:58:04 2019 -0300

    csharp: add move information to EnumerableToAccessor

    Still need to fix the converted accessor ownership, maybe by creating a
    custom accessor class that released the pinned memory when is freed.
```

ref T8486

Depends On D10878

Co-authored-by: Lauro Moura <lauromoura@expertisesolutions.com.br>

Test Plan: meson build -Dbindings=mono,cxx -Dmono-beta=true

Reviewers: YOhoho

Reviewed By: YOhoho

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8486

Differential Revision: https://phab.enlightenment.org/D10879
2019-12-17 11:34:42 -03:00
Yeongjong Lee f90a97470d eina_mono: replace EinaAccessor and EinaIerator with IEnumerable
Summary:
Eina.Accessor<T> => System.Collections.IEnumerable<T>
Eina.Iterator<T> => System.Collections.IEnumerable<T>

Unit test will work with D10879.

ref T8486

Test Plan: meson build -Dbindings=mono,cxx -Dmono-beta=true

Reviewers: lauromoura

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8486

Differential Revision: https://phab.enlightenment.org/D10878
2019-12-17 11:34:30 -03:00
Stefan Schmidt 7855a97f0d examples: js: fix variable name
Summary:
Simple mispell in the example.

Depends on D10882
Reported-By: https://lgtm.com/projects/g/Enlightenment/efl

Reviewers: felipealmeida, lauromoura

Reviewed By: felipealmeida

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10883
2019-12-17 11:33:45 -03:00
Bruno da Silva Belo b6521cc279 csharp: Suppressing non-events Raise methods.
Summary: ref T8390

Reviewers: lauromoura, felipealmeida, YOhoho, jptiz

Reviewed By: jptiz

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8390

Differential Revision: https://phab.enlightenment.org/D10717
2019-12-17 11:26:57 -03:00
Bruno da Silva Belo c40e948270 csharp:Suppressing Warning and Add suffix collection.
Summary: ref T8408

Reviewers: lauromoura, felipealmeida, YOhoho, jptiz

Reviewed By: jptiz

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8408

Differential Revision: https://phab.enlightenment.org/D10669
2019-12-17 11:26:23 -03:00
Xavi Artigas 0265f4fd55 docs: Add detailed text styling information
Summary:
More detailed descriptions for each attribute.
Relationship between attributes.
Default values.
Links to direct API methods for the corresponding property.
General text overhaul and formatting.

Test Plan: Builds and passes tests. Generate docgen or DocFX documentation and enjoy your new Text styling descriptions!

Reviewers: ali.alzyod

Reviewed By: ali.alzyod

Subscribers: AbdullehGhujeh, cedric, #reviewers, #committers, woohyun, bu5hm4n

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10873
2019-12-17 14:20:12 +01:00
Xavi Artigas 3bfc73a95a docs: Add missing docs for Efl.Canvas.Object_Animation 2019-12-17 14:07:20 +01:00
Jaehyun Cho bfc095104c csharp: apply same form of "Since EFL" to all manual bindings .cs files
The following form of "Since EFL" is applied to descriptions of all
manual bindings .cs files.
/// <para>Since EFL 1.XX.</para>
2019-12-17 20:18:54 +09:00
Stefan Schmidt 0f52bbb00e ecore_evas: add double header include safety
Reported-By: https://lgtm.com/projects/g/Enlightenment/efl
Reviewed-by: Chris Michael <cp.michael@samsung.com>
Differential Revision: https://phab.enlightenment.org/D10887
2019-12-17 09:59:44 +01:00
Hermet Park be8d1afd1e evas mapping: fix memory leak.
These two dynamically allocated properties were not freed.
free them when cow data is reset.
2019-12-17 17:19:21 +09:00
Ali Alzyod 68e9bf9c14 efl_canvas_textblock: allow style_apply with wrap=none
Summary:
1- passing style_apply("wrap=none") had no effect previously, and now disable wraping
2- style_all_get() by default return "wrap=word", but now return  "wrap=none"

refer to T8523

Reviewers: segfaultxavi, woohyun, cedric

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10888
2019-12-16 19:11:33 +01:00
Xavi Artigas 16efc25ceb elm_test: workarounds for canvas_textblock style
The horizontally scrollable single-line text input box does not currently visible.
This patch turns it into a vertically scrollable multiline input box, with an
arbitrary minsize.
Also, make the label unselectable.
2019-12-16 11:35:35 +01:00
WooHyun Jung dfc9a3eef3 elm_slider: remove unused file
Summary:
Just removed elm_slider_eo.legacy.h which did not
have any dependency with other files

Test Plan:
1. sudo ninja install
2. elementary_test
3. Slider

Reviewers: segfaultxavi, bu5hm4n, zmike

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10876
2019-12-16 10:36:11 +01:00
Hermet Park de06ddb3ed ui position_manager: fix doc typo. 2019-12-16 17:24:17 +09:00
SangHyeon Jade Lee 0887b48f9f efl_ui : stablized factory classes.
Summary:
for mvvm publizing,
caching factory and layout factory need to be out of beta.

Reviewers: cedric, bu5hm4n, segfaultxavi

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10855
2019-12-16 16:58:50 +09:00
Ali Alzyod c3dbcb2447 edje_entry: real part protection check
Fix T8524

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10875
2019-12-13 16:35:32 -08:00
Marcel Hollerbach 5892292ac8 efl_ui: docuement code
there was the request that this needs to be documented, here we are.

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10874
2019-12-13 09:33:07 -08:00
Marcel Hollerbach 7d1463124a efl_ui_widget: do not execute up handler when on destruction
otherwise we would cause an error.

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10846
2019-12-13 09:33:05 -08:00
Marcel Hollerbach 4982da6327 evas_focus: protect against faulty focus object
the problem is that we only remove ourselfs from the focused list in the
invalidator. However, we allowed invalidated objects to be part of this
hash, which made everything go boom.

With this commit you at least only get one error and you should fix up
this case.

This fixes random errors in enlightenment (That are appearing theire
since seats have been introduced to evas, the problem before invalidate
was that the object was already destructor called, but not fully
destructed yet).

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10845
2019-12-13 09:33:04 -08:00
Marcel Hollerbach 349df85679 efl_ui_spotlight_manager_*: do not keep ptr of dead pointer
when content is deleted, we should not keep a dangling pointer of it.
Setting it to NULL here is enough, as later on a swtich_to reuest will
be sent.

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10844
2019-12-13 09:33:03 -08:00