Commit Graph

64856 Commits

Author SHA1 Message Date
Marcel Hollerbach 4fb7d88126 efl_ui_spotlight_manager_stack: stack hide content below show content
Summary:
the spotlight manger fades in new content, and hides the old content.
With this commit the show content is stacked above the hide content,
which means, the user can already interact with the new content, before
the old one is hidden.

Reviewers: zmike, cedric, segfaultxavi

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10997
2020-01-02 09:35:12 -05:00
Marcel Hollerbach 51a3977ad7 efl_ui_spotlight_manager_stack: do not keep final state
Summary:
keeping the final state here results in the fact that the map is not
getting reseted. Which is a problem, as the element would not be
displayed correctly after that.

Final state here means, that the last configuration of Efl.Gfx.Mapping will be kept, and it will *not* be resetted.

Reviewers: zmike, cedric, segfaultxavi

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10999
2020-01-02 09:35:12 -05:00
Marcel Hollerbach 92c01d9e63 efl_ui_item: add API that restricts a item from beeing unselected
Summary:
There are usecases where items should not be unselectable by the user.
For example in the tab_bar. With this commit, a tab bar user cannot
unselect a item by hand anymore.

Depends on D10305

Reviewers: zmike, woohyun, segfaultxavi, cedric

Reviewed By: zmike, segfaultxavi, cedric

Subscribers: SanghyeonLee, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10306
2020-01-02 09:12:39 -05:00
Ali Alzyod 87e5907f18 efl.text: add null check for cursor and attribute internal methods
Reviewers: woohyun, segfaultxavi, bu5hm4n, zmike

Reviewed By: bu5hm4n

Subscribers: ProhtMeyhet, cedric, #reviewers, #committers

Tags: #efl

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10899
2020-01-02 12:53:20 +01:00
Cedric BAIL 4e6fd08306 evas: don't initialize font multiple time.
After splitting font family and size set operation, expedite lost a 10%
speed due to doing a double initialization (Once when the family is set
and one when the size is set). This was noticable in a few tight running
tests. This patch enforce that no initialization is called until the size
and the family are set.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10976
2020-01-02 12:53:12 +01:00
Ali Alzyod 3c54f6458f Efl.Text.Font.Properties: rename Efl.Text_Font_Properties
Efl.Text.Font.Properties: rename Efl.Text_Font_Properties

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10990
2020-01-02 12:43:46 +01:00
Boris Faure a2afcfc872 evas: fix compilation with -Dwl=false
Reviewed-by: Chris Michael <cp.michael@samsung.com>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10994
2020-01-02 12:41:16 +01:00
Ali Alzyod 3cc8ea77fa efl_ui_text: scroller mode clean up
simplify code, and reduce calls:

It is only required to set scroll mode in two cases:
- When creating scroller
- When changing multiline property

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10981
2020-01-02 12:41:13 +01:00
Ali Alzyod 20b7c515d1 efl.text.font.properties: remove comments from eo files
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D10971
2020-01-02 12:41:10 +01:00
Marcel Hollerbach 7005241b22 efl_ui_collection: always scroll in the item
never the focused element. The focused element can be different from the
item. This fixes a error when item is not focusable, but content in the
item is.

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10980
2020-01-02 12:16:13 +01:00
Ali Alzyod 41c7e1c908 efl.text.cursor: emit events CANVAS_TEXTBLOCK_CHANGED when insert text using efl_text_cursor_markup_insert
efl.text.cursor: emit events CANVAS_TEXTBLOCK_CHANGED when insert text using efl_text_cursor_markup_insert

Differential Revision: https://phab.enlightenment.org/D10985
2020-01-02 12:16:11 +01:00
Ali Alzyod a95a509cfd efl.text.interactive: remove event freeze when keyboard button is pressed
this event freeze will prevent submission of EFL_UI_TEXTBOX_EVENT_CHANGED on efl.ui.textbox object, when inserting text using the keyboard.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10979
2020-01-02 12:03:08 +01:00
junsu choi 3e5bdd2d15 elm_animation_view: Fix play/play_back behavior
Summary:
In elm_animation_view(legacy), play means forward and play_back backward.
So change the sign of the speed value for control.

Test Plan: N/A

Reviewers: Hermet, smohanty, kimcinoo

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10995
2020-01-02 16:57:39 +09:00
Hermet Park 991ca66681 ui_image: fix wrong scale_method expand behavior.
Previous fix 46ee203331 is not perfect
at some cases, its condition should be this.
2020-01-02 14:16:40 +09:00
Alastair Poole 5c7fe5ac31 elm_code_widget: Line numbers Off then Gutter Off.
When line numbers were disabled in the widget there was still
some remnant of the background colour of gutter in the widget.
This respects having the line numbers disabled visually.
2020-01-02 00:01:00 +00:00
Alastair Poole 072ff46aa2 elm_code_widget: Fix cursor position sync.
The scroller was causing the cursor to be out of sync with the
widget content. This fixes that.
2020-01-01 23:16:25 +00:00
junsu choi e3b77fcff8 Efl.Ui.Vg_Animation: Implaments Efl.Playable interface
Summary:
Change API
.duration_time => Efl.Playable.length.get

ref T8476
Depends on D10939

Test Plan: N/A

Reviewers: Hermet, bu5hm4n, kimcinoo, segfaultxavi, zmike

Reviewed By: segfaultxavi, zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8476

Differential Revision: https://phab.enlightenment.org/D10953
2019-12-31 09:53:23 -05:00
junsu choi 43288c7ace Efl.Ui.Animation_View : Change class name to Efl.Ui.Vg_Animation
Summary:
Since "View" is a reserved word for MVVM, change the class name appropriately.
Efl.Ui.Animation_View => Efl.Ui.Vg_Animation

ref T8476
Depends on D10931

Test Plan: elementary_test -> "Vector Graphcis Animation"

Reviewers: Hermet, bu5hm4n, kimcinoo, segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8476

Differential Revision: https://phab.enlightenment.org/D10939
2019-12-31 09:53:16 -05:00
junsu choi 3dc3deba62 Efl.Player: Add setter of playback_progress
Summary:
The setter of Efl.Player.playback_progress is implemented in each class below.
Efl.Ui.Animation_View
Efl.Ui.Image
Efl.Ui.Image_Zoomable
Efl.Canvas.Video

ref T8476
Depends on D10915

Test Plan: N/A

Reviewers: Hermet, bu5hm4n, kimcinoo, Jaehyun_Cho, segfaultxavi, zmike

Reviewed By: zmike

Subscribers: zmike, cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8476

Differential Revision: https://phab.enlightenment.org/D10931
2019-12-31 09:53:10 -05:00
junsu choi baa1e6553b Efl.Ui.Animation_View: Change state name
Summary:
play-> playing
play_back -> playing_backwards
pause -> paused
stop -> stoped

Depends on D10862
ref T8476

Test Plan: N/A

Reviewers: Hermet, bu5hm4n, segfaultxavi, kimcinoo

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8476

Differential Revision: https://phab.enlightenment.org/D10915
2019-12-31 09:53:03 -05:00
junsu choi e1afc7c181 Efl.Ui.Animation_View: Implements Efl.Player interface
Summary:
Chnaged API
.speed.set        => Efl.Player.playback_speed.set
.speed.get        => Efl.Player.playback_speed.get
.progress.get     => Efl.Player.playback_progress.get
.play             => Efl.Player.playing.set(true)
.stop             => Efl.Player.playing.set(false)
.pause            => Efl.Player.paused.set(true)
.resume           => Efl.Player.paused.set(false)
.play_sector      => .playing_sector
.auto_play        => .autoplay
.auto_repeat      => .autorepeat

Remove API
.is_playing_back
.playback         => (use negative speed value)

New feature API
Efl.Player.playback_position.set
Efl.Player.playback_position.get
Efl.Player.playing.get
Efl.Player.paused.get

ref T8476

Test Plan:
meson_option.txt -> remove json in evas-loaders-disabler option
elementary_test -to "animation view"

Reviewers: Hermet, bu5hm4n, kimcinoo, Jaehyun_Cho, segfaultxavi, zmike

Reviewed By: segfaultxavi, zmike

Subscribers: zmike, segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8476

Differential Revision: https://phab.enlightenment.org/D10862
2019-12-31 09:52:56 -05:00
SangHyeon Jade Lee 2f8683ef41 evas: fix legacy evas_object_clip_unset for group object.
Summary:
evas_object_clip_unset was broken for group object in several month or year..

basically,
evas_object_clip_unset(obj)
efl_canvas_object_clipper_set(obj, NULL)
is equal on efl_clip implements,
but on the group object, we need to unclip the whole group children in
efl_canvas_group_efl_canvas_object_clipper_set
which was not performed by legacy clip_usnet API.

Test Plan:
try clip_unset(obj) and clipper_set(obj, NULL) in any group clipped case
(i.e. scroller content) and see clip_unset is broken and fixed by patch.

Reviewers: cedric, bu5hm4n, zmike

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10984
2019-12-31 09:48:18 -05:00
Ali Alzyod 5154b5a8fc efl_ui_text: support focus navigation
With this commit you can move the focus from the textbox widget to the surrounding widgets, (as it is done in legacy).

ref T8538
ref T8522

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10987
2019-12-31 11:56:59 +01:00
Ali Alzyod 2ec10f18d3 elementary_text: Efl.Ui.Textbox Input Field
Entry was added to the same box. This commit fixes this.
You could observe this problem when starting the "Textbox Input Field" demo in elm_test

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10986
2019-12-31 11:42:31 +01:00
Marcel Hollerbach 3a75d76001 efl_ui_datepicker: do not substract anything fom mday
out of the documentation of struct tm:
int tm_mday;			/* Day.		[1-31] */
shifting this range one up results in day 32 beeing selectable, but 1
not beeing selectable.

With this commit we could have again working CI.

Differential Revision: https://phab.enlightenment.org/D10992
2019-12-31 11:24:36 +01:00
Hermet Park 745eea61b0 evas gl: enable GL_LINE_SMOOTH only at gles 1.x
As the GLES specification,
GL_LINE_SMOOTH is not supported since GLES2.
2019-12-31 16:31:09 +09:00
Hermet Park 0f0f8d7fbc vector container: skip re-ordering as possible.
don't try anything if the stack is already top or bottom.
2019-12-31 15:15:56 +09:00
Hermet Park f4257b605e vector lottie: update shape layer order properly.
Shape layer order can be changed during animation,
We should rearrange them if it's necessary.
2019-12-31 15:04:08 +09:00
Hermet Park 174c593c70 evas vg: add an new interface efl_canvas_vg_container_children_direct_get()
Summary: We need an efficient method to navigate children faster.

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10989
2019-12-31 14:19:01 +09:00
Hermet Park d79693d1a9 evas vg: rewrite efl_gfx_stack_raise_to_top, lower_to_bottom()
The implementation was totally stupid,
previous function were wrongly working.

Thus, we rewrite it simple again.
2019-12-31 13:32:56 +09:00
Lauro Moura e632c1334a csharp: Add StyleCop support to dotnet build
This patch adds support to run the StyleCop rules. To enable, -Ddotnet=true
is needed, You can pass -Ddotnet-stylecop=CAXXXX,CAXXYY where X and Y are digits for CAs
or SAs. You can also ask that the CAs and SAs cause errors instead of warnings.

Differential Revision: https://phab.enlightenment.org/D10969
2019-12-30 22:17:32 -03:00
Stefan Schmidt 2af38d11ed ci: create a daily build to run with coverage enabled and upload to codecov
Summary:
For this we bring back a native Linux build on the Travis with Ubuntu
bionic. This allows use easy integration with codecov as Travis and
Codecov have figured out all details.
This means we need to be a bit more careful with our $DIST checks as
empty no longer means osx. It could as well be the Linux job.

Covergae reports will show up here:
https://codecov.io/gh/Enlightenment/efl

We are starting with 36%. Time to improve. :-)

Fixes: T7910

Reviewers: bu5hm4n, zmike

Reviewed By: zmike

Subscribers: cedric

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10867
2019-12-30 11:39:39 -05:00
Hosang Kim 9c41899a08 ecore_evas_buffer: Unregister input events when ecore_evas_buffer is freed
Summary:
When ecore_evas_buffer is freed, input events is not unregistered.
So _window_hash size is increasing.

Reviewers: Hermet, cedric, raster, zmike

Reviewed By: zmike

Subscribers: zmike, rajeev.jnnce, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10983
2019-12-30 11:23:22 -05:00
a.srour 0164162a48 Edje: edc text_class applied without font or font_size in style
Summary:
The issue with `text_class` in Edc styles has to be within a string containing `font` & `font_size` properties to effect style, if font or font_size not presented in the same string text_class will be ignored.

So in the following Edc example, `text_class` will be ignored:
```
collections {
   text_classes {
      text_class {
         name: "tc1";
         font: "Sans";
         size: 20;
      }
   }
   styles {
      style {
         name: "style1";
         base: "color=#00FF00 text_class=tc1";
         tag: "br" "\n";
      }
   }
}
```

To apply text_class `tc1`, font and font_size has to be added to `styles.style.base` value, to be as follows:
```
...
base: "font=Serif font_size=15 color=#00FF00 text_class=tc1";
...
```

NOTE: The produced font will be `Sans` and font_size equal to `20`

Test Plan:
`layout.edc`
```
// compile: edje_cc layout.edc
// play: edje_player layout.edj
collections {
    text_classes {
       text_class {
          name: "tc1";
          font: "Sans";
          size: 20;
       }
    }
    styles {
        style {
            name: "style1";
            base: "color=#FFFFFF text_class=tc1";
        }
    }
    group {
        name : "group1";
        parts {
           part {
              name : "tb1";
              type: TEXTBLOCK;
              scale: 1;
              entry_mode: NONE;
              description {
                  state: "default" 0.0;
                  rel1.relative: 0.0 0.0;
                  rel2.relative: 0.5 0.5;
                  text {
                     style: "style1";
                     align: 0.0 0.0;
                     text: "Hello EFL";
                  }
              }
           }
        }
    }
}

Reviewers: segfaultxavi, smohanty, ali.alzyod, cedric, zmike

Reviewed By: zmike

Subscribers: zmike, segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8477, T8478

Differential Revision: https://phab.enlightenment.org/D10692
2019-12-30 11:12:37 -05:00
Marcel Hollerbach 97ffbe1f12 efl_ui_spin_button: lets support floating point numbers
Summary: this was a int ... cutting of the floating point digits. Now it works.

Reviewers: zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10977
2019-12-30 11:12:32 -05:00
Marcel Hollerbach cdb21cd30d efl_ui_progressbar: rename from pulse to infinite_mode
Summary:
ref T8501
Depends on D10942

Reviewers: cedric, woohyun, zmike, segfaultxavi

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8501

Differential Revision: https://phab.enlightenment.org/D10943
2019-12-30 11:10:43 -05:00
Marcel Hollerbach 25731f84da efl_ui_progressbar: remove pulse_mode
Summary:
pulse_mode is now implicit with pulse, if you set the progressbar to
pulse, the state is internally adjusted in a way that the theme is put
into the correct state. Legacy is not impacted by this because of the
previous commit.

ref T8501
Depends on D10941

Reviewers: cedric, woohyun, zmike, segfaultxavi

Reviewed By: zmike, segfaultxavi

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8501

Differential Revision: https://phab.enlightenment.org/D10942
2019-12-30 11:08:47 -05:00
Marcel Hollerbach 8fefb6f099 elm_progressbar: make pulse and pulse_mode independend from legacy
Summary:
the next commit will refactor this API for Efl.Ui namespace.

ref T8501

Reviewers: cedric, woohyun, zmike, segfaultxavi

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8501

Differential Revision: https://phab.enlightenment.org/D10941
2019-12-30 11:08:41 -05:00
Carsten Haitzler d958f6907d elm - theme - fix corner case of double-select on new radio styles 2019-12-30 14:06:50 +00:00
Ali Alzyod 64d160da0a efl.text.style: underline enum rename + underline method fix
Summary: underline methods was not working + fix enums names

Reviewers: woohyun, segfaultxavi, bu5hm4n, zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7945

Differential Revision: https://phab.enlightenment.org/D10975
2019-12-30 13:27:13 +09:00
Ali Alzyod 7b105b33bb efl.text.style: strikethrough_type & Background_type enum rename
Summary:
rename **solid color** to **single**
rename **disabled** to **none**

Reviewers: woohyun, segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7942, T7941

Differential Revision: https://phab.enlightenment.org/D10974
2019-12-30 10:56:37 +09:00
Ali Alzyod 895f64f33c efl_ui_textbox: replace legacy calls with new ones
Summary: This patch only changes some of legacy calls, with new ones

Reviewers: woohyun, zmike, bu5hm4n

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8522

Differential Revision: https://phab.enlightenment.org/D10982
2019-12-30 10:31:33 +09:00
rafspiny d8b2cf28b1 Fix check for XIGetProperty
Summary: The function XIGetProperty returns 0 on success. More info on the function here: https://www.x.org/releases/X11R7.5/doc/man/man3/XIGetProperty.3.html

Reviewers: raster, stefan_schmidt, bu5hm4n

Reviewed By: raster

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10978
2019-12-28 22:06:17 +00:00
Carsten Haitzler f989cea52d elm - add plain and icon style radio and check and elm tests for it
this will be common enough to put into elm - there is no way to do a
gimp style "tool palette" where you select one of them (like one from
a set of radio buttons) at all times... but you don't want the "round
circle" but instead want it to look more like a button to fit in with
a palette style look. this calls for styles... so here they are.

@feat
2019-12-28 20:39:08 +00:00
Ross Vandegrift 2e854ce7ed correct edje pkg-config generation for luaold
Currently, edje.pc gets its lua Requires from the -Dlua-interpreter argument.
If -Dlua-interpreter=lua, an unversioned lua entry ends up in Requires, which
cannot always be satisifed.  The evas filters meson.build handles this case by
generating a version-specific entry.  This patch copies that logic into the top
level meson.build, and passes the result to the edje subproject.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10965
2019-12-28 10:47:46 +01:00
Xavi Artigas 595a066a64 whitespace 2019-12-27 11:45:35 +01:00
Xavi Artigas 858caa21b0 docs:Clarify Efl.Text_Formatter format parameter
Ref T8455
2019-12-27 11:37:43 +01:00
Cedric BAIL 4624b56bed elementary: make sure that our index for the maximum number of object is actually unsigned int bound.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10927
2019-12-27 11:36:59 +01:00
Cedric BAIL 6756485476 elementary: improve focus memory for Efl.Ui.CollectionView.
This patch will make the CollectionView remember at all time the last
focus object and the last item in the list.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10677
2019-12-27 11:36:56 +01:00
Ali Alzyod e583b9159e efl_style: rename enums (background,strikthrough) from enabled to solid_color
Reviewers: woohyun, segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7942

Differential Revision: https://phab.enlightenment.org/D10967
2019-12-27 16:10:24 +09:00