Summary:
Fileselector button fails to run in inwin mode.
It is caused by incorrect window parent finding.
This patch corrects the window parent finding.
@fix
Test Plan:
run FileSelector Button, toggle Inwin mode option to on,
eo gives error and nothing is shown.
Reviewers: Hermet, seoz
Reviewed By: seoz
Differential Revision: https://phab.enlightenment.org/D2552
Summary:
Updated gengrid to move item selection in 'vertical' mode to the last
item, when currently selected item is not in the last row. As per the
original behaviour, on moving down from such an item, it takes the
focus out of the gengrid widget. Now it is updated to go to the last
item (in last row), and then on further pressing down, focus comes
out of gengrid.
This is something similar to what happens in other UI systems like in
Ubuntu and Windows, when pressing down on (n-1)th row, the last item
in the nth row gets focused.
Signed-off-by: Vaibhav Gupta <g.vaibhav1@samsung.com>
Reviewers: Hermet, SanghyeonLee, raster
Reviewed By: raster
Subscribers: sachin.dev, singh.amitesh
Differential Revision: https://phab.enlightenment.org/D2418
@fix elm_object_cursor_set() to work also when used with the mouse pointer
yet inside the widget, otherwise you need to mouseout/mousein to actually see
the new setted cursor.
Please give a short review on this one, maybe there is a simpler way to check
if the pointer is inside the widget...
Also added a button in the cursor test for this use case
Summary:
When content is resized, scrollbar's position is not updated.
Add bar position update after bar size is changed.
This is sample for resizing issue.
Test Plan: elementary_test -> scroller3
Reviewers: jaehwan, woohyun, seoz, raster, Hermet
Reviewed By: Hermet
Subscribers: raster
Differential Revision: https://phab.enlightenment.org/D2291
Summary:
For instance, ecore_evas sets initial withdrawn state EINA_FALSE if elm_engine is "buffer".
Therefore, the initial withdrawn state is derived from ecore_evas property.
@fix
Reviewers: raster, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2435
Summary:
When entry is resized, selection handlers are not updated,
it causes selection handlers to be placed in wrong position.
This patch fixes it.
@fix
Reviewers: woohyun, seoz, herdsman, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2487
Summary:
Issue: Too many widgets get created during smart add itself, even if
not necessary, adding to the launch time.
Solution:
Create widgets based on mode, check for modes in generic functions
like smart theme, focus etc:-
Test Plan: elementary_test can be used to test colorselector demo.
Reviewers: cedric, raster, Hermet
Subscribers: rajeshps, govi, poornima.srinivasan
Differential Revision: https://phab.enlightenment.org/D2532
Summary: The "closed_height" is not using in code.
Reviewers: raster, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2535
Summary:
check theme of tooltip label by
$clouseau elementary_test -to "tooltip"
tooltipi label theme was elm/label/base/default but we want theme
"elm/label/base/tooltip/default" to be set instead.
@fix
Test Plan: $clouseau elementary_test -to "tooltip"
Reviewers: raster, Hermet
Subscribers: seoz, sachin.dev
Differential Revision: https://phab.enlightenment.org/D2509
Summary:
This uses new Evas Callback type EVAS_CALLBACK_CANVAS_VIEWPORT_RESIZE
to listen to view port size changes.
Reviewers: Hermet, cedric, raster
Reviewed By: raster
Subscribers: SanghyeonLee, seoz
Differential Revision: https://phab.enlightenment.org/D2527
Summary:
elm_object_item_del_cb_set() can set delete callback that is called on item deletion.
Del_cb, Evas_Smart_Cb, has void pointer for item data as its first parameter.
However, getting item data is broken.
@fix
Reviewers: Hermet
Reviewed By: Hermet
Subscribers: Hermet
Differential Revision: https://phab.enlightenment.org/D2524
When closing the application, the delete function given by the user in
the Item Class was called twice. During the clear process, the function
was called for every built item and then during the item destruction.
This patch fixes this behaviour by calling the user function only during
the item destruction.
Another fix has been added. It zero'es the built list pointer inside the
item. Without this fix, the item points to a list node that is already
freed and can lead during widget deletion to an invalid access inside
the list.
@fix T2394
Move enums from elm_scroller_common.h to elm_scroller.eo in order to make them
more accessible for bindings. Delete elm_scroller_common.h.
Moved the include for elm_scroller.eo.legacy.h to the top of elm_scroller_legacy.h
to allow the use of the generated types in the function declarations.
Summary:
For now, if apply image mask to smart obejct, masking does not work except to implement in edc file.
@feature
Reviewers: Jaehyun_Cho, Jaehyun, jpeg, raster, cedric, Hermet
Subscribers: raster, jpeg, cedric
Projects: #elementary
Differential Revision: https://phab.enlightenment.org/D2055
Summary:
elm_object_style_set(obj, "XXXX"); should return FALSE if XXXX style does not exist.
Although it does set default style if "XXXX" style does not exist.
@fix
Reviewers: raster, Hermet
Subscribers: seoz, sachin.dev
Differential Revision: https://phab.enlightenment.org/D2511
Summary:
When popup has a content which is larger than window size, popup is to be larger than window.
so, scroller is added into popup content area.
Test Plan:
1. Making "elementary_test - popup" window smaller than popup content size.
2. Excute "popup-center-title + genlist content + 1 button" in "elementary_test popup"
After applying this patch.
3. popup content shows with scroller.
Reviewers: Hermet, seoz, woohyun, raster
Subscribers: raster
Differential Revision: https://phab.enlightenment.org/D2216
Summary:
Currently elm_notify doesn't allow to set or get text if
user's style contain some text parts and he need to set text into them.
Reviewers: cedric, seoz
Subscribers: raster, stefan_schmidt, reutskiy.v.v
Differential Revision: https://phab.enlightenment.org/D1333
AT-SPI2 specification states that active window can have only one widget
with FOCUSED state. This differs from elementary design which assumes
that whole elementary widget tree branch is focused.
Patch assumes that if a widget have no focusable children and can have
focus it can be marked as FOCUSABLE on atspi bus.
Move enums from elm_win_common.h to elm_win.eo in order to make them
more accessible for bindings.
Moved the include for elm_win.eo.legacy.h to the top of elm_win_legacy.h
to allow the use of the generated types in the function declarations.
This commit adds the Eolian class elm_win_standard.
It is basically a derivation from elm_win that creates a default background.
The intent is to replace the legacy functions elm_win_util_standard_add and
elm_win_util_dialog_add by functions accessible via Eo API functions such as
eo_add and eo_do.
To fully replace an elm_win_util_standard_add call, use:
eo_add(ELM_WIN_STANDARD_CLASS, NULL,
elm_obj_win_name_set("example"),
elm_obj_win_type_set(ELM_WIN_BASIC),
elm_obj_win_title_set("Example"));
Removed the constructing method elm_obj_win_constructor.
Now "name" and "type" are properties that must be set at creation, like this:
eo_add(ELM_WIN_CLASS, NULL,
elm_obj_win_name_set("example"),
elm_obj_win_type_set(ELM_WIN_BASIC));
Also, the "title" property can be set at creation now.
Summary:
There could be a demand for providing subtle different item styles
according to the existence of icon or text swallowed in genlist item.
For example, if icon exists, genlist item shows icon, or show rectangle
where icon should be placed.
One style can have various form with this signal.
Reviewers: Hermet
Subscribers: Hermet
Differential Revision: https://phab.enlightenment.org/D2348
This commit also updated one of the elementary test to show
the new one of doing it.
This lets users of the API just add a callback and automatically
get animation ticks. It's done per window, because update rate
may be different for different windows (think different screens).
Summary:
Some newly implemented attributes are not present in several classes and
interfaces.
This patch:
- Adds some attributes (like @nullable, @optional, own, free) to several .eo files.
- Changes some eina types names to the equivalent eolian name (like "Eina_Bool" to "bool")
- Adds the element type of lists and iterators.
Reviewers: felipealmeida, tasn
Reviewed By: tasn
Differential Revision: https://phab.enlightenment.org/D2350
Jupp, its a dirty hack but it helps to work around the problem for now and
get the release out. I will revert it in master after the release and we
keep the bug open until this is fixed and hopefully backported.
ref T2367
This should be a proper fix for T1717. Idea is that we build a list of operation
that needs to be deferred in order (including pop and push) so that we are sure
we can pop and push in any order without the need to wait for any event.
Changed all the callback_call to pass the correct Elm_Object_Item
(Eo) pointer, was passing Elm_Slideshow_Item_Data instead.
@fix
Also updated the test
Summary:
If current item is disabled, next item should be
taken.
Signed-off-by: Umesh Tanwar <umesh.tanwar@samsung.com>
@fix
Reviewers: raster, Hermet
Subscribers: singh.amitesh, sachin.dev
Differential Revision: https://phab.enlightenment.org/D2458
Summary:
fix the _item_multi_select_down() function for
ELM_OBJECT_SELECT_MODE_DISPLAY_ONLY select_mode.
_item_multi_select_up is right, but _item_multi_select_down is wrong.
So fixed this.
Signed-off-by: Umesh Tanwar <umesh.tanwar@samsung.com>
@fix
Reviewers: Hermet, raster
Reviewed By: raster
Subscribers: sachin.dev, singh.amitesh
Differential Revision: https://phab.enlightenment.org/D2452
Summary:
After discussion with DaveMDS, D2402 is a wrong fix and must be reverted.
This reverts commit a7978f931a4b67820b6b65758ce6f362c1ebec70.
Reviewers: cedric, DaveMDS
Subscribers: jpeg
Differential Revision: https://phab.enlightenment.org/D2437
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Thiep Ha
Vaibhav Gupta
Daniel Zaoui
Aleksey Karmanov
Davide Andreoli
Daniel Kolesa
Tom Hacohen
Lukasz Stanislawski
ChunEon Park
Jaehyun Cho
Amitesh Singh
kumar navneet
shilpa.singh
Woochan Lee
Jee-Yong Um
Yakov Goldberg
jiin.moon
taehyub
Carsten Haitzler
Vitalii Vorobiov
Cedric BAIL
Lukasz Stanislawski
Ji-Youn Park
Vitor Sousa
maxerba
Chris Michael
Stefan Schmidt
Sung-Taek Hong
Umesh Tanwar
kabeer khan