Subject: Conformant Widget Code refactoring patch
Can you please review the attached patch for elm_conformant.
Change Log: 1. On Theme change, swallowing Parts again. Swallowing
parts done in separate function.
2. Conformant parts size set is repeated in two places, moved to a
function.
3. Conformant Object Move/Resize is handled to realign the Visible
content area.
SVN revision: 58948
I have attached patch for elm_diskselector.
This patch is setting the width of elm_diskselector using its parent width
size, if there is no mention in the theme file.
SVN revision: 58895
NOTE: if you want to implement even/odd in your theme you know
need to listen to both signal :
- elm,state,odd from elm
- elm,state,even from elm
If you set data of "stacking_even" to "above" of you item group
it will raise the even object above the odd one (that's the default
behaviour).
You could also explicitly active/deactivate the stacking by setting
data of "stacking" to "no". Default is "yes".
SVN revision: 58822
I introduce a new concept to genlist.
I named it "genlist mode" after I discussed it with raster.
Using this feature, one can activate/deactivate any mode(effect) to an item.
The mode is defined in genlist item edc.
You can watch a sample video on youtube.
http://www.youtube.com/watch?v=ZPbwpzwwiS8
I created two sample mode: Slide and Rotate.
[Feature Description]
- One can activate a specific mode to an item.
- One item is activated at one time while others are deactivated.
- Genlist handles deactivating other items when one item is activated.
- There are two different view: before activated, after activated.
- Genlist creates the second view when the first view is activated. Usually the first view is animated.
- Genlist destroys the second view when the item finishes deactivating.
- Creating/Destroying the second view on the fly gives performance enhancement because there is no reason to hold all objects in two views all the time.
- Mode is defined in genlist edc so one can easily add it more.
- Mode edc style is separated from normal genlist styles. One can combine any genlist style with mode edc style.
[API]
- EAPI void elm_genlist_item_mode_set(Elm_Genlist_Item *it, const char *mode_type, Eina_Bool mode_set) EINA_ARG_NONNULL(1, 2);
Activate/Deactivate a mode to an item.
- EAPI const char *elm_genlist_mode_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
Get activated mode name.
- EAPI const Elm_Genlist_Item *elm_genlist_mode_item_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
Get activated item.
[Structure]
- Elm_Genlist_Item
Added const char *mode_item_style;
[Usage]
- Set mode style name to genlist item class.
itc.mode_item_style = "mode";
- Activated mode to an item whenever you want.
elm_genlist_item_mode_set(it, "slide", EINA_TRUE);
SVN revision: 58791
I added some APIs for name to elm_map.c and added some test code to test_map.c
I used nominatim OSM service. (http://http://nominatim.openstreetmap.org/)
as i felt, it's response time was very good to use.
SVN revision: 58703
Mail from Sangho Park.
I added some APIs for route to elm_map.c
There are some route services provided by Open Street Map (yours, open
route service, monav...)
I just added 'yours' url callback and will add ors, monav.
And added some test code to test_map.c
SVN revision: 58474
Segment Control Widget is a horizontal control made of multiple segment items
together, each segment item is set to equal size, functioning similar to
discrete two state button. Only one segment item can be at selected state.
SVN revision: 58461
Subject: Re: [E-devel] [Patch] Display more than 3 items
This is Shinwoo Kim, learned that I could contribute to EFL! :)
I'm pleased to inform you that the patch for the "elm_diskselector".
Until now, the "elm_diskselector" only display 3 items at once,
if you accept this patch, the "elm_diskselector" can display more than 3
items.
For this feature, "elm_diskselector_display_item_num_set(Evas_Object *obj,
int num)" is added.
I would like to know more about your opinion about this feature. Thanks.
SVN revision: 58405
Subject: [E-devel] [Patch] elm_genlist :
elm_genlist_realized_items_update api added
I added elm_genlist_realized_items_update api.
elm_genlist_item_update api already exists.
But If the application want to change all realized items using this api,
application always have to check genlist all realized items and call
elm_genlist_item_update api.
This routine is being used at many functions of application.
So I made elm_genlist_realized_items_update api.
This helps application to update easily all realized items at a time.
SVN revision: 58403
It's just useless and makes zero sense. No matter what we'll
get a useless output and it just slows everything down.
Should probably be added when it makes sense, but it will probably
need something like elm_label_wrap_width_set.
SVN revision: 58393
In some cases, for example resizing the GenGrid test or just using
ephoto, the scroller would jump to the right before going to it's
proper direction. We should check if the position is below minimum
after we reduce the position, and not instead.
SVN revision: 58383
Unified double-click smart callback signal name to "clicked,double".
Wrong signal name "clicked" is still there.
But this will be removed soon after fixing all codes in trunk.
SVN revision: 58293
Patch from 장효영 (Hyoyoung Chang). Basically checking extensions is silly,
and some real life use shows it just breaks things. Especially since we
aren't liberal enough with the extensions we check.
I also cleaned up some whitespace and weird indentation at the edges.
SVN revision: 58229
Subject: [E-devel] [Patch] elm_genlist - group index homogeneous mode
support
Current, genlist using group index can't use homogeneous mode.
So this is patch for support homogeneous mode when the genlist uses
group index.
SVN revision: 58173
Subject: [E-devel] [Patch] for Gettext /I18N
Mr. Govi in SISO made a patch for following description.
Detail Description:
1. If EFL/Elementary Application has i18n String with its own PO file,
then Elementary will end up looking for internal Strings at application
PO files. Passing PACKAGE name in the Elementary String Look up macro
eliminates this issue and looks for internal String from Elm.po files.
2. Macro E_(str) is used, to differentiate the elementary Strings from
commonly used #define _(str) in the applications. ( Just E ed :) )
SVN revision: 58085
Subject: [E-devel] [PATCH]: keyboard navigation in menus
I was using elementary on a target that only has a keyboard, and I add
to do several modification on the elm_menu to handle keyboard
navigation.
- patch 1: discard a menu from C source code
- patch 2: add accessors for menu items and add the ability to handle
selected item from C source code
SVN revision: 58084
Subject: [E-devel] Patch for photocam elm_photocam_file_set
hello, i made a patch for photocam, because i found a bug that
sometimes grid_clearall is done after image preload process, but it
should be done before image preload process, otherwise, only low
quality image is loaded.
Please have a check, thanks~
SVN revision: 58083
Subject: [E-devel] elm_genlist - bug fix about _update_job
I found one bug in _update_job.
Now, when the elm_genlist_item_update is called, all realized items have
been updated.
In _update_job logic, item block is recalculated if it->minw and
itminw is
not same.
But before comparing that, itminw value is saved it->w.
And it->minw value is saved in _item_realzie function.
Then there are different between it->minw and itminw value.
So the item block is recalculated and _item_block_position is called.
After applying below patch, elm_genlist_item_update api updates only one
item.
SVN revision: 58082
Subject: [E-devel] [PATCH] Patch to give focus to the content in
elm_notify
lm_notify has not handled the focus movement.
Even though a button widget is contained in an notify widget and notify
widget is shown, button widget could not be focused.
Therefore, button couldn't process any key event such as space and enter key.
This patch will solve this problem.
SVN revision: 58081
If the scroller is stopped and set the freeze push while bounce
animation is running, it will stop bouncing in a moment. Even if the scroller
is set the freeze pop again, the scroller don't finish the bouncing. I think
that it should finish the bouncing when it is set the freeze pop.
SVN revision: 58063
Elementary was missing window types for dropdown_menu, popup_menu,
tooltip, notification, combo, and dnd. This patch adds the missing
types into the enum and elm_win code.
SVN revision: 57992
Subject: [E-devel] [Patch] Small patch for elm_slider (scrolling pop +
push)
I made small patch for elm_slider.
I think scrolling should be freezed (not held) when dragging is
started.
This is because scrolling can go on with elm_widget_scroll_hold_push.
SVN revision: 57959
>>> Hello,
>>>
>>> I was using elementary on a target that only has a keyboard, and I add
>>> to do several modification on the elm_menu to handle keyboard
>>> navigation.
>>> - patch 2: add accessors for menu items and add the ability to handle
>>> selected item from C source code
SVN revision: 57957
Subject: [E-devel] [Patch] Focus issue in elm_widget.c
I've checked there were some focus problems when an object is hidden.
So I made patch for that ~
SVN revision: 57898
Subject: [E-devel] [PATCH] elm_entry : use EINA_FALSE instead of 0 when calling edje_object_part_text_select_allow_set
Date: Fri, 18 Mar 2011 13:04:44 +0900
Hi,
This is simple patch to use EINA_FALSE instead of 0 when calling
edje_object_part_text_select_allow_set in elm_entry.c
Would you please apply in svn?
SVN revision: 57836
It cause a error since the pan object does not have any child yet.
And why it should be visible even if it should call evas_object_show after setting child?
Anyway, the line does nothing.
SVN revision: 57683
After a widget is created(obj = elm_widget_add), the object does not have any parent object.
However if user call elm_widget_sub_object_add(parent, obj), then CRI will be happened.
So the exception should be there.
SVN revision: 57667
Subject: [E-devel] [Patch] elm_smart_scroller_child_region_show_internal
In the els_scroller of the elementary, the function
"elm_smart_scroller_child_region_show_internal"
have a problem. If the parameters "x,y,w,h" have the wrong value like
"elm_scroller_region_show(scroller,
-300, -300, 900, 900);", the scroller move the position temporarily.
The scroller seem to jump.
So if the value of the parameter is not valid, it should be changed to
valid value.
The work is applied already in the function
"elm_smart_scroller_region_bring_in".
It should be applied in the function
"elm_smart_scroller_child_region_show_internal" too.
I changed the code like bring_in function.
SVN revision: 57666
Subject: [E-devel] [Patch] elm_map_marker_region_get
This is a patch for elm_map_marker.
I added one api to get the coordinates of the marker.
because marker->longitude and marker->latitude are private data,
app can't access the coordinates of the marker.
SVN revision: 57665
Subject: [E-devel] [Patch] anchorview's "clicked" signal is always
sent when mouse up.
I've checked "anchor,clicked" signal is always sent with mouse_up.
That is, mouse_down on the anchor -> mouse_move out from the anchor ->
mouse_up can emit "anchor,clicked" signal.
So I made one patch for right clicked signal emitting.
SVN revision: 57664
Subject: [E-devel] [PATCH] elm_gengrid selection key patch
Unlike other widget, gengrid processes only the "Return" key for
selecting item.
This patch makes gengrid be able to process KP_Enter and space key for
selecting item.
SVN revision: 57662
Since these APIs are committed not much days ago, Im modified the API names to make better.
But Im not sure. how many people are using this APIs at this time.
I guess nobody.
SVN revision: 57651
These APIs provide options to user to set the properties of the transit objects will be rest or not when the transition ends.
The properties include geometry, color, evas_map data..
SVN revision: 57498
Hello.
I attached the modified patch about calc_job problem.
When I tested gengrid, sometimes gengrid renderd two times in different
shape in a moment.
So I checked gengrid code, I found cause in calc_job function.
calc_job added to ecore job after elm_gengrid_item_size_set and
elm_gengrid_item_append(,prepend,insert_before,insert_after) and etc.
Sometimes pan_smart's cvw and cvh is 0 at this time.
I think, No need to calc_job when pan_smart's cvw and cvh is 0.
Please check about this patch.
Thanks.
SVN revision: 57491
It will provide new apis - elm_transit_object_prop_hold_set/get to give a option for keeping the object property when effect is over.
SVN revision: 57396
Subject: [E-devel] elm_genlist - bug fix about del callback
I found one bug in elm_genlist_clear.
In case append lots of items in genlist, some items are still in genlist
item queue before it is processed in _item_queue.
At that time, if application calls elm_genlist_item_del api that has item in
genlist queue and elm_genlist_clear is called at once, "func.del" callback
is called twice.
If application frees some memory in "func.del" callback, It occurs
double free memory problem.
For example, some application has many items. and all items are deleted. but
all items are not proceed in queue. then application is terminated.
In that case, double free problem is occured in application.
So, I fixed elm_genlist_clear code and made a patch.
SVN revision: 57371
Subject: Re: [E-devel] [Patch] elm_map_user_agent_set and get
This is a patch for elm_map for setting user-agent.
- Add elm_map_user_agent_set
- Add elm_map_user_agent_get
- modify doxygen
elm_map uses OSM(OpenStreetMap), but we can add custom map provider.
If custom map provider server filters robot out (currently default
user-agent is 'curl'),
we need some APIs to set/get user-agent.
SVN revision: 57353
[patch] els_scroller - simple bug fix about bar-dragging. by Jae Hwan Kim.
More info:
You can test it in "Scroller" menu of the "elementary_test".
We cannot move the scroller by dragging the bar.
The reason is why the bar-dragging-event and mouse-move-event confict.
When bar is draged, the movement by mouse-move should be freezed.
SVN revision: 57184
Subject: [E-devel] [patch] elm_label - bugfix at string manipulation
ear Elementary developers.
It's a elm_label bugfix.
It has two small improvements.
1. Current code can be reference null ptr.
- replocater = curlocater + key_len + 1;
- while ((*replocater != '=') && (replocater))
^^^
-
replocater++;
It should be *replocater, not replocater
2. there are two while loop to find a separate character in
string.
I changed it from loop to strchr.
SVN revision: 57161
Subject: [E-devel] [Patch] elm_map_marker_remove test code
Dear all,
This is a patch for elm_map_marker_remove test code.
I added one button for marker_remove to test_map.c
SVN revision: 57044
objects hierarchical region show. Scroller pan geometry is included, as scrolelr
is smart object, not in genlist hierarchy.
Patch By Govindaraju SM <govi.sm@samsung.com>
SVN revision: 56981
1. the range of marker to remove.
2. after free(marker->groups[i]), reuse the value.
Patch by Sangho Park <gouache95@gmail.com>
Reviewed by Atton Jonathan.
SVN revision: 56849
Carsten Haitzler
Tom Hacohen
govi.sm
Sangho Park
Daniel Juyung Seo
ChunEon Park
cnook
Cedric BAIL
Michael BOUCHAUD
Christopher Michael
Seunggyun Kim
Boris Faure
Brett Nash
WooHyun Jung
Tristan Lelong
suxia li
Jihoon Kim
Jae Hwan Kim
Hyoyoung Chang
Daniel Kolesa
titan
Jonathan Atton