Commit Graph

58345 Commits

Author SHA1 Message Date
JongMin Lee a07d729b2f elm: resolve possible memory leak.
@fix
2018-04-20 15:41:32 +09:00
JongMin Lee a42451d688 elm: resolve possible memory leak.
@fix
2018-04-20 15:36:32 +09:00
JongMin Lee b1caf014ef ecore_wl_dnd: correct wrong variable assignment
@fix
2018-04-20 15:29:44 +09:00
Jaehyun Cho fcffd58223 efl_net_control_access_point-connman: Remove unused code
if the method is EFL_NET_CONTROL_ACCESS_POINT_PROXY_METHOD_UNSET, then
the function is returned before.
2018-04-20 14:28:41 +09:00
Jaehyun Cho 0bebd097b5 elc_multibuttonentry: Fix to make multibuttonentry to be legacy only
To make multibuttonentry to be legacy only, inappropriate efl ui
interface usages are removed in multibuttonentry.
2018-04-20 14:07:35 +09:00
Hermet Park fd85423ae3 ecore: fix a potential memory leak.
if the func argument is null, allocated memory won't be freed properly.
return it as soon as possible.

@fix
2018-04-20 13:29:46 +09:00
Hermet Park 215b854b54 edje edje_cc: fix memory leak.
This token has temporary alloc'd memory.
We should free it before loosing its ptr address.

@fix
2018-04-20 13:12:22 +09:00
Hermet Park 5ea2f94ffb edje: Don't access a garbage pointer.
set null to avoid multiple access.
At 221 line, it tries to free tmp again.
2018-04-20 11:44:43 +09:00
Lauro Moura 1179058017 efl_mono: Fix after prop get const change 2018-04-19 14:06:02 -03:00
Stephen 'Okra' Houston cf359629a5 Focus: If tree focus is set to not allow focus on the object - don't give it focus.
Patch from Marcel 'bu5hm4n' Hollerbach
2018-04-19 11:19:51 -05:00
Lauro Moura 90f7144e81 elementary: Fix multibuttonentry legacy build.
Summary:
The legacy header was still referencing the eo class removed in
939690a8a9.

Reviewers: cedric, Jaehyun_Cho, vitor.sousa

Reviewed By: vitor.sousa

Differential Revision: https://phab.enlightenment.org/D5970
2018-04-19 12:38:19 -03:00
Jaehyun Cho d767c31a57 test_ui_stack: Add test using Efl.Ui.Stack class
Add test using Efl.Ui.Stack, Efl.Ui.Navigation_Layout, and
Efl.Ui.Navigation_Bar classes.

Navigation_Bar widget is set into Navigation_Layout widget and
Navigation_Layout widget is pushed into Stack widget.
2018-04-19 23:40:10 +09:00
Jaehyun Cho 6c65b6368a efl_ui_navigation_bar: Add Efl.Ui.Navigation_Bar class
Efl.Ui.Navigation_Bar is a widget which provides a bar form useful for
navigation.
2018-04-19 23:40:06 +09:00
Jaehyun Cho 7e8722be00 efl_ui_navigation_layout: Add Efl.Ui.Navigation_Layout class
Efl.Ui.Navigation_Layout is a widget which provides a layout form useful
for navigation.
2018-04-19 23:40:01 +09:00
Jaehyun Cho ab4fa83f62 efl_ui_stack: Add Efl.Ui.Stack class
Efl.Ui.Stack is a container arranges objects in stack structure by
pushing and popping them.
2018-04-19 23:39:57 +09:00
Jaehyun Cho e3315baaa3 efl_canvas_object: Add events for state changes of object's animation
Add events to notice the state changes of canvas object's animation.
anim_started, anim_running, and anim_ended events are added.
2018-04-19 23:39:32 +09:00
Woochan Lee 939690a8a9 Revert Efl.Ui.Multibuttonentry to create new one.
Summary:
Revert e02b2f04c2945ad60fab5612af1e02b0838b7ff5.

I couldnt make a revert commit for many commit has been related with above commit.

I will create a new MBE eo class ASAP. (https://phab.enlightenment.org/T5358)

Reviewers: cedric, woohyun, Jaehyun_Cho, SanghyeonLee, herb

Reviewed By: Jaehyun_Cho

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D5954
2018-04-19 22:22:01 +09:00
Daniel Kolesa a2ccdb7b21 eolian: re-enable non-dependencied parsing
The issue was that standalone-parsed files (outside of dependencies
of some other unit) were not being included in that dependency tree
(obviously) which resulted in their own dependency tree being
excluded from merging, causing the database hashes to lack the
necessary elements.

To fix this, I trigger merging of the "standalone" dependency trees
separately, by calling _merge_units from defer parsing cb.
2018-04-19 13:44:14 +02:00
Daniel Kolesa 974fa323a1 eolian: disable non-dependencied parsing for the time being
As 543902f2ba breaks build,
disable parsing with state as a parent for now, until the issue
is figured out.
2018-04-18 21:17:31 +02:00
Lauro Moura 15fcaaec69 elm: Move legacy genlist types to elm_general.
Summary: Fixes T6771

Reviewers: bu5hm4n, felipealmeida

Subscribers: q66, cedric

Maniphest Tasks: T6771

Differential Revision: https://phab.enlightenment.org/D5938
2018-04-18 19:03:19 +02:00
Daniel Kolesa 543902f2ba eolian: make doc ref resolution global
Doc refs no longer introduce new dependencies into files. Instead,
they're parsed globally, and any doc ref lookup is also made
globally. This allows unit based dependencies to correspond more
to what files actually really need at compile time/runtime, with
docs being irrelevant to that; it also simplifies the API.

The doc resolution API now takes Eolian_State instead of
Eolian_Unit, too.
2018-04-18 16:38:14 +02:00
Daniel Kolesa d13cfe1b83 eolian: doc ref validation cleanup 2018-04-18 16:38:14 +02:00
Daniel Kolesa 28b1dd25c7 eolian: add internal api for dep deferring + parsing without dep
This is cleaner than adding into a hash manually. Additionally, it
is now possible to request that the file be parsed not as a dep,
but rather standalone, which will be useful later.
2018-04-18 16:38:14 +02:00
Daniel Kolesa 311fada0d2 eolian: simpler and more efficient defer parsing 2018-04-18 16:38:14 +02:00
Derek Foreman 50a9b49acc elm_win: Don't do auto norender on non X11 engines
This only really makes sense on X11 and can lead to some seriously
confusing cases on other engines (*cough* wayland) when elm's idea
of iconified state doesn't match the compositor's.

While currently only X11 is whitelisted, other backends can be
added, though I suspect most are more like wayland where it makes
no sense at all.

ref T6834
2018-04-18 09:15:39 -05:00
Mike Blumenkrantz ab430e3ee5 tests: preload elm csd theme in elm_suite startup
Summary:
ref T6864
Depends on D5958

Reviewers: stefan_schmidt

Subscribers: cedric

Maniphest Tasks: T6864

Differential Revision: https://phab.enlightenment.org/D5959
2018-04-18 13:58:15 +02:00
Mike Blumenkrantz 9bfa85fdf0 tests: skip second ecore_shutdown call in elm_suite when forking
Summary:
init is only called here to verify the refcount, shutdown is only necessary
when not forking in order to preserve the environment

ref T6864

Reviewers: stefan_schmidt

Subscribers: cedric

Maniphest Tasks: T6864

Differential Revision: https://phab.enlightenment.org/D5958
2018-04-18 13:57:49 +02:00
Stefan Schmidt 72f4ab875d examples: cxx: fix some missing const attributes in colourable*
Fixing some fallout from fcae7cab27

Given that the examples do not build for weeks with CXX enabled this is
just the tip of the iceberg.
2018-04-18 10:15:26 +02:00
Stefan Schmidt c79f6640bd travis: fix install of packages on macOS
Some recent OSX builds failed on Travis due to a change on the macOS
image they are providing. The python package could not be installed.

==> Pouring python@2-2.7.14_3.sierra.bottle.1.tar.gz
Error: The `brew link` step did not complete successfully
The formula built, but is not symlinked into /usr/local
Could not symlink bin/2to3-2
Target /usr/local/bin/2to3-2
is a symlink belonging to python. You can unlink it:
  brew unlink python
2018-04-18 10:15:26 +02:00
YeongJong Lee 2c8c7807f1 config: fix Efl.Ui.Slider key binding
Summary: this fixes T6796

Test Plan: elemetary_test -to slider

Reviewers: woohyun, Hermet, Jaehyun_Cho

Reviewed By: Jaehyun_Cho

Subscribers: cedric

Maniphest Tasks: T6796

Differential Revision: https://phab.enlightenment.org/D5962
2018-04-18 15:34:35 +09:00
Derek Foreman 73beab6a08 ecore_con: Fix build
commit fcae7cab27 broke connman stuff,
I've blindly fixed it up here.  I don't actually use or test ant of this
but apparently I build it.

If it's broken, please mail the pieces to Daniel Kolesa.

Ref T6859 I guess
2018-04-17 14:49:20 -05:00
Daniel Kolesa fcae7cab27 eolian gen: enable constness generation on property getter impls
This changes a lot of things all across the EFL. Previously,
methods tagged @const had both their external prototype and
internal impl generated with const on object, while property
getters only had const on the external API. This is now changed
and it all has const everywhere.

Ref T6859.
2018-04-17 20:31:55 +02:00
Derek Foreman e50b43d02f ecore_wl2: handle configure_complete after handling configure
since configure_complete may result in a draw op, configure should be
handled first so the size is correct.
2018-04-17 11:12:27 -05:00
Mike Blumenkrantz 67705589ac tests: preload elm_init and default theme groups in elm_suite
Summary:
opening the default theme file can take up to 0.2s in worst case during
a test

ref T6864
Depends on D5914

Reviewers: stefan_schmidt

Reviewed By: stefan_schmidt

Subscribers: cedric

Maniphest Tasks: T6864

Differential Revision: https://phab.enlightenment.org/D5915
2018-04-17 15:43:52 +02:00
Mike Blumenkrantz 22cb35c9a4 tests: use loop test to split jpeg tests from evas_object_image_all_loader_data
Summary:
jpeg loader tests take 4+ seconds due to manual value comparisons, so ensure
that they run separately

ref T6856

Reviewers: stefan_schmidt

Subscribers: cedric

Maniphest Tasks: T6856

Differential Revision: https://phab.enlightenment.org/D5911
2018-04-17 15:14:52 +02:00
YeongJong Lee c943c4a2ff elm_dbus_menu: add missing const for Eina_List
Summary:
This fixes following warning

../src/lib/eina/eina_list.h:1421:10: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]

Test Plan: make

Reviewers: SanghyeonLee

Reviewed By: SanghyeonLee

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D5952
2018-04-17 11:08:25 +09:00
Davide Andreoli 01a95d1f40 Revert "Genlist: restore old behaviour of item next/prev in group items"
This reverts commit f0a0da9f44.

As per T5938 seems we really want to restore a totally wrong
behaviour, without taking care of newer apps being broken.

I revert this for now, but I'm still convinced that we must
find a way to let user use a sane ordering for newer app.

I'm thinking about adding an api in genlist to let the widget
use the new sane ordering, something like
elm_genlist_fixed_ordering_set(bool) so that new apps can use
this to ensure correct behaviour. zmike what do you think about
this solution?
2018-04-17 00:11:11 +02:00
junsu choi ad6ef48053 eo : Add null check
Summary:
This commit add null check on __efl_auto_unref_set.
In EO_OBJ_POINTER, if obj_id is null, obj can also be null.

Test Plan: N/A

Reviewers: woohyun, kimcinoo, cedric

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D5869

Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
2018-04-16 11:24:29 -07:00
SubodhKumar b650325b88 edje: Dont append font source if fonts are not embedded in edje
Summary:
If font source is not embedded in edje, it should not
be appended in font source to skip the lookup in edj file
while loading font.

@fix

Test Plan: NA

Reviewers: cedric

Reviewed By: cedric

Subscribers: shilpasingh

Differential Revision: https://phab.enlightenment.org/D5909

Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
2018-04-16 11:23:23 -07:00
Bryce Harrington 4ea4a20455 eina: Improve documentation formatting
Summary:
Revise wording of a few parameters, improve consistency of punctuation
and documentation body placement.

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D5918

Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
2018-04-16 11:21:50 -07:00
Wonki Kim d1ed913f85 elementary: Remove unreachable code lines
Summary: This patch removes unreacahble code lines

Reviewers: cedric, woohyun, eagleeye

Differential Revision: https://phab.enlightenment.org/D5923

Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
2018-04-16 11:21:21 -07:00
Bryce Harrington 025b54ce52 eina: Cleanup documentation for Sparse Matrix.
Summary:
Revises some descriptions, polishes wording, makes punctuation and
formatting more consistent, and straightens out some convoluted grammar
here and there.

There are a few places where the parameter documentation was incorrectly
cut-and-pasted from other routines, so this is fixed.  Also, in
eina_matrixsparse_iterator_new() the docs say the elements are not
returned sequentially, but from the context and code I think it meant to
say they're not _consecutive_.

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D5924

Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
2018-04-16 11:20:24 -07:00
Wonki Kim 34216aa9eb Fix a shutdown logic to be reachable in some case
Summary:
move evas_async_events_shutdown: to out of EVAS_CSERVE2 ifdef block
to make it reachable.

Reviewers: cedric, woohyun

Differential Revision: https://phab.enlightenment.org/D5926

Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
2018-04-16 11:18:29 -07:00
SangHyeon Lee 9c8ebc9dfc elm_menu, toolbar, ctxpopup : remove unnecesary interface efl_ui_item and efl_ui_menu
Summary:
Legacy menu toolbar and ctxpopup are not new efl interface widget,
but it have efl interfaces, efl_ui_item and efl_ui_menu.
if we plan to implement this two, it should be a class not a interface,
so I remove it on legacy widget.

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D5939

Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
2018-04-16 11:03:02 -07:00
Mike Blumenkrantz 9dcf6f71d0 ecore: further reduce pipe wait time during shutdown.
Summary:
it turns out that 0.01s is actually a lot, accounting for something like
20s across a run of 'make check' while providing no additional value

ref e0c8ab4c79
ref T6825
ref T6864

Reviewers: cedric

Maniphest Tasks: T6864, T6825

Differential Revision: https://phab.enlightenment.org/D5941

Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
2018-04-16 10:57:32 -07:00
Mike Blumenkrantz 7708154069 tests: remove explicit checks for eina mempool tests
Summary:
this was only a temporary measure
Depends on D5916

Reviewers: stefan_schmidt

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D5937
2018-04-16 12:24:35 +02:00
Mike Blumenkrantz 576570ce27 tests: flush stdout after printing test suite timing info
Summary:
avoid repeating lines

Depends on D5937

Reviewers: stefan_schmidt

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D5917
2018-04-16 12:24:35 +02:00
Mike Blumenkrantz 1885374ce5 tests: do not attempt to parallelize test suites with only 1 test case
Summary: Depends on D5911

Reviewers: stefan_schmidt

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D5916
2018-04-16 12:24:35 +02:00
YeongJong Lee ffbbf7b7d6 elm_list: check there is focused item when list get focus at first
Summary:
list have got focus. but there isn't logic to check whether focused_item exist.
we need that logic for list focus
this fixes T6807, T6799

Test Plan: elementary_test -to 'list focus'

Reviewers: bu5hm4n

Reviewed By: bu5hm4n

Subscribers: cedric

Maniphest Tasks: T6807, T6799

Differential Revision: https://phab.enlightenment.org/D5935
2018-04-15 11:52:34 +02:00
Davide Andreoli f0a0da9f44 Genlist: restore old behaviour of item next/prev in group items
Commit fd82c2521 has changed the behaviour of item_next/prev_get()
in case of genlist with group items (not tree).

The lagacy behaviour was to tread normal items and group items
in a flat way, like if group items was on the same level of
the children normal items.

As the commit already implement bug compatibility, seems to me
the case to restore also this case. Note that this changes only
apply to legacy genlist (I think).

Let me know if this broke something for you...as touching genlist
code is always an "I hope this is right" operation.
2018-04-13 20:37:36 +02:00