So basically you can request markup without images. If you want both request
MARKUP | IMAGES. Then when an image comes in you'll get an image as markup.
SVN revision: 56076
Subject: [E-devel] [Patch] elm_map downloading progress info & bug fix
I added one new signal, one new API and fixed seg fault bug.
- signal : "download" (this signal is called when map_tile is
downloaded)
- API : elm_map_utils_downloading_status_get(const Evas_Object *obj, int
*try_num, int *finish_num)
- seg fault : if user select custom map provider, seg fault occurs,
because
there is no url_cb in the custom map provider
you can check download progress using these signal & API.
the example is in "test_map.c".
SVN revision: 56039
Subject: [PATCH] elc_ctxpopup
Here code is for the ctxpopup.
Since the functionalities of ctxpopup are somewhat different,
I'm trying to overwrite the ctxpopup code entirely first.
The main reason is,
Original ctxpopup could determine it's size and position by itself.
Of course, upstreamed version supports this. But it can not be reduced
it's
size
And it supposes the arrow position to center of box edje.
Basically,
This version calculates it's box size first then find available space
from
the it's position.
The origin position of the box is not expected, it finds the available
positions.
But if there is not enough space to be shown, then it finds a best
direction
to be shown again.
In this case, it reduces it's size also as to be shown entirely.
Since the ctxpopup supports scroller, the reduced box could show the all
items also.
(The point is ctxpopup should know the size of total items...)
I'm not sure the upstreamed version could cover the above scenario,
If then, I need to modify it first.
(fixed some minor formatting issue too)
SVN revision: 56021
Subject: [E-devel] [Patch] elm_genlist doxygen fix and addition.
I fixed some typos of Genlist doxygen and added more explanations.
Please review this and apply this to upstream.
SVN revision: 56017
Subject: [E-devel] [PATCH] Change the second parameter type of
elm_slidershow_timeout_set
Most of APIs related to timeout_set / get uses double type as parameter,
but elm_slidershow uses integer type.
For uniformity, the second parameter type of elm_slideshow_timeout_set
is changed into double type.
SVN revision: 56015
Patch original from Hyoyoung Chang.
Modified by me a lot, with some extra debug.
Also I removed the sizeof(char). That was defined to be one before most of us
where born.
SVN revision: 55986
Even it looks somewhat alien elm,
I hope EFL supports basic effect by using c and edc.
In some cases, it is useful for app developers.
They want to use effects easily and quickly as Other F/W does
providing.
Here is patch again.
Added two lines for elm_transit_duration_set exception handling.
I guess there are possibilities still to add/modify some functions to
the
transit.
So, currently the exception cases does not defined yet.
But I will try patches soon as perfect things.
Please consider about transit.
And.. if this transit is acceptable,
How about deprecate elm_animator as soon as possible?
SVN revision: 55966
Subject: RE: [E-devel] [Patch] Group index support
I added a small patch for Genlist group item clear.
And I changed git->minh to git->h in item_block_position function.
Thanks Govi
SVN revision: 55965
raster: may I rename elementary_config.h to config.h ? If I
add macros for all the init stuff, it would be nice to have
consistent name for that file
SVN revision: 55952
Subject: RE: [E-devel] [Patch] Group index support
I added a small patch for Genlist Group.
I missed one. Thanks Govi!
Can you review this and apply it to upstream?
SVN revision: 55929
Subject: [E-devel] [Patch] Group index support
I added group index feature.
This feature support to show item indicates group index.
I attached capture images showing group index.
As you can see attached png images, Group index item includes same group
items.
The group index is shown until every items that have same group index
are scrolled. so group index realize/unrealize is not excuteded in
_item_block_position function.
instead of the function, group index is controlled in _pan_calculate
function.
"Genlist Group" and "Genlist Group Tree" menu is added in
elementary_test. you can test group index operations in elementary_test.
This patch is not support elm_genlist_item_insert_before/after
operation of group index. We are now considering the operations in group index.,
This patch assumes that the previous 2 patches are already applied to upstream.
'[E-devel] [Patch] Tree support for elm_genlist_item_prepend() API.'
'[E-devel] [Patch] Tree support for
elm_genlist_item_insert_before/after() APIs',
So this patch does not include the changes of the previous patch.
I separated this patch.
- 004.elm_genlist.c.patch.txt
Patch for src/lib/elm_genlist.c
- 005.test_genlist.c.patch.txt
Patch for src/bin/test_genlist.c
- 006.genlist.patch.txt
Patch for data/theme/default.edc
And you have to add attached group_index.png file into 'data/themes'
'group_index.png' file is group index background image.
Daniel Juyung Seo help make test code and refactoring group index code.
SVN revision: 55925
Subject: Re: [E-devel] [Patch] elm_map pinch zoom
This is a patch for elm_map pinch zoom.
you can zoom in/out using two fingers.
- add event handler for multi touch.
(also fixed the TOUCH_HOLD_RANGE to use finger size as it should be)
SVN revision: 55920
I fixed a bug for elm_genlist_item_insert_before/after() declarations.
(Thanks glima.)
I should have modified EINA_ARG_NONNULL() when I added a new parameter.
1st and 5th parameter should not be NULL.
Anybody can review and apply this to upstream?
Thanks.
Daniel Juyung Seo (SeoZ)
SVN revision: 55880
Subject: [E-devel] [Patch] elm_genlist multi-touch smart callbacks
added
I added 6 multi-touch smart callbacks in elm_genlist, please refer to
below.
"multi,sweep,left" - Genlist has been multi-touch swept left.
"multi,sweep,right" - Genlist has been multi-touch swept right.
"multi,sweep,top" - Genlist has been multi-touch swept top.
"multi,sweep,bottom" - Genlist has been multi-touch swept bottom.
"multi,pinch,out" - Genlist has been multi-touch pinched out.
"multi,pinch,in" - Genlist has been multi-touch pinched in.
I think these smart callbacks are very useful for elm_genlist
multi-touch
effect.
If this patch have any issue, please let me know.
SVN revision: 55878
Subject: [E-devel] [Patch] elm_actionslider feature patch for
elementary.
This patch is for elementary elm_actionslider.
Mr. Sumanth created this patch. I reviewed it and fixed some.
This patch includes below features.
- Indicator label Set/Get APIs.
- _del_hook fix for wd->drag_button_base.
- Added magnet disable feature. _drag_button_up_cb fix for no magnet
handling. If magnet position is set to ELM_ACTIONSLIDER_NONE, it disables
magnetic. Added a test case to elementary_test.
SVN revision: 55872
Subject: [E-devel] elm_label patch(bugfix)
It's a bugfix patch of elm_label.
In strbuf_key_value_replace, null pointer reference can be occured
SVN revision: 55870
Subject: [E-devel] [Patch] Tree support for
elm_genlist_item_insert_before/after() APIs
I added tree feature support to
elm_genlist_item_insert_before/after() APIs.
This patch assumes that the previous patch, '[E-devel] [Patch] Tree
support
for elm_genlist_item_prepend() API.', is already applied to upstream.
So this patch does not include the changes of the previous patch.
This patch includes API break. I added parent parameter.
To support genlist group index feature, it should have a parent
parameter
like elm_genlist_item_append/prepend() do.
Raster already agreed to this API break.
I or my co-worker will introduce genlist group index feature today.
But for the reviewer's convenience, I separated this patch.
- 001.elm_genlist.patch.txt
Patch for src/lib/elm_genlist.c
- 002.elm_genlist.patch.txt
Patch for src/lib/Elementary.h.in, src/bin/test_genlist.c
- 003.elm_genlist.patch.txt
Due to API break, I changes other EFL libraries and applications on SVN.
SVN revision: 55869
Subject: [E-devel] [Patch] Tree support for elm_genlist_item_prepend()
API.
I added tree feature support to elm_genlist_item_prepend() API.
(elm_genlist_item_append() already supports tree.)
This patch is tested with elementary_test -> Genlist Tree.
Please review this and apply it to upstream.
SVN revision: 55868
elm_photocam widget does not support keyboard input.
This patch makes elm_photocam be able to process keyboard input such
as Left,
Right, Up, Down, PgDn, and PgUp key.
In addition, image will be zoomed in or out when '+' or '-' key in
keypad is pressed.
Please review it and let me know if there is any problem in this patch.
SVN revision: 55842
I found one small bug in elm_gengrid.c
"item" is used after "free(item)" in elm_gengrid_item_del() function.
Can anybody check about this ?
SVN revision: 55841
Subject: [E-devel] elm_map patch for supporting keyboard input
Most of elementary widgets can process keyboard input, but elm_map widget
has not. This patch makes elm_map be able to process keyboard input such as
Left, Right, Up, Down, PgDn, and PgUp key. In addition, map image will be
zoomed in or out when '+' or '-' key in keypad.
Please review it and let me know if there is any problem in this patch.
Merry Christmas!
SVN revision: 55840
Subject: [E-devel] [Patch] elm_bubble theme patch
I'm Sohyun Kim. Nice to meet you.
This is a patch for bubble theme.
The bubble has a region for icon, label and info text.
However, it has the region, if icon, label and info text are not set.
I modified theme and added edje signals.
1. add edje signal for label and info text state
2. remove text size for label and info text default state
-> set it on "visible" state
3. add base image state for info text only
SVN revision: 55839
Subject: [E-devel] [Patch] els_scroller momentum_animator and bounce
animator disabled set/get added
This is a patch for momentum_animator and bounce animator
enabling/disabling
in els_scroller.
I added below api for disabling when the scroller's momentum or bounce
animator need to be disabled in some case.
Eina_Bool elm_smart_scroller_momentum_animator_disabled_get
(Evas_Object
*obj);
void elm_smart_scroller_momentum_animator_disabled_set
(Evas_Object *obj, Eina_Bool disabled);
void elm_smart_scroller_bounce_animator_disabled_set
(Evas_Object *obj, Eina_Bool disabled);
Eina_Bool elm_smart_scroller_bounce_animator_disabled_get
(Evas_Object
*obj);
SVN revision: 55690
Reasons for this patch are as follows.
1. Clicked signal is emitted from button when mouse release region
coincides
with button region and there has not been any drag outside the region
during
pressed state. (theme change)
2. Unpressed signal is emitted from button every time we press on
button and
unpress it irrespective of whether we unpress in button's region or
outside.
(theme change)
3. The unsetting of maximum size hint has been removed from _sizing_eval
function as there is a possibility that some application may set this
hint
and if we unset it then this information set by application will be
lost.
4. Modification in test code for button to show the difference between
clicked and unpressed signal emission from this widget. Added a
scroller in
the heirarchy to show the effect of hold on clicked signal emission.
SVN revision: 55687
Subject: [E-devel] [Patch] elm_map module patch
This is a patch for elm_map module.
when app developers or companies want to use specific license map (i.e
google map), module is needed.
- add new map provider for module "ELM_MAP_SOURCE_MODULE".
- add test_map module.
- add test code for module provider.
- add my name to AUTHORS.
SVN revision: 55684
here is a patch for elm_genlist.
Fixing Eina_Bool in elm_genlist.
0 -> EINA_FALSE
1 -> EINA_TRUE
And fixed return value of _item_block_recalc from int to Eina_Bool.
Anybody can review this and apply it to upstream?
Thanks.
Daniel Juyung Seo (SeoZ)
SVN revision: 55673
Subject: [E-devel] elm_cnp_helper patch(check string length)
Dear Brett Nash, and Elementary developers.
It's a elm_cnp_helper patch.
main changes are
1. check string length when retrieving filename
2. adding bmp filetype and ignoring filetype case
(also a type error fix for utf8).
SVN revision: 55656
Subject: Re: [E-devel] elm_label patch(ellipsis, sliding)
It's a elm_label patch.
My previous patch is too big to submit.
So I did split into patch files.
(Thanks for Gastavo and Rasterman)
2. adding label text sliding feature
SVN revision: 55654
Subject: Re: [E-devel] elm_label patch(ellipsis, sliding)
Dear Elementary developers.
It's a elm_label patch.
My previous patch is too big to submit.
So I did split into patch files.
(Thanks for Gastavo and Rasterman)
main changes are
1. refine ellipsis algorithm
- improve to cut string to fit
SVN revision: 55653
Subject: [E-devel] [PATCH] Patch for elm_slider.c (if you click the
bar of the slider, the button will be at there.)
I made one patch for elm_slider.c file.
If you click the bar of the slider, the button will be located at there.
(If you keep your "mouse_down" after moving of the button, you can
continuously move the button.)
SVN revision: 55610
Subject: [E-devel] [PATCH] elm scroller, scrolled entry: events
propagation, min size
It's not possible to connect event handler such as
EVAS_CALLBACK_KEY_UP to
elm_scrolled_entry because the scroller inside the scrolled entry does
not
propagate events. So this is the patch for adding events propagation set
function to scroller and setting it to EINA_TRUE in elm scrolled entry.
And one more thing in scrolled entry, while evaluating its size,
scrolled
entry does not consider its min size.
(It just refers to the min size of its scroller object instead of
scrolled
entry object.)
So here in the attached patch, scrolled entry compares its min size to
the
min size of the scroller object and set the bigger one to its min size
to
keep the min size set by intent.
looks good - some mistakes you made. you forgot the patch that adds
elm_scroller_propagate_events_set() to Elementary.h.in .... i added it
for
you. but remember to include it in your patch next time. Also the
documentation could be a LOT better! i fixed that for you too. also -
you
could have added a elm_scroller_propagate_events_get(). i added that
too for
you. oh.. and you didn't use ELM_CHECK_WIDTYPE().
SVN revision: 55609
Subject: Re: [E-devel] [PATCH] elm widget: make show_region_set
function call all region show functions set by parents
I'm trying to send several patches that I've changed.
This is just the beginning of my patch rushes..
'elm_widget_show_region_set' function works fine in the simple case (any
widget inside one scroller) however, in the complex parent-child case
(such
as entry in the box in the horizontal scroller in the layout in the
vertical
scroller) it doesn't work correctly because all show region functions
set by
scrollers are not called.
So I changed it to call all show region functions set by its parents
widgets
if exist.
Please review the attached patch file and feel free to give me any
kind of
feedback.
SVN revision: 55592
If you try to create a new widget, you must be sure that the parent
is really an evas object.
With the previous implementation it was possible to call an _add
function for an elementary widget with any non-null pointer as parent
eventually causing crashes (like with the elm_box).
SVN revision: 55521
elm_widget_disabled_set was calling focus_jump and it broke the focus tree.
Now, using focus_cycle to pass focus to next object.
Added test to disable focused button in test_focus.
SVN revision: 55408
Subject: Re: [E-devel] [PATCH] els_scroller
els_scroller has some problems.
First, when the function "elm_scroller_page_size_set" is used and the
scroller is bounced,
the signal "scroll,anim,stop" is not called.
Second, the signal "scroll,anim,stop" is called at the time
"ELM_THUMBSCROLL_FRICTION",
even if the animation of scroller end before the time.
So I changed the code "els_scroller.c".
Patch code is the following.
SVN revision: 55341
Subject: [E-devel] [PATCH] elm_slider patch for disable state
elm_slider does not support disable state, so I make this patch.
Please review it and upload in svn if it is ok.
(nb - also fixed vertical slider sizing in defaul theme and changed
jihoons changes to slider test to make the vertical sliders in a
horizontal box so they dont get silly long windows)
SVN revision: 55340
Subject: [E-devel] [PATCH] Some modifications for adapting
elm_longpress_timeout_get().
I made a patch for adapting elm_longpress_timeout_get() function to all
winsets, using long press event.
And I checked one warning in elm_entry.c , so I modified it.
SVN revision: 55339
When we have time, we'll research a way of signalling
mouse events from bottom up, too (or at least emulate that).
Might be useful for "trapping" mouse wheel events, what
Elementary can't do as is.
SVN revision: 55325
The Api is very large, probably there is some EINA_ARG_NONNULL that are
missing in some parameters and others that I put that should not be
there, I tried my best to not have these mistakes, if you find
any, please, fix it :).
SVN revision: 55189
As we talked last week, I made a version of adding external image in
elm_entry. It seeks a local file if prefix is 'file://' then it loads image and adds it. If image file can't be loaded, adding
wft emoticon.
patch in with minor fix for path and an added actual test case in elm
entry test.
SVN revision: 55134
The reason for modifying about elm_colorselector can be "readability".
Each bar in the colorselector has its own color type (like hue, saturation,
...)
So I thought it will be better, if I added enum for each color type.
And, for about elm_entry.c , I thought that "SIG_CLICKED" was wrongly
emitted (by "MOUSE_UP" event).
I deleted mouse_up callback function (as you advised),
because this function didn't do anything by my modification.
By: WooHyun Jung <wh0705.jung@samsung.com>
SVN revision: 55097
Discomfitor, go fix ecrustify :(. Sucking hard for functions like
elm_object_signal_callback_add, i.e., big function prototypes as
argument types.
SVN revision: 55055
When searching for an icon in a theme, efreet needs to load the specific
cache for the theme. So if an icon doesn't exist, this will be a huge
overhead. So it is better to find a theme on init, and then stick with
it.
SVN revision: 55004
elm_scroller_policy_get was not verifying if its parameters are null.
elm_scroller_region_get was not getting the y if you pass x = null
and y != null
SVN revision: 54987
If the file is a NULL pointer, it will delete the old imagem and set its
internal strings about file and group to NULL.
In the get function if the file argument is null does not mean that
it will not retrieve the group too.
SVN revision: 54986
This commit fix the first issue with launcher in elm_test, when was appearing a
white rect all over it and the icons names seemed to be missing. It also fix
a related issue reported by the editje guys.
SVN revision: 54979
As I’ve talked to you just before, I’m sending you the patch file for
applying max size in sizing_eval function in the scroller.
This patch will work in the case below
- elm_scroller_content_min_limit() function is set to 1 (either
width or height)
- the content’s min size is growing up unlimitedly (such as
entry case)
Then the min size of the scroller cannot exceed the max size of itself.
(if we let it be grown up to the content’s min size, there is no way
to limit the size of the scroller and to enable scrolling.)
Please consider this way to avoid failure case (min is greater than
max) in the sizing_eval function,
and give me a feedback if it doesn’t meet any other requirement.
Thank you.
P.S.) patch file was created based on Rev. 54766.
SVN revision: 54978
NB: we got textblock parts as some of our text elements, everyone
knows. They support text_class fallbacking, but what would be an
elegant solution to achive reasonable mapping for styling tags (bold,
highlight, etc)? e17 has some "blah_hilight" text classes, which imho
are ugly...
SVN revision: 54915
Although some widgets are modified in this patch there should not be any visible
change. Actually this patch is intended to fix a Gengrid issue (patch following).
In Gengrid when the items were bigger than the grid itself the scroll would not
work correctly when the alignment was other than 0.0. That happened because the
smart scroller object was assuming the pan origin to be (0,0) and doing some
miscalculations based on that.
SVN revision: 54902
Edje caching primitives exposed in Elm, too, now, and stored at
config. Also, there's now a poller running for all Elm apps doing
cache flushing. All these things have configurable values, of course.
Testing config version bumping too, it should work.
SVN revision: 54851
Spank watchwolf. The last added externals dont compile with the flags
that we try to keep OK, since revision 53683.
Replace calloc(1,X) to use ELM_NEW, i want do tests with mem pool.
SVN revision: 54778
Now working on exposing edje caching too, and having a cache dumping
poller. Patch also replaces some focus_overalay object functions,
too.
SVN revision: 54770
add.del items will try and stick to viewing an acnhor item. it also
handles wrapping text properly now if style has such a thing - a test
style with that is there too (message style) for now - found isasue in
edje with textblock styles - doesnt change on state change. but anyway
- re-wrapping text works.. and it progressively processes the genlist
blocks to re-calc sizes etc. etc. so you dont block and so-on. i5ts
not too shabby. as for that - store has a generic struct type reader
now and is being tested... and get rid of unused var.
SVN revision: 54738
seem to silly fast - scroll speed also now increaese by 1.5x not 2x
and since time extends linearly by left over time from previous scroll
it's less extreme, but still accelerated.
SVN revision: 54733
maybe wrapping unbounded ones into a "general" TC.
TC swithing exposes various widgets bugs WRT layouting of children
objects, we gotta fix them.
SVN revision: 54715
Fix up the syle, use a better (more toolbar-ish) image, align the title in center, add a white bg, remove some useless offset and, last but not least, add an elm.swallow.content part...or your app cant go much further ;)
SVN revision: 54705
In this theme scrollbars do not disappear after a timeout, they are dragable,
there are up and down arrows to scroll and the line you see is also clickable
(much like e17 scrollbars). Ah, they also respect finger size hints.
Ok, some of you will want to kill me, others will probably try but I think that
at this moment is much easier to have a separate theme to desktop systems until
we define exactly what are all the theme differences between them.
SVN revision: 54701
With a small rectangle swallowed as a base is now possible to make scrollbars
respect the finger size hint. But it just makes sense when thumbscroll is
disabled, i.e, when scrollbars should be dragable.
SVN revision: 54700
Some of the gengrid items themes defined in Ephoto can be reused by others
later so it would be better to have those in the default theme.
SVN revision: 54694
Like android and iphone, the scrollbar was made smaller to not incentivate users
to try to drag it since it is not dragable (yet).
And do not worry desktops, you will have a suitable scrollbar soon.
SVN revision: 54693
I'm now populating the default theme with text classes, just commit
with one for now. There can be tweakings at Elm config app's UI fonts
page, I know, but that will come later (editable preview field, font
hinting/fallback, blablabla).
WARNING: for users testing elm config, an old "rm -rf
~/.elementary/config" might be needed here, after this commit.
SVN revision: 54681
1. elm_genlist_item_item_class_update() API
It is required to change an item's item class on run-time.
Applications want to change a certain item's style and callbacks
dynamically.
This looks ok because changing one item's style does not affect performance,
And this API uses elm_genlist_item_update internally.
API name follows elementary naming conventions.
I've also added test code to elementary_test, Genlist 7.
2. constant to macro.
I replaced 2 constants for max_item_per_block and longpress_timeout to
macros.
This could be used in other places of the code.
3. duplicated assignment.
In elm_genlist_item_append, it->before = 0 is written in if and else.
I put this statement out of if().
4. fix doxygen typo
I fixed elm_genlist_compress_mode_set doxygen.
By: Daniel Juyung Seo <juyung.seo@samsung.com>
SVN revision: 54639
Actually it would be nice to fix these in the entire API.
Most widgets use homogenous, elm_genlist uses homogeneous,
that looks to be the name adopted on evas.
SVN revision: 54634
Brett Nash
Gustavo Lima Chaves
Carsten Haitzler
sangho park
ChunEon Park
Daniel Juyung Seo
Jihoon Kim
Nicolas Aguirre
Seunggyun Kim
Mike Blumenkrantz
Vincent Torri
Daniel Juyung Seo
Bruno Dilly
Jeonghyun Yun
Hyoyoung Chang
김지훈
Sohyun Kim
Fabiano Fidêncio
Christopher Michael
WooHyun Jung
Myungjae Lee
Iván Briano
3v1n0
Sebastian Dransfeld
Tiago Rezende Campos Falcao
Otávio Pontes
Jae Hwan Kim
Cedric BAIL
helen
samsung
Massimo Maiurana
Rui Seabra
Leandro Pereira
Rafael Fonseca
Davide Andreoli
Gustavo Sverzut Barbieri
Lucas De Marchi