Commit Graph

49477 Commits

Author SHA1 Message Date
Jean-Philippe Andre ac0dd31075 ecore_input_evas: Enable cancel events by default
After my input event changes, the propagation path has been altered
from:
 ecore_x -> evas_event
to:
 ecore_x -> ecore_input_evas -> evas_event

But ecore_input_evas was ignoring cancel events by default. There
should be no good reason to disable cancel events anymore,
according to @jypark. Also, this fixes an actual bug :)

Fixes T4301
2016-08-09 14:56:39 +09:00
Jean-Philippe Andre d6817f4d6e evas filters: Fix minor issue with print
If the call to tostring() fails, replace the string by (invalid)
rather than ignore the error.

Fixes CID 1308612
2016-08-09 11:43:52 +09:00
Jean-Philippe Andre 4f98d6a007 edje_cc: Remove unused variable 'got_hash'
got_hash will always be zero at the point where it's read.

Fixes CID 1261439
2016-08-09 11:05:50 +09:00
Stefan Schmidt 4e08a2e834 examples: elm: enable +evas3d_scene_on_button_example again
This was disabled at some point but works fien in my testing so enable it
again. If we no longer want it we should remove it completely.
2016-08-08 17:46:46 +02:00
Stefan Schmidt 4d8fd20902 build: examples: make sure we build all examples in list
At some point we lost the \ after track_example_01 and in combination with the
commented out line right afterwards we lost all examples coming after this line.

This just surfaced with JPs latest commit when I did a distcheck build but was
there for a longer time. We now make sure all disabled examples are moved out of
the multi-line list.
2016-08-08 17:20:50 +02:00
Stefan Schmidt 72b88e51f4 eina: add includes for getpid() to work on MacOSX
Without this I get errors from the clang compiler used on Travis for some OSX
builds:
../src/lib/eina/eina_inline_lock_posix.x:845:27: error: use of undeclared identifier 'getpid'
2016-08-08 16:49:55 +02:00
Daniel Hirt 3eae9ff74f Elm.Entry: force cursor change on size_eval signal
This is a follow-up to ba060fe932.
Fixes T4274.
2016-08-08 16:47:22 +03:00
Daniel Kolesa d27c27528c elua: load modules from local dirs first
This fixes cases when running scripts locally - local modules
are preferred over systemwide, avoiding possibly outdated system
scripts from being run.
2016-08-08 14:38:39 +01:00
Stefan Schmidt a5fd63067d eina: safepointer: add since tags to new eina safepointer EAPI 2016-08-08 14:59:57 +02:00
Daniel Hirt be461b8f1b Canvas.text: fix segfault with ellipsis cases
The specific handling for (0.0 <= ellip < 1) doesn't support multi-line cases.
One of the main reasons is that we haven't had the chance to define the wanted
behavior for multi-line.
This is a temporary hack to fix a segfault. The behavior is still undefined,
though.

Fixes T3885.
2016-08-08 15:18:30 +03:00
Jean-Philippe Andre 39166d3fbb examples: Fix button theme
A program was not handling the various states properly.
2016-08-08 20:41:51 +09:00
Carsten Haitzler 0bcd4f73d2 elm filesel - handle api that might provide path too big for buffer
this addresses a path that could be too small (unlikely due to max
path generally being 4k), for a stack buffer. this should make
coverity happy. fix CID 1356634
2016-08-08 18:38:25 +09:00
Carsten Haitzler 933c0a6b04 eina_module - check result of module load from an array of modules
we don't give any debug or info if a module in a list fails to load.
we should at least offer debug info. do that. this fixes coverity
issue CID 1039687
2016-08-08 18:38:25 +09:00
Jean-Philippe Andre 5c88499105 examples: Fix path to edj theme files (theme examples)
A bit complex but should work in most cases (installed & not)
2016-08-08 18:15:53 +09:00
Jean-Philippe Andre fa779f81a4 examples: Compile edj files in elementary examples 2016-08-08 17:49:42 +09:00
Carsten Haitzler 60fec61c8b ecore gl module - dont check value that is already valid
make coverity happy with CID 1347410 - it's technically right that the
code assumes the im ptr is valid until then as it dereferences it
until then and then stores it under pd->image but then checks for
NULL.. it would have crashed already if it were, so rmemove the
pointless check.
2016-08-08 17:47:14 +09:00
Carsten Haitzler e5dbf6cfba elm init - handle return value of ecore_file_init make coverity happy
this isn't an issue as init will never fail, but makes coverity happy
with CID 1353589
2016-08-08 17:47:14 +09:00
Carsten Haitzler 05ad541534 elm dbus menu - handle return value of eldbus_message_iter_arguments_get
handle possible error return of eldbus_message_iter_arguments_get()
according to coverity CID 1353591. this should fix that.
2016-08-08 17:47:14 +09:00
Carsten Haitzler 9d8c829c2f elm app client - check return of eldbus_message_iter_arguments_get
as accoding to coverity CID 1353593 chekc returns of the above
function and return/continue as apporpriate if these fail (which
generallly they shouldnt unless some end of the dbus client is broken).
2016-08-08 17:47:14 +09:00
Carsten Haitzler e3e68f8ae0 efl vpath - make sure we check returns of mkdir just in case for errors
so vpath has a fallback if all things bad go wrong to mkdir a homedir
in /tmp and if that fails use /tmp or use / - if $HOME isnt set ... but
$HOME alwasy should be, so this is only for "a broken system".

this should fix CID 1354286
2016-08-08 17:47:14 +09:00
Carsten Haitzler b146b60974 edje entry - handle insanely low lemory if list_append fails
this fixes coverity CID 1357752
2016-08-08 17:47:14 +09:00
Carsten Haitzler c827d42fbd elm_need_efret() - improve error handling according to coverity
fix CID 1360466

we don't actually chekc if efreet inits right with elm_need_efreet()
as we just assume it inits (And there pretty much is no case where it
will not), but make coverity happy and check.

@fix
2016-08-08 17:47:14 +09:00
Carsten Haitzler c52aa54e61 emotion modules -0 check return value of eina_module_load and print err
this should inform the user via eina log errors that a module load
failed. this fixes CID 1360954
2016-08-08 17:47:14 +09:00
Jean-Philippe Andre f06506c970 evas: Mark native_surface as const
The void* argument should be considered read-only.
This doesn't change anything, really.
2016-08-08 15:16:53 +09:00
Sungtaek Hong 2de14b985c elm_map: fix wrong check of source search
Summary:
When map source is set by elm_map_source_set(),
it foreaches enlisted sources, and should return
when the source cannot be found.

@fix

Test Plan:
Call elm_map_source_set(map, [any type], [Wrong source name]);
         Observe  ERR("source name (%s) is not found", source_name) message.

Reviewers: Hermet, cedric, jpeg

Reviewed By: jpeg

Subscribers: conr2d

Differential Revision: https://phab.enlightenment.org/D4212
2016-08-08 15:16:53 +09:00
Carsten Haitzler dd584b9f79 efl - edje entry - dont emit changed on markup set unless text changed
if the text didnt actually change we generat a lot of noise in changed
signals for no change at all in text. shortcut this and check the new
and old text and compare ptrs, 0 length and strings etc.

this fixes T4045

@fix
2016-08-08 14:27:26 +09:00
Carsten Haitzler 94af40b3b6 evas cserve2 client - treat an invalid size header as fatal
this should make coverity CID 1361430 happy
2016-08-08 14:15:02 +09:00
Jean Guyomarc'h 55f791eb4c ecore_cocoa: remove pointless debug message
This message was also very annoying because systematically
printed out in the syslog when a cocoa window was closed.
2016-08-08 00:12:49 +02:00
Vincent Torri e4c166281f Edje_Edit.h: undef EAPI at the end of the header file
Fixes T4303
2016-08-07 11:47:05 +02:00
Carsten Haitzler c416dfa6eb Revert "elementary: keep theme consistent regarding the disabling of odd/even."
Revert "elementary: disable visual hint at odd/even."

This reverts commit c64071ae13.
This reverts commit 7affe8c204.

This reverds the odd/even theme changes because this BREAKS
ENLIGHTENMENT COMPLETELY. Enlightement also uses odd/even list looks
and REMOVING this REMOVES every 2nd lost item member (it makes them
0x0 sized). This is a major break in actual FUNCTIONALITY in the name
of looks. NO. Revert.

We ship with this look. no more breaking stuff like this in the name
of cosemtics and not ACTUALLY fixing any bug at all. it creates bugs.
2016-08-07 18:30:38 +09:00
Daniel Hirt 24ccd475b8 Evas font: fix size query again
Some wrong variables were used in the rewrite at
8c6effae8e, basically reverting the original fix.
2016-08-07 11:26:53 +03:00
Carsten Haitzler a71f0ed24b edje_cc - fix inheritance of programs and store channel too in copy
this fixes programs that inherit and play audio on specific channels.
i found that sound worked on single line entries but not multipline
beause single line inherit from multi but didnt copy this program
param - the channel number. this fixes this

@fix
2016-08-06 19:10:24 +09:00
Carsten Haitzler 9e09c46574 elm config - dont rescale ui if no config that needs rescale changed
also finger size, and other thigns that could affect ui look that may
need elm rescale to work.

this fixes T4296

@fix
2016-08-06 18:10:36 +09:00
Carsten Haitzler b26bef48f2 evas cserver client tool - handle possible < 0 sized return
this is cserver so its trusted but handle possible < 0 size msg.
address coverity CID1361243
2016-08-06 16:16:19 +09:00
Carsten Haitzler 2bcb4105e1 pdf loader - check return for rmdir
fixes CID 1361218
2016-08-06 15:59:23 +09:00
Carsten Haitzler 83752435cf eina log - handle possible overflow from high mem (last few bytes) or env
fixes CID 1361219
if you had an env var a few gb in size or we had stuff in the last bit
of memory address space this might be an issue, but that won't happen.

@fix
2016-08-06 15:53:18 +09:00
Carsten Haitzler 20c6bd296b eina log - keep coverity happy with potential ptr comparison overflow
fixes CID 1361220

in theory yes end minus start could be insanely huge or end be very
high in memory thus causing an overflow. this would have to be in the
last few bytes of memory space, so it never going to happen. and the
input from the env var has to be sane anyway as its user controlled.

@fix
2016-08-06 15:50:17 +09:00
Carsten Haitzler 15e34ffe15 embryo_cc - fix coverity complaint about assert
fix assert using a strance assert syntax and go back to basic asserts.
fix coverity CID 1361224

@fix
2016-08-06 15:41:02 +09:00
Stephen Houston 31f351ae4e Eio: Update my email address. 2016-08-05 20:33:27 -05:00
Carsten Haitzler d19cd4e63c eina threadqueue - for paranoia lock+ulock+free in order locks taken
so mimic order of locks taken to be paranoid ... this wouldnt be a
deadlock issue but just to be safe instead of sorry.
2016-08-06 09:56:02 +09:00
Stefan Schmidt 64bf1da8c1 edje: mark new edje_mmap_3d_has() API with since tag 2016-08-05 23:14:57 +02:00
Stefan Schmidt 063c31cb24 ecore_wl2: mark new events with since tag 2016-08-05 23:14:57 +02:00
Stefan Schmidt bb984760cd evas: add missing since tag for new evas_object_type_get() API 2016-08-05 23:14:56 +02:00
Cedric Bail 7e8c6b212d ecore: properly track events in Efl.Loop.Fd object.
Thanks Gustavo.
2016-08-05 12:14:18 -07:00
Cedric Bail a7bb1662e2 Revert "elementary/layout: attach edje object API with eo compositing"
This reverts commit 8a988717e1.

It seems we can't actually inherit from class more than once and neither eo
nor eolian will complain about it. You will just get random weird behavior.
This patch should come back once we have made an interface of edje.
2016-08-05 11:09:55 -07:00
Davide Andreoli a3ad7553c5 Simple test case to spot out a bad bug in elm.Entry
The bug is explained in T4296, basically the "changed" signal in elm.Entry is called randomly.
2016-08-05 19:02:19 +02:00
Carsten Haitzler 26db5d5056 eina thread queue - ensure blocks cannot be freed until lock+unlock
just in case... check blocks cannot be freed until locked and unlocked
just in case someone still is holding a lock.
2016-08-05 23:52:20 +09:00
Stefan Schmidt 0a243671c7 README: clarify poppler dependency
We actually need poppler-cpp which is packaged in various ways in different
distros so better give both names here.
2016-08-05 15:26:02 +02:00
Stefan Schmidt 5db441a6df README: update build dependencies and build instructions
Remove part where we recommend the now merged loaders and players and update
build dependencies as well as recommended options.
2016-08-05 14:35:02 +02:00
Carsten Haitzler 84e4cf7145 ecore imf test - remove unused variable 2016-08-05 20:34:42 +09:00