This reverts commit 9f4c43c20dfa36e7a8be18278acf4336c13574d7.
I'm sorry but this causes a side effect(list sizing issue) at enventor.
And I couldn't find any mis-usage in enventor side.
We can't not accept this patch unless we figure the exact reason out.
Summary: This clarifies the documentation of the new api.
Reviewers: SanghyeonLee, shilpasingh, cedric
Reviewed By: cedric
Subscribers: bu5hm4n, buds
Differential Revision: https://phab.enlightenment.org/D3725
Summary:
elm_fileselector_buttons_ok_cancel_set() API checks the existence of
ok button before adding it.
This patch makes condition statement more intuitive.
Reviewers: cedric, bu5hm4n
Differential Revision: https://phab.enlightenment.org/D3770
======
CC libelementary_la-elm_interface_atspi_value.lo
elm_interface_atspi_image.c: In function '_elm_interface_atspi_image_description_set':
elm_interface_atspi_image.c:36:9: warning: 'old_descr' may be used uninitialized in this function [-Wmaybe-uninitialized]
eina_stringshare_del(old_descr);
^
======
Summary:
- in dump_cb buf is allocated by malloc() ->strdup() -> free.
This is needless.
- And buf allocated in dump_cb is strdup again.
This may cause memory leak.
Reviewers: Hermet, woohyun, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3752
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
When item_show / scrolling is happening, _item_block_position will be
called from smart_calculate where item width is set as block width.
If items are not realized _item_realize will be called and if items are
getting realized for first time we set mincalcd as false. So later
item width gets overwritten by min width of item and so issue is happening.
@fix T2603
Signed-off-by: godly.talias <godly.talias@samsung.com>
Test Plan: elementary_test -> Genlist Group -> show 480
Reviewers: prince.dubey, shilpasingh, SanghyeonLee, cedric
Subscribers: rajeshps, seoz, govi
Maniphest Tasks: T2603
Differential Revision: https://phab.enlightenment.org/D3729
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary: This API will return the number of items that have passed the filter at a given point of time. If the API is called before "filter,done" callback comes, it may or may not give the filtered count for the complete genlist.
Test Plan: Updated Genlist_filter example to print the output from filtered_count_get API in "filter,done" callback.
Reviewers: SanghyeonLee, shilpasingh, cedric
Reviewed By: cedric
Subscribers: buds
Differential Revision: https://phab.enlightenment.org/D3725
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
refine code and theme, hopefully solve the issue
that the height of file list (genlist) is calculated wrong.
Test Plan: elementary_test -to fileselector
Reviewers: SanghyeonLee, jpeg, cedric
Subscribers: taxi2se
Differential Revision: https://phab.enlightenment.org/D3715
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary: mapi have to be set NULL after free(m->api)
Reviewers: kimcinoo
Reviewed By: kimcinoo
Differential Revision: https://phab.enlightenment.org/D3756
Eo's syntax has changed (see efl.git for more info), this adjusts
elementary accordingly.
This is a merge commit that merges my branch will all of the fixes
I just ran my script (email to follow) to migrate all of the EFL
automatically. This commit is *only* the automatic conversion, so it can
be easily reverted and re-run.
If the scale is set on an object before contents are set, it will not
pass to them. Because of this, in the test, scale of the first label
remains 1.0, i.e the window scale, instead of 0.5.
The patch modifies the order of the instructions by setting the scale
after setting the label as content of the frame.
Summary: Radio inherits from Check now and remove the duplicate codes
Reviewers: yashu21985, cedric, tasn, raster
Reviewed By: raster
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D3747
Switch to use a lcov config file which geninfo_auto_base and remove hard coding
the base dir to src/lib. geninfo_auto_base is designed for a use case like
ours where we have several base dirs (lib, bin, tests, ...) and it detects them
automatically. This fixes failures in a coverage run like this:
genhtml: ERROR: cannot read
/srv/build/workspace/manual_elm_gcc_x86_64_exactness_coverage/src/lib/test_win_state.c
Where the file is simply looked for in the wrong directory.
gcc thinks the vars may in theory be uniitiialized. it's right but it
won't actually happen. but having noise in warning output is bad, so
fix the warnings so we can focus on the real bugs/issues/warnings
Summary:
After genlist/genrid items are cleared, item highlight still
remains in blank space. This patch fixes this by updating highlight.
Test Plan:
elementary_test -to fileselector
enter blank directory and see highlight still remains
Reviewers: jpeg, SanghyeonLee, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3683
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Check for all error conditions case in elm_spinner_label_format_set
and set label format only if its valid.
Signed-off-by: Shilpa Singh <shilpa.singh@samsung.com>
@feature
Test Plan:
1. Launch elementary test spinner
2. Set invalid formats e.g. formats with out %, formats with more than
one format specifier "%d %s" etc:-
Reviewers: jpeg, cedric
Reviewed By: cedric
Subscribers: govi, buds, subodh6129
Differential Revision: https://phab.enlightenment.org/D3720
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Cedric BAIL
Tom Hacohen
Stephen okra Houston
Hermet Park
shashank.p
Jee-Yong Um
Marcel Hollerbach
Amitesh Singh
SungTaek Hong
Shinwoo Kim
Minkyu Kang
godly.talias
Hosang Kim
Woochan Lee
Mike Blumenkrantz
Jonghee Choi
Daniel Zaoui
Jean Guyomarc'h
Stefan Schmidt
Lauro Moura
Carsten Haitzler
Shilpa Singh