Commit Graph

11603 Commits

Author SHA1 Message Date
Umesh Tanwar ddbea82857 Genlist: Test case added in Genlist Focus example.
Summary:
Added test case to enable/disable mouse wheel. Mouse Wheel is
used to scroll the genlist up/down.

Signed-off-by: Umesh Tanwar <umesh.tanwar@samsung.com>

Test Plan: elementary_test -> Genlist Focus -> Wheel Disabled

Reviewers: raster, Hermet, cedric

Subscribers: sachin.dev, singh.amitesh, SanghyeonLee, eagleeye

Differential Revision: https://phab.enlightenment.org/D2757
2015-06-25 13:24:21 +09:00
Daniel Zaoui 50fa3bfe7c X11/CnP: remove X11 invocations from elm_entry
Code specific to X11 should not be part of elm_entry and can be easily
replaced with elm_cnp APIs.

@fix T2183
2015-06-24 08:26:38 +03:00
Daniel Zaoui 185e88db91 CnP: improve loss callback
- Reset loss cb after invocation as it is no more needed
- When selection is set, previous owner loss cb is invoked only
if the new owner and the previous one are different.
2015-06-24 08:26:38 +03:00
Jaehwan Kim 434a133255 config: fix the flush file path.
@fix
2015-06-23 22:58:30 +09:00
Daniel Zaoui 5eeb1f5622 DnD: remove text/uri handling
This type is not a standard type and can be handled as a text/uri-list
of one uri.

@fix
2015-06-23 16:05:47 +03:00
Daniel Zaoui 422e28129e DnD: remove from elm_cnp code specific to elm_entry
The tag insertion has to be done only from elm_entry callback. elm_cnp
is not supposed to know what will be done with the data.
2015-06-23 15:57:02 +03:00
Daniel Zaoui dff887b560 Tests/DnD: fix uri parsing
When no \n is present at the end of the uris list, the function doesn't
return the uri.
2015-06-23 15:55:31 +03:00
woochan lee 4033c8f587 widget: Add a case that elm_layout is an item view object.
Summary:
The internal API "_elm_widget_item_highlight_in_theme()" look like for list item highlight.
but it can use in another widget which has item view as elm_layout.
In that case, ERR log will be printed.

Reviewers: singh.amitesh, Hermet, woohyun

Differential Revision: https://phab.enlightenment.org/D2736
2015-06-23 08:30:22 +09:00
ChunEon Park f641925d6e list: --printf 2015-06-22 21:41:38 +09:00
Cedric BAIL 356220f6d7 examples: fix changes in Evas.Canvas3D namespace. 2015-06-22 12:36:58 +02:00
Amitesh Singh 5583a93c6d elm_genlist: code refractoring of _item_process
Summary:
When item_process is success, then we want to call _item_process_post.
Old code was confusing before.

Reviewers: raster, Hermet, SanghyeonLee

Subscribers: seoz, sachin.dev

Differential Revision: https://phab.enlightenment.org/D2739

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-22 12:36:57 +02:00
Amitesh Singh bb9563c892 elm_genlist: reset timer to NULL on cancel only.
Summary: @fix

Reviewers: raster, seoz, SanghyeonLee

Subscribers: sachin.dev, seoz

Differential Revision: https://phab.enlightenment.org/D2730

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-22 12:36:57 +02:00
Umesh Tanwar 7c71953733 elm_scroller: add wheel_disable_set API
Summary:
This API can be used by widgets like Genlist/Gengrid, which implements
Elm_Interface_Scrollable interface.Mouse wheel is used to scroll up and
down on widget.

@feature

Test Plan: elementary_test -> Scroller -> Wheel Disable

Reviewers: raster, Hermet, cedric, SanghyeonLee, singh.amitesh

Subscribers: JackDanielZ, herdsman, cedric, sachin.dev

Differential Revision: https://phab.enlightenment.org/D2715

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-22 12:36:57 +02:00
Sung-Taek Hong b38c83cd73 elm_colorselector: fix horiz/vertical padding to be affected by base_scale in edc
Summary:
elm_colorselector get its padding size from data in edc.
However, when calculating the padding size, it does not consider
base_scale of the style from where it gets padding size.
In this commit, the padding size from edc is divided by its
base_scale so that desirable size can be calculated.

@fix

Reviewers: Hermet, woohyun

Subscribers: woohyun, Hermet

Differential Revision: https://phab.enlightenment.org/D2721

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-22 12:36:57 +02:00
Prince Kr Dubey cbb9985b9b elm_genlist: fix highlighted items overlap with group item during scrolling and focus when intersect.
Summary: Highlighted genlist item overlap with group item during scrolling and focus when itersect.

Test Plan:
Run elementary_test.
	   open Genlist Group.
	   select one item and try to cross the group item via scrolling.
	   Highlighted item comes over group item.

Reviewers: Hermet, raster, cedric

Reviewed By: cedric

Subscribers: rajeshps, govi, poornima.srinivasan, shilpasingh

Differential Revision: https://phab.enlightenment.org/D2640

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-22 12:36:57 +02:00
Prince Kr Dubey cc2fac3551 genlist: fix Issue "In Tree effect feature, items floates when number of item crosses item block size".
Summary: "In Tree effect feature, during expansion of tree, when total number of items crosses block count, items start floating".

Test Plan: Run elementary_test, open Genlist Tree, keep expanding items untill it crosses number of count 32 (Block count). Resize the window, floting items can be seen.

Reviewers: raster, cedric

Subscribers: shilpasingh, poornima.srinivasan, govi, rajeshps

Differential Revision: https://phab.enlightenment.org/D2627

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-22 12:36:57 +02:00
Minwoo, Lee 9818f2a7d2 elm_entry: modify to not allocate Eina_Rectangle
Summary: modify to not allocate Eina_Rectangle and use it directly on the stack with EINA_RECTANGLE_SET

Reviewers: raster, woohyun, cedric

Reviewed By: cedric

Differential Revision: https://phab.enlightenment.org/D2737

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-22 12:36:57 +02:00
Amitesh Singh a7684bfb5c genlist: fix resize of items when added after elm_genlist_clear().
Summary:
This fixes following issue.

1. Add genlist items
2. Clear genlist by elm_genlist_clear()
3. Append items.
   Genlist items are shrinked. This patch fixes that issue.

@fix
Partially resolves: T2367

Reviewers: Hermet, raster, cedric, raoulh, SanghyeonLee

Subscribers: sachin.dev, seoz

Differential Revision: https://phab.enlightenment.org/D2733
2015-06-22 19:06:21 +09:00
Carsten Haitzler e04954710d update po's 2015-06-22 16:49:13 +09:00
Daniel Zaoui 1776d9b647 DnD: fix usage of TARGETS
- TARGETS notifier is specific to CnP and should not be called for DnD
- On DnD (when drag starts) and on CnP, it doesn't make sense that the TARGETS
type are sent to the potential target. Only basic types should be sent.
2015-06-21 10:14:58 +03:00
Carsten Haitzler 98cb45e77d elm confiug - remove now useless x11 property handling - donr by files
follow on from b1c5de0b9aa67b9d5cc4722e9462830beb3af37b,
aa7f859da10ce007a7b945a8703e70161c96146d
2015-06-18 20:12:04 +09:00
Andrii Kroitor 74c86474fc colorselector: fix missing style warning
Test Plan:
1. open "elementary_test colorselector"
2. click "all" button

Reviewers: cedric, seoz, Hermet, raster

Differential Revision: https://phab.enlightenment.org/D2635

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-17 15:59:20 +02:00
SangHyeon Lee 3304346e37 gengrid: remove duplicated focus state recovering.
Summary:
gengrid focus state recovering in item_realize is duplicated.
remove unnecessary lines.

you can find same signal emit codes under line 1018.

Test Plan: test elemetary test gengrid focus highight show correctly after code merged.

Reviewers: raster, Hermet, seoz, jaehwan, cedric

Reviewed By: cedric

Subscribers: singh.amitesh, eagleeye

Differential Revision: https://phab.enlightenment.org/D2656

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-17 15:59:19 +02:00
Youngbok Shin e8b50f5788 colorselector: add safety check for NULL pointer from ecore_x_image_new().
Summary:
ecore_x_image_new() API can return NULL.
@fix

Reviewers: raster, woohyun, Hermet, cedric

Differential Revision: https://phab.enlightenment.org/D2667

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-17 15:59:19 +02:00
Shinwoo Kim 67b5d368b0 notify: fix prevent issue, dereference null return value
Summary: Fix prevent issue: Dereference null return value

Test Plan: Use static analysis tool such as prevent

Reviewers: raster, woohyun, jaehwan, Hermet

Subscribers: seoz

Differential Revision: https://phab.enlightenment.org/D2669

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-17 15:59:19 +02:00
Hosang Kim 2e123305b4 dayselector : add safety check for NULL pointer from _item_find()
Summary:
It could make crash when _item_find() is failed.
CID - 404129
CID - 402467
CID - 398714
CID - 390012

@fix

Reviewers: raster, thiepha, woohyun, Hermet

Differential Revision: https://phab.enlightenment.org/D2683

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-17 15:59:19 +02:00
Marcel Hollerbach b592c6df35 elm_icon_external: cleanup ERR msg in error case
Summary:
Setting the group without checking it exists causes a errormessage, this
is pretty annoying for people which want to set a standart icon. And
give a better errormessage if the standart setting failed.

Reviewers: raster, cedric

Reviewed By: cedric

Differential Revision: https://phab.enlightenment.org/D2686

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-17 15:59:19 +02:00
Hosang Kim 6d03b2af7e atspi_bridge: fix memory leak issue
Summary:
Call eldbus_message_unref to free Eldbus_Message structure.
And delete unused Eldbus_Message variable.
CID-386474
CID-391869
CID-394549

Reviewers: raster, woohyun, CHAN, Hermet, seoz, lukasz.stanislawski, cedric

Reviewed By: cedric

Differential Revision: https://phab.enlightenment.org/D2690

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-17 15:59:19 +02:00
Vaibhav Gupta a350f64b6e test_gengrid: remove EINA_UNUSED for a used argument
Summary: Signed-off-by: Vaibhav Gupta <g.vaibhav1@samsung.com>

Reviewers: raster, Hermet, cedric

Reviewed By: cedric

Subscribers: sachin.dev, singh.amitesh

Differential Revision: https://phab.enlightenment.org/D2670

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-17 15:59:19 +02:00
Anand dde6511cbc elm_gen_common: fix typo in Struct variable documentation
Reviewers: Hermet, cedric

Reviewed By: cedric

Differential Revision: https://phab.enlightenment.org/D2634

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-17 15:59:19 +02:00
Minwoo, Lee 1f93f2c712 edje_externals: add safety check for NULL pointer
Summary: Dereferencing null pointers in external_signal()

Reviewers: bdilly, raster, woohyun, cedric

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D2688

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-17 15:59:19 +02:00
taehyub f1778f1884 app_server: add null check for dbus_state_set/elm_app_server_views_eet_new
Reviewers: Hermet, woohyun, raster, cedric

Reviewed By: cedric

Differential Revision: https://phab.enlightenment.org/D2705

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-17 15:59:19 +02:00
Vitor Sousa c875a437bd elm_image: Solve clash on the meaning of "animated"
Summary:
Both Elm_Image and its base interface Efl.Image have a property named
"animated".
The meaning for Efl.Image is whether or not the image has animation.
On the other hand, Elm_Image use it to set whether an image, which supports
animation, is to animate itself or not.
Thus Elm_Image have another property (animated_available) to tell whether the
image have animation or not, making it even more confusing.

Renamed the "animated" property of Elm_Image to "animated_enable" to make
the intended meaning clearer.
Also replaced the "animated_available" property with the "animated" property
from the Efl.Image interface, since both refers to the same thing, in order
to reduce the API.

Added implementations of the legacy methods for backward compatibility.

Address the issue:
- Elm image and the image interface clash because of the meaning of "animated".
Specified in the page:
https://phab.enlightenment.org/w/efl_interfaces/

Reviewers: felipealmeida, tasn

Subscribers: raster

Differential Revision: https://phab.enlightenment.org/D2354
2015-06-17 10:17:19 +01:00
Jaehwan Kim 7c67f4e1ba config: fix comment 2015-06-17 17:51:40 +09:00
Jaehwan Kim 290f4fe871 config: make a config directory, if it is not.
create the config directory to register flush file to eio_monitor.
2015-06-17 17:38:24 +09:00
Carsten Haitzler 02cf05265b fix more elm config file pointer access
again - follow up from changes to config code to fix seg
2015-06-17 16:54:08 +09:00
Carsten Haitzler 4089264efb elm config files - don't write to file if file handle is null
fixes seg with new file only config for elm
2015-06-17 16:38:54 +09:00
ChunEon Park 50aceb5a89 win: fix bug about engine value.
When application does not have any value of engine,
this app should be launched with elm_config's value.

Signed-Off-By: Wonsik Jung <sidein@samsung.com>
2015-06-17 13:54:42 +09:00
Mike Blumenkrantz 21f0103397 win: do not use deferred ecore evas deletion for FAKE wins
these ees will be deleted externally anyway

@fix
2015-06-16 17:01:49 -04:00
Mike Blumenkrantz cb37de01f6 win: only trigger del trap if win type is not FAKE
@fix
2015-06-16 17:01:43 -04:00
Mike Blumenkrantz 6061ed0a75 theme: migrate all e users of darken_rounded_square to new darken_square image
nearly everything in e is square except for this, which was a holdover from the
b&w theme. the new image looks more coherent with the rest of the square look

image created by me, licensing to match rest of theme images

@feature
2015-06-16 16:31:10 -04:00
Mike Blumenkrantz 6f62c8b496 notification: set fixed on app icon to eliminate edje calc error 2015-06-16 16:31:10 -04:00
Thiep Ha dd67ff133f entry: emit changed,user signal when text is pasted or dropped
Summary:
When text is pasted or dropped into entry, the "changed,user" signal
should be emitted, not "changed" signal.
Currently, the "changed" signal is emitted.
This patch fixes this issue.

@fix

Reviewers: herdsman, tasn

Subscribers: tasn

Differential Revision: https://phab.enlightenment.org/D2710
2015-06-16 14:41:55 +01:00
Jaehwan Kim 43cfff4cd5 elm_config: remove X dependency.
Summary:
In wayland, elm_config_all_flush doesn't work.
It has X dependency totally.
It uses ecore_file_monitor instead of X property.

Reviewers: Hermet, devilhorns, raster, cedric

Differential Revision: https://phab.enlightenment.org/D2502
2015-06-16 13:52:24 +09:00
Mike Blumenkrantz 586efebad6 comp effects: add tooltip visibility effect 2015-06-15 13:55:34 -04:00
Mike Blumenkrantz 5a061d5e0f comp effects: increase size of vertical visibility effect to include shadows 2015-06-15 13:55:34 -04:00
Ji-Youn Park c933ff6f50 elm_flip: small error handle fix
if we cannot create slice, we had better stop to change slice
2015-06-15 22:38:12 +09:00
Jaehyun Cho d8a5472f5b index: Add NULL check for malloc memory allocation. 2015-06-15 15:59:49 +09:00
Jaehyun Cho 9e1968823d layout: Add NULL check for calloc memory allocation. 2015-06-15 15:39:02 +09:00
Jaehyun Cho a67e7e39ef layout: Fix to pass correct argument for edje_object_part_unswallow. 2015-06-15 15:36:09 +09:00