Commit Graph

63916 Commits

Author SHA1 Message Date
Mike Blumenkrantz 46b8945cd3 release: Update NEWS and bump version for 1.23.1 release 2019-10-11 10:57:58 -04:00
Jaehyun Cho e21cbb2a7d efl_ui_panes: fix not to consider content min size for legacy panes
Summary:
Since legacy panes did not consider its content's min size, the
content's min size calculation logic is not done for legacy panes.

Reviewers: zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10372
2019-10-11 10:16:35 -04:00
Mike Blumenkrantz de96af44dd evas/language: #ifdef guard variable which is only used inside #ifdef
Summary:
this variable is already only changed inside an #ifdef, so declare and
free it only inside the same ifdef for clarity

CIDs 1401016, 1400807

Reviewers: cedric

Reviewed By: cedric

Subscribers: bu5hm4n, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10320
2019-10-11 10:16:30 -04:00
Marcel Hollerbach bd1610d26a efl_canvas_animation_player: fix double free
Summary:
when we are returning 0 in a animation callback, the animator will be
deleted.

This fixes a crash in tab_pager.
Depends on D10306

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10307
2019-10-11 10:16:29 -04:00
Lauro Moura 243d9700e9 cv: Switch to safe 32/64 bits printf masks
This should silence 32-bit warnings about long long stuff

Reviewers: vtorri, cedric, bu5hm4n

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10214
2019-10-11 10:16:27 -04:00
Cedric BAIL 8bc12c2dff ecore_con: use only Eina_Magic infrastructure for set and check in Ecore_Con.
Summary:
We can not have half our code rely on Ecore magic check and the other half
use Eina_Magic or this will lead to inconsistency with Eina_Magic definition.
Depends on D10363

Reviewers: zmike, bu5hm4n, segfaultxavi, stefan_schmidt

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10364
2019-10-11 10:14:39 -04:00
Cedric BAIL 969a13c96d ecore_con: do not crash in test if nothing is returned by Ecore_Con_Url.
Summary: Depends on D10362

Reviewers: zmike, bu5hm4n, segfaultxavi, stefan_schmidt

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10363
2019-10-11 10:14:38 -04:00
Cedric BAIL 4505f5169c ecore_con: destructor are always called when finalize return NULL.
Summary:
This prevent crash and double free during an invalid Ecore_Con_Eet failure
to initialize.

Reviewers: zmike, bu5hm4n, segfaultxavi, stefan_schmidt

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10362
2019-10-11 10:14:37 -04:00
Lauro Moura b21fd79bdf csharp: Add missing docs to slice.
Summary:
Also removed uneeded methods.

Slice also may need some API love to be actually useful later.

ref T8292

Reviewers: segfaultxavi, felipealmeida, brunobelo, woohyun

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8292

Differential Revision: https://phab.enlightenment.org/D10327
2019-10-11 10:14:35 -04:00
Lauro Moura 6d4e71f72c csharp: Fix doc and hide stuff from strbuf.
Summary: ref T8293

Reviewers: felipealmeida, brunobelo, woohyun, segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8293

Differential Revision: https://phab.enlightenment.org/D10326
2019-10-11 10:14:09 -04:00
Lauro Moura 7d48cec9a3 csharp: Fix docs and hide stuff from stringshare.
Summary: ref T8293

Reviewers: segfaultxavi, brunobelo, felipealmeida, woohyun

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8293

Differential Revision: https://phab.enlightenment.org/D10325
2019-10-11 10:14:07 -04:00
Lauro Moura 53f8e22a65 csharp: Document eina_value.cs
Summary:
Added more docs alongside the since information.

For items that should be skipped from the end user of the binding but
must stay public for generated code,
`EditorBrowsable(EditorBrowsableState.Never)` was used.

ref T8293

Reviewers: brunobelo, felipealmeida, woohyun, segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8293

Differential Revision: https://phab.enlightenment.org/D10313
2019-10-11 10:14:05 -04:00
SangHyeon Jade Lee a68e1e6be9 elm: fix legacy callback names.
Summary:
this patch is fix of D10240.
there are few mischanges on callback names,
so fix it orginal legacy names,

SCROLL_CHANGED = "scroll"
SCROLL_ANIM_START = "scroll,anim,start"
SCROLL_ANIM_STOP = "scroll,anim,stop"
SCROLL_DRAG_START = "scroll,drag,start"
SCROLL_DRAG_STOP = "scroll,drag,stop"

Reviewers: bu5hm4n, eagleeye, akanad

Reviewed By: eagleeye

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10332
2019-10-11 10:14:02 -04:00
Bruno da Silva Belo 43ef6d457d csharp: updating eina_iterator docs and hide api.
Summary: ref T8293

Reviewers: felipealmeida, lauromoura, segfaultxavi, woohyun

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8293

Differential Revision: https://phab.enlightenment.org/D10330
2019-10-11 10:14:00 -04:00
Bruno da Silva Belo a0638130b7 csharp: updating eina_inlist docs and hide api.
Summary: ref T8293

Reviewers: lauromoura, felipealmeida, segfaultxavi, woohyun

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8293

Differential Revision: https://phab.enlightenment.org/D10329
2019-10-11 10:13:58 -04:00
Bruno da Silva Belo a0172bd5ff csharp: updating eina_inarray docs and hide api.
Reviewers: lauromoura, felipealmeida, segfaultxavi, woohyun

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8293

Differential Revision: https://phab.enlightenment.org/D10328
2019-10-11 10:13:56 -04:00
Mike Blumenkrantz dbf8241202 examples/emotion: remove dead code
this can never be reached

CID 1400928

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10322
2019-10-11 10:13:50 -04:00
Mike Blumenkrantz bdb521103b tests/position_manager: initialize variable in declaration
this member is never used anywhere, but it creates a CID

CID 1404747

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10319
2019-10-11 10:13:48 -04:00
Mike Blumenkrantz e1e7a92af8 efl_ui/selection_manager: be explicit with sizeof() usage
Summary:
ensure we don't have issues with portability and type sizes

CID 1385141

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10201
2019-10-11 10:13:46 -04:00
Bruno da Silva Belo 4af1df2ea5 csharp: updating eina_binbuf docs and hide api.
Reviewers: felipealmeida, lauromoura, segfaultxavi, woohyun

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8293

Differential Revision: https://phab.enlightenment.org/D10310
2019-10-11 10:13:00 -04:00
Bruno da Silva Belo 90249dd31f csharp: updating eina_accessor docs and hide api.
Reviewers: felipealmeida, lauromoura, segfaultxavi, woohyun

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8293

Differential Revision: https://phab.enlightenment.org/D10308
2019-10-11 10:12:57 -04:00
Bruno da Silva Belo 58196e2cac csharp: removing extra //
Summary: dotnet warning about extras /

Reviewers: lauromoura, felipealmeida

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8293

Differential Revision: https://phab.enlightenment.org/D10282
2019-10-11 10:12:48 -04:00
Lauro Moura 9c2c27cf49 csharp: Do not use the System Bus for testing.
Summary: To allow the C# bindings running on the CI

Reviewers: zmike, brunobelo, felipealmeida, segfaultxavi, stefan_schmidt

Reviewed By: stefan_schmidt

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8313

Differential Revision: https://phab.enlightenment.org/D10283
2019-10-11 10:12:41 -04:00
Lauro Moura d41f654087 csharp: Add some docs to MVVM infrastructure
Reviewers: SanghyeonLee, felipealmeida, cedric, segfaultxavi

Reviewed By: segfaultxavi

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10301
2019-10-11 10:12:20 -04:00
Mike Blumenkrantz a8fd7ca02c efl_ui/win: initialize max size hints to -1 during constructor
Summary:
this is just a cosmetic change for ease of debugging since it will already
be clamped to max size during eval if it remains unchanged

for max size hints a value of -1 means that the hint is unset but a value
of 0 is technically valid depending on the implementation
Depends on D10296

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10297
2019-10-11 10:12:10 -04:00
Mike Blumenkrantz 160d8254ca efl_ui/win: fix max size hint eval
Summary:
win objects should never permit the max size on any axis to be 0, otherwise
the window will be clamped to 1px on the given axis

fixes T8304
@fix
Depends on D10272

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8304

Differential Revision: https://phab.enlightenment.org/D10296
2019-10-11 10:12:08 -04:00
Mike Blumenkrantz 9ab57088ca ci: fix return value warning in test build code
Summary: this is a void function

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10272
2019-10-11 10:12:04 -04:00
Xavi Artigas 4e85fdb2e0 docs: Remove redundant documentation
Lots of EO files had the same information at the property and set/get level.
Removed the redundant bits, and moved to the property level the common ones.
Set and Get documentation should be used only to clarify setter-only or
getter-only behavior.
2019-10-11 10:11:57 -04:00
Cedric BAIL fab6bb8bda eldbus: properly cleanup local variable during destruction.
Summary: Depends on D10288

Reviewers: zmike, bu5hm4n, segfaultxavi, stefan_schmidt, jsuya

Reviewed By: zmike

Subscribers: ProhtMeyhet, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10289
2019-10-11 10:11:53 -04:00
Cedric BAIL af8c4235a2 eldbus: connection are destroyed on invalidate, there is no point for any object to not cleanup on invalidate.
Summary:
This solve a bug when there is a change in order of destruction and you would expect the model to still work.
Depends on D10287

Reviewers: zmike, bu5hm4n, segfaultxavi, stefan_schmidt, jsuya

Reviewed By: bu5hm4n

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10288
2019-10-11 10:11:51 -04:00
Cedric BAIL 8cd36b93d7 eldbus: Eldbus_Proxy require to handle self desctruction as refcounting doesn't fully protect.
Summary:
If the connection is destroyed before the proxy, the proxy will clear itself and self destroy.
Before that it will trigger the free callback to handle proper cleanup. Refcounting it doesn't
protect it from this self destruction scenario. So it is mandatory to always have a free callback
set on a proxy to handle its death properly.
Depends on D10286

Reviewers: zmike, bu5hm4n, segfaultxavi, stefan_schmidt, jsuya

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10287
2019-10-11 10:11:49 -04:00
Cedric BAIL cbb3f8ba0b eldbus: properly call parent finalize during creation of Eldbus.Model_Method.
Summary: @fix

Reviewers: zmike, bu5hm4n, segfaultxavi, stefan_schmidt, jsuya

Reviewed By: bu5hm4n

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10286
2019-10-11 10:11:46 -04:00
WooHyun Jung 4f97c2cb56 efl_ui_image: fix backward compatibility issue
Summary:
Previously, "anim" property was saved before checking
evas-image's "animated" stated. This patch just corrects
the issue.

Reviewers: zmike, bu5hm4n, segfaultxavi

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10293
2019-10-11 10:11:42 -04:00
Marcel Hollerbach 20d76ae6bd efl_ui_datepicker: no need to delete the manager here
Summary:
it is already picked up when datetime is invalidated, due to the correct
parent beeing set.

Reviewers: zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10291
2019-10-11 10:11:37 -04:00
Bruno da Silva Belo 5fe4fb364a c: coverity: resource leaked when using realloc.
Summary:
from https://en.cppreference.com/w/c/memory/realloc
```
On success, returns the pointer to the beginning of newly allocated memory.
To avoid a memory leak, the returned pointer must be deallocated with free()
or realloc(). The original pointer ptr is invalidated and any access to it
is undefined behavior (even if reallocation was in-place).

On failure, returns a null pointer. The original pointer ptr remains valid
and may need to be deallocated with free() or realloc(). ```
So a temporary to test if `realloc` failed
then use the original pointer to use `free`.
`CID1404749`
`CID1404741`

Reviewers: lauromoura, felipealmeida, zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10284
2019-10-11 10:11:35 -04:00
Jongmin Lee bf7ee82d38 ecore : fix incorrect size of expression for coverity
Summary: correct bad use of sizeof function (detected by coverity tool)

Test Plan: N/A

Reviewers: Hermet, woohyun, kimcinoo, cedric, jsuya

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10281
2019-10-11 10:09:32 -04:00
Bruno da Silva Belo bfacadb67d csharp: Standardizing doc tag.
Reviewers: felipealmeida, brunobelo, segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10280
2019-10-11 10:07:45 -04:00
junsu choi 92045ec49a efl_ui_animation_view : Put @beta on Efl.Ui.Animation_View_State
Summary: Efl.Ui.Animation_View class still in beta state.

Test Plan: N/A

Reviewers: Hermet, kimcinoo, smohanty

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10268
2019-10-11 10:07:42 -04:00
Xavi Artigas a1e35a95b2 evas: silence compiler warning in textblock
Uninitialized variable.
2019-10-11 10:06:50 -04:00
Bruno da Silva Belo 19f89251ea csharp: More updated docs to 1.23.
Summary: eina_config and eina_common updated to 1.23.

Reviewers: lauromoura, felipealmeida, segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8293

Differential Revision: https://phab.enlightenment.org/D10263
2019-10-11 10:06:42 -04:00
Xavi Artigas b21a1daa02 docs: Fix problems with monospaced text
Eolian recently added support for $[...] which allows highlighting
more than one word in monospaced text.
2019-10-11 10:06:38 -04:00
Felipe Magno de Almeida ab4ba5bfa5 elementary: Add documentatio to efl_ui_layout_factory.eo
Summary:
Documentation was very sparse and actually empty in some places. Add proper documentation

Related to T7717

Reviewers: woohyun, cedric, SanghyeonLee, lauromoura, brunobelo, myoungwoon, segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10267
2019-10-11 10:06:21 -04:00
Stefan Schmidt 6d5b40233a evil: make it clear in the docs that this library is private to efl
Since the 1.23 release we are stricter with the use of evil. It is
supposed to be used inside efl only and not exposed as API. Make this
clear in the docs as well.

Reviewed-by: Vincent Torri <vincent.torri@gmail.com>
Differential Revision: https://phab.enlightenment.org/D10295
2019-10-07 12:54:36 +02:00
Stefan Schmidt 95f87f4e43 evil: remove stray x character from docs section
Reviewed-by: Vincent Torri <vincent.torri@gmail.com>
Differential Revision: https://phab.enlightenment.org/D10294
2019-10-07 12:54:36 +02:00
Stefan Schmidt b57d0ae3ac evil: bring back doxygen intro page for evil library
While we switched evil to be not a public AP, but internal lib only, we
still want to have its documentation shown.

Reviewed-by: Vincent Torri <vincent.torri@gmail.com>
Differential Revision: https://phab.enlightenment.org/D10270
2019-10-07 12:54:36 +02:00
Stefan Schmidt 7f9ca6a6ba efl_ui_video: bring back Elm_video doxygen group for docs
This group got lost at some point and resulted in broken link in our
doxygen documentation.

Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D10273
2019-10-04 10:46:45 +02:00
Stefan Schmidt d4596fa531 docs: fix elementary group name in docs
Use aliase for group name for a better look.

Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D10271
2019-10-04 10:46:45 +02:00
Mike Blumenkrantz b88ec82b5c doc: improve colorselector preview
Summary:
this has always been broken, it was just never noticed because colorselector
was broken

@fix

ref T8304

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8304

Differential Revision: https://phab.enlightenment.org/D10278
2019-10-04 10:46:44 +02:00
Marcel Hollerbach 8d1e3661ec meson: pass correct PACKAGE_DATA_DIR
Summary:
PACKAGE_DATA_DIR was set to the build dir instead to the elementary
specific data dir.

ref T8304

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8304

Differential Revision: https://phab.enlightenment.org/D10275
2019-10-04 10:46:44 +02:00
Mike Blumenkrantz 8503a6e8aa efl_ui/bg: unset finger_size multiplier during construction
Summary:
this is not a clickable widget, so it shouldn't use finger size

ref T8304

@fix

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8304

Differential Revision: https://phab.enlightenment.org/D10274
2019-10-04 10:46:44 +02:00