forked from enlightenment/efl
Woochan Lee
62a09f69a1
Summary: 1. Why there is a edje signal callback in elm_calendar? and do we need to maintain? We used edje part like a button before (3 years ago?), So there is a callbacks to get edje signal. Im pretty sure it is not use anymore. but we need to maintain backward compatibility. 2. elm_calendar using using repeat feature in efl_ui_button for it. why did i change it to manual timer? We opend elm_calendar_interval_set() APIs. Support this API the manual timer is proper then using button's feature. 3. why scroll freeze? and why only elm_calendar does it? When the user long press calendar button area and then move the scroll will be activated. it can prevent that weird action. efl_ui_calendar using button's feature. i not sure scroll freeze is deserve to attached in button side as a feature or not. So i will consider more for this case. 4. Why efl_ui_calendar doesn't have year buttons (double spinner case) After interface work, we don't accept style change in the runtime. so that featrue will be supported as API. The year_button_set/get() property should be added. but i dont know is it really needed... If the app developer want use year inc/dec button for efl_ui_calendar. they can inherit the class and make it easily. Test Plan: View, Action, API test in the elementary-test sample App. Ps. The issue of the calendar2 crash when it closed. It's not relative with this commit. its focus. i will look around. Reviewers: Hermet, zmike, ManMower, segfaultxavi, devilhorns Reviewed By: Hermet Subscribers: cedric, #committers, zmike Tags: #efl Differential Revision: https://phab.enlightenment.org/D6626 |
||
|---|---|---|
| .. | ||
| benchmarks | ||
| bin | ||
| bindings | ||
| edje_external | ||
| examples | ||
| generic | ||
| lib | ||
| modules | ||
| scripts | ||
| static_libs | ||
| tests | ||
| wayland_protocol | ||
| CMakeLists.txt | ||
| CMakeLists_Eina.txt | ||
| Makefile.am | ||
| Makefile_Cxx.am | ||
| Makefile_EPhysics.am | ||
| Makefile_Ecore.am | ||
| Makefile_Ecore_Audio.am | ||
| Makefile_Ecore_Avahi.am | ||
| Makefile_Ecore_Buffer.am | ||
| Makefile_Ecore_Cocoa.am | ||
| Makefile_Ecore_Con.am | ||
| Makefile_Ecore_Drm.am | ||
| Makefile_Ecore_Drm2.am | ||
| Makefile_Ecore_Evas.am | ||
| Makefile_Ecore_FB.am | ||
| Makefile_Ecore_File.am | ||
| Makefile_Ecore_IMF.am | ||
| Makefile_Ecore_IMF_Evas.am | ||
| Makefile_Ecore_Input.am | ||
| Makefile_Ecore_Input_Evas.am | ||
| Makefile_Ecore_Ipc.am | ||
| Makefile_Ecore_Js.am | ||
| Makefile_Ecore_SDL.am | ||
| Makefile_Ecore_Wayland.am | ||
| Makefile_Ecore_Win32.am | ||
| Makefile_Ecore_Wl2.am | ||
| Makefile_Ecore_X.am | ||
| Makefile_Ector.am | ||
| Makefile_Edje.am | ||
| Makefile_Edje_Helper.am | ||
| Makefile_Eet.am | ||
| Makefile_Eet_Helper.am | ||
| Makefile_Eeze.am | ||
| Makefile_Efl.am | ||
| Makefile_Efl_Js.am | ||
| Makefile_Efl_Mono.am | ||
| Makefile_Efl_Mono_MSBuild_Gen_Helper.am | ||
| Makefile_Efreet.am | ||
| Makefile_Eina.am | ||
| Makefile_Eio.am | ||
| Makefile_Eldbus.am | ||
| Makefile_Elementary.am | ||
| Makefile_Elocation.am | ||
| Makefile_Elput.am | ||
| Makefile_Elua.am | ||
| Makefile_Elua_Helper.am | ||
| Makefile_Embryo.am | ||
| Makefile_Emile.am | ||
| Makefile_Emotion.am | ||
| Makefile_Eo.am | ||
| Makefile_Eolian.am | ||
| Makefile_Eolian_Cxx.am | ||
| Makefile_Eolian_Cxx_Helper.am | ||
| Makefile_Eolian_Files_Helper.am | ||
| Makefile_Eolian_Helper.am | ||
| Makefile_Eolian_Js.am | ||
| Makefile_Eolian_Js_Helper.am | ||
| Makefile_Eolian_Mono_Helper.am | ||
| Makefile_Escape.am | ||
| Makefile_Ethumb.am | ||
| Makefile_Ethumb_Client.am | ||
| Makefile_Evas.am | ||
| Makefile_Evil.am | ||
| Makefile_Wayland_Protocols.am | ||
| Makefile_efl_wl.am | ||