orbea
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

region_add: Fix copying wrong rect during smart merge 

Summary:
When testing partial rendering on TV, found this bug.
Probably this was caused because of wrong copy/paste.
When region1 completely subsumes region2, region2 should be ignored.
But currently region2 is copied to region1 which makes region1 rect completly wrong.
This was causing lot of visual defects because of wrong rects.
This patch will fix those visual defects when partial rendering is enabled.

Test Plan: Tested with the patch on TV after enabling partial rendering.

Reviewers: raster, cedric, Hermet, ManMower

Reviewed By: ManMower

Subscribers: bu5hm4n, ajwillia.ms, ManMower, devilhorns, cedric, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6696
This commit is contained in:
Yeshwanth Reddivari 2018-07-31 07:29:03 -05:00 committed by Derek Foreman
parent dc2ad11281
commit 52cf0a49c6
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/lib/evas/canvas/render2/region.c
View File

@ -851,10 +851,7 @@ region_add(Region *dest, Region *source)
// Region 1 completely subsumes region 2
if (!dest->data && CONTAINS(&dest->bound, &source->bound))
{
if (dest != source) return region_copy(dest, source);
return EINA_TRUE;
}
// Region 2 completely subsumes region 1
if (!source->data && CONTAINS(&source->bound, &dest->bound))