orbea
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

efl_ui_progressbar: add null check 

Summary: a segmentation fault occurs once the argument is not valid.

Test Plan: N/A

Reviewers: cedric, Jaehyun_Cho

Reviewed By: Jaehyun_Cho

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D5974
This commit is contained in:
Bowon Ryu 2018-04-20 17:49:44 +09:00 committed by Jaehyun Cho
parent 57cfa21836
commit 90135320d1
1 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/lib/elementary/efl_ui_progressbar.c
View File

@ -841,17 +841,16 @@ elm_progressbar_part_value_get(const Evas_Object *obj, const char *part)
EAPI Eina_Bool EAPI Eina_Bool
elm_progressbar_horizontal_get(const Evas_Object *obj) elm_progressbar_horizontal_get(const Evas_Object *obj)
{ {
Efl_Ui_Dir dir; EFL_UI_PROGRESSBAR_DATA_GET_OR_RETURN(obj, sd, EINA_FALSE);
dir = efl_ui_direction_get(obj);
return _is_horizontal(dir); return _is_horizontal(sd->dir);
} }
EAPI void EAPI void
elm_progressbar_inverted_set(Evas_Object *obj, Eina_Bool inverted) elm_progressbar_inverted_set(Evas_Object *obj, Eina_Bool inverted)
{ {
Efl_Ui_Dir dir; Efl_Ui_Dir dir;
EFL_UI_PROGRESSBAR_DATA_GET(obj, sd); EFL_UI_PROGRESSBAR_DATA_GET_OR_RETURN(obj, sd);
dir = _direction_get(_is_horizontal(sd->dir), inverted); dir = _direction_get(_is_horizontal(sd->dir), inverted);
@ -861,17 +860,16 @@ elm_progressbar_inverted_set(Evas_Object *obj, Eina_Bool inverted)
EAPI Eina_Bool EAPI Eina_Bool
elm_progressbar_inverted_get(const Evas_Object *obj) elm_progressbar_inverted_get(const Evas_Object *obj)
{ {
Efl_Ui_Dir dir; EFL_UI_PROGRESSBAR_DATA_GET_OR_RETURN(obj, sd, EINA_FALSE);
dir = efl_ui_direction_get(obj);
return _is_inverted(dir); return _is_inverted(sd->dir);
} }
EAPI void EAPI void
elm_progressbar_horizontal_set(Evas_Object *obj, Eina_Bool horizontal) elm_progressbar_horizontal_set(Evas_Object *obj, Eina_Bool horizontal)
{ {
Efl_Ui_Dir dir; Efl_Ui_Dir dir;
EFL_UI_PROGRESSBAR_DATA_GET(obj, sd); EFL_UI_PROGRESSBAR_DATA_GET_OR_RETURN(obj, sd);
dir = _direction_get(horizontal, _is_inverted(sd->dir)); dir = _direction_get(horizontal, _is_inverted(sd->dir));