These screenshots are used in the documentation but we never made sure that we
have them actually. This resulted in our docs missing image links.
Thanks to Jean Rene Dawin for reporting it at the Enlightenment Developer Day.
Moved the data fetching to be after the tests. This doesn't really
matter and is mostly there to silence coverity. Coverity was complaining
about "it" being dereferenced before the null check (implicit in
EO_OBJ), so reordering it will fix it.
CID 1040000
Summary:
elm_hover_dismiss() doesn't hide hover directly, but sends signal only.
It can be translated that "dismiss" do not hide hover only, but handles
some works. (EDC program, callbacks etc.)
However, "dismiss" sends signals after hide hover itself, so following
edje signals are ignored. (Hover cannot be seen already!)
This patch makes hover dismiss delayed while handling edje signal.
@fix
Test Plan: elementary_test hover2
Reviewers: Hermet, cedric
Reviewed By: cedric
Subscribers: woohyun
Differential Revision: https://phab.enlightenment.org/D3068
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Issue: If text set is NULL to naviframe, crash happens in strcmp
Soln: Check for text if NULL, before passing to strcmp
@fix
Test Plan:
//Pass the text as NULL
elm_object_part_text_set(nf, "title", NULL);
Reviewers: Hermet, cedric
Reviewed By: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D3052
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Hoversel can be used like dropdown or pulldown menu.
In that case, changing hoversel label into selected item lable can be
considered as common usage of hoversel.
This API automatizes changing label.
Reviewers: SanghyeonLee, Hermet, cedric
Reviewed By: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D2963
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Some modifications for hoversel scrollability are applied.
For example,
The logic for generating scroller is changed. (newly added during activation)
If hoversel's contents are larger than hover,they will be resized to fit hover.
If hoversel is moved (by window rotation etc.), scroller will be resized.
Reduandant code are removed from popup for scrollability.
Test Plan:
You can see the sample for scrollable hoversel in second one
of "elementary_test hoversel".
Reviewers: Hermet, SanghyeonLee, cedric
Reviewed By: cedric
Subscribers: godlytalias, Hermet
Differential Revision: https://phab.enlightenment.org/D2926
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Set proper atspi parents in cases when AT-SPI object tree structure
should be different then elementary tree (mostly in cases of elm_widget_items)
Add regression tests for those cases.
This patch moves some duplicated implementation from elm_widget
and elm_widget_item classes into atspi base mixin. It allows to
better share code and reduce maintainability.
Change-Id: I8d264661e7ffade7da72299f29075a536d71eaa3
Introduce global event emitter for accessibility events. With such emitter
there is no need to register array of callbacks on every accessibility object.
Fallback eldbus interface allows to handle dbus method call on
multiple object paths only with single callback. This greatly
reduces a ammount of memory since there is no need
to register eldbus interface for every accessible object.
Summary:
Before item packed again in mbe box. box calc own min height.
In this case, there is no need to increase line number when entry is box item.
Actually the min height of box calculated wrong here.
@fix
Test Plan:
Give a color to internal box.
Then items add.
Check the internal box area got a wrong height value.
Reviewers: Hermet, cedric
Differential Revision: https://phab.enlightenment.org/D3102
Summary:
MBE internal box get its padding size from edc.
Previously, it does not consider when calculating the padding size.
In this commit, the padding size from edc is divided by its base_scale
so that desirable size can be calculated.
@fix
Reviewers: Hermet, cedric
Differential Revision: https://phab.enlightenment.org/D3103
Summary:
There is no good entry test for changing editable mode.
This patch adds a test for changing editable in entry.
Reviewers: Hermet, tasn, herdsman
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D3112
Summary:
If item filters are appended and multibuttonentry is deleted, the
filter list is not freed causing leak
Signed-Off By: Kumar Navneet <k.navneet@samsung.com>
Signed-Off By: Shilpa Singh <shilpa.singh@samsung.com>
Test Plan:
append item filters and when multibuttonentry is deleted leak is
observed, run valgrind in this scenario.
Reviewers: Hermet, cedric, CHAN
Subscribers: navnbeet
Differential Revision: https://phab.enlightenment.org/D3118
the remote editor needs to be rewritten to use x11 client messages
and wayland shell extensions at some point. need to make this stable
now to use in e20 release
After a52a53802aebf03d297aa857f0cb6a9779949a49 callback was called after every
spinner value change even if it was made from code.
This commit fixes unfocus issues without breaking callbacks logic
@fix
Reviewers: CHAN, ajwillia.ms
Subscribers: CHAN, ajwillia.ms
Differential Revision: https://phab.enlightenment.org/D3107
Signed-off-by: Andy Williams
Summary:
I need to think more about item omitted case, horizontal case as well.
Now i'm working on this. It may need to refactoring internal logic.
Please revert this commit it break view when index item omitted.
@fix
This reverts commit 560338c5c31bda8912938074cb736eabdb9f1f31.
Reviewers: Hermet, cedric, woohyun
Differential Revision: https://phab.enlightenment.org/D3062
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Flipselector lose last character when 50 characters showing case.
This defined value will using in snprintf, fetch_str(_edje_embryo_fn_fetch_str).
As you already know, we have to give the location in array for '\n'.
Test Plan: Give the 50 characters for flipselector text.
Reviewers: Hermet, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3064
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
elm_multibuttonentry_clear API not worked well.
It deleted only odd items. Because of the sd->items has been modified inside elm_widget_item_del().
Then we don't have to search target item inside of _item_del().
@fix
Test Plan:
Add MBE items.
Call elm_multibuttonentry_clear API.
Check the bug state.
Reviewers: Hermet, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3065
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
When calendar widget is already created and if we change language,
weekdays do not get translated because weekday string is statically
stored only during create.
Update the weekdays again when object is changed.
Test Plan:
1. Create and show calendar widget
2. Change the language
Weekdays do not get translated
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D3035
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
The focus go to scroller only when it needs.
If the focusable object isn't in the current viewport of the scroller,
the scroller should have the focus.
If not, the focus move to the focusable object in the scroller.
@feature.
When the focus is moved, it uses focus_direction instead of
focus_origin.
It can get the focus by using the geometry of previous focused object or item
@feature
Summary:
If there is a special value for current spinner value, just jump to apply and show up the special value for entry text.
There is no need to check format.
@fix
Test Plan:
Add special value for each spinner value.
Spinner editable set as true.
Click the button layout for activated spinner entry.
Check the entry text.
Reviewers: cedric, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2976
Summary:
When user call elm_calendar_first_day_of_week_set() to change first day of week.
the marked day has to update.
But, it's not updated, because of internal logic error.
I fixed internal logic for update specific day mark.
@fix
Test Plan:
Called elm_calendar_mark_add()
Then called elm_calendar_first_day_of_week_set(
Check the mark in not updated.
Reviewers: Hermet, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3100
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
If there is a spinner on scroller.
User can scrolling and spinner button longpress at the same time.
Prevent this weird action, delete longpress timer when scroller enabled.
@feature
Reviewers: Hermet, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3101
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Add Filtering support in genlist based on filter function set by application.
@feature
Test Plan: Genlist filter sample added in elementary_test
Reviewers: raster, shilpasingh, cedric, SanghyeonLee
Subscribers: SanghyeonLee, divyesh, rajeshps, govi, prince.dubey, poornima.srinivasan
Differential Revision: https://phab.enlightenment.org/D2514
Summary:
Set the display mode to none only when both clipboard and keypad is
hidden.
Signed-Off By: Shashank Pandey <shashank.p@samsung.com>
Signed-Off By: Shilpa Singh <shilpa.singh@samsung.com>
@fix
Test Plan: Keypad opened, Clipboard opened, close clipboard
Reviewers: woohyun, CHAN, Hermet
Reviewed By: Hermet
Subscribers: CHAN, Jaehyun, shashank0990
Differential Revision: https://phab.enlightenment.org/D2968
this fix is a fix due to the fix in
933dfca5bcda4943ecdd81ab09dc34989234f7f3 whihc fixed other issues. now
focus is properly set where it should be. this affected rage
@fix
Summary:
In Types Dnd test, if we drag from label to entry, the text is inserted
with "<br/>". The reason is that we drag with type ELM_SEL_FORMAT_TEXT
but the transferred data is markup.
This patch fixes it by changing the transferred data to text.
@fix
Reviewers: JackDanielZ
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D3072
Summary:
The x, y coordinates in pos callback should be relative to
the top-left of the object.
This patch corrects the x,y coordinates and adds poscb to elementary test
to clearly show the bug case.
Test:
Run Genlist Dnd Dflt Anim with the change in this patch.
Drag an item to other genlist and see the printed out item, x, y.
@fix
Reviewers: JackDanielZ
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D3063
Summary:
There was override for elm_object_item_part_text_get() only.
This patch implements elm_object_item_part_text_set().
Reviewers: Hermet, cedric
Subscribers: Hermet
Differential Revision: https://phab.enlightenment.org/D3054
multibuttonentry is editable
Summary:
Input panel should be controlled only if Multibuttonentry is editable, else causes issues in applications controlling keypad by themselves
@fix
Reviewers: CHAN, Hermet
Reviewed By: Hermet
Subscribers: navnbeet
Differential Revision: https://phab.enlightenment.org/D3050
Summary: slider is not focused after slider is dragged.
Test Plan: elementary_test -> slider
Reviewers: woohyun, seoz, smohanty, cedric, raster
Differential Revision: https://phab.enlightenment.org/D3057
Add elm_object_focus_next_item_set/get,
elm_object_item_focus_next_object_set/get and
elm_object_item_focus_next_item_set/get.
If the item and object is set at the same time,
the item is preference to object when the focus moves.
This feature is implemented about gengrid.
It will be implemented about ohter widgets.
@feature
Summary:
If file path is wrong, don't need to call the image preload api.
And the result of evas_object_image_load_error_get api is not correct
after calling the image_preload api.
I will check more about it.
Reviewers: cedric, Hermet, jpeg
Reviewed By: jpeg
Differential Revision: https://phab.enlightenment.org/D3039
Summary:
MBE item append logic changed when mirrored set as true.
The item appended from left side of internal box to right side, even mirrored set as true.
@fix
Test Plan:
Precondition : elm_widget_mirrored_set as true.
Run mbe sample in elementary_test.
Add item.
Reviewers: cedric, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2975
this fixes a bug with horizontal style toolbar items and toolbar code
itself simply emitting the wrong signals that causes 0 height items.
this fixes T2710
@fix
smooth out scrolling and simplifyconfig as well as expose config apis
to configure it all and elm config ui sliders and checkboxes for
related config values etc. etc. - with this it is much smoother if you
use the default values, though latency is a bit worse. it looks nicer
though.
@feature
there is an annoyance in elm that when focus goes back toa window it
restores focus to the last focused widget. if that widget happens to
be invisible in a scroller then this is really annoying as the
scrollers reset. this makes restoring optional. only if there is a
hilight object AND it's visible - then restore, otherwise don't and
revert focus to the window itself again.
@fix
i found that the focus doesnt auto-show when focusing things inside
scrollers and so on. i had to add more points to trigger auto show.
this fixes that
@fix
Summary:
When the calendar view updated(Press next button to activated next month),
a lot of signals process(signal emitted) to calendar edc.
The signals which related with view update, should process in same loop.
If not, the view looks weird.
To ensure signals process same time, i called "edje_object_message_signal_process" after layout sizing eval called.
@fix
Reviewers: Hermet, cedric, woohyun
Subscribers: id213sin
Differential Revision: https://phab.enlightenment.org/D3019
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
There are two issues about preload
1. elm_image_preload_disabled_set api does not work.
Always returned before call the evas_object_image_preload()
2. image preload does not work at file_set time.
If image's show property is not TRUE, do not call evas_object_image_preload() at file_set time.
But there is no action when image's show property will be TRUE after call the file_set api.
@fix
Reviewers: Hermet, jpeg
Differential Revision: https://phab.enlightenment.org/D2989
Signed-off-by: Jean-Philippe Andre <jp.andre@samsung.com>
Fix behaviour for changed, activated, press events.
Forwarders must be set on entry's original events,
so they will call corresponding fileselector entry's callbacks.
@fix
if sd->obj is null then the a zoom timeout has a null data param and
that means we cant get sd data... so dont set up a zoom timeout unless
sd->obj is valid.
@fix
so elm map loads every module it can find in a recursive dir walk of
all elm modules. this si nuts. this can accidentallly load OLD modules
and thats a recipe for disaster. so check module arch dir aagainst
module arch string to load the right version and be quiet if module
doesn thave the right symbols - it's the wrong module type.
@fix
Summary:
When loop is set, the arrows on horizontal/vertical bar
should not be disabled. These arrows show the scrollable direction,
if enabled. Disabled arrows show no more scroll in that direction.
Signed-off-by: Umesh Tanwar <umesh.tanwar@samsung.com>
Merge branch 'master' of http://git.enlightenment.org/core/elementary
Test Plan: elementary_test -> scroller -> loop in x axis.
Reviewers: raster, Hermet, singh.amitesh
Subscribers: sachin.dev, SanghyeonLee, eagleeye
Differential Revision: https://phab.enlightenment.org/D2953
Summary:
fix sub-item position after prepending if parent item has no other
sub-items
Test Plan:
1. add genlist
2. add parent item
3. compare results of following actions:
case 1: append sub-item "child1" and then prepend sub-item "child2"
case 2: prepend sub-item "child2" and then append sub-item "child1"
ExR results are the same
CuR in case 2 sub-items are placed in wrong position
Reviewers: cedric, raster, reutskiy.v.v, SanghyeonLee, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2965
Summary:
Updated genlist to select first item which is not in
DISPLAY_ONLY mode
@fix
Signed-off-by: Vaibhav Gupta <g.vaibhav1@samsung.com>
Test Plan:
Following is the test to verify:
1. Create a genlist
2. Make 1st item as ELM_OBJECT_SELECT_MODE_DISPLAY_ONLY
3. Now bring the focus to genlist by key down
4. It should bring focus on 2nd item and not 1st.
Reviewers: raster, Hermet, SanghyeonLee, singh.amitesh
Subscribers: sachin.dev
Differential Revision: https://phab.enlightenment.org/D2957
Summary:
When text is set on a multibuttonentry item, item does not resize
again based on text.
Signed-off By: Kumar Navneet <k.navneet@samsung.com>
@fix
Test Plan: Set long text to multibuttonentry item, after item is created and shown.
Reviewers: woohyun, CHAN, Hermet
Reviewed By: CHAN, Hermet
Subscribers: navnbeet
Differential Revision: https://phab.enlightenment.org/D2967
Summary:
MBE clicked callback doesn't called when user click label, padding area of MBE.
Because of the MBE edc only has the SWALLOW part for internal box. never emit the signal for clicked.
So i added RECT part for bg of mbe.
@fix
Test Plan: Run elementary_test -> execute multibuttonentry sample.
Reviewers: seoz, woohyun, cedric, Hermet
Reviewed By: Hermet
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D2821
Summary:
When push is in progress, block popping until
push is complete to allow animation to complete.
@fix
Reviewers: Hermet
Subscribers: subodh6129, shashank0990
Differential Revision: https://phab.enlightenment.org/D2966
Summary:
This reverts commit bba4c217f2ce4f032fca6298cc8b2fc6ff3d7c19.
"x and y position variable assumes values ranging from min to max " is right.
but in looping behavior, x and y are able to have value bigger than max or smaller than min.
@fix
Test Plan:
1. elementary_test -> scroller
2. on Loop in X axis
3. scrolling page to left.
4. page is moved last page directly.
Reviewers: SanghyeonLee, tanwar.umesh07, raster, cedric, jaehwan, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2977
Summary:
Size or offset spacer make hover be able to move its swallows to right positions.
In elm_layout_sizing_eval() for hover, moving and resizing spacers are done
after moving and resizing hover.
It causes in hover's move or resize callback, geometry can not be got correctly.
Reviewers: SanghyeonLee, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2999
Summary:
Item layout will be added in elm focus tree.
evas_object_focus_set is no meaning here for MBE operation.
So i changed focus API from "evas_object_focus_set()" to "elm_object_focus_set()"
elm_object_focus_allow_set() already called in item adding function.
@fix
Reviewers: Hermet, cedric
Differential Revision: https://phab.enlightenment.org/D2993
Summary:
The focus movement is wrong when down key press
is done of first item of last row, intsead of
taking the focus out, it moves the focus to next
item (right).
@fix
Signed-off-by: Vaibhav Gupta <g.vaibhav1@samsung.com>
Test Plan:
1. Launch elementary_test -> Gengrid 2 sample
2. Add a few items such that there are 2 items in last row
3. Do a down key press on 1st item of last row
4. Observe focus movement
Reviewers: raster, Hermet, SanghyeonLee, singh.amitesh
Subscribers: sachin.dev
Differential Revision: https://phab.enlightenment.org/D3001
Item expandend state need to be resetted (contracted) when the
item goes in the items cache, otherwise when the item will be reused
it will have unwanted state (expanded).
Quite visible in the "Genlist Tree and Decorate All Mode" test
@fix
This fixes a behavioural change introduced in D1135.
Steps to reproduce:
1. elementary_test -> genlist/list/gengrid
2. scroll dragging the scroll-bar
3. an item nearest to viewport gets selected when you release the mouse button
Most of the time, we don't want item to be selected or focused on dragging
scroll-bar via mouse. Revert config flag to 0 to have old behaviour before D1135.
fixes: T2662
@fix
resize object was not getting focused in case of mouse click.
Steps to reproduce:
1. elementary_test -to "toolbar focus".
2. set focus to toolbar item via mouse.
3. focus does not come to toolbar.
fixes T2697
@fix
There is no need to loop when reorder mode is enabled. This looks
ugly and nobody wants it. This fault was introduced in 7aaa5c8d0a4a5714b4f1bf79e
This patch also fixes following crash
1. elementary_test -to "Gengrid 2".
2. Enable all the options available.
3. Do reorder of item via keys.
4. Observe segv on reordering edge items.
@fix
Steps to reproduce:
1. elementary -> gengrid focus
2. change mode to horizontal
3. set focus to one of item in 2nd column.
4. Press Left direction key
issue: focus moves out of gengrid.
@fix
Summary:
since the variable 'preferred_rot' is checked its validation in _elm_win_xwin_update(),
so, should be initialize it before invoking.
@fix
Reviewers: jypark, woohyun, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2987
Summary:
Added the following examples:
* bg_cxx_example_01
* bg_cxx_example_02
* bubble_cxx_example_01
* button_cxx_example_00
* button_cxx_example_01
* calendar_cxx_example_01
* calendar_cxx_example_02
* calendar_cxx_example_03
* calendar_cxx_example_04
* calendar_cxx_example_05
* clock_cxx_example
* datetime_cxx_example
* glview_cxx_example_01
* hoversel_cxx_example_01
* icon_cxx_example_01
* location_cxx_example_01
* menu_cxx_example_01
* popup_cxx_example_01
* radio_cxx_example_01
* separator_cxx_example_01
* slider_cxx_example
* spinner_cxx_example
* table_cxx_example_01
* table_cxx_example_02
* thumb_cxx_example_01
Added documentation for the above examples, as well as how using lambdas
with C++ elm binding. How to use autohide feature and how to use the C++
wrappers to create windows, widgets and call Eo functions from them with
automatic C++ type conversion and how to use signals from C++.
':' is usually regarded as the delimetr for new theme path
but it uses to look up the drive, ie, c: on windows, on the other hand.
this patch fixes to determine wheter ':' is used for drive name or delimeter.
@fix
Summary:
if app sets available rotations before invoking elm_win_alpha_set(),
wm rotation doesn't work.
this patch fixes it.
Test Plan: N/A
Reviewers: jypark
Reviewed By: jypark
Differential Revision: https://phab.enlightenment.org/D2946
Summary:
Since the _count variable is static, the buttons which are added
to scroller, get text value ahead of previously added count, instead
of starting from 1 every time a new window is opened for the example.
Signed-off-by: Vaibhav Gupta <g.vaibhav1@samsung.com>
Test Plan:
Following is the test:
1. Open Scroller 3 sample
2. Add some items and note the "Item count value of added buttons
3. Close the sample
4. Re-open Scroller 3 sample, and again add some items
5. Observe the "Item count" text of added buttons.
Reviewers: raster, Hermet, singh.amitesh
Subscribers: sachin.dev
Differential Revision: https://phab.enlightenment.org/D2959
Summary:
The original code did not consider the case where the text will be
reapplied by chunks. The repositioning of the cursor should be postponed
to when the idler work is done, or not required at all.
Fixes T2646.
@fix
Reviewers: NikaWhite
Reviewed By: NikaWhite
Maniphest Tasks: T2646
Differential Revision: https://phab.enlightenment.org/D2952
Stefan Schmidt
Tom Hacohen
Cedric BAIL
Jee-Yong Um
Shilpa Singh
Vivek Ellur
Lukasz Stanislawski
Amitesh Singh
Lukasz Stanislawski
Mike Blumenkrantz
woochan lee
ChunEon Park
Thiep Ha
Andrii Kroitor
Jaehwan Kim
Daniel Kolesa
Shashank Pandey
Hosang Kim
Prince Kumar Dubey
Carsten Haitzler
Andy Williams
Daniel Zaoui
Thiep Ha
Daniel Juyung Seo
jiin.moon
Boris Faure
Davide Andreoli
Yakov Goldberg
Daniel Zaoui
WooHyun Jung
Umesh Tanwar
Vaibhav Gupta
Vincent Torri
Seunghun Lee
Luciana Magno de Almeida
Felipe Magno de Almeida
Daniel Hirt