Summary:
Add Filtering support in genlist based on filter function set by application.
@feature
Test Plan: Genlist filter sample added in elementary_test
Reviewers: raster, shilpasingh, cedric, SanghyeonLee
Subscribers: SanghyeonLee, divyesh, rajeshps, govi, prince.dubey, poornima.srinivasan
Differential Revision: https://phab.enlightenment.org/D2514
Summary:
Set the display mode to none only when both clipboard and keypad is
hidden.
Signed-Off By: Shashank Pandey <shashank.p@samsung.com>
Signed-Off By: Shilpa Singh <shilpa.singh@samsung.com>
@fix
Test Plan: Keypad opened, Clipboard opened, close clipboard
Reviewers: woohyun, CHAN, Hermet
Reviewed By: Hermet
Subscribers: CHAN, Jaehyun, shashank0990
Differential Revision: https://phab.enlightenment.org/D2968
this fix is a fix due to the fix in
933dfca5bcda4943ecdd81ab09dc34989234f7f3 whihc fixed other issues. now
focus is properly set where it should be. this affected rage
@fix
Summary:
In Types Dnd test, if we drag from label to entry, the text is inserted
with "<br/>". The reason is that we drag with type ELM_SEL_FORMAT_TEXT
but the transferred data is markup.
This patch fixes it by changing the transferred data to text.
@fix
Reviewers: JackDanielZ
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D3072
Summary:
The x, y coordinates in pos callback should be relative to
the top-left of the object.
This patch corrects the x,y coordinates and adds poscb to elementary test
to clearly show the bug case.
Test:
Run Genlist Dnd Dflt Anim with the change in this patch.
Drag an item to other genlist and see the printed out item, x, y.
@fix
Reviewers: JackDanielZ
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D3063
Summary:
There was override for elm_object_item_part_text_get() only.
This patch implements elm_object_item_part_text_set().
Reviewers: Hermet, cedric
Subscribers: Hermet
Differential Revision: https://phab.enlightenment.org/D3054
multibuttonentry is editable
Summary:
Input panel should be controlled only if Multibuttonentry is editable, else causes issues in applications controlling keypad by themselves
@fix
Reviewers: CHAN, Hermet
Reviewed By: Hermet
Subscribers: navnbeet
Differential Revision: https://phab.enlightenment.org/D3050
Summary: slider is not focused after slider is dragged.
Test Plan: elementary_test -> slider
Reviewers: woohyun, seoz, smohanty, cedric, raster
Differential Revision: https://phab.enlightenment.org/D3057
Add elm_object_focus_next_item_set/get,
elm_object_item_focus_next_object_set/get and
elm_object_item_focus_next_item_set/get.
If the item and object is set at the same time,
the item is preference to object when the focus moves.
This feature is implemented about gengrid.
It will be implemented about ohter widgets.
@feature
Summary:
If file path is wrong, don't need to call the image preload api.
And the result of evas_object_image_load_error_get api is not correct
after calling the image_preload api.
I will check more about it.
Reviewers: cedric, Hermet, jpeg
Reviewed By: jpeg
Differential Revision: https://phab.enlightenment.org/D3039
Summary:
MBE item append logic changed when mirrored set as true.
The item appended from left side of internal box to right side, even mirrored set as true.
@fix
Test Plan:
Precondition : elm_widget_mirrored_set as true.
Run mbe sample in elementary_test.
Add item.
Reviewers: cedric, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2975
this fixes a bug with horizontal style toolbar items and toolbar code
itself simply emitting the wrong signals that causes 0 height items.
this fixes T2710
@fix
smooth out scrolling and simplifyconfig as well as expose config apis
to configure it all and elm config ui sliders and checkboxes for
related config values etc. etc. - with this it is much smoother if you
use the default values, though latency is a bit worse. it looks nicer
though.
@feature
there is an annoyance in elm that when focus goes back toa window it
restores focus to the last focused widget. if that widget happens to
be invisible in a scroller then this is really annoying as the
scrollers reset. this makes restoring optional. only if there is a
hilight object AND it's visible - then restore, otherwise don't and
revert focus to the window itself again.
@fix
i found that the focus doesnt auto-show when focusing things inside
scrollers and so on. i had to add more points to trigger auto show.
this fixes that
@fix
Summary:
When the calendar view updated(Press next button to activated next month),
a lot of signals process(signal emitted) to calendar edc.
The signals which related with view update, should process in same loop.
If not, the view looks weird.
To ensure signals process same time, i called "edje_object_message_signal_process" after layout sizing eval called.
@fix
Reviewers: Hermet, cedric, woohyun
Subscribers: id213sin
Differential Revision: https://phab.enlightenment.org/D3019
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
There are two issues about preload
1. elm_image_preload_disabled_set api does not work.
Always returned before call the evas_object_image_preload()
2. image preload does not work at file_set time.
If image's show property is not TRUE, do not call evas_object_image_preload() at file_set time.
But there is no action when image's show property will be TRUE after call the file_set api.
@fix
Reviewers: Hermet, jpeg
Differential Revision: https://phab.enlightenment.org/D2989
Signed-off-by: Jean-Philippe Andre <jp.andre@samsung.com>
Fix behaviour for changed, activated, press events.
Forwarders must be set on entry's original events,
so they will call corresponding fileselector entry's callbacks.
@fix
if sd->obj is null then the a zoom timeout has a null data param and
that means we cant get sd data... so dont set up a zoom timeout unless
sd->obj is valid.
@fix
so elm map loads every module it can find in a recursive dir walk of
all elm modules. this si nuts. this can accidentallly load OLD modules
and thats a recipe for disaster. so check module arch dir aagainst
module arch string to load the right version and be quiet if module
doesn thave the right symbols - it's the wrong module type.
@fix
Summary:
When loop is set, the arrows on horizontal/vertical bar
should not be disabled. These arrows show the scrollable direction,
if enabled. Disabled arrows show no more scroll in that direction.
Signed-off-by: Umesh Tanwar <umesh.tanwar@samsung.com>
Merge branch 'master' of http://git.enlightenment.org/core/elementary
Test Plan: elementary_test -> scroller -> loop in x axis.
Reviewers: raster, Hermet, singh.amitesh
Subscribers: sachin.dev, SanghyeonLee, eagleeye
Differential Revision: https://phab.enlightenment.org/D2953
Summary:
fix sub-item position after prepending if parent item has no other
sub-items
Test Plan:
1. add genlist
2. add parent item
3. compare results of following actions:
case 1: append sub-item "child1" and then prepend sub-item "child2"
case 2: prepend sub-item "child2" and then append sub-item "child1"
ExR results are the same
CuR in case 2 sub-items are placed in wrong position
Reviewers: cedric, raster, reutskiy.v.v, SanghyeonLee, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2965
Summary:
Updated genlist to select first item which is not in
DISPLAY_ONLY mode
@fix
Signed-off-by: Vaibhav Gupta <g.vaibhav1@samsung.com>
Test Plan:
Following is the test to verify:
1. Create a genlist
2. Make 1st item as ELM_OBJECT_SELECT_MODE_DISPLAY_ONLY
3. Now bring the focus to genlist by key down
4. It should bring focus on 2nd item and not 1st.
Reviewers: raster, Hermet, SanghyeonLee, singh.amitesh
Subscribers: sachin.dev
Differential Revision: https://phab.enlightenment.org/D2957
Summary:
When text is set on a multibuttonentry item, item does not resize
again based on text.
Signed-off By: Kumar Navneet <k.navneet@samsung.com>
@fix
Test Plan: Set long text to multibuttonentry item, after item is created and shown.
Reviewers: woohyun, CHAN, Hermet
Reviewed By: CHAN, Hermet
Subscribers: navnbeet
Differential Revision: https://phab.enlightenment.org/D2967
Summary:
MBE clicked callback doesn't called when user click label, padding area of MBE.
Because of the MBE edc only has the SWALLOW part for internal box. never emit the signal for clicked.
So i added RECT part for bg of mbe.
@fix
Test Plan: Run elementary_test -> execute multibuttonentry sample.
Reviewers: seoz, woohyun, cedric, Hermet
Reviewed By: Hermet
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D2821
Summary:
When push is in progress, block popping until
push is complete to allow animation to complete.
@fix
Reviewers: Hermet
Subscribers: subodh6129, shashank0990
Differential Revision: https://phab.enlightenment.org/D2966
Summary:
This reverts commit bba4c217f2ce4f032fca6298cc8b2fc6ff3d7c19.
"x and y position variable assumes values ranging from min to max " is right.
but in looping behavior, x and y are able to have value bigger than max or smaller than min.
@fix
Test Plan:
1. elementary_test -> scroller
2. on Loop in X axis
3. scrolling page to left.
4. page is moved last page directly.
Reviewers: SanghyeonLee, tanwar.umesh07, raster, cedric, jaehwan, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2977
Summary:
Size or offset spacer make hover be able to move its swallows to right positions.
In elm_layout_sizing_eval() for hover, moving and resizing spacers are done
after moving and resizing hover.
It causes in hover's move or resize callback, geometry can not be got correctly.
Reviewers: SanghyeonLee, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2999
Summary:
Item layout will be added in elm focus tree.
evas_object_focus_set is no meaning here for MBE operation.
So i changed focus API from "evas_object_focus_set()" to "elm_object_focus_set()"
elm_object_focus_allow_set() already called in item adding function.
@fix
Reviewers: Hermet, cedric
Differential Revision: https://phab.enlightenment.org/D2993
Summary:
The focus movement is wrong when down key press
is done of first item of last row, intsead of
taking the focus out, it moves the focus to next
item (right).
@fix
Signed-off-by: Vaibhav Gupta <g.vaibhav1@samsung.com>
Test Plan:
1. Launch elementary_test -> Gengrid 2 sample
2. Add a few items such that there are 2 items in last row
3. Do a down key press on 1st item of last row
4. Observe focus movement
Reviewers: raster, Hermet, SanghyeonLee, singh.amitesh
Subscribers: sachin.dev
Differential Revision: https://phab.enlightenment.org/D3001
Item expandend state need to be resetted (contracted) when the
item goes in the items cache, otherwise when the item will be reused
it will have unwanted state (expanded).
Quite visible in the "Genlist Tree and Decorate All Mode" test
@fix
This fixes a behavioural change introduced in D1135.
Steps to reproduce:
1. elementary_test -> genlist/list/gengrid
2. scroll dragging the scroll-bar
3. an item nearest to viewport gets selected when you release the mouse button
Most of the time, we don't want item to be selected or focused on dragging
scroll-bar via mouse. Revert config flag to 0 to have old behaviour before D1135.
fixes: T2662
@fix
resize object was not getting focused in case of mouse click.
Steps to reproduce:
1. elementary_test -to "toolbar focus".
2. set focus to toolbar item via mouse.
3. focus does not come to toolbar.
fixes T2697
@fix
There is no need to loop when reorder mode is enabled. This looks
ugly and nobody wants it. This fault was introduced in 7aaa5c8d0a4a5714b4f1bf79e
This patch also fixes following crash
1. elementary_test -to "Gengrid 2".
2. Enable all the options available.
3. Do reorder of item via keys.
4. Observe segv on reordering edge items.
@fix
Steps to reproduce:
1. elementary -> gengrid focus
2. change mode to horizontal
3. set focus to one of item in 2nd column.
4. Press Left direction key
issue: focus moves out of gengrid.
@fix
Summary:
since the variable 'preferred_rot' is checked its validation in _elm_win_xwin_update(),
so, should be initialize it before invoking.
@fix
Reviewers: jypark, woohyun, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2987
Summary:
Added the following examples:
* bg_cxx_example_01
* bg_cxx_example_02
* bubble_cxx_example_01
* button_cxx_example_00
* button_cxx_example_01
* calendar_cxx_example_01
* calendar_cxx_example_02
* calendar_cxx_example_03
* calendar_cxx_example_04
* calendar_cxx_example_05
* clock_cxx_example
* datetime_cxx_example
* glview_cxx_example_01
* hoversel_cxx_example_01
* icon_cxx_example_01
* location_cxx_example_01
* menu_cxx_example_01
* popup_cxx_example_01
* radio_cxx_example_01
* separator_cxx_example_01
* slider_cxx_example
* spinner_cxx_example
* table_cxx_example_01
* table_cxx_example_02
* thumb_cxx_example_01
Added documentation for the above examples, as well as how using lambdas
with C++ elm binding. How to use autohide feature and how to use the C++
wrappers to create windows, widgets and call Eo functions from them with
automatic C++ type conversion and how to use signals from C++.
':' is usually regarded as the delimetr for new theme path
but it uses to look up the drive, ie, c: on windows, on the other hand.
this patch fixes to determine wheter ':' is used for drive name or delimeter.
@fix
Summary:
if app sets available rotations before invoking elm_win_alpha_set(),
wm rotation doesn't work.
this patch fixes it.
Test Plan: N/A
Reviewers: jypark
Reviewed By: jypark
Differential Revision: https://phab.enlightenment.org/D2946
Summary:
Since the _count variable is static, the buttons which are added
to scroller, get text value ahead of previously added count, instead
of starting from 1 every time a new window is opened for the example.
Signed-off-by: Vaibhav Gupta <g.vaibhav1@samsung.com>
Test Plan:
Following is the test:
1. Open Scroller 3 sample
2. Add some items and note the "Item count value of added buttons
3. Close the sample
4. Re-open Scroller 3 sample, and again add some items
5. Observe the "Item count" text of added buttons.
Reviewers: raster, Hermet, singh.amitesh
Subscribers: sachin.dev
Differential Revision: https://phab.enlightenment.org/D2959
Summary:
The original code did not consider the case where the text will be
reapplied by chunks. The repositioning of the cursor should be postponed
to when the idler work is done, or not required at all.
Fixes T2646.
@fix
Reviewers: NikaWhite
Reviewed By: NikaWhite
Maniphest Tasks: T2646
Differential Revision: https://phab.enlightenment.org/D2952
This is an example of classic code copy and paste mistake.
Probably inspired from similar code in genlist/gengrid.
We were actually deleting the other items (except selected one) in
viewport in _elm_list_nearest_visible_item_get() which results into crash
while deleting the list object.
@fix
Resolves: T2662
Summary:
After item looping, Gengrid item was getting selected.
So, checked for item_select_on_focus_disable flag and
accordingly set focus state or selected state of Gengrid item.
@fix
Signed-off-by: Yeshwanth Reddivari <r.yeshwanth@samsung.com>
Reviewers: raster, Hermet, singh.amitesh, SanghyeonLee
Subscribers: sachin.dev
Differential Revision: https://phab.enlightenment.org/D2937
performing strlen() on potential non-string data is not recommended and can
even lead to crashes. nul terminating non-string data is pointless and enables
bad application behavior such as calling strlen() on potentially non-string data
@fix
previously the drop format was chosen in a manner unrelated to what
the offered format was, leading to applications receiving either the correct
data with the wrong format, the wrong data with the wrong format, or
the wrong data with the correct format. by comparing the drop handler
types with the offered type and ensuring that there is a match, the
correctness of the format that the application receives is more reliable
@fix
conformant would ignore min size of content (and propagate min size
to paent widget - eg window). this was just wrong. remove fixed here
(also align is useless as that is a default).
@fix
In the widget code, focus origin is added. It can know
the focus movement is originated by which action.
The widgets can choose the item focus moves to last focused item
or geometrically nearby item by focus origin.
In gengrid, focus moves to last focused item if focus origin is
ELM_FOCUS_REVERT. It moves to nearby item if focus origin is from
ELM_FOCUS_UP to ELM_FOCUS_LEFT.
TODO: widgets have items should add the direction feature if it
want the focus to move to nearby item.
@feature
Summary: The Elm Copy and Paste test was not actually pasting the
copied text into the entry when the Paste button was clicked. This
patch fixes that issue.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
When the focus is move to the object in scroller, it is scrolled
to show the focus region as a widget.
If the focus region want to be shown as an item,
set the mode ELM_FOCUS_REGION_SHOW_ITEM.
If then, it will be scrolled as an item.
TODO: Widgets have items are added on_focus_region function.
@feature
This commit is related to 4d553d2bcf2157053433994ca3facb56bd670da9.
It doesn't work if item_select_on_focus_disable is 1.
So _item_focus_down is changed like _item_single_select_down.
@fix
Summary:
do not return yet in case of edge items if looping
is disabled. try to select/focus last item.
Signed-off-by: Jyotiprakash Sahoo <jp.sahoo@samsung.com>
@fix
Test Plan: elementary_test -> Gengrid 2
Reviewers: raster, singh.amitesh, cedric, SanghyeonLee
Reviewed By: SanghyeonLee
Differential Revision: https://phab.enlightenment.org/D2865
These files come from some modules in src/modules while we set out base dir to
src/lib. In result these files are search for in src/lib and not found. In the
long term we want to find out how to collect them as well but for now a working
coverage is already good.
Overall coverage rate:
lines......: 18.1% (12596 of 69412 lines)
functions..: 18.6% (1766 of 9500 functions)
Will work on getting these run by jenkins once it is back.
Summary:
When user set min max as 50, 150 with %d format, then value set as 100.
The spinner value set as '0'
Because the sd->val type is double.
Spinner entry has same problem.
@fix
Test Plan:
Set spinner format as %d.
Check the spinner value.
It's not supported.
Reviewers: Jaehyun_Cho, cedric, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2898
Conflicts:
src/lib/elm_spinner.c
Summary:
When the scroller size changes by dragging the
corners, the calculations will miss the condition "x+w == x1 + w1".
This is because of format specific computer calculations. So,
improvisation is made in comparisons.
@ fix
Signed-off-by: Umesh Tanwar <umesh.tanwar@samsung.com>
Test Plan:
elementary_test -> scroller -> scroll to the extreme right (right arrow brightness changes).
Now, drag the lower right corner to increase the width of scroller. Drag the corner slowly to see the issue clearly.
The arrow brightness changes alternatively, instead the hbar is positioned to the extreme right.
Reviewers: Hermet, cedric, raster
Subscribers: singh.amitesh, eagleeye, SanghyeonLee, sachin.dev
Differential Revision: https://phab.enlightenment.org/D2796
Summary:
When icon is set, icon size is calculated without considering
edje base scale. This can lead to a miscalculation when
base scale is set other than 1.0.
@fix
Reviewers: seoz, woohyun, cedric, Hermet
Reviewed By: Hermet
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D2798
Summary:
_elm_access_say() does not free the given text.
But, the text from eina_strbuf_string_steal() is not cared
from outside of _elm_access_say(), too.
It should be changed to eina_strbuf_string_get().
Test Plan: N/A
Reviewers: cedric, woohyun, kimcinoo, JackDanielZ, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2918
Summary:
Calling the elm_config_accel_preference_get api with "none" as parameter,
it means user does not want to use acceleration.
Reviewers: Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2920
If we want to run from the local build dir without make install before
elm_module would fail to load the modules as it is expecting them in the
final install location.
We can now change this by setting ELM_RUN_IN_TREE to force it load the not
yet installed modules.
ref T2028
Our tests require a theme file. So far they picked this just from the system
where it was installed to in a previous run. We have situations where this would
not work though. Running make check before install on a new system or during
distcheck comes to mind.
With AM_TESTS_ENVIRONMENT we make that the theme is also looked for in the not
yet installed builddir.
Thanks to Lukasz Stanislawski for pointing me to this.
ref T2028