Summary: Unsure whether these are left-over, or are going to be
implemented in the near future...but for now, #if 0 out these 2
functions as they are currently unused.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Allow to add some extra contextul information about accessibility objects
which can be used by Assistive Technology to provide better user experience.
API is still marked as beta.
@feature
org.a11y.atspi.Collection interface allows to perform fast search
queries on accessibility objects tree.
Due to lack of specification of collection interface this implementation
base on gnome project implementation from https://git.gnome.org/browse/at-spi2-atk/.
@feature
This actually doesn't work for coverity, I guess we just need to mark it
as false-positive, as it will never be null.
This reverts commit 178e7e6ac9419742d1bbe583fd252fc6536e5649.
These screenshots are used in the documentation but we never made sure that we
have them actually. This resulted in our docs missing image links.
Thanks to Jean Rene Dawin for reporting it at the Enlightenment Developer Day.
Moved the data fetching to be after the tests. This doesn't really
matter and is mostly there to silence coverity. Coverity was complaining
about "it" being dereferenced before the null check (implicit in
EO_OBJ), so reordering it will fix it.
CID 1040000
Summary:
elm_hover_dismiss() doesn't hide hover directly, but sends signal only.
It can be translated that "dismiss" do not hide hover only, but handles
some works. (EDC program, callbacks etc.)
However, "dismiss" sends signals after hide hover itself, so following
edje signals are ignored. (Hover cannot be seen already!)
This patch makes hover dismiss delayed while handling edje signal.
@fix
Test Plan: elementary_test hover2
Reviewers: Hermet, cedric
Reviewed By: cedric
Subscribers: woohyun
Differential Revision: https://phab.enlightenment.org/D3068
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Issue: If text set is NULL to naviframe, crash happens in strcmp
Soln: Check for text if NULL, before passing to strcmp
@fix
Test Plan:
//Pass the text as NULL
elm_object_part_text_set(nf, "title", NULL);
Reviewers: Hermet, cedric
Reviewed By: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D3052
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Hoversel can be used like dropdown or pulldown menu.
In that case, changing hoversel label into selected item lable can be
considered as common usage of hoversel.
This API automatizes changing label.
Reviewers: SanghyeonLee, Hermet, cedric
Reviewed By: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D2963
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Some modifications for hoversel scrollability are applied.
For example,
The logic for generating scroller is changed. (newly added during activation)
If hoversel's contents are larger than hover,they will be resized to fit hover.
If hoversel is moved (by window rotation etc.), scroller will be resized.
Reduandant code are removed from popup for scrollability.
Test Plan:
You can see the sample for scrollable hoversel in second one
of "elementary_test hoversel".
Reviewers: Hermet, SanghyeonLee, cedric
Reviewed By: cedric
Subscribers: godlytalias, Hermet
Differential Revision: https://phab.enlightenment.org/D2926
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Set proper atspi parents in cases when AT-SPI object tree structure
should be different then elementary tree (mostly in cases of elm_widget_items)
Add regression tests for those cases.
This patch moves some duplicated implementation from elm_widget
and elm_widget_item classes into atspi base mixin. It allows to
better share code and reduce maintainability.
Change-Id: I8d264661e7ffade7da72299f29075a536d71eaa3
Serie of patches reducing overall memory overhead of atspi mode.
The main changes include:
* use recently fixed eldbus_service_register_fallback function instead
of regular ones.
* use global accessibility events emitter and handler to avoid registering array
of callbacks on every accessible object.
* do not keep strings with object paths
Introduce global event emitter for accessibility events. With such emitter
there is no need to register array of callbacks on every accessibility object.
Fallback eldbus interface allows to handle dbus method call on
multiple object paths only with single callback. This greatly
reduces a ammount of memory since there is no need
to register eldbus interface for every accessible object.
Summary:
Before item packed again in mbe box. box calc own min height.
In this case, there is no need to increase line number when entry is box item.
Actually the min height of box calculated wrong here.
@fix
Test Plan:
Give a color to internal box.
Then items add.
Check the internal box area got a wrong height value.
Reviewers: Hermet, cedric
Differential Revision: https://phab.enlightenment.org/D3102
Summary:
MBE internal box get its padding size from edc.
Previously, it does not consider when calculating the padding size.
In this commit, the padding size from edc is divided by its base_scale
so that desirable size can be calculated.
@fix
Reviewers: Hermet, cedric
Differential Revision: https://phab.enlightenment.org/D3103
Summary:
There is no good entry test for changing editable mode.
This patch adds a test for changing editable in entry.
Reviewers: Hermet, tasn, herdsman
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D3112
Summary:
If item filters are appended and multibuttonentry is deleted, the
filter list is not freed causing leak
Signed-Off By: Kumar Navneet <k.navneet@samsung.com>
Signed-Off By: Shilpa Singh <shilpa.singh@samsung.com>
Test Plan:
append item filters and when multibuttonentry is deleted leak is
observed, run valgrind in this scenario.
Reviewers: Hermet, cedric, CHAN
Subscribers: navnbeet
Differential Revision: https://phab.enlightenment.org/D3118
the remote editor needs to be rewritten to use x11 client messages
and wayland shell extensions at some point. need to make this stable
now to use in e20 release
After a52a53802aebf03d297aa857f0cb6a9779949a49 callback was called after every
spinner value change even if it was made from code.
This commit fixes unfocus issues without breaking callbacks logic
@fix
Reviewers: CHAN, ajwillia.ms
Subscribers: CHAN, ajwillia.ms
Differential Revision: https://phab.enlightenment.org/D3107
Signed-off-by: Andy Williams
Summary:
I need to think more about item omitted case, horizontal case as well.
Now i'm working on this. It may need to refactoring internal logic.
Please revert this commit it break view when index item omitted.
@fix
This reverts commit 560338c5c31bda8912938074cb736eabdb9f1f31.
Reviewers: Hermet, cedric, woohyun
Differential Revision: https://phab.enlightenment.org/D3062
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Flipselector lose last character when 50 characters showing case.
This defined value will using in snprintf, fetch_str(_edje_embryo_fn_fetch_str).
As you already know, we have to give the location in array for '\n'.
Test Plan: Give the 50 characters for flipselector text.
Reviewers: Hermet, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3064
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
elm_multibuttonentry_clear API not worked well.
It deleted only odd items. Because of the sd->items has been modified inside elm_widget_item_del().
Then we don't have to search target item inside of _item_del().
@fix
Test Plan:
Add MBE items.
Call elm_multibuttonentry_clear API.
Check the bug state.
Reviewers: Hermet, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3065
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
When calendar widget is already created and if we change language,
weekdays do not get translated because weekday string is statically
stored only during create.
Update the weekdays again when object is changed.
Test Plan:
1. Create and show calendar widget
2. Change the language
Weekdays do not get translated
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D3035
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
The focus go to scroller only when it needs.
If the focusable object isn't in the current viewport of the scroller,
the scroller should have the focus.
If not, the focus move to the focusable object in the scroller.
@feature.
When the focus is moved, it uses focus_direction instead of
focus_origin.
It can get the focus by using the geometry of previous focused object or item
@feature
Summary:
If there is a special value for current spinner value, just jump to apply and show up the special value for entry text.
There is no need to check format.
@fix
Test Plan:
Add special value for each spinner value.
Spinner editable set as true.
Click the button layout for activated spinner entry.
Check the entry text.
Reviewers: cedric, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2976