Summary:
Although elm_win is only created and evas_object_show with elm_win is not called,
evas_rendering works sometimes.
This rendering is not necessary. Because on one is shown and just back buffer is allocated.
This patch is the prohibiting auto-rendering, if elm_win is shown by calling evas_object_show()
It is effective for power consumption and reducing memory.
@fix
Test Plan:
1. elementary_test : checking all menus's working
2. modifed bg_example_02 : updated elm_bg's color by animator without evas_object_show(elm_win)
Reviewers: jpeg, jypark, raster
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D3282
Summary:
Eo complained about an invalid type 'Edje_Object' passed to
elm_widget_sub_object_add(). It is the segment control itself
that should be the subject of the call to this function.
@fix
Test Plan: elementary_test: no more Eo errors
Reviewers: cedric, stefan_schmidt
Differential Revision: https://phab.enlightenment.org/D3277
Summary:
The region position passed to region_show and region_bring_in used to be
relative to the object position, not the scroller.
This fixes T1686.
@fix
Reviewers: seoz
Maniphest Tasks: T1686
Differential Revision: https://phab.enlightenment.org/D3168
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
When _elm_interface_scrollable_page_bring_in is called, page is not changed yet.
So "page,changed" smart callback is unnecessary.
Sometimes "page,changed" smart callback is called twice.
Because "drag,stop" and "anim,stop"is called it.
So I add updating current page code.
Test Plan:
elementary_test -> scroller
1. using wheel.
2. using "prev page" and "next page".
3. draging sceen
Reviewers: Hermet, singh.amitesh, cedric, raster, jaehwan, seoz
Differential Revision: https://phab.enlightenment.org/D3260
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
There was all the necessary code, except that the default
theme did not implement properly the signal & required data.
There is still a problem though, as the "timeout" smart callback
will be called at the start of the animation, so it's not possible
for an app to hide() or del() at this point (that would get
rid of the animation). But there's no other callback after
the animation ends.
elementary_test -to Notify > "Bottom" illustrates this issue.
Removed #include for elementary_config.h if HAVE_CONFIG_H is
defined. Which causes errors with external projects. Instead,
defined the necessary macros to use the Eo API.
Summary:
Previously child_can_focus flag could be only updated when
child is deleted from object's subobject list. This patch
additionally updates child_can_focus flag when focusability
is changed with elm_widget_focus_can_set function.
Patch solves child_can_focus issue in similar situations:
elm_icon_add(layout);
elm_object_content_set(layout, icon);
elm_widget_child_can_focus_get(layout); // returns EINA_TRUE
icon = elm_icon_add(win);
elm_object_content_set(layout, icon);
elm_widget_child_can_focus_get(layout); // returns EINA_FALSE
@fix
Reviewers: cedric, stefan_schmidt
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D3237
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
When user called "elm_multibuttonetnry_editable_set()" API as false.
the internal entry will be unpacked from box.
Then called that API as true again.
the internal entry just show without box packed.
Also, editable set API should not work in MBE shrink mode.
Test Plan:
Alternately Call elm_multibuttonentry_ediable_set API as true, false.
Then check the internal entry state.
Reviewers: Hermet, cedric
Differential Revision: https://phab.enlightenment.org/D3134
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
The select function set in item_append does not get called on item selection issue fix.
As per documentation, the function has to get called.
@fix
Test Plan: elementary_test is updated with the demo
Reviewers: navnbeet, Hermet, CHAN, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3158
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Hoversel scrollability can be considered as default behavior of hoversel.
These APIs are not necessary any more.
Reviewers: cedric, DaveMDS
Subscribers: DaveMDS, cedric
Differential Revision: https://phab.enlightenment.org/D3241
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
At-spi clients assume that object:state-changed:focused event is emitted
on application start. By the time atspi_bridge will establish
connection on at-spi bus all focused events are already emitted.
To fix this we reemit "focused" event in bridge connection callback.
This fixes a bug when Orca screen reader do not read first element after
application launch.
@fix
Summary:
In D2063, "max_size" data item is added to limit the number of items
to show at a time when hoversel is expanded.
However, it limits the number of items too few, so makes scrollable
function useless.
This patch removes limitation of hoversel size with pixels,
but if it needs, developers can set the limitation yet.
(By theme customization)
Test Plan:
elementary_test "hoversel"
click the second hoversel
Reviewers: DaveMDS, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3223
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
The Internal box can has a lot of label for child when user set text many times.
Fix this wrong implement. It has to get only one label for child.
@fix
Test Plan:
Call elm_object_text_set() many times for MBE.
Check the label got a wrong geometry.
Reviewers: Hermet, cedric
Differential Revision: https://phab.enlightenment.org/D3133
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
The timestamp has 0 value when n_long_tap_start callback called.
Then timestamp is same on each n_long_tap_move callback functions.
For fix this bug, update timestamp before called state_set function.
Also update timestamp in every timeout.
Test Plan:
Run test_gesture_layer2.c
Print timestamp in every n_long_tap_XXX callback.
Reviewers: tasn, cedric
Differential Revision: https://phab.enlightenment.org/D3144
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
elm_hoversel_scroll_enabled_set/get() API were changed to
elm_hoversel_scrollable_set/get().
However, the name of member of Elm_Hovsersel_Data related to those API
are not changed.
It can confuse developers later, so change it same to the name defined
in elm_hoversel.eo file.
Reviewers: Hermet, cedric
Differential Revision: https://phab.enlightenment.org/D3140
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
For various angles 90, 180, 270, the calculation of dnd window position
is not proper causing window to be placed wrongly while dragging.
Signed-Off By: Kumar Navneet <k.navneet@samsung.com>
@fix
Test Plan:
Longpress and drag and drop in entry by placing device at various angles
90, 180 and 270.
Reviewers: woohyun, cedric, thiepha
Reviewed By: thiepha
Subscribers: navnbeet
Differential Revision: https://phab.enlightenment.org/D3188
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
I missed this one yesterday. Also change it to use floating point values
instead of casting which does not make much sense for hard-coded values.
CID: 1327343
When dividing with an int we would loose the fractional part. Better cast to
a double to make clear we want double precision here.
CID: 1327343, 1327344
for release we need to test performance - esp of evas and eo in real life usage
and scroling is just such one. this adds a simple automated scrolling
test to genlist test (hit the button or ELM_TEST_AUTOBOUNCE=1
elementary_test -to genlist) so you can get consistent input and benchmark info
This change is the simplest I could do, but I think it would be better
to move _item_theme_hook inside _item_new. This is a further attempt
to fix T2777.
Summary:
Currently path is strdup() when getting real path, but it is not freed
in some cases.
@fix
Reviewers: seoz, Hermet, woohyun, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3194
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>