Mike Blumenkrantz
903727f174
unused--
...
SVN revision: 64918
2011-11-07 23:59:12 +00:00
Mike Blumenkrantz
11ff2ab3eb
I don't spend hours and hours and hours and days of my free time hacking on ecrustify for people to not use it.
...
SVN revision: 64917
2011-11-07 23:53:01 +00:00
Mike Blumenkrantz
512062bee3
okay. I'm not often as serious as I am now.
...
take a moment, look around, and find something that comforts you. enjoy this thing for a few minutes or until you are sufficiently relaxed.
IF YOU SEND US A PATCH, TEST COMPILE IT.
IF IT HAS WARNINGS, FIX THEM. ALL OF THEM.
IF YOU COMMIT A PATCH THAT CREATES WARNINGS, DON'T.
IF YOU HAVE COMMITTED A PATCH THAT CREATED WARNINGS:
* GO BACK TO SCHOOL
* LEARN PHYSICS AND ENGINEERING
* INVENT A TIME MACHINE
* GO BACK IN TIME AND SPANK YOURSELF
SVN revision: 64916
2011-11-07 23:49:08 +00:00
Mike Blumenkrantz
c94c9ffe05
unused var--
...
SVN revision: 64915
2011-11-07 23:42:19 +00:00
Mike Blumenkrantz
bc6ff37c70
more crashes--
...
SVN revision: 64914
2011-11-07 23:41:59 +00:00
Mike Blumenkrantz
154673d7b8
more dead stores
...
SVN revision: 64913
2011-11-07 23:38:57 +00:00
Mike Blumenkrantz
839b515b43
even MORE unused vars
...
SVN revision: 64912
2011-11-07 23:37:54 +00:00
Mike Blumenkrantz
fe4b68060e
yet enother unused var
...
SVN revision: 64911
2011-11-07 23:36:56 +00:00
Mike Blumenkrantz
986ff1bdd5
another unused var
...
SVN revision: 64910
2011-11-07 23:35:57 +00:00
Mike Blumenkrantz
bc6f8843a1
fix uninitialized variable
...
SVN revision: 64909
2011-11-07 23:34:42 +00:00
Mike Blumenkrantz
276297887c
this isn't doing what you thought it was doing.
...
SVN revision: 64908
2011-11-07 23:33:11 +00:00
Mike Blumenkrantz
d5a1ff9f66
crash--
...
SVN revision: 64907
2011-11-07 23:32:44 +00:00
Mike Blumenkrantz
5a249be7bb
OMG! DEVILHORNS USING AN EDITOR WITH TABS INSTEAD OF WHITESPACES????? SAY IT AIN'T SO!!!
...
SVN revision: 64906
2011-11-07 23:30:27 +00:00
Mike Blumenkrantz
4ae3818d7c
fix another null deref
...
SVN revision: 64905
2011-11-07 23:29:44 +00:00
Mike Blumenkrantz
2a905bb70d
properly set __UNUSED__ here
...
SVN revision: 64904
2011-11-07 23:21:33 +00:00
Mike Blumenkrantz
d884b0a407
I uhhhhh...what?
...
SVN revision: 64903
2011-11-07 23:20:36 +00:00
Mike Blumenkrantz
c0ddaeb734
I can't help but feel like some part of this is a bug. probably because it is.
...
SVN revision: 64902
2011-11-07 23:18:07 +00:00
Mike Blumenkrantz
a438f3ed36
more dead stores
...
SVN revision: 64901
2011-11-07 23:15:01 +00:00
Mike Blumenkrantz
aa9f9ac26b
another unused var
...
SVN revision: 64900
2011-11-07 23:10:30 +00:00
Mike Blumenkrantz
9254625b31
avoid null strcmp
...
SVN revision: 64899
2011-11-07 23:09:26 +00:00
Mike Blumenkrantz
d7dac60928
it's a dead assignment removal party and everybody's invited!
...
SVN revision: 64898
2011-11-07 23:06:59 +00:00
Mike Blumenkrantz
0fb45b0a22
leif, you're killing me with these.
...
SVN revision: 64897
2011-11-07 23:04:25 +00:00
Mike Blumenkrantz
3c2cf6dab2
checks like this only work with initializers!
...
SVN revision: 64896
2011-11-07 23:03:07 +00:00
Mike Blumenkrantz
1331c05a13
presumably this is what was supposed to be here
...
SVN revision: 64895
2011-11-07 23:02:13 +00:00
Mike Blumenkrantz
fb59344571
this was useless and nonsensical, so I rewrote it to be even more nonsensical in the hopes that someone who knows what it was supposed to do will see it and fix it
...
SVN revision: 64894
2011-11-07 22:58:10 +00:00
Mike Blumenkrantz
7e4081d9f1
fix more null derefs
...
SVN revision: 64893
2011-11-07 22:50:54 +00:00
Mike Blumenkrantz
5940c38112
even more unused vars!
...
SVN revision: 64892
2011-11-07 22:48:19 +00:00
Mike Blumenkrantz
68e596ed48
more unused vars
...
SVN revision: 64891
2011-11-07 22:47:17 +00:00
Mike Blumenkrantz
8b55bddc37
LET THERE BE (fewer) FRAMETABLES!
...
SVN revision: 64890
2011-11-07 22:42:21 +00:00
Mike Blumenkrantz
bc45b835df
just return here, eh?
...
SVN revision: 64889
2011-11-07 22:41:02 +00:00
Mike Blumenkrantz
223013c370
woooo dead stores! yeaahh!!!!
...
SVN revision: 64888
2011-11-07 22:39:56 +00:00
Mike Blumenkrantz
694b58f985
I guess make this explicit even though it will never happen
...
SVN revision: 64887
2011-11-07 22:37:20 +00:00
Mike Blumenkrantz
a0c180f41a
if (fail) goto exit;
...
exit:
return;
who can spot what's wrong with the above snippet? cookies for the first one to answer correctly!
SVN revision: 64886
2011-11-07 22:36:11 +00:00
Mike Blumenkrantz
d27e4fad0f
as it turns out, this whole thing was pretty dumb so I'm cutting it down
...
SVN revision: 64885
2011-11-07 22:33:29 +00:00
Mike Blumenkrantz
91118b6790
initializers: I don't really have anything witty to say about them, but you should know that they're important
...
SVN revision: 64884
2011-11-07 22:31:03 +00:00
Mike Blumenkrantz
9a1b59641a
allocating 0 bytes: stay classy e
...
SVN revision: 64883
2011-11-07 22:29:29 +00:00
Mike Blumenkrantz
c3fff8a8a7
fix possible null deref here
...
SVN revision: 64882
2011-11-07 22:28:05 +00:00
Mike Blumenkrantz
59ad77e297
checking return value of alloca is like checking whether your app is still running
...
SVN revision: 64881
2011-11-07 22:19:50 +00:00
Mike Blumenkrantz
cf3762ba28
not sure what the point of this is, so away with it!
...
SVN revision: 64880
2011-11-07 22:18:34 +00:00
Mike Blumenkrantz
35d0205db5
remove unused var here
...
SVN revision: 64879
2011-11-07 22:17:23 +00:00
Mike Blumenkrantz
f50d13d49d
remove dead store here
...
SVN revision: 64877
2011-11-07 22:14:27 +00:00
Mike Blumenkrantz
970335809a
someone forgot to break this case statement. how embarrassing for this person and his family.
...
SVN revision: 64876
2011-11-07 22:13:01 +00:00
Mike Blumenkrantz
696204e49a
and maybe use the right variable name here
...
SVN revision: 64875
2011-11-07 22:11:32 +00:00
Mike Blumenkrantz
d082be3165
hey let's not crash here
...
SVN revision: 64874
2011-11-07 22:10:24 +00:00
Mike Blumenkrantz
54413de9b1
clean up some compiler warnings
...
SVN revision: 64873
2011-11-07 22:07:06 +00:00
Massimo Maiurana
f0d513fc00
updating french translations
...
SVN revision: 64871
2011-11-07 18:17:09 +00:00
Mike Blumenkrantz
eb623c407e
actually start dbus stuff c/o cedric
...
SVN revision: 64870
2011-11-07 15:56:48 +00:00
Massimo Maiurana
be57a363bf
updating french translations
...
SVN revision: 64845
2011-11-06 20:53:24 +00:00
Mike Blumenkrantz
27e3d40011
convert this to png
...
SVN revision: 64843
2011-11-06 18:53:59 +00:00
Cedric BAIL
a26e265d95
e: correctly detect local socket and don't leak memory.
...
SVN revision: 64810
2011-11-06 10:41:28 +00:00