From: Bluezery <ohpowel@gmail.com>

Subject: [E-devel][Patch][ecore_con] Fix invalid curl handle removal by valgrind
Date: Wed, 22 Feb 2012 19:57:36 +0900

Hello,

discomfitor reports bugs by valigrind.  I checked it with valgrid and
I found the clues
curl_multi_remove_handle() should not be called when multi handles
being performed. So I removed curl_multi_remove_handle() code from
_ecore_con_url_info_read()
Now, curl_multi_remove_handle() is only called for all easy handles
when a multi-handle ended.
Please review this simple patch.


SVN revision: 68287
This commit is contained in:
Bluezery 2012-02-22 19:58:34 +00:00 committed by Mike Blumenkrantz
parent 84ba307c71
commit 40c61bce9a
1 changed files with 1 additions and 5 deletions

View File

@ -1441,11 +1441,7 @@ _ecore_con_url_info_read(void)
EINA_LIST_FOREACH_SAFE(_url_con_list, l, ll, url_con)
{
if (curlmsg->easy_handle == url_con->curl_easy)
{
_ecore_con_url_event_url_complete(url_con, curlmsg);
_ecore_con_url_multi_remove(url_con);
_url_con_list = eina_list_remove_list(_url_con_list, l);
}
_ecore_con_url_event_url_complete(url_con, curlmsg);
}
}
}