vtorri
/
entice
1
0
Fork 0
Code Issues 8 Pull Requests Packages Projects Releases Wiki Activity

add copy button in settings #8

New Issue
Closed
opened 2021-04-06 12:40:51 -07:00 by vtorri · 13 comments
vtorri commented 2021-04-06 12:40:51 -07:00 (Migrated from github.com)
Copy Link
No description provided.
Thanatermesis commented 2021-04-08 10:17:40 -07:00 (Migrated from github.com)
Copy Link

BTW I was thinking on this the other day... people are used "copy paste" images too (not only the url/address) , for example in elive we have a screenshot tool that is very useful because you take the range screenshot and then only "ctrl + p" into a website or somewhere you want to use the image (and there's the option to even not save the image at all, just having it in your clipboard)

so maybe the two options can be useful, "ctrl + c" to copy the image in the clipboard, and... maybe "ctrl + shift + c" to copy the url of the image 🤔 ? (that is less used by the users so maybe this hotkey is a good combo)

BTW I was thinking on this the other day... people are used "copy paste" images too (not only the url/address) , for example in elive we have a screenshot tool that is very useful because you take the range screenshot and then only "ctrl + p" into a website or somewhere you want to use the image (and there's the option to even not save the image at all, just having it in your clipboard) so maybe the two options can be useful, "ctrl + c" to copy the image in the clipboard, and... maybe "ctrl + shift + c" to copy the url of the image :thinking: ? (that is less used by the users so maybe this hotkey is a good combo)
👍 2
vtorri commented 2021-04-14 22:32:47 -07:00 (Migrated from github.com)
Copy Link

so right now, in git, the file name copy is managed with Ctrl-c and option in the hamburger menu

if it's sufficient ? If so, please close issue

so right now, in git, the file name copy is managed with Ctrl-c and option in the hamburger menu if it's sufficient ? If so, please close issue
triantares commented 2021-04-15 00:40:10 -07:00 (Migrated from github.com)
Copy Link

This absolutely perfect, thank you.
You have just made me set "entice" to my system-wide default picture viewer. 👍
BTW,
As you yourself opened this issue, it's you that has to close it. :

This absolutely perfect, thank you. You have just made me set "entice" to my system-wide default picture viewer. :+1: BTW, As you yourself opened this issue, it's you that has to close it. :
vtorri commented 2021-04-15 00:56:51 -07:00 (Migrated from github.com)
Copy Link

as for copying the image itself, i have to look a bit more.

@triantares i will remove some icons at the bottom (1:1 and fit icon, they will be available in another way, and there is anyway the keyboard shortcuts)

thanks for your interest in entice :-)

as for copying the image itself, i have to look a bit more. @triantares i will remove some icons at the bottom (1:1 and fit icon, they will be available in another way, and there is anyway the keyboard shortcuts) thanks for your interest in entice :-)
vtorri commented 2021-04-19 05:23:34 -07:00 (Migrated from github.com)
Copy Link

@Thanatermesis @triantares i have added a button which copies the file itself (in hamburger menu). It works with gimp in manjaro (virtualbox), so it should work for you too.

Please test

also, there is no shortcut yet
Ctrl-c is to copy filename

but if you think that

Ctrl-c : copy file
Ctrl-Shift-c : copy filename

is better, i'll implement this

@Thanatermesis @triantares i have added a button which copies the file itself (in hamburger menu). It works with gimp in manjaro (virtualbox), so it should work for you too. Please test also, there is no shortcut yet Ctrl-c is to copy filename but if you think that Ctrl-c : copy file Ctrl-Shift-c : copy filename is better, i'll implement this
vtorri commented 2021-04-22 00:22:58 -07:00 (Migrated from github.com)
Copy Link

@Thanatermesis @triantares have you tried both copy buttons ? They both work for me, but i want you to confirm. thank you

@Thanatermesis @triantares have you tried both copy buttons ? They both work for me, but i want you to confirm. thank you
triantares commented 2021-04-22 12:52:03 -07:00 (Migrated from github.com)
Copy Link

i want you to confirm. thank you

They both work in i.e libreoffice using Ctrl+v as well as the "paste" from the menu.
Weirdly, in "ghostwriter" it doesn't work. The paste option is in both cases greyed out but the file name does get copied if I use Ctrl+v.

On github, pasting the image works fine too. 👍

Both the file and the file path show up in my clipboard manager ... so I suspect it's a ghostwriter thingy.
Tried this on 2 different laptops running E16. :)

> i want you to confirm. thank you They both work in i.e libreoffice using Ctrl+v as well as the "paste" from the menu. Weirdly, in "ghostwriter" it doesn't work. The paste option is in both cases greyed out but the file name does get copied if I use Ctrl+v. On github, pasting the image works fine too. :+1: Both the file and the file path show up in my clipboard manager ... so I suspect it's a ghostwriter thingy. Tried this on 2 different laptops running E16. :)
vtorri commented 2021-04-22 13:41:34 -07:00 (Migrated from github.com)
Copy Link

and about shortcut ?

and about shortcut ?
Thanatermesis commented 2021-04-22 19:28:23 -07:00 (Migrated from github.com)
Copy Link

I was just trying but I got a segfault:

ERR<18320>:eo ../src/lib/eo/eo.c:1978 efl_isa() Object 0x5625539b9d90 is not a valid object in this context: object domain: 2, current domain: 0, local domain: 0, available domains: [0 1 ]. Are you trying to access this object from another thread?

    /lib/x86_64-linux-gnu/libeina.so.1|        ../src/lib/eina/eina_log.c : 2054 @ _eina_semaphore_free()
    /lib/x86_64-linux-gnu/libeina.so.1|        ../src/lib/eina/eina_log.c : 1456 @ eina_log_print_cb_stdout()
    /lib/x86_64-linux-gnu/libeina.so.1|        ../src/lib/eina/eina_log.c : 2307 @ eina_log_print()
    /lib/x86_64-linux-gnu/libeo.so.1  |          ../src/lib/eo/eo.c       : 1979 @ efl_isa()
    /lib/x86_64-linux-gnu/libevas.so.1| ../src/lib/evas/canvas/evas_data.c:   14 @ evas_object_data_get()
/usr/bin/entice0x55eb55446d7d 0x55eb55441000
addr2line: DWARF error: unable to read alt ref 341820
addr2line: DWARF error: unable to read alt ref 341820

    /lib/x86_64-linux-gnu/libecore.so.1| ../src/lib/ecore/ecore_timer.c:  172 @ _ecore_timer_legacy_tick()
    /lib/x86_64-linux-gnu/libeo.so.1   |               ??/??           :  172 @ efl_provider_unregister()
    /lib/x86_64-linux-gnu/libeo.so.1   |               ??/??           :  172 @ efl_event_callback_call()
    /lib/x86_64-linux-gnu/libecore.so.1| ../src/lib/ecore/ecore_timer.c:  670 @ _efl_loop_timer_expired_call()
    /lib/x86_64-linux-gnu/libecore.so.1| ../src/lib/ecore/ecore_main.c : 2399 @ ecore_job_del()
    /lib/x86_64-linux-gnu/libecore.so.1| ../src/lib/ecore/ecore_main.c : 1217 @ _ecore_main_loop_wakeup_time_get()
    /lib/x86_64-linux-gnu/libecore.so.1| ../src/lib/ecore/efl_loop.c   :   58 @ efl_loop_timeout()
    /lib/x86_64-linux-gnu/libecore.so.1|    src/lib/ecore/efl_loop.eo.c:   28 @ efl_loop_begin()
    /lib/x86_64-linux-gnu/libecore.so.1| ../src/lib/ecore/ecore_main.c : 1304 @ ecore_main_loop_begin()
/usr/bin/entice0x55eb5544c8bf 0x55eb55441000
/usr/bin/entice0x55eb55446b9f 0x55eb55441000
/lib/x86_64-linux-gnu/libc.so.60x7f06794e709b 0x7f06794c3000
/usr/bin/entice0x55eb55446bfa 0x55eb55441000

Note: I just rebuilt entice but not efl for this test, not sure if is related

Also left click in image:

ERR<18445>:entice ../src/bin/entice_settings.c:289 entice_settings_init() Can not grab the 'Esc' key

    /lib/x86_64-linux-gnu/libeina.so.1| ../src/lib/eina/eina_log.c: 2054 @ _eina_semaphore_free()
    /lib/x86_64-linux-gnu/libeina.so.1| ../src/lib/eina/eina_log.c: 1456 @ eina_log_print_cb_stdout()
    /lib/x86_64-linux-gnu/libeina.so.1| ../src/lib/eina/eina_log.c: 2307 @ eina_log_print()
/usr/bin/entice0x55eb5544834b 0x55eb55441000
/usr/bin/entice0x55eb5544839b 0x55eb55441000
addr2line: DWARF error: unable to read alt ref 341820
addr2line: DWARF error: unable to read alt ref 341820
addr2line: DWARF error: unable to read alt ref 341820
addr2line: DWARF error: unable to read alt ref 341820
    /lib/x86_64-linux-gnu/libevas.so.1            |      ../src/lib/evas/canvas/evas_callbacks.c             :  195 @ evas_bidi_shape_string()
    /lib/x86_64-linux-gnu/libeo.so.1              |                          ??/??                           :  195 @ efl_provider_unregister()
    /lib/x86_64-linux-gnu/libeo.so.1              |                          ??/??                           :  195 @ efl_event_callback_legacy_call()
    /lib/x86_64-linux-gnu/libevas.so.1            |      ../src/lib/evas/canvas/evas_callbacks.c             :  353 @ evas_bidi_shape_string()
    /lib/x86_64-linux-gnu/libevas.so.1            |      ../src/lib/evas/canvas/evas_callbacks.c             :  475 @ evas_bidi_shape_string()
    /lib/x86_64-linux-gnu/libevas.so.1            |      ../src/lib/evas/canvas/evas_callbacks.c             :  475 @ evas_bidi_shape_string()
    /lib/x86_64-linux-gnu/libevas.so.1            |      ../src/lib/evas/canvas/evas_events.c                : 1716 @ evas_device_seat_id_get()
    /lib/x86_64-linux-gnu/libevas.so.1            |      ../src/lib/evas/canvas/evas_events.c                : 1620 @ evas_event_input_multi_up()
    /lib/x86_64-linux-gnu/libeo.so.1              |                          ??/??                           : 1620 @ efl_provider_unregister()
    /lib/x86_64-linux-gnu/libeo.so.1              |                          ??/??                           : 1620 @ efl_event_callback_legacy_call()
    /lib/x86_64-linux-gnu/libecore_evas.so.1      |       ../src/lib/ecore_evas/ecore_evas.c                 : 4838 @ _ecore_evas_mouse_multi_up_process()
    /lib/x86_64-linux-gnu/libecore_evas.so.1      |       ../src/lib/ecore_evas/ecore_evas.c                 : 5151 @ _ecore_evas_input_direct_cb()
    /lib/x86_64-linux-gnu/libecore_input_evas.so.1| ../src/lib/ecore_input_evas/ecore_input_evas.c           :  538 @ _ecore_event_evas_mouse_button()
    /lib/x86_64-linux-gnu/libecore.so.1           |            ../src/lib/ecore/ecore_event_message_handler.c:  362 @ ecore_main_fd_handler_active_set()
    /lib/x86_64-linux-gnu/libecore.so.1           |               src/lib/ecore/efl_loop_message_handler.eo.c:   14 @ efl_loop_message_handler_message_call()
    /lib/x86_64-linux-gnu/libecore.so.1           |            ../src/lib/ecore/efl_loop.c                   :  602 @ efl_loop_timeout()
    /lib/x86_64-linux-gnu/libecore.so.1           |            ../src/lib/ecore/efl_loop.c                   :  640 @ efl_loop_message_process()
    /lib/x86_64-linux-gnu/libecore.so.1           |            ../src/lib/ecore/ecore_main.c                 : 2515 @ ecore_job_del()
    /lib/x86_64-linux-gnu/libecore.so.1           |            ../src/lib/ecore/ecore_main.c                 : 1217 @ _ecore_main_loop_wakeup_time_get()
    /lib/x86_64-linux-gnu/libecore.so.1           |            ../src/lib/ecore/efl_loop.c                   :   58 @ efl_loop_timeout()
    /lib/x86_64-linux-gnu/libecore.so.1           |               src/lib/ecore/efl_loop.eo.c                :   28 @ efl_loop_begin()
    /lib/x86_64-linux-gnu/libecore.so.1           |            ../src/lib/ecore/ecore_main.c                 : 1304 @ ecore_main_loop_begin()
/usr/bin/entice0x55eb5544c8bf 0x55eb55441000
/usr/bin/entice0x55eb55446b9f 0x55eb55441000
/lib/x86_64-linux-gnu/libc.so.60x7f06794e709b 0x7f06794c3000
/usr/bin/entice0x55eb55446bfa 0x55eb55441000
I was just trying but I got a segfault: > ERR<18320>:eo ../src/lib/eo/eo.c:1978 efl_isa() Object 0x5625539b9d90 is not a valid object in this context: object domain: 2, current domain: 0, local domain: 0, available domains: [0 1 ]. Are you trying to access this object from another thread? ``` /lib/x86_64-linux-gnu/libeina.so.1| ../src/lib/eina/eina_log.c : 2054 @ _eina_semaphore_free() /lib/x86_64-linux-gnu/libeina.so.1| ../src/lib/eina/eina_log.c : 1456 @ eina_log_print_cb_stdout() /lib/x86_64-linux-gnu/libeina.so.1| ../src/lib/eina/eina_log.c : 2307 @ eina_log_print() /lib/x86_64-linux-gnu/libeo.so.1 | ../src/lib/eo/eo.c : 1979 @ efl_isa() /lib/x86_64-linux-gnu/libevas.so.1| ../src/lib/evas/canvas/evas_data.c: 14 @ evas_object_data_get() /usr/bin/entice0x55eb55446d7d 0x55eb55441000 addr2line: DWARF error: unable to read alt ref 341820 addr2line: DWARF error: unable to read alt ref 341820 /lib/x86_64-linux-gnu/libecore.so.1| ../src/lib/ecore/ecore_timer.c: 172 @ _ecore_timer_legacy_tick() /lib/x86_64-linux-gnu/libeo.so.1 | ??/?? : 172 @ efl_provider_unregister() /lib/x86_64-linux-gnu/libeo.so.1 | ??/?? : 172 @ efl_event_callback_call() /lib/x86_64-linux-gnu/libecore.so.1| ../src/lib/ecore/ecore_timer.c: 670 @ _efl_loop_timer_expired_call() /lib/x86_64-linux-gnu/libecore.so.1| ../src/lib/ecore/ecore_main.c : 2399 @ ecore_job_del() /lib/x86_64-linux-gnu/libecore.so.1| ../src/lib/ecore/ecore_main.c : 1217 @ _ecore_main_loop_wakeup_time_get() /lib/x86_64-linux-gnu/libecore.so.1| ../src/lib/ecore/efl_loop.c : 58 @ efl_loop_timeout() /lib/x86_64-linux-gnu/libecore.so.1| src/lib/ecore/efl_loop.eo.c: 28 @ efl_loop_begin() /lib/x86_64-linux-gnu/libecore.so.1| ../src/lib/ecore/ecore_main.c : 1304 @ ecore_main_loop_begin() /usr/bin/entice0x55eb5544c8bf 0x55eb55441000 /usr/bin/entice0x55eb55446b9f 0x55eb55441000 /lib/x86_64-linux-gnu/libc.so.60x7f06794e709b 0x7f06794c3000 /usr/bin/entice0x55eb55446bfa 0x55eb55441000 ``` Note: I just rebuilt entice but not efl for this test, not sure if is related Also left click in image: > ERR<18445>:entice ../src/bin/entice_settings.c:289 entice_settings_init() Can not grab the 'Esc' key ``` /lib/x86_64-linux-gnu/libeina.so.1| ../src/lib/eina/eina_log.c: 2054 @ _eina_semaphore_free() /lib/x86_64-linux-gnu/libeina.so.1| ../src/lib/eina/eina_log.c: 1456 @ eina_log_print_cb_stdout() /lib/x86_64-linux-gnu/libeina.so.1| ../src/lib/eina/eina_log.c: 2307 @ eina_log_print() /usr/bin/entice0x55eb5544834b 0x55eb55441000 /usr/bin/entice0x55eb5544839b 0x55eb55441000 addr2line: DWARF error: unable to read alt ref 341820 addr2line: DWARF error: unable to read alt ref 341820 addr2line: DWARF error: unable to read alt ref 341820 addr2line: DWARF error: unable to read alt ref 341820 /lib/x86_64-linux-gnu/libevas.so.1 | ../src/lib/evas/canvas/evas_callbacks.c : 195 @ evas_bidi_shape_string() /lib/x86_64-linux-gnu/libeo.so.1 | ??/?? : 195 @ efl_provider_unregister() /lib/x86_64-linux-gnu/libeo.so.1 | ??/?? : 195 @ efl_event_callback_legacy_call() /lib/x86_64-linux-gnu/libevas.so.1 | ../src/lib/evas/canvas/evas_callbacks.c : 353 @ evas_bidi_shape_string() /lib/x86_64-linux-gnu/libevas.so.1 | ../src/lib/evas/canvas/evas_callbacks.c : 475 @ evas_bidi_shape_string() /lib/x86_64-linux-gnu/libevas.so.1 | ../src/lib/evas/canvas/evas_callbacks.c : 475 @ evas_bidi_shape_string() /lib/x86_64-linux-gnu/libevas.so.1 | ../src/lib/evas/canvas/evas_events.c : 1716 @ evas_device_seat_id_get() /lib/x86_64-linux-gnu/libevas.so.1 | ../src/lib/evas/canvas/evas_events.c : 1620 @ evas_event_input_multi_up() /lib/x86_64-linux-gnu/libeo.so.1 | ??/?? : 1620 @ efl_provider_unregister() /lib/x86_64-linux-gnu/libeo.so.1 | ??/?? : 1620 @ efl_event_callback_legacy_call() /lib/x86_64-linux-gnu/libecore_evas.so.1 | ../src/lib/ecore_evas/ecore_evas.c : 4838 @ _ecore_evas_mouse_multi_up_process() /lib/x86_64-linux-gnu/libecore_evas.so.1 | ../src/lib/ecore_evas/ecore_evas.c : 5151 @ _ecore_evas_input_direct_cb() /lib/x86_64-linux-gnu/libecore_input_evas.so.1| ../src/lib/ecore_input_evas/ecore_input_evas.c : 538 @ _ecore_event_evas_mouse_button() /lib/x86_64-linux-gnu/libecore.so.1 | ../src/lib/ecore/ecore_event_message_handler.c: 362 @ ecore_main_fd_handler_active_set() /lib/x86_64-linux-gnu/libecore.so.1 | src/lib/ecore/efl_loop_message_handler.eo.c: 14 @ efl_loop_message_handler_message_call() /lib/x86_64-linux-gnu/libecore.so.1 | ../src/lib/ecore/efl_loop.c : 602 @ efl_loop_timeout() /lib/x86_64-linux-gnu/libecore.so.1 | ../src/lib/ecore/efl_loop.c : 640 @ efl_loop_message_process() /lib/x86_64-linux-gnu/libecore.so.1 | ../src/lib/ecore/ecore_main.c : 2515 @ ecore_job_del() /lib/x86_64-linux-gnu/libecore.so.1 | ../src/lib/ecore/ecore_main.c : 1217 @ _ecore_main_loop_wakeup_time_get() /lib/x86_64-linux-gnu/libecore.so.1 | ../src/lib/ecore/efl_loop.c : 58 @ efl_loop_timeout() /lib/x86_64-linux-gnu/libecore.so.1 | src/lib/ecore/efl_loop.eo.c : 28 @ efl_loop_begin() /lib/x86_64-linux-gnu/libecore.so.1 | ../src/lib/ecore/ecore_main.c : 1304 @ ecore_main_loop_begin() /usr/bin/entice0x55eb5544c8bf 0x55eb55441000 /usr/bin/entice0x55eb55446b9f 0x55eb55441000 /lib/x86_64-linux-gnu/libc.so.60x7f06794e709b 0x7f06794c3000 /usr/bin/entice0x55eb55446bfa 0x55eb55441000 ```
vtorri commented 2021-04-22 20:34:50 -07:00 (Migrated from github.com)
Copy Link

I think i've just fixed this 2 minutes ago, or at least the first one

I think i've just fixed this 2 minutes ago, or at least the first one
vtorri commented 2021-04-26 01:34:21 -07:00 (Migrated from github.com)
Copy Link

@Thanatermesis what is the status of your sefault ?

btw, if there is still a segfault, please provide a usefull backtrace (with gdb or valgrind, with debug symbols for entice)

thanks

@Thanatermesis what is the status of your sefault ? btw, if there is still a segfault, please provide a usefull backtrace (with gdb or valgrind, with debug symbols for entice) thanks
Thanatermesis commented 2021-04-26 10:59:52 -07:00 (Migrated from github.com)
Copy Link

seems like segfault is gone now

seems like segfault is gone now
vtorri commented 2021-04-26 11:10:54 -07:00 (Migrated from github.com)
Copy Link

closing, then

closing, then
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No Label
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vtorri/entice#8
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?