The conversion to eina_file_map() in r78179 broke the error path of
efreet_init_parse(). Particularly if file doesn't exist. Since the variables
were not initialized it was trying to operate on random values from the stack.
So I got the following crash on E17:
#0 0x00007f238b0bbd67 in waitpid () from /usr/lib/libpthread.so.0
#1 0x00000000004397a3 in e_alert_show ()
#2 0x0000000000526392 in e_sigseg_act ()
#3 <signal handler called>
#4 0x0000000000000031 in ?? ()
#5 0x00007f239315df0f in efreet_ini_parse (file=file@entry=0x7fff39ce46f0 "/home/lucas/local/share/enlightenment/applications/defaults.list")
at /home/lucas/p/e-svn/trunk/efreet/src/lib/efreet_ini.c:245
#6 0x00007f239315e100 in efreet_ini_new (file=0x7fff39ce46f0 "/home/lucas/local/share/enlightenment/applications/defaults.list")
at /home/lucas/p/e-svn/trunk/efreet/src/lib/efreet_ini.c:82
#7 0x0000000000538174 in _e_util_default_terminal_get ()
#8 0x00000000005382dc in e_util_terminal_desktop_get ()
#9 0x00007f23706a1065 in e_fwin_init () from /home/lucas/local/lib/enlightenment/modules/fileman/linux-gnu-x86_64-ver-pre-svn-08/module.so
#10 0x00007f237069b524 in e_modapi_init () from /home/lucas/local/lib/enlightenment/modules/fileman/linux-gnu-x86_64-ver-pre-svn-08/module.so
#11 0x000000000050420d in e_module_enable ()
#12 0x0000000000504e77 in _e_module_cb_idler ()
#13 0x00007f238da22739 in _ecore_call_task_cb (data=<optimized out>, func=<optimized out>) at /home/lucas/p/e-svn/trunk/ecore/src/lib/ecore/ecore_private.h:265
#14 _ecore_idle_enterer_call () at /home/lucas/p/e-svn/trunk/ecore/src/lib/ecore/ecore_idle_enterer.c:234
#15 0x00007f238da24c1b in _ecore_main_loop_iterate_internal (once_only=once_only@entry=0) at /home/lucas/p/e-svn/trunk/ecore/src/lib/ecore/ecore_main.c:1826
#16 0x00007f238da252c7 in ecore_main_loop_begin () at /home/lucas/p/e-svn/trunk/ecore/src/lib/ecore/ecore_main.c:934
#17 0x0000000000436167 in main ()
Besides initializing the variables, there's no need to "goto" if the file
doesn't exist.... just return.
SVN revision: 78272
after some poking around and looking - terminology is taking about
800ms to start ... and we seem to use about 300ms or so of that time
statting files and tregistering them for file monitoring (the dirs
that are found there) and also handling a big batch of incoming file
monitor events for some reason even tho nothing changed.
this cuts down some time+noise, but we need to do a lot of work here. :(
SVN revision: 78108
On Thu, Sep 20, 2012 at 8:06 PM, Zbigniew Kosinski <z.kosinski@samsung.com> wrote:
> Hello,
>
> Right now efreet_shutdown function doesn't return values below 0.
>
> In my opinion, efreet_mime_shutdown function should behave in the same way
> as efreet_shutdown.
>
> I have prepared patch proposal to prevent decrementing init counter below 0.
>
> Please take a look at attached file.
>
> BR,
>
> Zbigniew Kosinski
SVN revision: 76921
Need to release generated file name, else we will use same filename
again when opening cache.
Also need to close cache, as a cache rebuild might not trigger cache
close if the cache in another language already exists.
SVN revision: 75020
Sebastian Dransfeld
Lucas De Marchi
Carsten Haitzler
Gustavo Sverzut Barbieri
Mike Blumenkrantz
Daniel Juyung Seo
Cedric BAIL
Vincent Torri