Sorry if it looks like a 'taste' discussion, i'm only wondering :)
As you sad earlier "... that's a bigger discussion."
Do you like
if (head.size < 0)
{
}
else
{
}
instead of
if (head.size < 0)
{
}
else
{
}
?
Personally I like the last one.
Original
#ifndef E_SYSTEM_H
# define E_SYSTEM_H 1
# include "config.h"
# ifndef _FILE_OFFSET_BITS
# define _FILE_OFFSET_BITS 64
# endif
# ifdef STDC_HEADERS
# include <stdlib.h>
…So, tried yours:
original:
if (!strncmp(v->mount_point, e_user_dir_get(), strlen(e_user_dir_get())))
if (unlink(v->mount_point))
printf("Error unlinking mount point!\n");
…
Another question.
What will be the difference between
static void
_cb_search_changed(void *data, Evas_Object *obj EINA_UNUSED, void *event_info EINA_UNUSED)
{
ecore_timer_add(0.3,…@raster, it got me wondering, do we need to restart timer on each entry change?
Not exactly so.
Here we make a selection only when your search entry text is exactly equal to the string in the list. In the middle of typing we have no selection.
But i think about timer.…
Small things - like .h files being ignored...
when it comes to formatting I think that's a bigger discussion... have a look at efm2 and at the .clang-format there and try that. yes -…
Yep.
Had a lot of problems with compilation when headers are turned on (but in EFL :).
Nevertheless, have a try.
Probably yes.
.clang-format - since 0.50
.clang-format-include and .clang-format-ignore - since 0.58
Agree, i don't see either.
But we can both be wrong :)
It is better to test.
@raster, we need your guru-opinion?
Too many different commits. Difficult to to trace the outline.
Think shoud be splitted.
@vtorri, did you see this. Some win32 stuff :)
And where is "Japanese translation", mentioned in title?
Approved for GDM. Use the same patch.
But i'm not sure that it works for other display managers.
To approve changes, they should be tested with
- SDDM
- LightDM
- LXDM
May be…
Would be very appreciated if you could provide a link to the example with the novel meson coding approach.
It is a try to fight with the warning:
* 0.60.0: {'dep 'iconv' custom lookup'}