Summary:
Below bugs are exist in gengrid widget when use horizontal mode and mirrored set.
1. Gengrid item is placed wrong position when mirrored set.
Current calulation for mirroring in _item_place only consider pan object positions.
if widget is mirrored, item should be placed opposited position so object x position must be
consider in mirroring calculation also.
2. Gengrid scroll(pan) minimum size is returned wrong value when mirroed set.
As the result of 1's calculation present oposite position of items, so align also reversed when mirrored.
but current gengrid didn't change align x so minimum size is return wrong value
and scroller expanded wrong direction.
@fix
Test Plan:
1. run elementary_test and set mirroring On
2. run Gengrid2 in elementary_test
3. see how items are placed by push append button repeatly.
4. see scroller shows correct position and items.
5. change usr/bin/test_gengrid.c to set another align value on gengrid and test again.
Reviewers: raster, seoz, Hermet, jaehwan
Subscribers: Jaehyun, anand.km, eagleeye, singh.amitesh
Differential Revision: https://phab.enlightenment.org/D2553
Summary:
There is a code to compare value is changed.
1256: if (sd->val == val) return;
Even value changed the value changed callback didn't called before.
Reviewers: woohyun, shilpasingh, Hermet
Reviewed By: shilpasingh, Hermet
Differential Revision: https://phab.enlightenment.org/D2560
this delays norender and throttle handling to allow for quick
show/hide etc. changes an app may make so to not jump state so often.
this also fixes an issue wqhere config may change leaving all windows
in norender mode.
Summary:
test_glview.c: In function ‘_print_gl_log’:
test_glview.c:347:10: warning: declaration of ‘log’ shadows a global declaration [-Wshadow]
Reviewers: JackDanielZ
Differential Revision: https://phab.enlightenment.org/D2577
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
the paper with earmarked corner and dir in it just doesn't stand out.
too plain and so you can't tell dirs from other files easily at all.
replace with a more normal foler icon that now stands out.
Summary:
When environment variable ELM_ITEM_SELECT_ON_FOCUS_DISABLE is set
_item_focused_next() function doesn't support for ELM_OBJECT_SELECT_MODE_DISPLAY_ONLY mode.
Signed-off-by: Umesh Tanwar <umesh.tanwar@samsung.com>
@fix
Reviewers: raster, Hermet
Subscribers: singh.amitesh, sachin.dev
Differential Revision: https://phab.enlightenment.org/D2464
Summary:
Fileselector button fails to run in inwin mode.
It is caused by incorrect window parent finding.
This patch corrects the window parent finding.
@fix
Test Plan:
run FileSelector Button, toggle Inwin mode option to on,
eo gives error and nothing is shown.
Reviewers: Hermet, seoz
Reviewed By: seoz
Differential Revision: https://phab.enlightenment.org/D2552
Summary:
Updated gengrid to move item selection in 'vertical' mode to the last
item, when currently selected item is not in the last row. As per the
original behaviour, on moving down from such an item, it takes the
focus out of the gengrid widget. Now it is updated to go to the last
item (in last row), and then on further pressing down, focus comes
out of gengrid.
This is something similar to what happens in other UI systems like in
Ubuntu and Windows, when pressing down on (n-1)th row, the last item
in the nth row gets focused.
Signed-off-by: Vaibhav Gupta <g.vaibhav1@samsung.com>
Reviewers: Hermet, SanghyeonLee, raster
Reviewed By: raster
Subscribers: sachin.dev, singh.amitesh
Differential Revision: https://phab.enlightenment.org/D2418
@fix elm_object_cursor_set() to work also when used with the mouse pointer
yet inside the widget, otherwise you need to mouseout/mousein to actually see
the new setted cursor.
Please give a short review on this one, maybe there is a simpler way to check
if the pointer is inside the widget...
Also added a button in the cursor test for this use case
Summary:
When content is resized, scrollbar's position is not updated.
Add bar position update after bar size is changed.
This is sample for resizing issue.
Test Plan: elementary_test -> scroller3
Reviewers: jaehwan, woohyun, seoz, raster, Hermet
Reviewed By: Hermet
Subscribers: raster
Differential Revision: https://phab.enlightenment.org/D2291
Summary:
For instance, ecore_evas sets initial withdrawn state EINA_FALSE if elm_engine is "buffer".
Therefore, the initial withdrawn state is derived from ecore_evas property.
@fix
Reviewers: raster, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2435
Summary:
When entry is resized, selection handlers are not updated,
it causes selection handlers to be placed in wrong position.
This patch fixes it.
@fix
Reviewers: woohyun, seoz, herdsman, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2487
Summary:
Issue: Too many widgets get created during smart add itself, even if
not necessary, adding to the launch time.
Solution:
Create widgets based on mode, check for modes in generic functions
like smart theme, focus etc:-
Test Plan: elementary_test can be used to test colorselector demo.
Reviewers: cedric, raster, Hermet
Subscribers: rajeshps, govi, poornima.srinivasan
Differential Revision: https://phab.enlightenment.org/D2532
Summary: The "closed_height" is not using in code.
Reviewers: raster, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2535
Summary:
check theme of tooltip label by
$clouseau elementary_test -to "tooltip"
tooltipi label theme was elm/label/base/default but we want theme
"elm/label/base/tooltip/default" to be set instead.
@fix
Test Plan: $clouseau elementary_test -to "tooltip"
Reviewers: raster, Hermet
Subscribers: seoz, sachin.dev
Differential Revision: https://phab.enlightenment.org/D2509
Summary:
This uses new Evas Callback type EVAS_CALLBACK_CANVAS_VIEWPORT_RESIZE
to listen to view port size changes.
Reviewers: Hermet, cedric, raster
Reviewed By: raster
Subscribers: SanghyeonLee, seoz
Differential Revision: https://phab.enlightenment.org/D2527
Summary:
elm_object_item_del_cb_set() can set delete callback that is called on item deletion.
Del_cb, Evas_Smart_Cb, has void pointer for item data as its first parameter.
However, getting item data is broken.
@fix
Reviewers: Hermet
Reviewed By: Hermet
Subscribers: Hermet
Differential Revision: https://phab.enlightenment.org/D2524