The -shared option in LDFLAG somehow is poisoning the configure run inside
distcheck. This results in the compiler test getting a segfault and failing.
I would really like to understand why this is needed to be set here manually
anyway. Same for fPIC and dPIC. I would expect that we leave this to the user
compiling the code or the packager. Skimming through the log only brought up
fixing c++11 globally. Not really a commit message that helps me to
understand why this is needed...
Summary: Do not set access info for naviframe prev_btn and next_btn when their access info are already set.
Reviewers: Hermet, kimcinoo
Reviewed By: kimcinoo
Differential Revision: https://phab.enlightenment.org/D1255
The Makefile.am in examples weren't conditioning the compilation of
C++ examples when C++ is disabled in configuration of elementary.
Which made the compilation to fail when --disable-c++11 is
used (in EFL or elementary) on C++ examples.
The example didn't include "elm_interface_atspi_widget_action.h" and
so failed on headers that used the type Elm_Atspi_Action in the
function's prototypes.
Summary:
Main purpose of exposing widget actions and keyboard shortcuts
is to allow accessibility clients to implement alternative methods
of GUI navigation.
Reviewers: z.kosinski
Reviewed By: z.kosinski
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D1227
Don't call ecore_x functions unless we are running under an
X11-compatible engine, else we get segfaults in elm_apps.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
better - why?
1. no reliance on fnmatrch headers - have special enums for this so
fnmatch is an internal detail (casefole may not exist)
2. don't leak strduped strings - free them when done
3. have the same code for genlist and grid (dup for now until an
interface makes it the same search interface)
4. improve docs
5. get right @since version
6. use label get func in item class - providing a func won't work when
multiple items of multiple classes exist in the list
As discussed in IRC, the commit that added text_part_set,
text_part_get functions to elm_button are wrong. The correct functions
to be used are from elm_layout: text_set and text_get.
Fixed the example to use these functions that are inherited on
elm_button from elm_layout and fixed the cleanup of childrens
in the parent window by using the del event callback.
Summary: This function allows user to search for item in Gengrid.
Test Plan: elementary_test -to "Gengrid Item Search By Text"
Reviewers: seoz, singh.amitesh, Hermet, raster
Differential Revision: https://phab.enlightenment.org/D1178
- _ev_handler can't know whether elm_win still exists, so changed log style from notify to printf.
In addition, release the callbacks when elm_win is destroyed.
- use elm_sys_notify_send instead of elm_sys_notify_simple_send to show more functionality.
- remove static variables not to print warnings when with more than two test_sys_notify pannel.
Previously I removed -fPIC from example LDFLAGS and CXXFLAGS. Now
I'm adding "-fPIC -DPIC" to configure.ac conditioned to HAVE_CXX11.
This commit fixes 'make check'.
Summary:
This patch is dependent on D1193 and D1136.
It will be pushed after D1193 and D1136 patch.
Reviewers: singh.amitesh
Differential Revision: https://phab.enlightenment.org/D1168
Conflicts:
src/lib/elm_genlist.c
Summary: When item looping feature is on and press up or down key, screen seems to be frozen.
Test Plan: elementary_test -to "genlist focus" -> click item looing enable -> move list up and down
Reviewers: anand.km, seoz, woohyun
Subscribers: singh.amitesh
Differential Revision: https://phab.enlightenment.org/D1193
elm_test_clock.c:15:23: warning: declaration of ‘clock’ shadows a global declaration [-Wshadow]
elm_test_index.c:15:23: warning: declaration of ‘index’ shadows a global declaration [-Wshadow]
Removed portability warnings from Automake.
Removed *.eo.hh from BUILT_SOURCES.
Fixed some redeclaration of variables.
Added datarootdir and datadir to elementary.pc.in.
The legacy functions do unref after construction of the object. Which
doesn't happen on the eo_add calls directly. So it is needed to do
two unref's before letting the parent own the child.
C++ compilers refuse to compile typedefs for types not declared yet.
The typedefs in the elm_interface_atspi_accessible.h were out of order
with the definition (and consequently its declaration) of its struct.
This fixes by modifying the order of the typedefs to be after the
struct definition.
Summary:
elm_test_atspi adjusted to recent internal api changes. Tests regarding elm_win
moved from elm_test_atspi to elm_test_win. Entry tests fixed. Test to
Atspi_Selection interface temporary skipped.
Reviewers: z.kosinski
Reviewed By: z.kosinski
Differential Revision: https://phab.enlightenment.org/D1199
Summary: This is required to support the animation of focus highlight object in case of item looping (genlist/gengrid/list).
Reviewers: seoz, woohyun, raster
Reviewed By: raster
Subscribers: anand.km, seoz
Differential Revision: https://phab.enlightenment.org/D1136
Summary: First item of widget should be focused when focus comes to the widget for first time.
Test Plan:
elementary_test -to "Genlist Focus"
elementary_test -to "Gengrid Focus"
elementary_test -to "List Focus"
elementary_test -to "toolbar Focus"
Reviewers: seoz
Differential Revision: https://phab.enlightenment.org/D1135
@feature
this adds a per-window property of "noblank". this implies turning
offf the screensaver whenever there is a window visible with this
property set on it. only x11 support atm.
Window show call triggers all smart objects' smart calculation
and in case of X11, XMapWindow() is called directly.
Also moved resize of window accordingly.
This fixes the following build warning.
elm_systray.c:294:1: warning: excess elements in struct initializer
[enabled by default]
elm_systray.c:294:1: warning: (near initialization for '_iface_desc')
[enabled by default]
- Removed unselected handling routine. As this is clicked callback,
there will be no unselected status for the clicked item in clicked
callback.
- Removed check for event_info. In the clicked callback, event_info
should be always valid.
- Changed internal variable name for the more item.
- Item based widget should emit this signal. This is good for the
consistency and makes application developers easy to guess.
- Added test case to elementary_test -> toolbar
@feature
in current code, when a list item is selected, "selected" callback is called first
and then focus is set to the item. this is a problem if another widget, popup for instance,
is created on top of the list in the callback function. in such a case, the popup should
get focused (not the list item). this patch fixes it by changing the order.
@fix
When running Enlightenment under Wayland only, during init of E we
make a call to elm_config_all_flush. elm_config_all_flush is making
calls to ecore_x_window function(s) (for setting of elm_profile),
However this causes a crash if the ELM_ENGINE is not one that is
running under X11 (ie: ELM_ENGINE=drm or wayland_*). So to fix this
crash, we will compare the current ELM_ENGINE and see if it is
X11-compatible before making unnecessary (and crashing) calls to
ecore_x_window functions.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Test of elm_fileselector_selected and future tests may have conditional loop
which some flag.
This patch adds elm_test_helper_wait_flag, simple wrapper of the loop with timer
in order to exit the loop when expected callbacks are not called.
Popup has an abnormal parent-child tree as follows, and this patch fixes it.
- when popup is created, it creates a notify as a child and the tree is [parent - popup - notify].
- when popup is visible, it is set as a content of notify and the tree is [parent - notify - popup].
- when popup is hidden, the tree is reverted.
To fix this, I made an internal layout and set it as the content of notify
so that the tree remains as [parent - popup - notify - layout] all the time.
Summary: Add an elm_map example using evas3d. elm_map is shown in 3D or 2D.
Reviewers: cedric, Hermet
Reviewed By: Hermet
Subscribers: cedric, seoz
Differential Revision: https://phab.enlightenment.org/D1120
Summary:
content couldn't be always a elm widget.
After checking whether it's elm widget or not, use widget API
Test Plan:
terminology -> options -> font -> select font and check below error message
ERR<25935>:eo lib/eo/eo.c:603 _eo_call_resolve() in elm_widget.eo.c:8: you called func 'elm_obj_widget_focus_get' (213) which is unknown in class 'Edje_Object'.
Reviewers: raster, cedric, seoz, Hermet
Reviewed By: Hermet
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D1186
Summary:
"focused" and "unfocused" signals are emitted from Win and Widget. This causes
signals duplication when window is unfocused. To avoid this duplication, emission of these
signals is deleted from the Win.
Reviewers: cedric, Hermet, seoz, raster, reutskiy.v.v
Subscribers: reutskiy.v.v
Differential Revision: https://phab.enlightenment.org/D1183
Summary:
hide UP ARROW, when there is nothing to scroll up; otherwise show UP ARROW.
hide DOWN ARROW, when there is nothing to scroll down; otherwise show DOWN ARROW.
hide LEFT ARROW, when there is nothing to scroll left; otherwise show LEFT ARROW.
hide RIGHT ARROW, when there is nothing to scroll right; otherwise show RIGHT ARROW.
Test Plan:
elementary_test-> scroller
check visibility of vertical-UP and vertical-DOWN arrows, when vertical-scrollbar is at position top, bottom or else-where.
check visibility of horizontal-LEFT and horizontal-RIGHT arrows, when horizontal-scrollbar is at position extreme-left, extreme-right or else-where.
Reviewers: raster, seoz, nirajkr, singh.amitesh
Subscribers: sachin.dev
Differential Revision: https://phab.enlightenment.org/D1092
Stefan Schmidt
Daniel Juyung Seo
Daniel Kolesa
Jaehyun Cho
Sanjeev BA
Felipe Magno de Almeida
Lukasz Stanislawski
Zbigniew Kosinski
Cedric BAIL
Chris Michael
Carsten Haitzler
Jyotiprakash Sahoo
Ryuan Choi
Daniel Zaoui
Savio Sena
Anand
Hosang Kim
Tae-Hwan Kim
Jihoon Kim
Savio Sena
Mike Blumenkrantz
Amitesh Singh
Anil Kumar Nahak
Jaeun Choi
Ryuan Choi
ChunEon Park
Tom Hacohen
Shobhit
wonguk.jeong
Kateryna Fesyna
E_counter