@feature
this adds a per-window property of "noblank". this implies turning
offf the screensaver whenever there is a window visible with this
property set on it. only x11 support atm.
Window show call triggers all smart objects' smart calculation
and in case of X11, XMapWindow() is called directly.
Also moved resize of window accordingly.
This fixes the following build warning.
elm_systray.c:294:1: warning: excess elements in struct initializer
[enabled by default]
elm_systray.c:294:1: warning: (near initialization for '_iface_desc')
[enabled by default]
- Removed unselected handling routine. As this is clicked callback,
there will be no unselected status for the clicked item in clicked
callback.
- Removed check for event_info. In the clicked callback, event_info
should be always valid.
- Changed internal variable name for the more item.
- Item based widget should emit this signal. This is good for the
consistency and makes application developers easy to guess.
- Added test case to elementary_test -> toolbar
@feature
in current code, when a list item is selected, "selected" callback is called first
and then focus is set to the item. this is a problem if another widget, popup for instance,
is created on top of the list in the callback function. in such a case, the popup should
get focused (not the list item). this patch fixes it by changing the order.
@fix
When running Enlightenment under Wayland only, during init of E we
make a call to elm_config_all_flush. elm_config_all_flush is making
calls to ecore_x_window function(s) (for setting of elm_profile),
However this causes a crash if the ELM_ENGINE is not one that is
running under X11 (ie: ELM_ENGINE=drm or wayland_*). So to fix this
crash, we will compare the current ELM_ENGINE and see if it is
X11-compatible before making unnecessary (and crashing) calls to
ecore_x_window functions.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Test of elm_fileselector_selected and future tests may have conditional loop
which some flag.
This patch adds elm_test_helper_wait_flag, simple wrapper of the loop with timer
in order to exit the loop when expected callbacks are not called.
Popup has an abnormal parent-child tree as follows, and this patch fixes it.
- when popup is created, it creates a notify as a child and the tree is [parent - popup - notify].
- when popup is visible, it is set as a content of notify and the tree is [parent - notify - popup].
- when popup is hidden, the tree is reverted.
To fix this, I made an internal layout and set it as the content of notify
so that the tree remains as [parent - popup - notify - layout] all the time.
Summary: Add an elm_map example using evas3d. elm_map is shown in 3D or 2D.
Reviewers: cedric, Hermet
Reviewed By: Hermet
Subscribers: cedric, seoz
Differential Revision: https://phab.enlightenment.org/D1120
Summary:
content couldn't be always a elm widget.
After checking whether it's elm widget or not, use widget API
Test Plan:
terminology -> options -> font -> select font and check below error message
ERR<25935>:eo lib/eo/eo.c:603 _eo_call_resolve() in elm_widget.eo.c:8: you called func 'elm_obj_widget_focus_get' (213) which is unknown in class 'Edje_Object'.
Reviewers: raster, cedric, seoz, Hermet
Reviewed By: Hermet
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D1186
Summary:
"focused" and "unfocused" signals are emitted from Win and Widget. This causes
signals duplication when window is unfocused. To avoid this duplication, emission of these
signals is deleted from the Win.
Reviewers: cedric, Hermet, seoz, raster, reutskiy.v.v
Subscribers: reutskiy.v.v
Differential Revision: https://phab.enlightenment.org/D1183
Summary:
hide UP ARROW, when there is nothing to scroll up; otherwise show UP ARROW.
hide DOWN ARROW, when there is nothing to scroll down; otherwise show DOWN ARROW.
hide LEFT ARROW, when there is nothing to scroll left; otherwise show LEFT ARROW.
hide RIGHT ARROW, when there is nothing to scroll right; otherwise show RIGHT ARROW.
Test Plan:
elementary_test-> scroller
check visibility of vertical-UP and vertical-DOWN arrows, when vertical-scrollbar is at position top, bottom or else-where.
check visibility of horizontal-LEFT and horizontal-RIGHT arrows, when horizontal-scrollbar is at position extreme-left, extreme-right or else-where.
Reviewers: raster, seoz, nirajkr, singh.amitesh
Subscribers: sachin.dev
Differential Revision: https://phab.enlightenment.org/D1092
atspi d-bus signals have similar signatures, however use dbus variant type
to encode signal specific data. This patch adds utility function to construct
atspi dbus signal with custom variant data.
Summary:
- Added Elm_Gengrid_Reorder_Type enum
- Added API elm_gengrid_reorder_type_set()
- Implemented the normal reorder type animation
- The old reorder type is changed to ELM_GENGRID_REORDER_TYPE_SWAP.
- ELM_GENGRID_REORDER_TYPE_NORMAL is the default reorder type.
Test Plan:
1. elementary_test->"Gengrid Focus"
2. Enable "Reorder Mode Enable"
3. Move the items by keys
@feature
Reviewers: raster, seoz
CC: seoz, chinmaya061, aryarockstar
Differential Revision: https://phab.enlightenment.org/D813
Summary:
When a wayland client requests selection_set, Wayland server doesn't care and doesn't know how long source data is.
so, it cannot ignore request for selection_set about empty buffer.
therefore to avoid copying empty buffer, it need to check length of buffer before request selection_set.
Test Plan:
1. Run "elementray_test -to entry5" with wayland server.
2. Drag text and try to paste.
3. Drag empty area in entry (request for selection_set on empty buffer is rejected)
4. Try to paste (you can see text of step 2).
Reviewers: devilhorns, raster, seoz
CC: gwanglim
Differential Revision: https://phab.enlightenment.org/D1146
Summary:
Change-Id: I94e3d39286df830ef07ed2bda0ec87fce34cec4a
Bug: T1354
Signed-off-by: Philippe Coval <philippe.coval@open.eurogiciel.org>
hotfix: look for versionned edbus lib
Without EFL application linked with edbus (deprecated DBUS API)
will fail to run and report this log :
CRI<12610>:dialer dialer/rc.c:442 \
rc_init() Elementary does not support DBus.
CRI<12610>:dialer dialer/main.c:166 \
elm_main() Could not setup remote control via DBus.
Bug: T1354
Change-Id: Id05ba2b5282243ccb566fc7b1ffb4b1e114004b1
Signed-off-by: Philippe Coval <philippe.coval@open.eurogiciel.org>
Test Plan: Bug-Tizen: TIVI-3234
Reviewers: cedric
Reviewed By: cedric
CC: cedric
Differential Revision: https://phab.enlightenment.org/D1116
Signed-off-by: Cedric BAIL <c.bail@partner.samsung.com>
This implements scrollable interface in elm_panel so that users can drag open/close panel.
Tap & hold on the edge and panel handler will appear.
Left scrollable panel is implemented in elementary_test > Panel Scrollable.
@feature
Summary:
The bug was there when reorder mode and sd->horizontal mode is enabled but item_loop_enable
is not set, then also the loop was occuring with right key event.
Test Plan: elementary_test -to "gengrid 2"
Reviewers: raster, seoz, eagleeye, SanghyeonLee
CC: seoz
Differential Revision: https://phab.enlightenment.org/D1121
Summary: API to get list of ctxpopup items and give the possibility to iterate the ctxpopup items
Reviewers: stanluk, z.kosinski, Hermet, seoz, raster
CC: Hermet, seoz
Differential Revision: https://phab.enlightenment.org/D1055
Summary: The focus of genlist should adjust its position on resizing(shrinking).
Reviewers: seoz
Differential Revision: https://phab.enlightenment.org/D1072
this matches the 8edc879cc2 commit in
efl where edje file changed singals are now gone. this creates nothing
but trouble. please see the efl commit log for details.
This implements scrollable interface in elm_panel so that users can drag open/close panel.
Tap & hold on the edge and panel handler will appear.
Left scrollable panel is implemented in elementary_test > Panel Scrollable.
@feature
elm_widget_tree_unfocusable_set with EINA_TRUE sets focus to the newest
focused object. If prev item is tree_focusable, one of its children can
get focus. This focus movement is unexpected, so should not be happened.
The division by zeor could happen when zoom_cnt is zeor OR when region_cnt
is zero. No need for both cases. In the curent implementation this is
impossible as both are hard coded defines. But code changes so we should
handle this.
CID: 1216619
Summary: Added possibility to set the minimum size of the left and right sides.
Reviewers: raster, cedric, seoz, Hermet
Differential Revision: https://phab.enlightenment.org/D998
Summary:
without given state Orca screen reader deafult script interpret
widget as 'grayed out'.
Test Plan: orca screen reader tests on ubuntu 13.10 with orca 3.10.1
Reviewers: raster, seoz, z.kosinski
Differential Revision: https://phab.enlightenment.org/D983
Summary: should do scrollable_content_set according to focus_region_get
Test Plan: None
Reviewers: woohyun
Differential Revision: https://phab.enlightenment.org/D981
Summary:
During drag, dragwin should be rotated when main window is rotated.
@fix
Reviewers: raster, JackDanielZ, woohyun
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D976
Summary:
If focus is set on item content object, it's treated as a
different object which results the focus deadlock. So, every
time whenever focus sets on item content object, we need to
unset and set the focus on genlist object. Thanks to Seoz for
the idea.
Test Plan: elementary_test -to "list focus"
Reviewers: seoz, SanghyeonLee, eagleeye
CC: seoz
Differential Revision: https://phab.enlightenment.org/D973
Summary:
Upon focus set, if the item content object is not of type widget
(could be of type Evas_Rectnagle) focus set/get is not possible.
ERR<17428>:eo lib/eo/eo.c:603 _eo_call_resolve() in elm_widget.eo.c:112: you called func 'elm_obj_widget_can_focus_get' (239) which is unknown in class 'Evas_Rectangle'.
ERR<17428>:eo lib/eo/eo.c:788 _eo_api_op_id_get() in elm_widget.eo.c:212: unable to resolve regular api func 'elm_obj_widget_child_can_focus_get' 0xb75e6f40 in class 'Evas_Rectangle'
Test Plan: elementary_test -to "list focus" (make focus_on_selection enabled and give a right key event when a content object is focused)
Reviewers: seoz, SanghyeonLee, eagleeye
CC: seoz
Differential Revision: https://phab.enlightenment.org/D972
Summary:
Method is required by AT-SPI clients when interface caching is disabled.
Method is not listed in any at-spi specification - found during fixing
clients behaviour.
Reviewers: raster, seoz, z.kosinski
Reviewed By: z.kosinski
Differential Revision: https://phab.enlightenment.org/D971
Summary:
According to the current elm_win code, client side border should be removed
when window is fullscreen mode. And border couldn't be shown on window
during fullscreen mode. When window is going into normal mode from fullscreen,
then display of border should be determined by its borderless state.
1. client border should be shown when window is going into normal mode from fullscreen with borderless state.
2. client border shouldn't be shown when window is going into normal mode from fullscreen with border state.
3. and also client border shouldn't be shown when window is fullscreen mode.
@fix
Test Plan:
1. run elementary_test in wayland server
2. run window states
3. select borderless
4. select fullscreen
5. unselect fullscreen
6. unselect borderless
Reviewers: raster, devilhorns, seoz
Differential Revision: https://phab.enlightenment.org/D988
Summary:
The focus of genlist was coming out of genlist's viewport area on resizing(shrinking).
This is fixed in this patch.
Test Plan: elementary_test -to genlist5, elementary_test -to fileselector
Reviewers: seoz, singh.amitesh, nirajkr
Differential Revision: https://phab.enlightenment.org/D949
Summary:
If item loop is enabled, the item moves infinitely in
horizontal manner (from right to left and from left to
right).
Need to implement:
-for reorder mode and horizontal mode.
@feature
DEPENDs On D841
Test Plan: elementary_test -to gengrid2
Reviewers: seoz, eagleeye, SanghyeonLee, raster
CC: seoz, raster
Differential Revision: https://phab.enlightenment.org/D842
Conflicts:
src/lib/elm_gengrid.c
Summary:
Added fixes for:
1.Normal mode: ELM_FOCUS_DOWN and ELM_FOCUS_UP
2.Horizontal mode: ELM_FOCUS_DOWN and ELM_FOCUS_UP
(i)
1|2|3
4|5|6
7|8|9
_elm_gengrid_item_edge_check for ELM_FOCUS_DOWN returns EINA_TRUE for item no.6.
It should not. Fixed this.
(ii)
1|2|3
4|5|6
7
_elm_gengrid_item_edge_check returns EINA_FALSE for ELM_FOCUS_DOWN
for item no. 5 and 6 but EINA_TRUE for item no. 7.
It should return EINA_TRUE for item no. 5 and 6 instead.
Fixed this.
(iii)
1|2|3
4|
_elm_gengrid_item_edge_check returned EINA_FALSE for ELM_FOCUS_UP
for item no. 3. Fixed this.
(iv)
1|4|7
2|5|
3|6|
Horizontal Mode: _elm_gengrid_item_edge_check returned EINA_FALSE
for ELM_FOCUS_DOWN for item no. 7. Fixed this.
(v)
1|4|7
2|5|
3|6|
Horizontal Mode: _elm_gengrid_item_edge_check returned EINA_FALSE
for ELM_FOCUS_UP for item no. 1. Fixed this.
Test Plan: elementary_test -to gengrid2
Reviewers: seoz, raster
CC: singh.amitesh, raster
Differential Revision: https://phab.enlightenment.org/D841
Conflicts:
src/lib/elm_gengrid.c
Carsten Haitzler
Daniel Juyung Seo
Daniel Kolesa
Jaeun Choi
Stefan Schmidt
Zbigniew Kosinski
Chris Michael
Ryuan Choi
ChunEon Park
Jaehyun Cho
Tom Hacohen
Lukasz Stanislawski
Shobhit
Amitesh Singh
wonguk.jeong
Kateryna Fesyna
E_counter
Jean-Philippe Andre
MinJeong Kim
Yakov Goldberg
Philippe Coval
yinsc
Chinmaya
Cedric BAIL
WooHyun Jung
Michal Jagiello
Anil Kumar Nahak
q66
Hosang Kim
Mike Blumenkrantz
Vyacheslav Reutskiy
Vincent Torri
Thiep Ha
efl
Gwanglim Lee
abhi
Lukasz Stanislawski
efl
maxerba