when insert a new item before/after an item, the relative item should not be NULL.
this patch fixes naviframe, gengrid, genlist, list, and toolbar.
@fix
elm_interface_atspi_widget object was previously used to implement
atspi features on top of elm_widget object. However such inheritance
obfuscates a design, so atspi features implementation was moved directly
into elm_widget code.
This commit is related to 260cdd6150d567fcee8d1afaf690e4b90cd16a2b.
When unrealized item is focused, edje object is not exist,
so genlist cannot read the focus highlight information from edje object.
Therefore, when the item is realized, check the item is focused or not and
need to update focus highlight.
Summary:
When unrealized item is focused, edje object is not exist,
so genlist cannot read the focus highlight information from edje object.
Therefore, when the item is realized, check the item is focused or not and
need to update focus highlight.
@fix
Test Plan: change edc for supporting focus highlight in edc, and set focus on unrealized items.
Reviewers: raster, seoz, jaehwan
Differential Revision: https://phab.enlightenment.org/D2128
Summary:
When an item is realized, select/disable/expand signal emission to the view object of an item was handled correctly,but there are no updating code for focus state.
@fix
Test Plan: tested by editing genlist/genlist item edc to react on elm,state,focused and move scroll signals to unrealized/realized item again.
Reviewers: raster, seoz
Reviewed By: seoz
Subscribers: eunue
Differential Revision: https://phab.enlightenment.org/D2024
there was no way to select an item with key input on ELM_ITEM_SELECT_ON_FOCUS_DISABLE mode.
this patch enables select and multi select with enter/space key input.
@fix
Summary:
Eina_List from elm_gengrid_realized_items_get must be freed by caller,
but elm_gengrid_realized_items_update doesn't free Eina_List.
So memory leak is happens.
@fix
Test Plan: Call elm_gengrid_realized_items_update repeatly and check memory share increase.
Reviewers: raster, seoz
Differential Revision: https://phab.enlightenment.org/D1903
Summary: When gengrid reordering by thumb scroll, some items disapear on screan.
Test Plan:
1. Enabled thumb scroll in elm config
2. Launch gengrid test in elementary_test
3. Check reorder mode enabled
4. Try to move reordering item to upon or lower area by thumb scrolling,
items disapear.
Reviewers: seoz, raster
Reviewed By: raster
Subscribers: bluezery
Differential Revision: https://phab.enlightenment.org/D1852
Summary:
Originally, key "Left" is mapped elm_gengrid_item_prev_get. But when gengrid is mirrored, key "Left" should remap elm_gengrid_item_next_get.
So I add more condition for checking mirroring.
1. reverse Left and Right key event
2. fix _elm_gengrid_item_edge_check logic
3. fix _item_show_region logic
Test Plan: elementary_test -> gengrid
Reviewers: SanghyeonLee
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D1381
Conflicts:
src/lib/elm_gengrid.c
Summary:
If item_loop is not enabled, the focus highlight should move to nearest visible object
with key events.
Test Plan: elementary_test -to "gengrid 2"
Reviewers: seoz, raster
Subscribers: sachin.dev, seoz
Differential Revision: https://phab.enlightenment.org/D1261
Summary:
Change requested by TAsn. Previuosly AT-SPI headers were kept private
and included directly into elementary source code. From now on,
AT-SPI headers can be included from Elementary.h public header, however
will be marked as beta APIs.
Commit includes following changes:
* include all atspi headers into new elm_interfaces.h header.
* marking all at-spi interfaces methods/properties as @protected.
* wrap all common headers with EFL_BETA_API_SUPPORT.
* make some common APIs visible in lib, by adding EAPI attribute
(if someone decides to use beta APIs).
Test Plan: out-off tree build with gcc, g++
Reviewers: tasn
Reviewed By: tasn
Subscribers: seoz, q66, kuuko
Maniphest Tasks: T1721
Differential Revision: https://phab.enlightenment.org/D1528
eo_add()'s counterpart is eo_del, not eo_unref. Regardless of that, some
objects were being double-deleted which spew out some eo errors. These
things should now be fixed.
bc6b6aa457 is the relevant EFL commit.
Summary:
If gengrid select mode is not ELM_OBJECT_SELECT_MODE_ALWAYS, ELM_OBJECT_SELECT_MODE_ALWAYS mode for
elm_genlist_item_select_mode was broken. In the item select routine, item mode(it->mode) was not checked.
So, I added the check routine there.
@fix
Test Plan: I revised the elementary_test code and tested with that.
Reviewers: raster, seoz
Reviewed By: seoz
Subscribers: SanghyeonLee, bluezery
Differential Revision: https://phab.enlightenment.org/D1372
Summary:
elm_widget calls _item_del_pre_hook of each widget and widget can
decide item deletion by return type. But gengrid and popup widget implemented
those _item_del_pre_hook function as a void type.
So this commit fixs the return types to Eina_Bool and changes gengrid widget to return EINA_FALSE when
the item wants to be deleted later.
And when the item wants to be deleted directly, it returns EINA_TRUE.
@fix
Test Plan: test in demo.
Reviewers: seoz, raster, bluezery
Subscribers: Hermet, jaehwan
Differential Revision: https://phab.enlightenment.org/D872
this was yet another thing broken by the mostly-unreviewed and untested widget item focus feature. it's still not completely fixed, since the reorder modes are broken, but at least it works for the general case again
@fix
@fix
To calc the position in a table you need to make the modulo of the col/row size, not the modulo on the x/y value
This unbreak the elm_gengrid_item_pos_get() function that was reporting wrong values
Summary:
Main purpose of exposing widget actions and keyboard shortcuts
is to allow accessibility clients to implement alternative methods
of GUI navigation.
Reviewers: z.kosinski
Reviewed By: z.kosinski
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D1227
better - why?
1. no reliance on fnmatrch headers - have special enums for this so
fnmatch is an internal detail (casefole may not exist)
2. don't leak strduped strings - free them when done
3. have the same code for genlist and grid (dup for now until an
interface makes it the same search interface)
4. improve docs
5. get right @since version
6. use label get func in item class - providing a func won't work when
multiple items of multiple classes exist in the list
Summary: This function allows user to search for item in Gengrid.
Test Plan: elementary_test -to "Gengrid Item Search By Text"
Reviewers: seoz, singh.amitesh, Hermet, raster
Differential Revision: https://phab.enlightenment.org/D1178
Lukasz Stanislawski
Jaeun Choi
Jaehwan Kim
SangHyeon Lee
Tom Hacohen
VBS
Amitesh Singh
Davide Andreoli
Daniel Juyung Seo
Hosang Kim
Chinmaya
Daniel Zaoui
Jae Yong Hwang
zmike
Carsten Haitzler
Jyotiprakash Sahoo