Summary:
Evas map was not updated when text was updated.
@fix
Test Plan:
1. Run the following test case.
elementary_test -to "efl.ui.textpath"
2. Toggle short text.
3. See a long line from the end of text which is wrong.
If you change angle, Evas map will be updated properly.
But, it should be updated when text is updated.
Reviewers: raster, cedric, thiepha, Hermet
Reviewed By: Hermet
Subscribers: Hermet, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6216
in the process of fixing a bug in elm config i found the eet will
decode junk data with a null edd. check for these where it was missing
and return null so it's easier to see a problem. not really a fix as
it's invalid use of the api, but it's nicer to debug...
This reverts commit 7b80038fa7.
JackDanielz asked nicely, but this hasn't been reverted. As this
totally breaks enlightenment (it's black) and this happens on
everythng I've tested (1 laptop, desktop and Xephyr) I'm calling this
patch a dud.
Now... what kind of review is going on here? This hasn't been tested.
What kind of review doesn't build + run things?
for the reasons of poor review and massive horribler fully complete
desktop like breakage ... this gets reverted as master should not be
broken like this.
Summary:
The round value was not being applied when input the value as an internal entry.
@fix
Test Plan: elementary_test -> spinner sample.
Reviewers: cedric, woohyun, Jaehyun_Cho
Reviewed By: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D5843
Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
drawing a non-override window before receiving a configure event results
in an unsized window, breaking spec. it also prevents ecore-evas resize
callbacks from triggering, yielding undefined returns from functions which
attempt to get the geometry of the ecore-evas
fix T6907
Reviewers: cedric, raster
Reviewed By: cedric
Subscribers: #committers, vtorri
Tags: #efl
Maniphest Tasks: T6907
Differential Revision: https://phab.enlightenment.org/D6019
Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
This reverts commit f37b96a1de.
as pointed out in D5957, this would break use of theme_set during the
efl_add constructor once this is implemented in the future
Reviewers: raster, cedric
Reviewed By: cedric
Subscribers: #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6146
Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
4976f1fc5276835940610b72ca4fa48776fc9410 erroneously flipped the
bool flag on this call, accidentally creating another object during
deletion which is illegal now as the notify object is now unparented
at this point which will result in a CRI error
this call was never required in the first place as the corresponding
layout object would have been deleted automatically due to widget parenting
@fix
Reviewers: cedric
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6147
Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
_edje_part_fetch() function gets an Edje which has the requested Edje_Real_Part.
Basically, it gets main Edje of the given object.
But, if a requested part is in a GROUP part, it gets the Edje of GROUP part.
It shouldn't be passed to _edje_efl_text_text_get() function directly.
@fix
Test Plan: N/A
Reviewers: herdsman, raster, cedric, woohyun
Reviewed By: cedric
Subscribers: #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6149
Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
The efl_gfx_color interface was not applied properly.
The implementation code of evas_object_smart_color_set was moved
to efl_gfx_color_set implementation code. But, these two functions are not same.
In efl_gfx_color_set impl, it has to call super's color set to apply
the given color values to widget object itself.
This bug caused color_set/get test failure and the following bug.
1. elm_image_add
2. evas_object_color_set
3. elm_image_file_set
4. show. See the given color is not applied. It was applied in the past.
Test Plan: color_set/get to elm_image object is included in test suite.
Reviewers: raster, cedric, herdsman, woohyun
Reviewed By: cedric
Subscribers: #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6163
Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
cl->socket is a Efl.Net.Socket_Simple. it is not inherit the Efl.Loop.fd class.
and The target of the class check have to be the inner_socket.
But inner_socket is Efl.Net.Socket_Ssl. Efl.Net.Socket_Ssl class is not inherit FD class.
Efl.Net.Socket_Tcp is inherit Efl.Loop.fd class. So, Need to add Efl.Net.Socket_Tcp to inheritance.
(The server side is a similar hierarchy. (ssl -> tcp -> ip -> fd))
Test Plan: N/A
Reviewers: cedric, jypark, myoungwoon, zmike, barbieri
Reviewed By: cedric
Subscribers: #committers, bowonryu, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6168
Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
1. Scroller in scroller case, callback process should continue.
If child scroller does not scroll, parent scroller should be checked whether scroll or not.
So returning EINA_TRUE is necessary.
2. down.dragged flag is always EINA_FALSE, so scroll is never unlocked.
@fix
Test Plan:
precondition
elementary_config -> scrolling -> Set Scroll Smooth Amount to 0
elementary_test -> pagescroller
Reviewers: woohyun, zmike, singh.amitesh, cedric
Reviewed By: cedric
Subscribers: #committers, cedric, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6187
Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
It was missing setting the 'is_ref' parameter to 1 to mirror the
internal_start call.
Test Plan: make check
Reviewers: cedric
Subscribers: #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6193
Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Also changed the previously failing tests to use ck_assert_int_eqinstead
of fail_if for better reporting.
Test Plan: make check
Reviewers: cedric, felipealmeida
Reviewed By: cedric
Subscribers: #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6194
Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
There was wrong logic for calculating # of slices, dt, dist of each segment.
It caused bad rendering quality by putting too much slices on small text.
In addition, textpath didn't care about smoothness of curve's slope changing.
The patch fixes to check differences of previous points and next points for Evas Map.
So, textpath can show more smoothly curved text.
Also, it fixes "autofit" bug when text is much huge than given circle's size.
@tix
Test Plan:
- I'll attach screenshots for comparing rendering quality.
- To see "autofit" bug.
1. Run the following command.
ELM_ACCEL=gl ELM_SCALE=2.0 elementary_test -to "efl.ui.textpath"
2. Toggle "autofit" check box.
3. See the bug case. Textpath can't show all text properly.
Reviewers: raster, cedric, thiepha
Subscribers: #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6195
Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
Elm.List.Item lifecycle where an exception in Efl. They were trying to prevent the death of
there parent, to avoid dealing with safely walking on items list. This has been on the todo
list for years and is now fixed by this patch.
Ecore_Event can still be in flight while the client get freed by the server.
We are protected agaist that and keep the client partially alive until the event
are processed, but we need to disconnect from the server as soon as possible
as we might outlive the server.
Making wref disapear before the last event require additional work to use
them during the FREE event. As I think we should introduce a wref that
disapear after the invalidate state, it makes sense to move that to a later
stage. Especially because their is no specific event related to them
being set to NULL.
Youngbok Shin
YeongJong Lee
Carsten Haitzler
Cedric BAIL
Woochan Lee
Mike Blumenkrantz
Bryce Harrington
junsu choi
Hosang Kim
Lauro Moura
WooHyun Jung
Cedric Bail