Commit Graph

10367 Commits

Author SHA1 Message Date
Daniel Juyung Seo c92b8e19e6 elm: Remove shadow variable declarations. 2015-06-26 10:30:20 +09:00
Daniel Juyung Seo 0891a4d11d edje_externals: Fix wrong free.
_signal is used after free. _signal will be freed soon any way.
This was introduced in 3da3082.

This fixes coverity CID 1308263.
2015-06-26 10:17:33 +09:00
Daniel Juyung Seo a7518cd19d test_win_keygrab: Fix buffer not null terminated error.
This fixes coverity CID 1308264.
2015-06-26 10:08:10 +09:00
Chris Michael 48fd252c94 elementary: Add rudimentary support for Elm Wayland apps to set border icon
Summary: This is a patch to fix T2453 where elm apps in weston/E did
not display the icon on the border. This is just preliminary support
because it only tries to find the efreet desktop file based on
_elm_appname. This support Could be extended to allow efreet to search
based on window title, etc, etc.

@fix

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2015-06-25 13:36:07 -04:00
SangHyeon Lee 9bb528ef09 elm_interface_scrollable: fix wrong mirrored calculation
Summary:
This Patch is regarding D2553, but funtionally independent patch.
D2557 is also related with this patch, so to test working fine,
need to install those all three patches.

1. _elm_interface_scrollable_content_region_show store wx
   into scroll_interface_data without coverting mirrored_x.
   fix to store wx to mirror-converted x if is_mirrored.

2. _elm_scroll_x_mirrored_get return mirroed_x after compare zero not minx.
   so current mirrored_x couldn't be less then 0.
   fix to check min not 0 for set return value.

3.  _elm_scroll_x_mirrored_get calculation need to consider start position of scroller.
some scroller(e.g. gengrid) start from non-zero position, so calculation need to change
like below.
ret = (cw - (x + w - min));

@fix

Test Plan: You can test this after merge D2553 patch and D2557 and test gengrid2.

Reviewers: raster, Hermet, seoz, jaehwan, tanwar.umesh07, cedric

Subscribers: tanwar.umesh07, Jaehyun, anand.km, eagleeye, singh.amitesh

Differential Revision: https://phab.enlightenment.org/D2558

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-25 17:24:08 +02:00
Prince Kr Dubey 782817d6c5 elm_gengrid: fix an overlap issue of item and group item on focus.
Summary: Issue: Gengrid item comes over group item on click.

Test Plan:
Run elementary test.
Open GenGrid Group. Click on any item which slightly overlap with group item.
Item comes over group item.

Reviewers: raster, cedric

Reviewed By: cedric

Subscribers: rajeshps, govi, poornima.srinivasan, shilpasingh

Differential Revision: https://phab.enlightenment.org/D2589

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-25 17:24:08 +02:00
SangHyeon Lee 3d536db3c2 elm_gengrid: fix the bug that gengrid item index(position) is updated wrong value in item_update
Summary:
elm_gengrid_item_update perform item_unrealize/item_realize/item_place itself.
But when gengrid items are added and not calculated yet,
caller want to get item's index after execute elm_gengrid_item_update,
return value is wrong because item_place update it's position in not-updated item's x and y.

to prevent this,
if item position is already updated,
do not updates position in item place.

additionally,
I fixed gengrid item prepend wrong posiiton update.
gengrid item position start from 1 not 0, so item_position_update also must be started from 1.

@fix

Test Plan:
To test this scenario,
need to fix src/bin/test_gengrid.c first.

1. add below codes in bottom of _after_bt_clicked(line 703).

```
      Elm_Object_Item *it = elm_gengrid_item_next_get(id->item);
      printf("before update efl item[%p], index [%d]\n",id->item,elm_gengrid_item_index_get(it));
      elm_gengrid_item_update(it);
      printf("after update efl item[%p], index [%d]\n",id->item,elm_gengrid_item_index_get(it));
```

2. execute elementary_test and go to gengrid2 test.

3. add 3 items and select 2nd item then add new item by insert after.

4. you can see index is changed wrong value after item_update executed.

after add fallback code in item_update,
index is returned same value even after item_update execusion.

Reviewers: raster, Hermet, seoz, jaehwan

Subscribers: anand.km, eagleeye, singh.amitesh

Differential Revision: https://phab.enlightenment.org/D2616

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-25 17:24:08 +02:00
Hosang Kim da81eff897 elm_list & elm_genlist & elm_gengrid: fix the behavior of using the mouse.
Summary:
Elementary widgets have different behavior of using the mouse, they need to be unified.
- swipe : without checking on hold, just checking drag state.
- longpress : after longpress, _item_unhighlight(), _item_unselect() are called.
- select : when the mouse pointer leaves item area, _item_unhighlight(), _item_unselect() are called.

First, apply this commit https://phab.enlightenment.org/D2550

Test Plan: elementary_test -> list

Reviewers: seoz, Hermet, CHAN, woohyun, kimcinoo, jaehwan, SanghyeonLee, cedric

Reviewed By: cedric

Differential Revision: https://phab.enlightenment.org/D2622

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-25 17:24:08 +02:00
Hosang Kim 126fb18ca9 gengrid: add unhighlight callback
Summary:
item_unselect check it->select status, so when item highlighted but not selected,
item highlight is remaining even after unselect_cb is called.

And item_select and item_highlight are separated, but item_unselect and item_unhighlight are mixed.
so divide them, too.

This patch will solve upon problem.

Reviewers: seoz, woohyun, Hermet, CHAN, raster, SanghyeonLee, cedric

Reviewed By: cedric

Differential Revision: https://phab.enlightenment.org/D2653

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-25 17:24:08 +02:00
SangHyeon Lee d700a9b86f gengrid: add item cache in gengrid for efficient realize/unrealize operation.
Summary:
gengrid realize/unrealize items each smart calculation if their posiiton is updated.
This concept will be occurred useless view object creation and deletion.
So instead of delete items in unrealize function, push item cache into cache list,
and pop item cache from cache list in realize function to reuse item view object
more efficiently.
the cache concept is already implemented in genlist widget and this patch is improved
item cache of genlist cache.
@feature

```
NOTICE: This patch is written under the D2561 Patch which add elm_gengrid_item_fields_update.
        So it must submitted after D2561.
```

Test Plan:
I've tested below three cases,
   1. tested ith this patch in elementary_test and checked all gengrid features are working properly.
   2. tested with changing CACHE_MAX to another value which is set 40 in default
       and checked all gengrid features are working properly.
   3. tested with set it->item->nocache true, and checked cache is never generated
       and checked all gengrid features are working properly.

Reviewers: raster, Hermet, seoz, jaehwan, singh.amitesh

Subscribers: eagleeye, singh.amitesh, Jaehyun

Differential Revision: https://phab.enlightenment.org/D2641

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-25 17:24:08 +02:00
godly.talias 7ee4a5b8b1 elm_spinner: add feature in spinner to change values while dragging relative to the speed of dragging
Summary:
Currently the values in spinner change while dragging only based on
the amount of pixels dragged, this patch will enable Spinner to change value
based on the speed of dragging so that it will be more user friendly. This
will help users to alter drag values by big amounts if dragged in a good speed.

Test Plan: test_spinner.c in elementary_test

Reviewers: raster, prince.dubey, shilpasingh, cedric

Reviewed By: cedric

Subscribers: poornima.srinivasan, rajeshps, govi

Differential Revision: https://phab.enlightenment.org/D2659

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-25 17:24:08 +02:00
Amitesh Singh f10b4eb8d0 genlist/list/win: Revert focus highlight animation when looping is enable
Summary:
  -
  Revert "focus: Added internal widget APIs of focus highlight object of elm window."

    This reverts commit 3f98d71830163a154762f2d16301d720c781b7c5.

  - Revert "List: Focus highlight when loop is enable"
This reverts commit 57ad32a900e71f83441bf7246671b8f16a8ec909.

  - Revert "genlist: Focus highlight when loop is enable"

    This reverts commit 91282a22cba66ee5e7799018d3abe8957fb1b1fa.

Reviewers: seoz, raster, jpeg, SanghyeonLee

Subscribers: anand.km, seoz

Differential Revision: https://phab.enlightenment.org/D2725

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-25 17:24:08 +02:00
Youngbok Shin d79b4c0055 calendar: show days of prev/next month.
Summary:
Show days of previous and next month on the blank area of calendar.
@feature

Test Plan: See calendar widget on elementary_test.

Reviewers: raster, seoz, woohyun, cedric

Reviewed By: cedric

Differential Revision: https://phab.enlightenment.org/D2728

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-25 17:24:08 +02:00
Vitalii Vorobiov 32d9ccc76a elm_colorselector: pixel-picker accuracy fix
Summary:
Looking at the base array of pixels,
the real middle of taken picture
is actually number 8 from array of 17 pixels (which starts from 0).

@fix

Reviewers: reutskiy.v.v, raster, NikaWhite, cedric

Reviewed By: NikaWhite, cedric

Differential Revision: https://phab.enlightenment.org/D2749

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-25 17:24:08 +02:00
Vaibhav Gupta f8d1c99e6e focus: fix typo in API Documentation.
Summary: Signed-off-by: Vaibhav Gupta <g.vaibhav1@samsung.com>

Reviewers: raster, Hermet, cedric

Reviewed By: cedric

Subscribers: sachin.dev, singh.amitesh

Differential Revision: https://phab.enlightenment.org/D2767

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-25 17:24:08 +02:00
Daniel Kolesa 3904cc7175 elm: constify Eolian methods correctly because of recent Eolian changes 2015-06-25 12:21:00 +01:00
Thiep Ha 08509f56a2 cnp: remove loss callback when object is deleted
Summary:
SEG_FAULT happens when the object which has selection is deleted,
and new selection is done at another object.
Reason: loss_cb is not removed when the object which has selection is deleted.
When new selection is set for new object, the loss_cb is called for deleted
object. As result, SEG_FAULT happens.

Test Plan:
Run elementary test, open Entry, do selection,
close Entry window, open Entry one more time, do selection.

Reviewers: JackDanielZ

Differential Revision: https://phab.enlightenment.org/D2763
2015-06-25 08:54:36 +03:00
Jaehwan Kim 1e2562700b config: read flush.cfg when elm_config_all_flush is called.
When elm_config_all_flush is called, another processes should get
the config of current process instead of saved base.cfg.
so current process save the config to flush.cfg and another processes
read it when it is changed.

@fix
2015-06-25 14:10:24 +09:00
Umesh Tanwar fd2fca2f9b Scroller : Remove white-spaces in header file.
Summary: Signed-off-by: Umesh Tanwar <umesh.tanwar@samsung.com>

Reviewers: cedric, raster, seoz, Hermet

Subscribers: sachin.dev, singh.amitesh

Differential Revision: https://phab.enlightenment.org/D2741
2015-06-25 13:47:17 +09:00
Umesh Tanwar ddbea82857 Genlist: Test case added in Genlist Focus example.
Summary:
Added test case to enable/disable mouse wheel. Mouse Wheel is
used to scroll the genlist up/down.

Signed-off-by: Umesh Tanwar <umesh.tanwar@samsung.com>

Test Plan: elementary_test -> Genlist Focus -> Wheel Disabled

Reviewers: raster, Hermet, cedric

Subscribers: sachin.dev, singh.amitesh, SanghyeonLee, eagleeye

Differential Revision: https://phab.enlightenment.org/D2757
2015-06-25 13:24:21 +09:00
Daniel Zaoui 50fa3bfe7c X11/CnP: remove X11 invocations from elm_entry
Code specific to X11 should not be part of elm_entry and can be easily
replaced with elm_cnp APIs.

@fix T2183
2015-06-24 08:26:38 +03:00
Daniel Zaoui 185e88db91 CnP: improve loss callback
- Reset loss cb after invocation as it is no more needed
- When selection is set, previous owner loss cb is invoked only
if the new owner and the previous one are different.
2015-06-24 08:26:38 +03:00
Jaehwan Kim 434a133255 config: fix the flush file path.
@fix
2015-06-23 22:58:30 +09:00
Daniel Zaoui 5eeb1f5622 DnD: remove text/uri handling
This type is not a standard type and can be handled as a text/uri-list
of one uri.

@fix
2015-06-23 16:05:47 +03:00
Daniel Zaoui 422e28129e DnD: remove from elm_cnp code specific to elm_entry
The tag insertion has to be done only from elm_entry callback. elm_cnp
is not supposed to know what will be done with the data.
2015-06-23 15:57:02 +03:00
Daniel Zaoui dff887b560 Tests/DnD: fix uri parsing
When no \n is present at the end of the uris list, the function doesn't
return the uri.
2015-06-23 15:55:31 +03:00
woochan lee 4033c8f587 widget: Add a case that elm_layout is an item view object.
Summary:
The internal API "_elm_widget_item_highlight_in_theme()" look like for list item highlight.
but it can use in another widget which has item view as elm_layout.
In that case, ERR log will be printed.

Reviewers: singh.amitesh, Hermet, woohyun

Differential Revision: https://phab.enlightenment.org/D2736
2015-06-23 08:30:22 +09:00
ChunEon Park f641925d6e list: --printf 2015-06-22 21:41:38 +09:00
Cedric BAIL 356220f6d7 examples: fix changes in Evas.Canvas3D namespace. 2015-06-22 12:36:58 +02:00
Amitesh Singh 5583a93c6d elm_genlist: code refractoring of _item_process
Summary:
When item_process is success, then we want to call _item_process_post.
Old code was confusing before.

Reviewers: raster, Hermet, SanghyeonLee

Subscribers: seoz, sachin.dev

Differential Revision: https://phab.enlightenment.org/D2739

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-22 12:36:57 +02:00
Amitesh Singh bb9563c892 elm_genlist: reset timer to NULL on cancel only.
Summary: @fix

Reviewers: raster, seoz, SanghyeonLee

Subscribers: sachin.dev, seoz

Differential Revision: https://phab.enlightenment.org/D2730

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-22 12:36:57 +02:00
Umesh Tanwar 7c71953733 elm_scroller: add wheel_disable_set API
Summary:
This API can be used by widgets like Genlist/Gengrid, which implements
Elm_Interface_Scrollable interface.Mouse wheel is used to scroll up and
down on widget.

@feature

Test Plan: elementary_test -> Scroller -> Wheel Disable

Reviewers: raster, Hermet, cedric, SanghyeonLee, singh.amitesh

Subscribers: JackDanielZ, herdsman, cedric, sachin.dev

Differential Revision: https://phab.enlightenment.org/D2715

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-22 12:36:57 +02:00
Sung-Taek Hong b38c83cd73 elm_colorselector: fix horiz/vertical padding to be affected by base_scale in edc
Summary:
elm_colorselector get its padding size from data in edc.
However, when calculating the padding size, it does not consider
base_scale of the style from where it gets padding size.
In this commit, the padding size from edc is divided by its
base_scale so that desirable size can be calculated.

@fix

Reviewers: Hermet, woohyun

Subscribers: woohyun, Hermet

Differential Revision: https://phab.enlightenment.org/D2721

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-22 12:36:57 +02:00
Prince Kr Dubey cbb9985b9b elm_genlist: fix highlighted items overlap with group item during scrolling and focus when intersect.
Summary: Highlighted genlist item overlap with group item during scrolling and focus when itersect.

Test Plan:
Run elementary_test.
	   open Genlist Group.
	   select one item and try to cross the group item via scrolling.
	   Highlighted item comes over group item.

Reviewers: Hermet, raster, cedric

Reviewed By: cedric

Subscribers: rajeshps, govi, poornima.srinivasan, shilpasingh

Differential Revision: https://phab.enlightenment.org/D2640

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-22 12:36:57 +02:00
Prince Kr Dubey cc2fac3551 genlist: fix Issue "In Tree effect feature, items floates when number of item crosses item block size".
Summary: "In Tree effect feature, during expansion of tree, when total number of items crosses block count, items start floating".

Test Plan: Run elementary_test, open Genlist Tree, keep expanding items untill it crosses number of count 32 (Block count). Resize the window, floting items can be seen.

Reviewers: raster, cedric

Subscribers: shilpasingh, poornima.srinivasan, govi, rajeshps

Differential Revision: https://phab.enlightenment.org/D2627

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-22 12:36:57 +02:00
Minwoo, Lee 9818f2a7d2 elm_entry: modify to not allocate Eina_Rectangle
Summary: modify to not allocate Eina_Rectangle and use it directly on the stack with EINA_RECTANGLE_SET

Reviewers: raster, woohyun, cedric

Reviewed By: cedric

Differential Revision: https://phab.enlightenment.org/D2737

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-22 12:36:57 +02:00
Amitesh Singh a7684bfb5c genlist: fix resize of items when added after elm_genlist_clear().
Summary:
This fixes following issue.

1. Add genlist items
2. Clear genlist by elm_genlist_clear()
3. Append items.
   Genlist items are shrinked. This patch fixes that issue.

@fix
Partially resolves: T2367

Reviewers: Hermet, raster, cedric, raoulh, SanghyeonLee

Subscribers: sachin.dev, seoz

Differential Revision: https://phab.enlightenment.org/D2733
2015-06-22 19:06:21 +09:00
Daniel Zaoui 1776d9b647 DnD: fix usage of TARGETS
- TARGETS notifier is specific to CnP and should not be called for DnD
- On DnD (when drag starts) and on CnP, it doesn't make sense that the TARGETS
type are sent to the potential target. Only basic types should be sent.
2015-06-21 10:14:58 +03:00
Carsten Haitzler 98cb45e77d elm confiug - remove now useless x11 property handling - donr by files
follow on from b1c5de0b9aa67b9d5cc4722e9462830beb3af37b,
aa7f859da10ce007a7b945a8703e70161c96146d
2015-06-18 20:12:04 +09:00
SangHyeon Lee 3304346e37 gengrid: remove duplicated focus state recovering.
Summary:
gengrid focus state recovering in item_realize is duplicated.
remove unnecessary lines.

you can find same signal emit codes under line 1018.

Test Plan: test elemetary test gengrid focus highight show correctly after code merged.

Reviewers: raster, Hermet, seoz, jaehwan, cedric

Reviewed By: cedric

Subscribers: singh.amitesh, eagleeye

Differential Revision: https://phab.enlightenment.org/D2656

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-17 15:59:19 +02:00
Youngbok Shin e8b50f5788 colorselector: add safety check for NULL pointer from ecore_x_image_new().
Summary:
ecore_x_image_new() API can return NULL.
@fix

Reviewers: raster, woohyun, Hermet, cedric

Differential Revision: https://phab.enlightenment.org/D2667

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-17 15:59:19 +02:00
Shinwoo Kim 67b5d368b0 notify: fix prevent issue, dereference null return value
Summary: Fix prevent issue: Dereference null return value

Test Plan: Use static analysis tool such as prevent

Reviewers: raster, woohyun, jaehwan, Hermet

Subscribers: seoz

Differential Revision: https://phab.enlightenment.org/D2669

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-17 15:59:19 +02:00
Hosang Kim 2e123305b4 dayselector : add safety check for NULL pointer from _item_find()
Summary:
It could make crash when _item_find() is failed.
CID - 404129
CID - 402467
CID - 398714
CID - 390012

@fix

Reviewers: raster, thiepha, woohyun, Hermet

Differential Revision: https://phab.enlightenment.org/D2683

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-17 15:59:19 +02:00
Marcel Hollerbach b592c6df35 elm_icon_external: cleanup ERR msg in error case
Summary:
Setting the group without checking it exists causes a errormessage, this
is pretty annoying for people which want to set a standart icon. And
give a better errormessage if the standart setting failed.

Reviewers: raster, cedric

Reviewed By: cedric

Differential Revision: https://phab.enlightenment.org/D2686

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-17 15:59:19 +02:00
Hosang Kim 6d03b2af7e atspi_bridge: fix memory leak issue
Summary:
Call eldbus_message_unref to free Eldbus_Message structure.
And delete unused Eldbus_Message variable.
CID-386474
CID-391869
CID-394549

Reviewers: raster, woohyun, CHAN, Hermet, seoz, lukasz.stanislawski, cedric

Reviewed By: cedric

Differential Revision: https://phab.enlightenment.org/D2690

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-17 15:59:19 +02:00
Vaibhav Gupta a350f64b6e test_gengrid: remove EINA_UNUSED for a used argument
Summary: Signed-off-by: Vaibhav Gupta <g.vaibhav1@samsung.com>

Reviewers: raster, Hermet, cedric

Reviewed By: cedric

Subscribers: sachin.dev, singh.amitesh

Differential Revision: https://phab.enlightenment.org/D2670

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-17 15:59:19 +02:00
Anand dde6511cbc elm_gen_common: fix typo in Struct variable documentation
Reviewers: Hermet, cedric

Reviewed By: cedric

Differential Revision: https://phab.enlightenment.org/D2634

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-17 15:59:19 +02:00
Minwoo, Lee 1f93f2c712 edje_externals: add safety check for NULL pointer
Summary: Dereferencing null pointers in external_signal()

Reviewers: bdilly, raster, woohyun, cedric

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D2688

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-17 15:59:19 +02:00
taehyub f1778f1884 app_server: add null check for dbus_state_set/elm_app_server_views_eet_new
Reviewers: Hermet, woohyun, raster, cedric

Reviewed By: cedric

Differential Revision: https://phab.enlightenment.org/D2705

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-17 15:59:19 +02:00
Vitor Sousa c875a437bd elm_image: Solve clash on the meaning of "animated"
Summary:
Both Elm_Image and its base interface Efl.Image have a property named
"animated".
The meaning for Efl.Image is whether or not the image has animation.
On the other hand, Elm_Image use it to set whether an image, which supports
animation, is to animate itself or not.
Thus Elm_Image have another property (animated_available) to tell whether the
image have animation or not, making it even more confusing.

Renamed the "animated" property of Elm_Image to "animated_enable" to make
the intended meaning clearer.
Also replaced the "animated_available" property with the "animated" property
from the Efl.Image interface, since both refers to the same thing, in order
to reduce the API.

Added implementations of the legacy methods for backward compatibility.

Address the issue:
- Elm image and the image interface clash because of the meaning of "animated".
Specified in the page:
https://phab.enlightenment.org/w/efl_interfaces/

Reviewers: felipealmeida, tasn

Subscribers: raster

Differential Revision: https://phab.enlightenment.org/D2354
2015-06-17 10:17:19 +01:00
Jaehwan Kim 7c67f4e1ba config: fix comment 2015-06-17 17:51:40 +09:00
Jaehwan Kim 290f4fe871 config: make a config directory, if it is not.
create the config directory to register flush file to eio_monitor.
2015-06-17 17:38:24 +09:00
Carsten Haitzler 02cf05265b fix more elm config file pointer access
again - follow up from changes to config code to fix seg
2015-06-17 16:54:08 +09:00
Carsten Haitzler 4089264efb elm config files - don't write to file if file handle is null
fixes seg with new file only config for elm
2015-06-17 16:38:54 +09:00
ChunEon Park 50aceb5a89 win: fix bug about engine value.
When application does not have any value of engine,
this app should be launched with elm_config's value.

Signed-Off-By: Wonsik Jung <sidein@samsung.com>
2015-06-17 13:54:42 +09:00
Mike Blumenkrantz 21f0103397 win: do not use deferred ecore evas deletion for FAKE wins
these ees will be deleted externally anyway

@fix
2015-06-16 17:01:49 -04:00
Mike Blumenkrantz cb37de01f6 win: only trigger del trap if win type is not FAKE
@fix
2015-06-16 17:01:43 -04:00
Thiep Ha dd67ff133f entry: emit changed,user signal when text is pasted or dropped
Summary:
When text is pasted or dropped into entry, the "changed,user" signal
should be emitted, not "changed" signal.
Currently, the "changed" signal is emitted.
This patch fixes this issue.

@fix

Reviewers: herdsman, tasn

Subscribers: tasn

Differential Revision: https://phab.enlightenment.org/D2710
2015-06-16 14:41:55 +01:00
Jaehwan Kim 43cfff4cd5 elm_config: remove X dependency.
Summary:
In wayland, elm_config_all_flush doesn't work.
It has X dependency totally.
It uses ecore_file_monitor instead of X property.

Reviewers: Hermet, devilhorns, raster, cedric

Differential Revision: https://phab.enlightenment.org/D2502
2015-06-16 13:52:24 +09:00
Ji-Youn Park c933ff6f50 elm_flip: small error handle fix
if we cannot create slice, we had better stop to change slice
2015-06-15 22:38:12 +09:00
Jaehyun Cho d8a5472f5b index: Add NULL check for malloc memory allocation. 2015-06-15 15:59:49 +09:00
Jaehyun Cho 9e1968823d layout: Add NULL check for calloc memory allocation. 2015-06-15 15:39:02 +09:00
Jaehyun Cho a67e7e39ef layout: Fix to pass correct argument for edje_object_part_unswallow. 2015-06-15 15:36:09 +09:00
Jaehyun Cho c04635c9b7 layout: Add NULL check for ELM_NEW memory allocation. 2015-06-15 14:56:42 +09:00
Youngbok Shin ed343cbab0 clock: Add safety check for NULL pointer from localtime() func.
Summary:
localtime() can return NULL when there is an error.
@fix

Reviewers: raster, woohyun, Hermet, JackDanielZ

Subscribers: JackDanielZ

Differential Revision: https://phab.enlightenment.org/D2666
2015-06-15 08:17:32 +03:00
Youngbok Shin 6f33f4f1d1 cnp: Add safety check for NULL pointer from malloc().
Summary:
It could make crash when malloc is failed.
@fix

Reviewers: raster, woohyun, Hermet, JackDanielZ, thiepha

Subscribers: JackDanielZ

Differential Revision: https://phab.enlightenment.org/D2671
2015-06-15 08:08:34 +03:00
Youngbok Shin d04e6c7d6a cnp: Fix memory leak issue.
Summary: Call efreet_uri_free() API to free Efreet_Uri structure.

Test Plan: None.

Reviewers: raster, cedric, woohyun, Hermet, thiepha, JackDanielZ

Subscribers: JackDanielZ

Differential Revision: https://phab.enlightenment.org/D2655
2015-06-15 08:05:02 +03:00
ChunEon Park d103e00145 calendar: + null check. 2015-06-15 13:58:02 +09:00
ChunEon Park 150f3b421c clendar: + null check
gmtime can return NULL vaule.
if so strftime will cause crash.

this patch just prevent that potential situation.
2015-06-15 13:39:14 +09:00
Hosang Kim 81ead01597 elm_interface_scrollable : Fix logic about setting EVAS_EVENT_FLAG_ON_HOLD
Summary: Even if scroller is not scrolled, EVAS_EVENT_FLAG_ON_HOLD is set. So clicked event is canceled in Edje.

Test Plan:
On the button in the vertical scroller, click button and move mouse horizontal.
Mouse up on the button, so now button is not clicked

Reviewers: Hermet, CHAN, seoz, jaehwan, woohyun, SanghyeonLee

Differential Revision: https://phab.enlightenment.org/D2550
2015-06-15 09:56:02 +09:00
Daniel Zaoui fcbb42d19b DnD: fix memory leak 2015-06-14 11:23:52 +03:00
Daniel Zaoui 9781aef4bb DnD/X11: Fix invalid access to memory
It seems X doesn't send the data with the termination.
2015-06-14 11:23:52 +03:00
Daniel Zaoui f66224b5f3 DnD/X11: rename notifiers
As the notify functions don't notify anymore, they have to be renamed to
reflect their real job, i.e data preparers before calling user
functions.
2015-06-14 11:23:47 +03:00
Daniel Zaoui b779ae6780 DnD/X11: refactor the notifiers
Each data notifier was preparing data and then invoking the user callbacks
for DnD or selection protocols.
Most of the notifiers code was handling the user callbacks invocation
and was the same for all of them.

This patch simplifies the notifiers by moving the user callbacks
invocation into a common place for all the types, i.e into the notify
dispatcher.
The notifiers prototype has been changed to suit the code modifications.
2015-06-14 11:21:33 +03:00
Daniel Zaoui 271a37f6eb DnD/X11: remove unused function 2015-06-13 12:29:35 +03:00
WooHyun Jung 1ca127d826 fileselector: add NULL check for memory allocation 2015-06-13 15:45:36 +09:00
Thiep Ha 8fe80fc6a3 entry: add dnd image handling
When image is dropped into entry, we should insert image to it.
This patch adds image inserting in dropping.

@fix
2015-06-12 11:53:57 +03:00
Thiep Ha 551074c5f2 Cnp/X11: correct object parameter in datacb
The object parameter in datacb must be the selection request object,
not the selection owner object.
This patch corrects that.

Test case: open two windows with entry, copy text from one entry in
first window, paste to entry in other window.

@fix
2015-06-12 11:53:55 +03:00
Thiep Ha 99ab88c1c7 Cnp/X11: move entry-only code in elm_cnp to entry
There is code in elm_cnp.c which is used to paste data to entry widget only.
This can cause error if widget is not entry.
This patch removes that code in elm_cnp.c and adds datacb to entry
to insert content to entry.

@fix
2015-06-12 11:53:34 +03:00
Thiep Ha 1ee5b72ceb Dnd/X11: add dnd support for image, uri types
There is no dnd callbacks for image, uri types.
This patch adds dnd callbacks for those types.

@fix
2015-06-12 11:45:00 +03:00
Youngbok Shin 61fe7e5f39 cnp: Add safety check for NULL pointer from strdup().
Summary:
It could make crash when strdup() is failed.
CID - 329115
@fix

Reviewers: raster, thiepha, woohyun, Hermet

Differential Revision: https://phab.enlightenment.org/D2673
2015-06-12 11:02:05 +03:00
Youngbok Shin 9fba74ea72 cnp: Add safety check for NULL pointer from calloc() for anim_icon.
Summary:
It could be failed to allocate memory for Anim_Icon.
CID - 337351
@fix

Reviewers: raster, thiepha, woohyun, Hermet

Differential Revision: https://phab.enlightenment.org/D2672
2015-06-12 11:01:55 +03:00
Youngbok Shin e227bad7fe cnp: Add safety check for NULL pointer from _elm_util_text_to_mkup().
Summary:
_elm_util_text_to_mkup() func could return NULL when malloc is failed internally.
CID - 398441
@fix

Reviewers: raster, thiepha, woohyun, Hermet

Differential Revision: https://phab.enlightenment.org/D2668
2015-06-12 10:56:22 +03:00
Ji-Youn Park bda0ccfb60 elm_win: fix keygrab bug to use wrong keygrab mode
The code set worng ecore_x_keygrab mode according keygrab mode.
and changed some codes for readablity.
2015-06-12 11:16:25 +09:00
Daniel Kolesa 2fbe7d5103 eo: migrate all event docs to new syntax 2015-06-11 17:14:02 +01:00
Daniel Kolesa 80f101d420 eo: migrate enum docs to new format 2015-06-11 16:39:33 +01:00
Thiep Ha 8677ef1add widget: Add null check
Summary: Adding NULL checking when allocate memory.

Reviewers: Hermet, seoz, cedric

Reviewed By: cedric

Differential Revision: https://phab.enlightenment.org/D2663

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-11 15:15:35 +02:00
Thiep Ha d9712847be transit: add NULL check for memory allocation.
Summary: Adding Null checking when allocate memory.

Reviewers: Hermet, seoz

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D2662

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-11 15:15:35 +02:00
Lukasz Stanislawski b2ec75db6d list: add atspi SELECTABLE state to elm_list items. 2015-06-11 11:00:27 +02:00
Shinwoo Kim 3a80bbcb41 [layout] support mirrored set for layout which is using elm_layout_file_set()
Summary: mirroed mode does not work, if layout uses elm_layout_file_set().

Test Plan:
the following is test code.
[test.edc]
collections {

   group {
      name: "layout/test";

      parts {

         part {
            name: "bg";
            type: RECT;
               description {
               state: "default" 0.0;
               color: 255 255 0 100;
            }
         }

         part {
            name: "test.rect";
            type: RECT;
               description {
               state: "default" 0.0;
               color: 255 0 0 255;
               rel1.to: bg;
               rel1.relative: 0.2 0.1;
               rel2.to: bg;
               rel2.relative: 0.5 0.2;
            }
         }

      } /* parts */
   } /* group */
} /* collections */

[test.c]
//Compile with:
//gcc -g test.c -o test `pkg-config --cflags --libs elementary`

#include <Elementary.h>
#include <Ecore_X.h>

static void
_bt_click(void *data, Evas_Object *obj, void *event_info)
{
   Eina_Bool mirrored;
   Evas_Object *layout;

   layout = data;

   mirrored = elm_config_mirrored_get();
   mirrored = !mirrored;
   printf("mirred: %d\n", mirrored);
   elm_config_mirrored_set(mirrored);
}

EAPI_MAIN int
elm_main(int argc, char **argv)
{
   Evas_Object *win, *box, *layout, *bt, *check;
   char buf[PATH_MAX];

   elm_app_info_set(elm_main, "elementary", "./test.edj");
   elm_policy_set(ELM_POLICY_QUIT, ELM_POLICY_QUIT_LAST_WINDOW_CLOSED);

   win = elm_win_add(NULL, "Layout", ELM_WIN_BASIC);
   elm_win_autodel_set(win, EINA_TRUE);

   box = elm_box_add(win);
   evas_object_size_hint_weight_set(box, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
   elm_win_resize_object_add(win, box);
   evas_object_show(box);

   // Adding layout and filling it with widgets
   layout = elm_layout_add(win);
   evas_object_size_hint_weight_set(layout, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
   evas_object_size_hint_align_set(layout, EVAS_HINT_FILL, EVAS_HINT_FILL);
   snprintf(buf, sizeof(buf), "./test.edj");
   elm_layout_file_set(layout, buf, "layout/test");
   elm_box_pack_end(box, layout);
   evas_object_show(layout);

   bt = elm_button_add(win);
   elm_object_text_set(bt, "mirrored");
   evas_object_size_hint_weight_set(bt, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
   evas_object_size_hint_align_set(bt, EVAS_HINT_FILL, EVAS_HINT_FILL);
   evas_object_smart_callback_add(bt, "clicked", _bt_click, layout);
   elm_box_pack_end(box, bt);
   evas_object_show(bt);

   check = elm_check_add(win);
   elm_object_text_set(check, "test");
   evas_object_size_hint_weight_set(check, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
   evas_object_size_hint_align_set(check, EVAS_HINT_FILL, EVAS_HINT_FILL);
   elm_box_pack_end(box, check);
   evas_object_show(check);

   evas_object_resize(win, 500, 500);
   evas_object_show(win);

   elm_run();
   elm_shutdown();

   return 0;
}
ELM_MAIN()

Reviewers: seoz, raster, tasn, Hermet

Subscribers: seoz, cedric

Differential Revision: https://phab.enlightenment.org/D2142
2015-06-09 14:05:58 +01:00
Carsten Haitzler e99831eb2f fix list item mode change on elm list
@fix
2015-06-09 16:43:38 +09:00
Carsten Haitzler 5e79a4e211 elm list - theme - make compress moder work again
someone.. somewhere along the way.. likely a long time ago.. broke
compress mode. likely the addition of the ellipsis value as an
ellipsis position or something related to that broke compatibility,
as this used to work. be that as it may... finding out just where is
virtually impossible, so fix it the simpler way - add elipsis values
2015-06-09 16:25:24 +09:00
Stefan Schmidt c7201386e3 test_win_keygrab: Better use strncpy when copying into fixed size buffer.
We should never copy more than PATH_MAX.

CID: 1298016
2015-06-08 17:21:45 +02:00
Lukasz Stanislawski 166d8c2db8 atspi: fix popup role and signal emission 2015-06-05 16:00:30 +02:00
Lukasz Stanislawski dd19750273 entry: improve at-spi2 accessibility support
* return guide text instead of content
* mask passwords
* set proper at-spi roles when entry enables password mode.
2015-06-03 17:38:34 +02:00
Lukasz Stanislawski 27090197cf atspi: fix signal name 2015-06-03 17:38:34 +02:00
taehyub 8bdcdf8cc6 interface scrollerable: modify the loop_v condition in _elm_scroll_momentum_animator() function
Summary:
change the 'sid->loop_v' condition to '!sid->loop_v' to delete momentum animator
when the vertical scroller reached the end of the content

@fix

Reviewers: raster, Hermet, woohyun

Subscribers: CHAN

Differential Revision: https://phab.enlightenment.org/D2609
2015-06-03 21:30:50 +09:00
Vaibhav Gupta bb6ea34e68 Gengrid: Fix typo in API Documentation.
Summary: Signed-off-by: Vaibhav Gupta <g.vaibhav1@samsung.com>

Reviewers: raster, Hermet

Reviewed By: Hermet

Subscribers: sachin.dev, singh.amitesh

Differential Revision: https://phab.enlightenment.org/D2619
2015-06-03 21:19:32 +09:00
Vaibhav Gupta 3118690837 Genlist: Fix typo in API Documentation
Summary: Signed-off-by: Vaibhav Gupta <g.vaibhav1@samsung.com>

Reviewers: raster, Hermet

Reviewed By: Hermet

Subscribers: sachin.dev, singh.amitesh

Differential Revision: https://phab.enlightenment.org/D2620
2015-06-03 21:17:49 +09:00
shilpa.singh cfaf18f967 Elm: Add context,open signal in elm_entry.
Summary:
When context,open signal is sent from elm_entry before showing context
menu, dynamic addition of context menu items to entry becomes easier.

@feature

Test Plan:
Run elementary_test
Launch Entry Scrolled test
Right Click on Multiline Markup entry

Reviewers: tasn

Reviewed By: tasn

Subscribers: subodh6129, poornima.srinivasan

Differential Revision: https://phab.enlightenment.org/D2580
2015-06-03 10:41:13 +01:00
Jaehyun Cho e9eeadd93c examples: Replace setenv() with elm_config_accel_preference_set().
Replace environment value set with elm_config_accel_preference_set.
2015-06-02 19:25:39 +09:00
Jaehyun Cho 64e799d1a7 examples: Replace preferred engine "opengl_x11" with accel preference "3d".
Replace preferred engine "opengl_x11" with accel preference "3d".
2015-06-02 19:22:39 +09:00
Daniel Zaoui 9ab2ab73fe Focus: add and fix comments 2015-06-02 08:46:55 +03:00
WooHyun Jung 52b95670e3 missed from prvious commit 2015-06-02 13:48:09 +09:00
WooHyun Jung 98060bd8da elm_focus: added new focus move policy and elm_object_focus_move_policy_set/get
New focus move policy, ELM_FOCUS_MOVE_POLICY_KEY_ONLY, is added.
If you set this policy as base focus move policy, objects cannot steal
focus by using mouse click or mouse in. Only keyboard input (such as Left,
Right, Up, Down, ...) can make focus be moved.
Additaionally, an object can have its own focus move policy by using
elm_object_focus_move_policy_set API.

@feature
2015-06-02 13:42:00 +09:00
Tom Hacohen d495b6874e Elm widget: Fix some Eolian warnings. 2015-06-01 15:02:05 +01:00
ChunEon Park 689ef74dd6 Revert "Spinner: Add changed callback call when spinner value set."
This reverts commit 8278dff6a742c391f7c04c3de1033574d818dbb6.

This is not good for scenarios and will break the compatibility.

Thanks to David for reporting.
2015-05-29 12:32:02 +09:00
Mike Blumenkrantz 70c1758ed5 tooltip: fix positioning when tooltip is affixed to a window object
@fix
2015-05-28 21:34:49 -04:00
Mike Blumenkrantz 024d76b560 glview: preserved changed state when altering render mode
fixes the case where glview is marked changed and then the render policy
is modified prior to the render callback executing

@fix
2015-05-28 15:36:25 -04:00
Tom Hacohen 9a0d2d172b Adjust according to Eo changes. 2015-05-28 17:48:02 +01:00
Mike Blumenkrantz f085834d1f gengrid/genlist: decrement item counter before triggering item del callback
@fix
2015-05-28 11:59:51 -04:00
SangHyeon Lee 26a9e6cec2 Gengrid: fix mirroring bug in gengrid widget.
Summary:
Below bugs are exist in gengrid widget when use horizontal mode and mirrored set.

1. Gengrid item is placed wrong position when mirrored set.
   Current calulation for mirroring in _item_place only consider pan object positions.
   if widget is mirrored, item should be placed opposited position so object x position must be
   consider in mirroring calculation also.

2. Gengrid scroll(pan) minimum size is returned wrong value when mirroed set.
   As the result of 1's calculation present oposite position of items, so align also reversed when mirrored.
   but current gengrid didn't change align x so minimum size is return wrong value
   and scroller expanded wrong direction.

@fix

Test Plan:
1. run elementary_test and set mirroring On
2. run Gengrid2 in elementary_test
3. see how items are placed by push append button repeatly.
4. see scroller shows correct position and items.
5. change usr/bin/test_gengrid.c to set another align value on gengrid and test again.

Reviewers: raster, seoz, Hermet, jaehwan

Subscribers: Jaehyun, anand.km, eagleeye, singh.amitesh

Differential Revision: https://phab.enlightenment.org/D2553
2015-05-28 23:07:27 +09:00
woochan lee 0301672b4b Spinner: Add changed callback call when spinner value set.
Summary:
There is a code to compare value is changed.
1256: if (sd->val == val) return;

Even value changed the value changed callback didn't called before.

Reviewers: woohyun, shilpasingh, Hermet

Reviewed By: shilpasingh, Hermet

Differential Revision: https://phab.enlightenment.org/D2560
2015-05-28 20:39:32 +09:00
Amitesh Singh 86d31eb47d genlist: do a proper clean up in clear().
Summary: Signed-off-by: Amitesh Singh <amitesh.sh@samsung.com>

Reviewers: raster, Hermet

Subscribers: seoz, sachin.dev

Differential Revision: https://phab.enlightenment.org/D2588
2015-05-28 19:59:22 +09:00
ChunEon Park b7607a499c clipper: removed.
we've discussed and concluded it's unncessary.
2015-05-28 17:41:49 +09:00
Carsten Haitzler da67a05a1c elm - fix profile handling if ELM_PROFILE is set - dont listen to x msg
@fix

don't listen to x profile set msg if ELM_PROFILE env var is used -
this overrides.
2015-05-28 14:58:47 +09:00
Carsten Haitzler 3ad9ee1cc7 elm = fix window norender handling
this delays norender and throttle handling to allow for quick
show/hide etc. changes an app may make so to not jump state so often.
this also fixes an issue wqhere config may change leaving all windows
in norender mode.
2015-05-28 12:27:59 +09:00
Daniel Juyung Seo 07112195e1 examples/evas3d: Use correct variable type for a return value. 2015-05-28 02:05:59 +09:00
Lukasz Stanislawski e483ffa636 gengrid: implement Atspi_Selection interface
Allow to select and deselect gengrid items by Assistive Technology
Clients through org.a11y.atspi.Selection dbus interface.
2015-05-27 08:23:51 +02:00
Anand f61f2ac8b2 test_glview: remove warning while compiling the elementary package
Summary:
test_glview.c: In function ‘_print_gl_log’:
test_glview.c:347:10: warning: declaration of ‘log’ shadows a global declaration [-Wshadow]

Reviewers: JackDanielZ

Differential Revision: https://phab.enlightenment.org/D2577

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-05-26 18:43:12 +02:00
Lukasz Stanislawski 69f5f2ef4c toolbar: implement Atspi_Selection interface
Allow to select and deselect toolbar items by Assistive Technology
Clients through org.a11y.atspi.Selection dbus interface.
2015-05-26 16:31:00 +02:00
Lukasz Stanislawski 1c9b108b8d genlist: implement Atspi_Selection interface
Allow to select and deselect genlist items by Assistive Technology
Clients through org.a11y.atspi.Selection dbus interface.
2015-05-26 15:36:06 +02:00
Umesh Tanwar 4be797c525 Genlist: support of ELM_OBJECT_SELECT_MODE_DISPLAY_ONLY mode of genlist item for ELM_ITEM_SELECT_ON_FOCUS_DISABLE config variable.
Summary:
When environment variable ELM_ITEM_SELECT_ON_FOCUS_DISABLE is set
_item_focused_next() function doesn't support for ELM_OBJECT_SELECT_MODE_DISPLAY_ONLY mode.

Signed-off-by: Umesh Tanwar <umesh.tanwar@samsung.com>

@fix

Reviewers: raster, Hermet

Subscribers: singh.amitesh, sachin.dev

Differential Revision: https://phab.enlightenment.org/D2464
2015-05-22 14:33:11 +09:00
Carsten Haitzler a52bce3a8d elm config - init wl if env vars indicate we should
this ensures event id's are initted and more if we are in wl mode like
in x11 mode

@fix
2015-05-22 12:12:36 +09:00
Amitesh Singh 748bfb5807 test_genlist: Fix warnings while running "Genlist Textblock".
Summary:
'Genlist Textblock' uses message style which does not have elm.swallow.icon
part.

Signed-off-by: Amitesh Singh <amitesh.sh@samsung.com>

Test Plan: elementary_test -to "Genlist Textblock"

Reviewers: raster, Hermet, JackDanielZ

Subscribers: seoz, sachin.dev

Differential Revision: https://phab.enlightenment.org/D2546
2015-05-22 03:42:25 +09:00
Thiep Ha c5014981be fileselector button: correct window parent finding
Summary:
Fileselector button fails to run in inwin mode.
It is caused by incorrect window parent finding.
This patch corrects the window parent finding.

@fix

Test Plan:
run FileSelector Button, toggle Inwin mode option to on,
eo gives error and nothing is shown.

Reviewers: Hermet, seoz

Reviewed By: seoz

Differential Revision: https://phab.enlightenment.org/D2552
2015-05-22 03:35:47 +09:00
Vaibhav Gupta 1488595c1e Gengrid: Updated gengrid to select the last item.
Summary:
Updated gengrid to move item selection in 'vertical' mode to the last
item, when currently selected item is not in the last row. As per the
original behaviour, on moving down from such an item, it takes the
focus out of the gengrid widget. Now it is updated to go to the last
item (in last row), and then on further pressing down, focus comes
out of gengrid.

This is something similar to what happens in other UI systems like in
Ubuntu and Windows, when pressing down on (n-1)th row, the last item
in the nth row gets focused.

Signed-off-by: Vaibhav Gupta <g.vaibhav1@samsung.com>

Reviewers: Hermet, SanghyeonLee, raster

Reviewed By: raster

Subscribers: sachin.dev, singh.amitesh

Differential Revision: https://phab.enlightenment.org/D2418
2015-05-21 18:02:00 +09:00
Daniel Zaoui 8019b970b9 Fix make clean
The problem was that eo files were deleted during make clean.
2015-05-21 10:02:40 +03:00
Aleksey Karmanov f00566ce63 elm_genlist: fix implementation of genlist tooltip functions
Summary:
elm_genlist_item_tooltip_style_get
elm_genlist_item_tooltip_window_mode_get
@fix

Reviewers: artem.popov, myoungwoon, Hermet

Reviewed By: Hermet

Differential Revision: https://phab.enlightenment.org/D2530
2015-05-21 10:22:23 +09:00
Davide Andreoli b735386a45 Immediatly change the cursor if changed from inside the widget
@fix elm_object_cursor_set() to work also when used with the mouse pointer
yet inside the widget, otherwise you need to mouseout/mousein to actually see
the new setted cursor.

Please give a short review on this one, maybe there is a simpler way to check
if the pointer is inside the widget...

Also added a button in the cursor test for this use case
2015-05-20 21:32:08 +02:00
Daniel Kolesa 3a2e56614c eo: remove occurences of @const_get/@const_set 2015-05-20 17:54:54 +01:00
Tom Hacohen c56d494f2f Fix usage of the now removed eo_error_set().
This API has been removed from Eo.
2015-05-20 16:31:42 +01:00
Daniel Zaoui b4f6cf1c8c Adapt Eo classes to use new Eolian types 2015-05-20 16:08:53 +03:00
Daniel Zaoui 7ec8cb336f Move elm_general types to Eolian format 2015-05-20 16:08:53 +03:00
Daniel Zaoui 3cbd0c1da8 Eolian: support of eot file 2015-05-20 16:08:53 +03:00
Tom Hacohen 27b72840c8 Adjust usage of eo_constructor() according to recent changes. 2015-05-20 13:03:28 +01:00
Lukasz Stanislawski 8062db6ab1 atspi: improve way of setting ATSPI SHOWING state
After this patch calculation of the atspi SHOWING state takes into
account also viewport of any parent implementing ELM_INTERFACE_SCROLLABLE.
2015-05-20 12:01:27 +02:00
Daniel Zaoui 5edaf3a9b1 test/scroller: apply coding style. 2015-05-20 09:09:46 +03:00
ChunEon Park bd8aea0eb0 scroller: add example for resizing scroll's content area.
Summary:
When content is resized, scrollbar's position is not updated.
Add bar position update after bar size is changed.

This is sample for resizing issue.

Test Plan: elementary_test -> scroller3

Reviewers: jaehwan, woohyun, seoz, raster, Hermet

Reviewed By: Hermet

Subscribers: raster

Differential Revision: https://phab.enlightenment.org/D2291
2015-05-19 22:00:18 +09:00
Jaehyun Cho 1a08a10f11 elm_win: Set initial withdrawn state from win's ecore_evas property.
Summary:
For instance, ecore_evas sets initial withdrawn state EINA_FALSE if elm_engine is "buffer".
Therefore, the initial withdrawn state is derived from ecore_evas property.
@fix

Reviewers: raster, Hermet

Reviewed By: Hermet

Differential Revision: https://phab.enlightenment.org/D2435
2015-05-19 21:32:11 +09:00
Amitesh Singh 0b7de4a33e hoversel: Added item_focus_set/item_focus_get.
Summary: @feature

Reviewers: seoz, Hermet, raster

Subscribers: seoz, sachin.dev

Differential Revision: https://phab.enlightenment.org/D2436

Conflicts:

	src/lib/elm_hoversel_item.eo
2015-05-19 21:25:39 +09:00
Amitesh Singh 19f90dc5b7 ctxpopup: Added item_focus_set/item_focus_get.
Summary: @feature

Reviewers: raster, Hermet

Reviewed By: Hermet

Subscribers: seoz, sachin.dev

Differential Revision: https://phab.enlightenment.org/D2439

Conflicts:

	src/lib/elm_ctxpopup_item.eo
2015-05-19 21:22:13 +09:00
Thiep Ha 8506c99f26 entry: update selection handlers when entry is resized
Summary:
When entry is resized, selection handlers are not updated,
it causes selection handlers to be placed in wrong position.
This patch fixes it.

@fix

Reviewers: woohyun, seoz, herdsman, Hermet

Reviewed By: Hermet

Differential Revision: https://phab.enlightenment.org/D2487
2015-05-19 21:13:55 +09:00
kumar navneet 6b1d3f0651 Patch to fix accessibility issue in coloselector item.
Summary:
Issue: accessibility not working in colorselector item
Soln: Fixed accessibility issue
Signed-off By: Kumar Navneet <k.navneet@samsung.com>
Signed-off By: Shilpa Singh <shilpa.singh@samsung.com>

Test Plan: export ELM_ACCESS_MODE=1, run elementary test and test color selector palette item.

Reviewers: cedric, Hermet, shilpasingh, raster

Reviewed By: shilpasingh

Subscribers: govi, poornima.srinivasan

Differential Revision: https://phab.enlightenment.org/D2496
2015-05-19 21:09:38 +09:00
Amitesh Singh aa2180941f test_hover.c: remove "transparent" hover style set.
Summary: This hover style does not exist anymore in default theme.

Reviewers: seoz, raster, Hermet

Subscribers: seoz, sachin.dev

Differential Revision: https://phab.enlightenment.org/D2513
2015-05-19 21:06:21 +09:00
Amitesh Singh c714e28f00 slider: use theme of object for popup.
Summary:
@fix

Signed-off-by: Amitesh Singh <amitesh.sh@samsung.com>

Reviewers: raster, Hermet, JackDanielZ

Subscribers: sachin.dev, seoz

Differential Revision: https://phab.enlightenment.org/D2542
2015-05-19 21:02:55 +09:00
shilpa.singh dde6e49e49 [Elm_ColorSelector]: Unnecessary widget creations, code execution avoided.
Summary:
Issue: Too many widgets get created during smart add itself, even if
not necessary, adding to the launch time.
Solution:
Create widgets based on mode, check for modes in generic functions
like smart theme, focus etc:-

Test Plan: elementary_test can be used to test colorselector demo.

Reviewers: cedric, raster, Hermet

Subscribers: rajeshps, govi, poornima.srinivasan

Differential Revision: https://phab.enlightenment.org/D2532
2015-05-19 20:56:48 +09:00
Amitesh Singh 2cd50b4e7f tooltip: set the correct style of label.
Summary:
check theme of tooltip label by
$clouseau elementary_test -to "tooltip"
tooltipi label theme was elm/label/base/default but we want theme
"elm/label/base/tooltip/default" to be set instead.

@fix

Test Plan: $clouseau elementary_test -to "tooltip"

Reviewers: raster, Hermet

Subscribers: seoz, sachin.dev

Differential Revision: https://phab.enlightenment.org/D2509
2015-05-19 18:09:50 +09:00
Daniel Kolesa 5535831733 eo: Eina_Bool -> bool 2015-05-18 16:27:18 +01:00
Daniel Kolesa 23632431bd eo: sync with eolian syntax changes
This change is being done as part of the changes started by
EFL revision 058a9c9d88.
2015-05-18 16:18:24 +01:00
Amitesh Singh b416722303 genlist: track viewport size changes and re-eval items when it resizes
Summary:
This uses new Evas Callback type EVAS_CALLBACK_CANVAS_VIEWPORT_RESIZE
to listen to view port size changes.

Reviewers: Hermet, cedric, raster

Reviewed By: raster

Subscribers: SanghyeonLee, seoz

Differential Revision: https://phab.enlightenment.org/D2527
2015-05-18 20:29:37 +09:00
Amitesh Singh ea8838eb46 entry: No need to free ptr returned by _elm_util_mkup_to_text
Summary:
This is revision over D2459

Signed-off-by: Amitesh Singh <amitesh.sh@samsung.com>

Reviewers: raster, Hermet, JackDanielZ

Subscribers: seoz, sachin.dev

Differential Revision: https://phab.enlightenment.org/D2461
2015-05-18 13:31:41 +03:00
ChunEon Park 74f0424f3e widget: more fix wrt item data.
widget item data is no more used.
use eo item data instead.

@fix.
2015-05-18 17:15:09 +09:00
Jee-Yong Um a522fa1b99 elm_object_item: fix the issue that del_cb doens't get item data as its parameter
Summary:
elm_object_item_del_cb_set() can set delete callback that is called on item deletion.
Del_cb, Evas_Smart_Cb, has void pointer for item data as its first parameter.
However, getting item data is broken.

@fix

Reviewers: Hermet

Reviewed By: Hermet

Subscribers: Hermet

Differential Revision: https://phab.enlightenment.org/D2524
2015-05-18 17:10:09 +09:00
Daniel Zaoui e4e5ccb34d SlideShow: Fix double invocation of ItemClass delete function
When closing the application, the delete function given by the user in
the Item Class was called twice. During the clear process, the function
was called for every built item and then during the item destruction.

This patch fixes this behaviour by calling the user function only during
the item destruction.

Another fix has been added. It zero'es the built list pointer inside the
item. Without this fix, the item points to a list node that is already
freed and can lead during widget deletion to an invalid access inside
the list.

@fix T2394
2015-05-18 08:47:59 +03:00
Amitesh Singh ef01775db8 label: Fix memory leak.
Summary:
Fix memory leak when txt is NULL.

@fix

Reviewers: raster, seoz, Hermet, JackDanielZ

Reviewed By: JackDanielZ

Subscribers: JackDanielZ, seoz, sachin.dev

Differential Revision: https://phab.enlightenment.org/D2460
2015-05-18 08:26:50 +03:00
ChunEon Park 7188d3bfd9 clipper: hide the region_set()/get() APIs.
Provide the simple api as possible.
2015-05-18 13:56:09 +09:00
ChunEon Park 31c24fe745 fix makedist break.
clipper.eo was missed in include list.
2015-05-18 13:30:43 +09:00
Yakov Goldberg 687cd6a310 elm_toolbar: fixing Eolian comment markup 2015-05-17 18:47:10 +03:00
Yakov Goldberg fc245e9dd1 elm_toolbar: Move enums to elm_toolbar.eo
Move enums from elm_toolbar_common.h to elm_tollbar.eo in order to make
them more accessible for bindings.
2015-05-17 16:04:01 +03:00
Yakov Goldberg 2258c0d9ee elm_flip: Move enums to elm_flip.eo
Move enums from elm_flip_common.h to elm_flip.eo in order to make them
more accessible for bindings. Delete elm_flip_common.h.
2015-05-17 16:03:45 +03:00
Yakov Goldberg 21b4fd4d58 elm_scroller: Move enums to elm_scroller.eo
Move enums from elm_scroller_common.h to elm_scroller.eo in order to make them
more accessible for bindings. Delete elm_scroller_common.h.

Moved the include for elm_scroller.eo.legacy.h to the top of elm_scroller_legacy.h
to allow the use of the generated types in the function declarations.
2015-05-17 16:03:45 +03:00
Yakov Goldberg d3750c504f elm_panel: Move enums to elm_panel.eo
Move enums from elm_panel_common.h to elm_panel.eo in order to make them
more accessible for bindings.
2015-05-17 16:03:45 +03:00
Yakov Goldberg 9a70ca3999 elm.win.eo: fixed typo
Change param type name according to eo file: Elm.Win.Keygrab_Mode
2015-05-17 16:03:45 +03:00
ChunEon Park a87ed94604 clipper: improve doc. 2015-05-15 23:31:07 +09:00
jiin.moon 37302c6d5f elementary: Create new widget for image masking
Summary:
For now, if apply image mask to smart obejct, masking does not work except to implement in edc file.
@feature

Reviewers: Jaehyun_Cho, Jaehyun, jpeg, raster, cedric, Hermet

Subscribers: raster, jpeg, cedric

Projects: #elementary

Differential Revision: https://phab.enlightenment.org/D2055
2015-05-15 23:09:42 +09:00
Amitesh Singh 6fb21212f4 theme: return false if elm_object_style_set() failed to set requested style.
Summary:
elm_object_style_set(obj, "XXXX"); should return FALSE if XXXX style does not exist.
Although it does set default style if "XXXX" style does not exist.

@fix

Reviewers: raster, Hermet

Subscribers: seoz, sachin.dev

Differential Revision: https://phab.enlightenment.org/D2511
2015-05-15 19:17:01 +09:00
taehyub 311293f9aa elc_popup: add scroller into popup content area
Summary:
When popup has a content which is larger than window size, popup is to be larger than window.
so, scroller is added into popup content area.

Test Plan:
1. Making "elementary_test - popup" window smaller than popup content size.
2. Excute "popup-center-title + genlist content + 1 button" in "elementary_test popup"
After applying this patch.
3. popup content shows with scroller.

Reviewers: Hermet, seoz, woohyun, raster

Subscribers: raster

Differential Revision: https://phab.enlightenment.org/D2216
2015-05-15 15:10:35 +09:00
Carsten Haitzler ed8e4a0430 elm - tests - fix const warnings with new eina home get func 2015-05-15 12:36:45 +09:00
Amitesh Singh 147c786606 layout: Flush layout resize object's edje signals on focus/unfocus.
Summary: @Fix

Reviewers: cedric, seoz, raster

Reviewed By: raster

Subscribers: kimcinoo, seoz

Differential Revision: https://phab.enlightenment.org/D1913
2015-05-15 12:34:12 +09:00
Carsten Haitzler 83744ad301 elm notify patch submit - rebase lost my fix? fix now in extra commit
somehow a git rebase lost a fix. i don't know how. put back.
2015-05-15 11:26:47 +09:00
Vitalii Vorobiov 7e0fa12710 Elm_Notify: adding elm_object_part_text_set/get functionality
Summary:
Currently elm_notify doesn't allow to set or get text if
user's style contain some text parts and he need to set text into them.

Reviewers: cedric, seoz

Subscribers: raster, stefan_schmidt, reutskiy.v.v

Differential Revision: https://phab.enlightenment.org/D1333
2015-05-15 11:23:25 +09:00
Cedric BAIL b4da061934 elementary: use portable way to get tmp and home environment. 2015-05-14 21:26:44 +02:00
ChunEon Park b371af1d25 genlist: fix to return item style correctly.
Since the genlist items can be unrealized,
they own the tooltip strings in their item field.
Also, the tooltip string should be returned with it.

@fix
2015-05-14 22:21:05 +09:00
Daniel Kolesa 2ccbb06fea eo: fix according to latest eolian changes 2015-05-14 11:27:32 +01:00
Lukasz Stanislawski 927d78d095 atspi: add ACTIVE state to elm_win 2015-05-13 15:39:24 +02:00
Lukasz Stanislawski 31545f69f8 atspi: set FOCUSABLE state only when widget has no focusable children
AT-SPI2 specification states that active window can have only one widget
with FOCUSED state. This differs from elementary design which assumes
that whole elementary widget tree branch is focused.
Patch assumes that if a widget have no focusable children and can have
focus it can be marked as FOCUSABLE on atspi bus.
2015-05-13 15:39:24 +02:00
Lukasz Stanislawski 06f97cd1af atspi: do not return ELM_ATSPI_STATE_ACTIVE when widget is enabled.
According to atspi specification ATSPI_STATE_ACTIVE is reserved
only for windows having keyboard focus.
2015-05-13 15:39:24 +02:00
Lukasz Stanislawski c306271bc3 atspi: handle state change notifications in on_focus function 2015-05-13 15:39:24 +02:00
Ji-Youn Park 8d1a238d1c elm_win: Add elm win key grab. If keyrouter support several keygrab mode, apps can use it. 2015-05-13 20:57:36 +09:00
Daniel Kolesa c075f15d67 eo: sync with latest Eolian changes and introduce a harmless temporary hack 2015-05-12 16:27:09 +01:00
Lukasz Stanislawski 5d61fe27d4 atspi: add component interface to elm_widget_item objects. 2015-05-12 15:31:20 +02:00
Lukasz Stanislawski 0279a91e57 atspi: fix accessible_at_point method to match specification. 2015-05-12 15:24:16 +02:00
Daniel Kolesa 5fdf454ef0 eo: fix up the remaining doc comments 2015-05-11 15:25:29 +01:00
Daniel Kolesa e74cd43c7b elm_widget_item: fix doc comments 2015-05-11 15:11:48 +01:00
Lukasz Stanislawski 7abf897ac0 atspi: more org.a11y.atspi.Window signals is broadcasted. 2015-05-11 15:48:49 +02:00
Vitor Sousa d9174d4bc0 elm_win: Move enums to elm_win.eo
Move enums from elm_win_common.h to elm_win.eo in order to make them
more accessible for bindings.

Moved the include for elm_win.eo.legacy.h to the top of elm_win_legacy.h
to allow the use of the generated types in the function declarations.
2015-05-07 16:00:03 -03:00
Vitor Sousa 06bfb7cb94 elm_win_standard: Add elm_win_standard class
This commit adds the Eolian class elm_win_standard.
It is basically a derivation from elm_win that creates a default background.

The intent is to replace the legacy functions elm_win_util_standard_add and
elm_win_util_dialog_add by functions accessible via Eo API functions such as
eo_add and eo_do.

To fully replace an elm_win_util_standard_add call, use:

  eo_add(ELM_WIN_STANDARD_CLASS, NULL,
         elm_obj_win_name_set("example"),
         elm_obj_win_type_set(ELM_WIN_BASIC),
         elm_obj_win_title_set("Example"));
2015-05-07 15:59:50 -03:00
Vitor Sousa 7d21b7beb1 elm_win: Replace elm_win_constructor by constructing properties
Removed the constructing method elm_obj_win_constructor.
Now "name" and "type" are properties that must be set at creation, like this:

  eo_add(ELM_WIN_CLASS, NULL,
         elm_obj_win_name_set("example"),
         elm_obj_win_type_set(ELM_WIN_BASIC));

Also, the "title" property can be set at creation now.
2015-05-07 13:55:27 -03:00
Daniel Kolesa fd06107d07 eolian: use the new property syntax 2015-05-07 17:32:53 +01:00
Jee-Yong Um 198f086feb elm_genlist: Emitting signal when content or text is set in genlist item
Summary:
There could be a demand for providing subtle different item styles
according to the existence of icon or text swallowed in genlist item.
For example, if icon exists, genlist item shows icon, or show rectangle
where icon should be placed.
One style can have various form with this signal.

Reviewers: Hermet

Subscribers: Hermet

Differential Revision: https://phab.enlightenment.org/D2348
2015-05-07 17:18:45 +09:00
Vitor Sousa a4e9658e70 elm_photocam: use Efl.File in Elm_Photocam
Summary:
Address the issue:
- Elm photocam and the file interface clash on file_set.
Specified in the page:

https://phab.enlightenment.org/w/efl_interfaces/

Reviewers: felipealmeida, tasn

Differential Revision: https://phab.enlightenment.org/D2351
2015-05-06 15:46:46 +01:00
Tom Hacohen 9639418c59 Win: Make animator,tick signal actually work.
This commit also updated one of the elementary test to show
the new one of doing it.

This lets users of the API just add a callback and automatically
get animation ticks. It's done per window, because update rate
may be different for different windows (think different screens).
2015-05-06 15:46:46 +01:00
Vitor Sousa 7b74f29445 Revised classes and interfaces in .eo files and added missing attributes
Summary:
Some newly implemented attributes are not present in several classes and
interfaces.

This patch:
- Adds some attributes (like @nullable, @optional, own, free) to several .eo files.
- Changes some eina types names to the equivalent eolian name (like "Eina_Bool" to "bool")
- Adds the element type of lists and iterators.

Reviewers: felipealmeida, tasn

Reviewed By: tasn

Differential Revision: https://phab.enlightenment.org/D2350
2015-05-06 15:46:46 +01:00
Tom Hacohen efc0d3ef35 Elm image: Use correct Eolian namespace syntax. 2015-05-06 15:46:46 +01:00
Tom Hacohen 8bbdeb3d93 Elm button: Use correct Eolian namespace syntax. 2015-05-06 15:46:45 +01:00
Tom Hacohen f627a65ea9 Most of elm: Use correct Eolian namespace syntax. 2015-05-06 15:46:45 +01:00
Tom Hacohen 63d1667b81 Elm bubble: Use correct Eolian namespace syntax. 2015-05-06 15:46:45 +01:00
Tom Hacohen c5ba34add2 Elm bg: Use correct Eolian namespace syntax. 2015-05-06 15:46:45 +01:00
Tom Hacohen 0316c2630f Elm box: Use correct Eolian namespace syntax. 2015-05-06 15:46:45 +01:00