@fix
The elm image orient_set api looks like it is a state, and it is
documented to SET the orietnation, but the code actually DOEs that
orientation when you set it. so docs and api name didnt match
functionality at all. this was bad an an oversight. you didn't notice
until you set orientation multiple times to an image. this fixes the
implementation to be as documented - a state that is applied and
remains that way until set to something else. setting to the same
orientation has no efect as with color, size, etc. etc. in evas.
you could look on this as an api break, but then either the docs
change AND api name changes to match the code, or code changes to
match the docs. we don't keep bug compatibility in efl and in this
case i'm making the call to break the behavior of a function as it
was broken already with respect to name and docs.
This reverts commit 1879cc39258c63c24f0abcff56558b1f1b60167a.
Hermet, please check this commit it makes Fileselector crash,
looks like you inverted the values: 1 should be EINA_TRUE.
I recommend you to use Exactness to run all the tests automatically.
this is a giant hack to provide widget parenting in e. do not use this function, do not use this type, do not even read the related documentation.
@feature
Summary:
On some systems (e.g. OS X), both Apple's windows manager and X11 can cohabit,
therefore we need to check for the DISPLAY environment variable only when ELM_DISPLAY
is not specified.
Reviewers: cedric, devilhorns, seoz, raster
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D1721
delete genlist item directly.
instead, remove the bunch of code that was related to lazy deletion.
we can success, if we clean up the resources and callback calls properly.
here i only found item focus callback that (may) required the lazy deletion.
This reverts commit fd71874024d14e5374aef93eae7d4cfbc0ea4521.
As the commit message says, the test crashes now. The ticket 1973 is
related to that issue.
Now, I understand there could be a bug inside inline stuff but it doesn't
mean that you have to push it and screw up all the test. You could just
attach a patch to the ticket and that's all folks!
Summary: When gengrid reordering by thumb scroll, some items disapear on screan.
Test Plan:
1. Enabled thumb scroll in elm config
2. Launch gengrid test in elementary_test
3. Check reorder mode enabled
4. Try to move reordering item to upon or lower area by thumb scrolling,
items disapear.
Reviewers: seoz, raster
Reviewed By: raster
Subscribers: bluezery
Differential Revision: https://phab.enlightenment.org/D1852
Summary: Use strncpm, not strcmp to support styles starting with vertical
Test Plan: Define spinner style which has 'vertcial' as a prefix
Reviewers: raster, cedric, seoz, woohyun, jaehwan, Hermet, jpeg
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D1839
Summary:
When elm_object_disabled_set API is called on any widget, All the
subobjects of the widget also has to be disabled issue fix.
@fix
Test Plan:
Call the API elm_object_disabled_set on any container widget like box,
layout etc:-, fix can be tested with test_box.c and test_layout.c test
codes.
Reviewers: Hermet, seoz, raster
Subscribers: govi, rajeshps
Differential Revision: https://phab.enlightenment.org/D1778
Summary:
There was a problem that image is stretched over its size
when elm_image_fill_outside_set() is applied.
This patch fixed that.
@fix
Reviewers: Hermet
Subscribers: Hermet
Differential Revision: https://phab.enlightenment.org/D1854
Summary:
fileselector: redirect keystrokes to the searchbar
Keystrokes like a-z A-Z 0-9 are redirected to the searchbar, so you dont
need to click arround to search files in the fileselector.
The search icon is from ApB (Apostolos B.), thx for that! :)
@feature Improved the searchbar
Reviewers: raster, seoz
Subscribers: ryuan.choi, cedric, seoz
Differential Revision: https://phab.enlightenment.org/D1237
Conflicts:
src/lib/elc_fileselector.c
Summary:
this function is called at least twice: in _smart_add and every time _theme_apply is called.
so we need either correctly free sd->cb_data or reuse it
@fix
Reviewers: seoz, cedric, raster, Hermet
Subscribers: reutskiy.v.v
Projects: #elementary
Differential Revision: https://phab.enlightenment.org/D1841
Summary:
Cause : When part name is NULL, edje_object_part_text_escaped_set is not called.
Measure : Add code for each conditions.
@fix
Reviewers: Hermet
Subscribers: Hermet
Differential Revision: https://phab.enlightenment.org/D1847
Summary:
The idle enterer added even after deleted sd for diskselector.
it makes crash.
@fix
Test Plan:
1. Run elementary_test
2. Execution diskselector.
3. Close diskselector sample window.
4. Crash occured.
Reviewers: Hermet, seoz, Jaehyun
Differential Revision: https://phab.enlightenment.org/D1843
Carsten Haitzler
ChunEon Park
Mike Blumenkrantz
Yakov Goldberg
Jean Guyomarc'h
Daniel Zaoui
vivek
VBS
Shinwoo Kim
shilpa.singh
Jee-Yong Um
Nibha Sharma
Marcel Hollerbach
Nak-Gyeong Kim
woochan lee