Summary:
Added a function print_glerror_log to handle both shaders and programs
logs.
Test Plan: elementary_test -> glview
Reviewers: raster, jpeg, seoz
Reviewed By: seoz
Subscribers: anand.km, seoz
Differential Revision: https://phab.enlightenment.org/D1826
Too much in this case is a fixed 4px. As fingers do not have a right button I think
that taking into account finger size is not needed here.
Also someone argued about the signal name is not really correct...
should I change it to somethig like: clicked,secondary ?
Summary:
A sample for elm_transit_tween mode which can be executed via
"Effects"-"Transit Tween Mode" button in elementary_test
Reviewers: Hermet
Subscribers: Hermet
Differential Revision: https://phab.enlightenment.org/D1817
Summary:
After applying clipping patch about image on outside,
the width or height of the image be decreased
if x or y of an image is less than zero.
The way to calculate width/height has changed.
This fixes a side effect added in 2839881f37ea85b3469d8fd37cfaa4f9d67458fa
Reviewers: Hermet
Differential Revision: https://phab.enlightenment.org/D1810
Summary:
Fix layout broken in ELM_COLORSELECTOR_ALL mode
due to missing part for layout sizing evaluation
@fix
Reviewers: Hermet
Subscribers: Hermet
Differential Revision: https://phab.enlightenment.org/D1802
Summary:
When colorselector widget is added, there are two align set command on palette_box part,
but that for picker part is omitted.
Apply elm_box_align_set function to picker part correctly.
@fix
Reviewers: Hermet
Reviewed By: Hermet
Subscribers: Hermet
Differential Revision: https://phab.enlightenment.org/D1790
Summary:
When resizes an image
if "fill_inside" and "aspect_fixed" in Elm_Image_Data struct are "TRUE",
extra width or height go outside of the object area.
The width or height on outside will be clipped.
@fix
Reviewers: Hermet
Differential Revision: https://phab.enlightenment.org/D1794
Summary:
Pass Elm_Object_Item *item instead of Elm_Widget_Item_Data *item as
*event_info in item->del_func to let *event_info be used.
@fix
Reviewers: Hermet
Differential Revision: https://phab.enlightenment.org/D1788
Summary:
Label widget example that handles "slide,end" signal
When each label ends its slide, it stops and makes next one slide.
Reviewers: Hermet
Subscribers: Hermet
Differential Revision: https://phab.enlightenment.org/D1787
Summary:
As mentioned in TODO replaced expressions in if statement with macros in elm_macros.
Signed-off-by: kabeer khan <kabeer.khan@samsung.com>
Reviewers: seoz, raster
Reviewed By: raster
Subscribers: raster
Differential Revision: https://phab.enlightenment.org/D1424
Summary:
Originally, key "Left" is mapped elm_gengrid_item_prev_get. But when gengrid is mirrored, key "Left" should remap elm_gengrid_item_next_get.
So I add more condition for checking mirroring.
1. reverse Left and Right key event
2. fix _elm_gengrid_item_edge_check logic
3. fix _item_show_region logic
Test Plan: elementary_test -> gengrid
Reviewers: SanghyeonLee
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D1381
Conflicts:
src/lib/elm_gengrid.c
Summary:
Naviframe: modify elm_naviframe_item_pop_to api's document guide more specific to avoid confusion.
the elm_naviframe_item_pop_to api does not pop all items from the top to the target item.
It destory the items between the top and the target item, after that pop and destory the top item.
so, the descriptions of elm_naviframe_item_pop_to() is modified to avoid cunfusion like above.
Reviewers: Hermet, woohyun, seoz
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D1780
Summary:
in this test sample, evas object size hint weight, align set API doesn't need to make view.
and line changed to code consistency.
Test Plan:
1. run elementary_test.
2. execution check test.
3. window resize.
- some objects align to left side of window. in the other hands, some objects align to center of window.
Reviewers: seoz, Hermet
Differential Revision: https://phab.enlightenment.org/D1781
Summary:
If item_loop is not enabled, the focus highlight should move to nearest visible object
with key events.
Test Plan: elementary_test -to "gengrid 2"
Reviewers: seoz, raster
Subscribers: sachin.dev, seoz
Differential Revision: https://phab.enlightenment.org/D1261
Once the window alpha is on, it would not go back to non-alpha window
automatically.
- non-alpha theme -> alpha theme: switch to alpha window
- alpha theme -> non-alpha theme: stay in alpha window
@feature
Summary: pulsing mode doen't work even though called elm_progressbar_pulse function in code , if pulse value is not true.
Test Plan:
1. run elementary_test
2. execution ExtProgressBar sample.
3. click 3rd button to start progressbar.
@fix
Reviewers: seoz, Hermet, woohyun, cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1770
A leave callback is invoked on the drop target of the previous DnD
operation, leading to inconsistency for applications.
The state of the dropable target was not resetted during drop.
This patch fixes that.
- Add more sample items.
- Clear genlist on focus callback only for the specified item.
- Fix broken item index handling
- Remove unnecessary app data structure members.
- Free unused item class.
DISPLAY environment variable may set regardless of Elementary/EFL.
Mostly user has no way to switch their intent engine such as "buffer"
Guarantee work application engine with their intended engine first.
@fix
Summary:
Summary: after popup layout refactoring, the popup object cant get evas event.
when popup using notify object block layout object will be covered with edje object.
it breaks evas smart member relationship.
Test Plan:
Test Plan:
1. added popup object.
2. key down event callback add for popup object.
3. run the elementary_test.
4. input some key on popup and check whether the registered function is executed or not.
Reviewers: eunue, Hermet, seoz
Differential Revision: https://phab.enlightenment.org/D1706
- Remove shadow variable.
- Don't call elm_init() twice. It is called automatically when you use
ELM_MAIN() macro.
- Don't set weight/align to swallowed objects.
- Set weight first before adding the object to window's resize object.
- Show window after creating all of its content.
Summary: This example shows the just using elementary with evas 3D.
Reviewers: cedric, raster, Hermet
Differential Revision: https://phab.enlightenment.org/D1755
this fixes a longstanding race condition where tooltip windowss could exist with a shape rectangle due to race conditions between applying window properties (eg. alpha) and reapplying the input rect
- This is a first clean up of 65240b5327e5ab1eb8f77835b4729444fe1f02df
- Fix wrong version for since tag.
- Fix indentation and remove trailing whitespaces.
- Make the code more readable.
- Remove a unused variable.
Summary:
encoded URI is pasted in terminology on dnd with file which has blank in name
ex. Test Blank.avi -> Test%20Blank.avi
Therefore, decode it when we extract file uris from uri list by using efreet.
by the way, copy and paste code likely needs refactoring..
Reviewers: raster, cedric
Subscribers: billiob, seoz
Differential Revision: https://phab.enlightenment.org/D1384
Summary:
elm_config_slider_indicator_visible_mode_set
elm_config_slider_indicator_visible_mode_get
The patch will enable the slider's indicator to get
visible always
visible on focus
visible never
visible on slider value change
Reviewers: raster, seoz
Subscribers: sachin.dev
Differential Revision: https://phab.enlightenment.org/D1558
Allow changing value of actionslider with keyboard. Make actionslider
focusable widget.
@feature
Conflicts:
config/default/base.src.in
config/mobile/base.src.in
config/standard/base.src.in
Summary: after popup layout refactoring, the popup object cant get evas event.
Test Plan:
1. added popup object.
2. key down event callback add for popup object.
3. run the elementary_test.
4. input some key on popup and check whether the registered function is executed or not.
Reviewers: seoz, eunue, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D1688
The items of an item is a list of Elm_Object_Item and not of Elm_Gen_Item.
Sorry @zmike ;-)
Fixes T1859
Another fix has been added in this commit, related to relative items.
elm_genlist_item_subitems_get has to return a list of Elm_Object_Item.
Because of the porting of the genlist item to Eo, this function returns
a list of Elm_Gen_Item.
Thanks to zmike and seoz for catching this.
Fixes T1859
Summary:
Using of dbus menu causes a weird exception that looks
like this (for example in function elm_win_main_menu_get(Evas_Object *win)):
> EINA: Data at address 0x0 is invalid. Replacing with zero page.
> mmap: Operation not permitted
> ERR<22270>:eina_mmap lib/eina/eina_mmap.c:110 _eina_mmap_safe_sigbus()
> Failed to mmap() /dev/zero in place of page. SIGBUS!!!
> Aborted (core dumped)
This issue appears because there is a lot of places where Elm_Object_Item is
used, but it should be Elm_Menu_Item_Data.
This issue could be reproduced with elementary_test:
1. run elementary test with dbus enabled.
2. find "Systray Item" button and click on it.
3. get SIGSEV in your console.
@fix
Reviewers: cedric, raster, seoz, Hermet
Reviewed By: Hermet
Subscribers: reutskiy.v.v
Differential Revision: https://phab.enlightenment.org/D1681
Summary:
Application do not change step size because only interface API is existed.
@feature
Test Plan: elementary_test -> scroller -> change step size
Reviewers: seoz, Hermet
Differential Revision: https://phab.enlightenment.org/D1677
Summary:
size_hint_align was used instead of evas_box's internal value for aligning
of internal items. Because of that layout functions of elm_box and evas_box
were incompatable
Fixed elm_box, els_box layout and widgets that used this behaviour.
@fix
Test Plan:
Run "elementary_test". All buttons should be left-aligned
"elm_box_align_set(tbx2, 0.0, 0.5);" (test.c:332)
Reviewers: cedric, Hermet, stefan_schmidt, seoz
Reviewed By: seoz
Subscribers: shilpasingh, reutskiy.v.v
Differential Revision: https://phab.enlightenment.org/D1512
This change is not simple because Elementary has not been built from the
first day to work with Eo. Code had to be adapted to fit the new design.
The del_pre that have not been replaced yet can return FALSE and
prevent deletion. For these classes, code modification has to be deeper
and will be done later.
Because of widget item design, it is hard to make it fit to Eo as it
should be:
- _eo_del_cb should have the callback pointer as data but pre_notify
function forces its storage into the item data because we need to be
able to call the cb before del is really triggered.
- only one cb is supported for an item, meaning replacing it would mean
we have to save the function pointer inside the item, delete the
callback with the previous function as data and then add the new
callback. Instead of it, we just add our own wrapper as Eo callback that
will invoke the function pointer stored in the item data.
ChunEon Park
Davide Andreoli
Daniel Juyung Seo
Amitesh Singh
Andrii Kroitor
Mike Blumenkrantz
Jee-Yong Um
jiin.moon
Jaehyun Cho
Stefan Schmidt
kabeer khan
Kairong Yin
Carsten Haitzler
Hosang Kim
Jyotiprakash Sahoo
taehyub
woochan lee
Chinmaya
Sanjeev BA
Anand
Daniel Zaoui
Cedric BAIL
se.osadchy
Wonguk Jeong
Anil Kumar Nahak
Lukasz Stanislawski
zmike
Vitalii Vorobiov