Summary: Since we end up calling free on the event->data parameter
after a drop is completed, we should actually be allocating a string
for this data (to be free'd later). This also fixes an issue where the
event length was not being set.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Summary: This function is expecting Eina_Bool as the return value, not
ints so let's use EINA_FALSE here.
NB: this just fixes a copy/paste issue
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Summary: In order for ecore_wl to start a drag, we need to send the
parent window of the object being dragged. Previous code was not
getting the parent window properly.
NB: This patch also fixes an issue where the data being sent to the
drop callback was being incorrectly sent.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Because not all item block have "max_items_per_block" number of items in it's block.
So the calculation is not correct when items are added & removed in each block.
Anyhow, we need more efficient way for this API because genlist uses inlinst.
Fixes bad drag&drop into entry widgets, since the drop callback
assumed that the dropped text ends with a NULL character.
How to reproduce:
1. Open 'elementary_test -to Entry'
2. Open some application (e.g. Firefox)
3. Select some (preferably short) text, and drag&drop it to the entry
widget. This sometimes pastes additional corrupted text (better try
with a 1-3 characters text).
@fix
This new @feature is just a convenient way to create dialogs, It
mimic the elm_win_util_standard_add() function but crete a
standard dialog, with background and the parent set.
WinDialog test changed to use the new function.
Previous logic was too much stick to special case for *tizen*
let decide item styles in theme as possible.
This might break reorder group item ui, but it won't be critical.
because tizen ui only depeneded on the scenario and they don't use them anymore.
This will be much better for multiple scenario in the future.
Summary:
Item_Data size set as 144 before. but test_gengrid_speed function called create_gengrid function with 5000 items.
it makes crash.
@fix
Test Plan:
1. run elementary_test.
2. click Gengrid update Speed.
3. crash.
Reviewers: seoz, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D1834
Summary:
There is no need to call glVertexAttribPointer &
glEnableVertexAttribArray() while rendering.
Reviewers: seoz, jpeg, Hermet
Reviewed By: Hermet
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D1827
OK, this commit try to fix the mess we have done with icon names in elm.
I just added standard names to icons yet existing in the elm theme, the
old name are, of course, preserved. But I marked them as -deprecated-.
Also added a new test: Icon Standard. It show all the icon that have standard
fdo names. This can be really usefull for user that need to choose icons to use.
I put some guidelines comment in the icons.edc files, I hope people will follow
the rules from now on... or will recive my personal spanking :D
I will work on those icons more in the next days: will add the new names to
elm docs, will try to match better fdo icon names, and maybe also add some
new icons...
Suggestions are always welcome.
@feature (maybe)
Summary:
Fixed to make colorselector have proper min size
when colorselector is in ELM_COLORSELECTOR_PICKER mode
@fix
Reviewers: Hermet
Subscribers: Hermet
Differential Revision: https://phab.enlightenment.org/D1832
Summary:
Added a function print_glerror_log to handle both shaders and programs
logs.
Test Plan: elementary_test -> glview
Reviewers: raster, jpeg, seoz
Reviewed By: seoz
Subscribers: anand.km, seoz
Differential Revision: https://phab.enlightenment.org/D1826
Too much in this case is a fixed 4px. As fingers do not have a right button I think
that taking into account finger size is not needed here.
Also someone argued about the signal name is not really correct...
should I change it to somethig like: clicked,secondary ?
Summary:
A sample for elm_transit_tween mode which can be executed via
"Effects"-"Transit Tween Mode" button in elementary_test
Reviewers: Hermet
Subscribers: Hermet
Differential Revision: https://phab.enlightenment.org/D1817
Summary:
After applying clipping patch about image on outside,
the width or height of the image be decreased
if x or y of an image is less than zero.
The way to calculate width/height has changed.
This fixes a side effect added in 2839881f37ea85b3469d8fd37cfaa4f9d67458fa
Reviewers: Hermet
Differential Revision: https://phab.enlightenment.org/D1810
Summary:
Fix layout broken in ELM_COLORSELECTOR_ALL mode
due to missing part for layout sizing evaluation
@fix
Reviewers: Hermet
Subscribers: Hermet
Differential Revision: https://phab.enlightenment.org/D1802
Summary:
When colorselector widget is added, there are two align set command on palette_box part,
but that for picker part is omitted.
Apply elm_box_align_set function to picker part correctly.
@fix
Reviewers: Hermet
Reviewed By: Hermet
Subscribers: Hermet
Differential Revision: https://phab.enlightenment.org/D1790
Summary:
When resizes an image
if "fill_inside" and "aspect_fixed" in Elm_Image_Data struct are "TRUE",
extra width or height go outside of the object area.
The width or height on outside will be clipped.
@fix
Reviewers: Hermet
Differential Revision: https://phab.enlightenment.org/D1794
Summary:
Pass Elm_Object_Item *item instead of Elm_Widget_Item_Data *item as
*event_info in item->del_func to let *event_info be used.
@fix
Reviewers: Hermet
Differential Revision: https://phab.enlightenment.org/D1788
Summary:
Label widget example that handles "slide,end" signal
When each label ends its slide, it stops and makes next one slide.
Reviewers: Hermet
Subscribers: Hermet
Differential Revision: https://phab.enlightenment.org/D1787
Summary:
As mentioned in TODO replaced expressions in if statement with macros in elm_macros.
Signed-off-by: kabeer khan <kabeer.khan@samsung.com>
Reviewers: seoz, raster
Reviewed By: raster
Subscribers: raster
Differential Revision: https://phab.enlightenment.org/D1424
Summary:
Originally, key "Left" is mapped elm_gengrid_item_prev_get. But when gengrid is mirrored, key "Left" should remap elm_gengrid_item_next_get.
So I add more condition for checking mirroring.
1. reverse Left and Right key event
2. fix _elm_gengrid_item_edge_check logic
3. fix _item_show_region logic
Test Plan: elementary_test -> gengrid
Reviewers: SanghyeonLee
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D1381
Conflicts:
src/lib/elm_gengrid.c
Summary:
Naviframe: modify elm_naviframe_item_pop_to api's document guide more specific to avoid confusion.
the elm_naviframe_item_pop_to api does not pop all items from the top to the target item.
It destory the items between the top and the target item, after that pop and destory the top item.
so, the descriptions of elm_naviframe_item_pop_to() is modified to avoid cunfusion like above.
Reviewers: Hermet, woohyun, seoz
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D1780
Mike Blumenkrantz
Stephen Houston
ChunEon Park
Chris Michael
Davide Andreoli
Daniel Hirt
woochan lee
Amitesh Singh
Daniel Juyung Seo
Jee-Yong Um
Andrii Kroitor
jiin.moon
Jaehyun Cho
Stefan Schmidt
kabeer khan
Kairong Yin
Carsten Haitzler
Hosang Kim
Jyotiprakash Sahoo
taehyub