Patch by Jérôme Pinot <ngc891@gmail.com>.
- #link on the beginning of a new line does give ugly output:
http://ngc891.blogdns.net/pub/projects/debug/doxygen-formating-eww.png
- some typos
- some missing @c
- in elm_web, convert remaining @li parameter lists to @param
- minor random fixes
SVN revision: 71486
window representation.
The attached change to Elementary makes a small refactor to use
existing code that was already conditional on the Elm engine to
retrieve the underlying window - thus allowing elm_win_xwindow_get to
return 0 in the case when called on a Wayland based Elm window.
Patches have been tested against X11 and Wayland built together by
running elementary_test.
SVN revision: 71455
new schema.
els_icon smart object was brought to be the base of the image widget,
in the form of an image class.
An elm icon is now a elm image, with a little more on top of it.
An elm photo is a now base widget aggregating an icon.
Toolbar's internal usage of the former els_icon is now changed to
icons, instead.
Some naviframe instantiations were set to enable events during
transitions, because this code is buggy and my chages exposed the
problem. It will be fixed as soon as I get to port Naviframe.
SVN revision: 71429
Subject: [E-devel] [Patch][elm_map] Add New "loaded" signal
I want to add new "loaded" signal to elementary map. This signal
notify users when all map tiles are loaded. Timer is used for this signal.
Currently "tile,loaded" can be used for each separated tile. So the
users are hard to know whether all tiles are loaded or not.
Please review this patch.
SVN revision: 71406
Subject: [E-devel] [patch] allow copy and paste operations for
non-widget evas objects
I am currently implementing a clipboard for WebKit-EFL. When using
elm_cnp_selection_get and set function an evas object passed has to be
a widget. Currently in WebKit-EFL we are using an view which is an
Evas_Object, but not a widget. Sample WebKit applications like
EWebLauncher and tests applications does not use elementary so I
cannot obtain parent widget for a view object and finally we cannot
perform copy and paste operations.
Widgets are used in elm_cnp_selection functions to obtain
Ecore_X_Window. My patch leaves current way of obtaining it and adds
an another in case when the standard one fails. When Evas_Object is
not a widget I am trying to get an Ecore_X_Window using ecore.
SVN revision: 71381
Subject: [E-devel] [Patch][elm_map] Add elm_map_overlays_get &
elm_map_overlay_visible_get
I want to add 2 new APIs (elm_map_overlays_get & elm_map_overlay_visible_get).
There are no way to get the group overlays because group overlay,
something like virtual overlay, is created and deleted dynamically.
So elm_map_overlays_get returns total overlay's list and user can get
any type of overlays including group overlays.
Overlays which is grouped can not be visible. Because overlay grouping
is performed by elm_map, user do not know whether overlays are visible
or not. So elm_map_overlay_visible_get is added for this reason.
SVN revision: 71354
parent is deleted.
On Tue, May 22, 2012 at 4:46 PM, Sohyun Kim <anna1014.kim@samsung.com>
wrote:
>
> Hi all.
> When I use elm_notify, I got a crash in the deleting routine. (you
can test it in elementary_test > Video)
>
> When parent window of elm_notify is deleted, elm_notify set its
parent to NULL.
> However, it doesn't delete event callbacks of the parent window.
>
> In the smart_del callback of elm_notify, it tries to delete event
callbacks of parent window.
> However, its parent is already set to NULL, the deleting is skipped.
> Then the widget data gets freed.
> In this case, when other objects in the window are deleted, they can
create the parent window's event (e.g. CHANGED_SIZE_HINTS,,)
>
> Please find a patch to delete event callbacks when parent window is
deleted.
>
> Regards, Sohyun
SVN revision: 71307
There is a case that parent can be NULL when you call
elm_ctxpopup_add().
This reverts commit 8bc665a6ebc9daf0d5faa46223635f46f3d0f682.
SVN revision: 71305
<ohpowel@gmail.com>
On Mon, May 21, 2012 at 5:32 PM, Bluezery <ohpowel@gmail.com> wrote:
> Hello,
>
> When ctx_popup is deleted, it calls "elm_widget_sub_object_del(parent,
> popup)" so that ctx_popup's parent can delete it's sub_ojbect,
> "ctx_popup".
> But this is not needed because parent already deletes it's sub-object
> in elm_widget.c
>
> Thanks
>
> --
> BRs,
> Kim.
SVN revision: 71301
Dear all, hello.
If an item of diskselector has only icon without label, then the icon
displays at left side of its space.
So if there is no label, the icon should display at the middle of its
space.
Please review the patch. Thanks.
Sincerely,
Shinwoo Kim.
Signed-Off-By: Kim Shinwoo <kimcinoo.efl@gmail.com>
SVN revision: 71279
Instead of a global 400msec value, we now have 200msec between mouse downs.
E.g if the first timestamp is 0, we get:
valid: down(0) up(50) down(150) up(300)
invalid: down(0) up(100) down(201) up(250)
SVN revision: 71200
I've received feedback on being bad to expose the thumb's frame.
So, making it a base widget here. Let me know what you guys think.
SVN revision: 71176
Documentation was wrong too and code had a slight bug stopping
genlist from contracting to min size.
Optimize the case of COMPRESS + homogeneous mode to avoid
queue entirely and use existing known item sizes.
SVN revision: 71140
sometimes the only separators are shown even though the items are hidden.
So the separator's visibility is desided by it's previous item.
SVN revision: 71093
behaves.
Containers like boxes should not be resizing themselves, but flagging
desireable sizes via size hints to parent widgets.
Let it be that way for now, though. Ctxpopup is giving me A LOT OF
HEADACHE to port to the new schema without having to rewrite it :(.
It has the craziest code flow on sizing things, and of course that
code is uber fragile to borks.
SVN revision: 71085
should be called prior to edje_object_part_swallow. This is because
evas-callback function(about EVAS_CALLBACK_CHANGED_SIZE_HINTS) which is
registered by _smart_sub_object_add should be called after the one
registered by edje_object_part_swallow.
SVN revision: 70985
Hi! All,
[test_menu]
I have added test code for following APIs, even though Elementary 1.0 is
released. :-)
- elm_menu_close()
- elm_menu_item_icon_name_set()
- elm_menu_item_is_separator()
- elm_menu_item_selected_set()
- elm_menu_parent_set()
Then, please review those patches and keep on the upstream.
Sincerely,
Shinwoo Kim.
SVN revision: 70983
* Fileselector test: add a check to enable/disable buttons
Updated Changelog and NEW, also add myself as authors...
btw: the EIO code in the Fileselector is crazy-complex, about 200
lines of code just to have the list of files ina dir... :/
SVN revision: 70965
Currently there's semi-ready code (1 liner) that does nothing. Hermet, you
promised you'll add ui-mirroring support AGES ago when this widget got in.
SVN revision: 70960
NOTE: This is not very robust yet. But that's not related to this patch.
You can see the issue when switching between two different theme in
elementary_config. At some point elementary_test start to loose information.
SVN revision: 70895
Hi Mr. Park,
Please find attached theme bug fix patch of elm_colorselector.
Bug:
1. Colorselector spreading its size to whole window.
2. Colorselector size not adjusting properly when shifted in between different modes.
Change Log: Color selector Theme fixed to adjust size properly based on mode and demo
application appropriately fixed with proper size.
Signed-Off-By : Shilpa Singh<shilpa.singh@samsung.com>
Thanks & Regards
Shilpa Singh
SVN revision: 70869
Hi!
I have just modified the elm_menu.c because there are some improper
indentation.
That's it... Thanks.
Sincerely,
Shinwoo Kim.
Signed-Off-By: Shinwoo Kim <kimcinoo@gmail.com>
SVN revision: 70758
widget hierarchy.
Win inherits directly from Elm_Widget_Smart_Class, while inwin is now
an elm layout.
Note that elm_widget_sub_object_list_get(), which was an unecessary
hack only used on win, was killed.
SVN revision: 70717
class: elm_layout.
This will be, besides the codebase for the elm_layout widget, a common
base for all other widgets which got an edje layout as a basis for
their decoration.
From now on, all elm_layout_* namespaced fuctions will function
on objects inheriting from this base:
- elm_layout_content_set
- elm_layout_content_get
- elm_layout_content_unset
- elm_layout_text_set
- elm_layout_text_get
(recovered from deprecated header -> not anymore)
- elm_layout_sizing_eval
- elm_layout_data_get
- elm_layout_edje_get
- elm_layout_file_set
- elm_layout_theme_set
- elm_layout_box_append
- elm_layout_box_prepend
- elm_layout_box_insert_before
- elm_layout_box_insert_at
- elm_layout_box_remove
- elm_layout_box_remove_all
- elm_layout_table_pack
- elm_layout_table_unpack
- elm_layout_table_clear
Three missing functions on layouts were added, then:
- elm_layout_signal_emit
- elm_layout_signal_callback_add
- elm_layout_signal_callback_del
Naturally, the elm_object_ namespaced counterparts of those will also
function (they will be deprecated on the future).
SVN revision: 70708
This is for general purpose containers in Elm, those supporting
- elm_object_part_content_set()
- elm_object_part_content_get()
- elm_object_part_content_unset()
SVN revision: 70707
resize objects to new schema.
sub-object-{add,del} new class functions got their bodies in. One by
one, the old elm_widget_ namespaced calls to them got to be migrated
to the class calls.
A resize object is now a sub-object, too. This should be like that
from the start -- we share code and avoid callback duplication -- what
leaded to a plethora of bugs.
SVN revision: 70705
properly by real widgets.
I'm also creating a *compatibility* class on top of it, which extends
the old (unique) one to its old components, so that everything goes
unnoticed for the widgets.
Next, we'll be accessing class functions for widget hooks *on the base
class*, which will be proxied back to the instance ones.
Then, one by one the widgets will be translated to a proper
hierarchical smart class parentage, making extensibility and reuse
much better.
Last, but not least, since we'll be moving these hooks to the class,
where (almost) everything is a function, let's adapt to the future --
take away the "_func" suffix from them.
NB: there is ONE hook and associated data which was kept on the base,
for now: "show_region" stuff. I did that because scrollers need that
in order to work, right now. Keep in mind, though, the scrollers will
be reworked, so that fields ought to be changed soon, too.
SVN revision: 70704
in naviframe. Patch by Shilpa Onkar Singh <shilpa.singh@samsung.com>
On Thu, May 3, 2012 at 2:30 PM, SHILPA ONKAR SINGH
<shilpa.singh@samsung.com> wrote:
> Hi All,
>
> Please find attached, patch for elc_naviframe bug fix: "wrong signal
sent when subtitle,title is set".
>
> Change Description:
> Bug Fix: Wrong signal sent when title/subtitle is set in naviframe.
>
> Thanks & Regards
> Shilpa Singh
SVN revision: 70685
using elm_widget_focus_direction_go function, focus will be moved from
the current focused object to the near object in one direction.
Direction can be set by degree(for easy usability). Degree changes
clockwise, i.e. 0 means UP, 90 means RIGHT, 180 means DOWN, and 270
means LEFT. You can select any direction by changing this degree.
SVN revision: 70681
widget hierarchy.
Win inherits directly from Elm_Widget_Smart_Class, while inwin is now
an elm layout.
Note that elm_widget_sub_object_list_get(), which was an unecessary
hack only used on win, was killed.
SVN revision: 70640
class: elm_layout.
This will be, besides the codebase for the elm_layout widget, a common
base for all other widgets which got an edje layout as a basis for
their decoration.
From now on, all elm_layout_* namespaced fuctions will function
on objects inheriting from this base:
- elm_layout_content_set
- elm_layout_content_get
- elm_layout_content_unset
- elm_layout_text_set
- elm_layout_text_get
(recovered from deprecated header -> not anymore)
- elm_layout_sizing_eval
- elm_layout_data_get
- elm_layout_edje_get
- elm_layout_file_set
- elm_layout_theme_set
- elm_layout_box_append
- elm_layout_box_prepend
- elm_layout_box_insert_before
- elm_layout_box_insert_at
- elm_layout_box_remove
- elm_layout_box_remove_all
- elm_layout_table_pack
- elm_layout_table_unpack
- elm_layout_table_clear
Three missing functions on layouts were added, then:
- elm_layout_signal_emit
- elm_layout_signal_callback_add
- elm_layout_signal_callback_del
Naturally, the elm_object_ namespaced counterparts of those will also
function (they will be deprecated on the future).
SVN revision: 70631
This is for general purpose containers in Elm, those supporting
- elm_object_part_content_set()
- elm_object_part_content_get()
- elm_object_part_content_unset()
SVN revision: 70630
resize objects to new schema.
sub-object-{add,del} new class functions got their bodies in. One by
one, the old elm_widget_ namespaced calls to them got to be migrated
to the class calls.
A resize object is now a sub-object, too. This should be like that
from the start -- we share code and avoid callback duplication -- what
leaded to a plethora of bugs.
SVN revision: 70628
properly by real widgets.
I'm also creating a *compatibility* class on top of it, which extends
the old (unique) one to its old components, so that everything goes
unnoticed for the widgets.
Next, we'll be accessing class functions for widget hooks *on the base
class*, which will be proxied back to the instance ones.
Then, one by one the widgets will be translated to a proper
hierarchical smart class parentage, making extensibility and reuse
much better.
Last, but not least, since we'll be moving these hooks to the class,
where (almost) everything is a function, let's adapt to the future --
take away the "_func" suffix from them.
NB: there is ONE hook and associated data which was kept on the base,
for now: "show_region" stuff. I did that because scrollers need that
in order to work, right now. Keep in mind, though, the scrollers will
be reworked, so that fields ought to be changed soon, too.
SVN revision: 70627
Warnings resolved:
argument <name> of command @param is not found in the argument list of <function>
The following parameters of <function> are not documented.
Files modified:
elm_calendar.h
elm_map.h
Patch by: Thiago Thamada <tiba@profusion.mobi>
SVN revision: 70526
Subject: [E-devel] [patch] missing doxygen files in release tarballs
This patch add to EXTRA_DIST essential files for doxygen
small build fix:
SVN revision: 70514
<hyoyoung@gmail.com>
On Fri, Apr 20, 2012 at 4:10 PM, Hyoyoung Chang <hyoyoung@gmail.com>
wrote:
> Dear all,
>
> After introduced flipped mode to genlist, some clearing process is
> added to _elm_genlist_item_unrealize.
> In item _elm_genlist_item_unrealize, item is casting to gengrid item
> or genlist item.
> segfault is occurred in _elm_genlist_item_unrealize at using gengrid.
> this patch moves flipped mode clearing process to _item_realize_cb.
>
> Thanks.
>
SVN revision: 70355
Hyoyoung Chang <hyoyoung@gmail.com>
On Fri, Apr 20, 2012 at 5:19 PM, Hyoyoung Chang <hyoyoung@gmail.com>
wrote:
> After discuss with seoz, i changed to not clean selections also i
> removed the new added internal func.
>
> Thanks
>
> On Fri, Apr 20, 2012 at 4:00 PM, Hyoyoung Chang <hyoyoung@gmail.com>
wrote:
>> Dear all,
>>
>> I made a small patch to fix remained selection bug.
>> In decorate all mode, some item selection is not cleared after unset
>> decorate all mode.
>> I added to fix it.
>> And make unselecting common routine to a internal function.
>>
>> Thanks.
SVN revision: 70354
Subject: [E-devel] [patch] elm_genlist - bugfix at item flipped
I made a small patch about item flipped.
It resolves two bugs
1. flip_set and unset is called quickly, sometimes genlist can't free
flipped data.
it fixed to remove checking flipped status in item unrealize
2. add item unhighlight at flip_job
SVN revision: 70306
Subject: [E-devel] [Patch][Genlist] fix the bug in _elm_genlist_item_del_notserious
I made a patch to fix the bug in _elm_genlist_item_del_notserious.
If relcount is not 0 or walking is not 0, return.
SVN revision: 70291
Subject: [E-devel] [Patch][elementary_test] test_list
I had added test code for the elementary. but I made a pause it
because of
some reasons and just started again.
Today I have attached a patch for the elm_list which does not have test
code for the API elm_list_item_prev();
Please review the attached patch and give any feedbacks. I'll be back
with
other patches. Thanks!
SVN revision: 70265
Change Description: [elm_datetime.c] Separator parsing logic is changed in Datetime widget.
Predefined set of characters (both global and field specific) are ignored as field separators.
Can some one, please review and check-in the code in SVN Elementary.
Thanks, Sumanth
Singed-Off-By: Sumanth Krishna Mannam<sumanth.m@samsung.com>
SVN revision: 70220
verification. Patch by Taehwan Kim <ohpowel@gmail.com>
On Tue, Apr 10, 2012 at 5:37 PM, Bluezery <ohpowel@gmail.com> wrote:
> Hello,
>
> Currently, elm_widget_sub_object_add() does not check if obj and sobj
> are same object.
> Actually it is a user problem if user add object itself as it's sub
object.
> But I think that this checking is needed and it is better to give
> error logs to users. Because it causes infinite loop and it is hart
> to debugging. :(
>
> Thanks.
SVN revision: 69995
Author : cnook kimcinoo@gmail.com
The evas_object_hide(popup) could not hide the popup.
So, I added callback to hide the popup, with the test
code.
SVN revision: 69960
text in "elm.text". This is because wd->text is updated by edje's
signal callback. I'll think more about removing all codes wd->text.
With my opinion they are useless.
SVN revision: 69948
Current Issue:
Focus does not go to Popup content and action area.
Reason:
focus_next hook is returning EINA_FALSE in focus_next_hook.
Change Description:
1. Routed the focus_next call to the internal notify object.
2. Set the visibility of action area layout in edc to True as the
visibility of the action area layout returns zero even if due to state
change it is set to visible state in edje.
3. Deleted the show event callback "_popup_show" in del_pre_ hook.
Signed-Off-By: RAJEEV RANJAN<rajeev.r>@samsumg.com>
SVN revision: 69947
Hyoyoung Chang <hyoyoung@gmail.com>
On Thu, Apr 5, 2012 at 3:12 PM, Hyoyoung Chang <hyoyoung@gmail.com>
wrote:
> Dear all,
>
> I made a patch for elm_genlist_fields_update to selective content
update.
> a genlist item can update any content regardless of its mode.
>
> Thanks.
>
> PS: It assumed my previous patch is applied ([patch] elm_genlist -
> split flip content from item's content)
SVN revision: 69944
Current Issue:
Currently when we add a widget to window as a sub-object, e.g.
elm_notify_add(win) which internally calls elm_widget_sub_object_add
then the focus chain using <TAB> includes only
the first focusable subitem of the widget, not all.
Whereas with elm_win_resize_object_add, it works fine and cycles to
all focusable sub-items of the widget.
Reason:
The reason is that we are appending sub-object to the list in
elm_win which is used for focus chain, only in case of
elm_win_resize_object_add.
Change Description:
Added a new API: EAPI Eina_List
*elm_widget_sub_object_list_get(const Evas_Object *obj);
This API returns the list of sub-objects of an elementary widget
(sd->subobjs) where sd is Smart_Data pointer obtainted using
elm_widget_smart_data_get(obj).
We have used this API in elm_win for focus_next_hook implementation.
Signed-Off-By: RAJEEV RANJAN<rajeev.r>@samsumg.com>
SVN revision: 69943
When pasting data to entry, notify_handler_text sent incorrect string.
Because notify_handler_text received string including garbage value.
I cut string as its data length.
Signed-By-Off: Minseok Kim <minseok3.kim@samsung.com>
SVN revision: 69942
Dear ALL,
If the block that must be removed/freed, it has already removed/freed in
_item_block_del.
So I removed the code in _clear_cb.
Thanks
Joey
Submitted-By-Off ChankWook Jung<jchanwook@gmail.com>
SVN revision: 69929
Revert "elm bin: Use convenient utility function elm_win_util_standard_add() instead of elm_win_add() + elm_bg_add(). This is for normal style (ELM_WIN_BASIC) window."
This reverts commit 31b24a0edb0028528d7c859070e03236ba42867b.
SVN revision: 69847
Change Description:
- Year min/max values are moved to elm_config.
- Format specifier must come along with % followed by any separator. ( % 123d is not supported but %d will denote Date format specifier)
- Field separator can constitute multiple spaces, Space followed by any other non format specifier is also treated as the separator till its max length. ( %d x/ %b #2 format displays 27 x/ Mar #2 )
Thanks, Sumanth
Submitted-By-Off Sumanth Krishna Mannam<sumanth.m@samsung.com>
SVN revision: 69846
Chang <hyoyoung@gmail.com>
On Fri, Mar 30, 2012 at 5:17 PM, Hyoyoung Chang <hyoyoung@gmail.com>
wrote:
> I talked with seoz. and agreed with previous naming changing is
insufficient.
>
> so changed like this
> "mode_" -> "deco_it_"
> "edit_" -> "deco_all_"
>
> Thanks
>
> On Fri, Mar 30, 2012 at 3:33 PM, Hyoyoung Chang <hyoyoung@gmail.com>
wrote:
>> Dear all,
>>
>> After edit mode naming is changed, some legacy naming is remained.
>> I changed naming to follow API naming changes.
>>
>> "edit_" -> "deco_"
>> and also some explicit edc part names are changed.
>>
>> Some naming are remained as is, I'll fix at next patches.
>>
>> Thanks.
>
SVN revision: 69836
for this change.
Revert "After edit mode naming is changed, some legacy naming is remained."
This reverts commit 5e1aa3c8b0382a0ca471150f4c219cd32dbdbe22.
SVN revision: 69835
I changed naming to follow API naming changes.
"edit_" -> "deco_" and also some explicit edc part names are changed.
Some naming are remained as is, I'll fix at next patches.
SVN revision: 69793
Subject: [E-devel] [patch][elementary] elc_popup, restack issue
The elc_popup does not raise to the top of its layer even though
evas_object_raise() is called with the popup object.
Because the elm_widget_resize_object_set(); makes notify object which is
internally used in the popup have a smart parent.
Ultimately, the callback function for EVAS_CALLBACK_RESTACK of the
notify
is not called.
So I removed elm_widget_resize_object_set(); from the popup and added
some
implementations to show the popup properly.
Moreover, I have added test code also in the attached patch. Then,
please
review the patch and give any feedbacks. Thanks.
SVN revision: 69790
1. delete old content object
2. check whether new content object is same as old content object
3. rename internal content set hook function
4. elm_widget_sub_object_del will be followed by evas_object_del
5. added some doxygen description.
SVN revision: 69738