Summary:
Since the _count variable is static, the buttons which are added
to scroller, get text value ahead of previously added count, instead
of starting from 1 every time a new window is opened for the example.
Signed-off-by: Vaibhav Gupta <g.vaibhav1@samsung.com>
Test Plan:
Following is the test:
1. Open Scroller 3 sample
2. Add some items and note the "Item count value of added buttons
3. Close the sample
4. Re-open Scroller 3 sample, and again add some items
5. Observe the "Item count" text of added buttons.
Reviewers: raster, Hermet, singh.amitesh
Subscribers: sachin.dev
Differential Revision: https://phab.enlightenment.org/D2959
Summary:
The original code did not consider the case where the text will be
reapplied by chunks. The repositioning of the cursor should be postponed
to when the idler work is done, or not required at all.
Fixes T2646.
@fix
Reviewers: NikaWhite
Reviewed By: NikaWhite
Maniphest Tasks: T2646
Differential Revision: https://phab.enlightenment.org/D2952
This is an example of classic code copy and paste mistake.
Probably inspired from similar code in genlist/gengrid.
We were actually deleting the other items (except selected one) in
viewport in _elm_list_nearest_visible_item_get() which results into crash
while deleting the list object.
@fix
Resolves: T2662
Summary:
After item looping, Gengrid item was getting selected.
So, checked for item_select_on_focus_disable flag and
accordingly set focus state or selected state of Gengrid item.
@fix
Signed-off-by: Yeshwanth Reddivari <r.yeshwanth@samsung.com>
Reviewers: raster, Hermet, singh.amitesh, SanghyeonLee
Subscribers: sachin.dev
Differential Revision: https://phab.enlightenment.org/D2937
performing strlen() on potential non-string data is not recommended and can
even lead to crashes. nul terminating non-string data is pointless and enables
bad application behavior such as calling strlen() on potentially non-string data
@fix
previously the drop format was chosen in a manner unrelated to what
the offered format was, leading to applications receiving either the correct
data with the wrong format, the wrong data with the wrong format, or
the wrong data with the correct format. by comparing the drop handler
types with the offered type and ensuring that there is a match, the
correctness of the format that the application receives is more reliable
@fix
In the widget code, focus origin is added. It can know
the focus movement is originated by which action.
The widgets can choose the item focus moves to last focused item
or geometrically nearby item by focus origin.
In gengrid, focus moves to last focused item if focus origin is
ELM_FOCUS_REVERT. It moves to nearby item if focus origin is from
ELM_FOCUS_UP to ELM_FOCUS_LEFT.
TODO: widgets have items should add the direction feature if it
want the focus to move to nearby item.
@feature
Summary: The Elm Copy and Paste test was not actually pasting the
copied text into the entry when the Paste button was clicked. This
patch fixes that issue.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
When the focus is move to the object in scroller, it is scrolled
to show the focus region as a widget.
If the focus region want to be shown as an item,
set the mode ELM_FOCUS_REGION_SHOW_ITEM.
If then, it will be scrolled as an item.
TODO: Widgets have items are added on_focus_region function.
@feature
This commit is related to 4d553d2bcf2157053433994ca3facb56bd670da9.
It doesn't work if item_select_on_focus_disable is 1.
So _item_focus_down is changed like _item_single_select_down.
@fix
Summary:
do not return yet in case of edge items if looping
is disabled. try to select/focus last item.
Signed-off-by: Jyotiprakash Sahoo <jp.sahoo@samsung.com>
@fix
Test Plan: elementary_test -> Gengrid 2
Reviewers: raster, singh.amitesh, cedric, SanghyeonLee
Reviewed By: SanghyeonLee
Differential Revision: https://phab.enlightenment.org/D2865
Summary:
When user set min max as 50, 150 with %d format, then value set as 100.
The spinner value set as '0'
Because the sd->val type is double.
Spinner entry has same problem.
@fix
Test Plan:
Set spinner format as %d.
Check the spinner value.
It's not supported.
Reviewers: Jaehyun_Cho, cedric, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2898
Conflicts:
src/lib/elm_spinner.c
Summary:
When icon is set, icon size is calculated without considering
edje base scale. This can lead to a miscalculation when
base scale is set other than 1.0.
@fix
Reviewers: seoz, woohyun, cedric, Hermet
Reviewed By: Hermet
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D2798
Summary:
_elm_access_say() does not free the given text.
But, the text from eina_strbuf_string_steal() is not cared
from outside of _elm_access_say(), too.
It should be changed to eina_strbuf_string_get().
Test Plan: N/A
Reviewers: cedric, woohyun, kimcinoo, JackDanielZ, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2918
Summary:
Calling the elm_config_accel_preference_get api with "none" as parameter,
it means user does not want to use acceleration.
Reviewers: Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2920
If we want to run from the local build dir without make install before
elm_module would fail to load the modules as it is expecting them in the
final install location.
We can now change this by setting ELM_RUN_IN_TREE to force it load the not
yet installed modules.
ref T2028
Our tests require a theme file. So far they picked this just from the system
where it was installed to in a previous run. We have situations where this would
not work though. Running make check before install on a new system or during
distcheck comes to mind.
With AM_TESTS_ENVIRONMENT we make that the theme is also looked for in the not
yet installed builddir.
Thanks to Lukasz Stanislawski for pointing me to this.
ref T2028
internal object content_area was not swallowed into popup
since elm_object_part_content_set() was used.
Steps to reproduce:
1. clouseau elementary_test -to popup
2. open subpopup example.
3. observe orphan content_area object in clouseau widget list.
Summary:
elm_list, elm_genlist widgets are handle focus highlight
relying on only elm_widget_focus_highlight_enabled_get() API.
The API is not considered about auto focus highlight feature.
So, we need to check a flag for auto focus from _elm_config.
It resolves T2555.
@fix
Test Plan: elementary_test -> List Focus or Genlist Focus
Reviewers: raster, cedric, SanghyeonLee, singh.amitesh
Reviewed By: SanghyeonLee, singh.amitesh
Maniphest Tasks: T2555
Differential Revision: https://phab.enlightenment.org/D2914
Summary:
When editable set is set to FALSE, there is no need to specifically
hide the keypad as keypad will automatically hide when entry is hidden.
@fix
Signed-off By: Kumar Navneet <k.navneet@samsung.com>
Reviewers: woohyun, Hermet, CHAN, cedric
Reviewed By: cedric
Subscribers: subodh6129, navnbeet
Differential Revision: https://phab.enlightenment.org/D2907
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Currently, the first item is marked selected when
the colorselector is added. However, this is not normal behavior
since the first item is not shown selected.
Moreover, always selecting the first item during creation does not
sound natural.
Reviewers: cedric, Hermet, woohyun
Differential Revision: https://phab.enlightenment.org/D2906
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
The numerical formula below is calculated with the double type.
-> ELM_SCALE_SIZE(x) (int)(((double)(x) / elm_app_base_scale_get()) * elm_config_scale_get())
But if number of significant figure of the return value goes over 15, the epsilon error will happen.
Because of that, it is better to divide to do later.
Reviewers: woohyun, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D2900
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
The evas box swallowed in "elm,swallow,index" part.
Then the each index item will be appended into evas_box when elm_index_go called.
If user make the line or dot for that swallow part for resize same as internall box.
edje_size_min_calc always give the '0'value for it.
Box will be swallowed the only on swllow part for desicion index layout size.
So the index min value should follow the box size.
Test Plan:
Run any index sample.
Get the index min size and check the value.
It gets always wrong before.
Reviewers: cedric, Hermet, woohyun
Differential Revision: https://phab.enlightenment.org/D2896
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
An item size calculated with scale value when item appended.
This code is not need.
@fix
Reviewers: Hermet, woohyun, cedric
Reviewed By: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D2840
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
I add the APIs for supporting multi language on index.
"elm_index_item_priority_set()" API can give the priority value for each item.
it will be grouping with each priority items when index start to draw the item.
It can get a 0 or 1 (default : -1) -1 priority item show always even priority changed.
"elm_index_priority_set()" API can changed the current priority in manually.
priority will be up automatically when user send move event into last of priority 1 group item.
otherwise, priority will be down automatically when user send move event into first of priority 0 group item.
"elm_index_priority_get()" API can get a current index priority.
@feature
Test Plan:
I added the test application in test_index with give the name as "test_index3"
(It's for only show how to handle the priority APIs and show the how does it works for multi language
so it doesn't operate with genlist.)
You can check the how it works and how APIs works for it as well.
Reviewers: eunue, seoz, woohyun, Hermet
Subscribers: SanghyeonLee, eagleeye
Differential Revision: https://phab.enlightenment.org/D2729
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Currently, hoversel shows all items at the same time, but to limit
the size of contents and make it scrollable is neccesary to some users.
elm_hoversel_scroll_enabled_set/get() API makes the contents of hoversel
scrollable or not.
Test Plan:
The newly added scroll function is enabled for the second hoversel
in "hoversel" sample of elementary_test.
Reviewers: Hermet, raster, herdsman, cedric, tasn
Subscribers: JackDanielZ, cedric, Hermet
Differential Revision: https://phab.enlightenment.org/D2603
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
If name of theme has ".",example "abc.def.edj", it would fail to check the file name.
So, I changed the strchr functions to strrchr function.
Reviewers: seoz, raster, Hermet, cedric
Reviewed By: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D2285
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
This patch is code refactoring for genlist item cache logic
as same as gengrid item cache and removing unnecessary
Item_Cache properties.
{selected, disabled, expanded} exist in Item_Cache,
but _item_cache_find ignore those flagged properties,
so _elm_genlist_item_status_update will not working with
itc properties(all itc properties are EINA_FALSE).
Test Plan: Need to check elementary_test genlist sample working properly.
Reviewers: raster, Hermet, seoz, jaehwan, cedric
Reviewed By: cedric
Subscribers: cedric, singh.amitesh, eagleeye
Differential Revision: https://phab.enlightenment.org/D2660
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
There is no way to give padding between each items, previously.
So i added horizontal, vertical padding here.
I will add APIs for set, get padding size set, get.
@feature
Test Plan:
Change the horizontal, vertical paddidng value in multibuttonentry.edc
Run elementary_test
Execute multibuttonentry sample.
Add items.
Check the padding between items.
Reviewers: woohyun, seoz, Hermet, raster
Reviewed By: Hermet, raster
Subscribers: raster
Differential Revision: https://phab.enlightenment.org/D2534
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Currently when user clicks on the radio, and when api value_set() called by
the developer we emit "elm,state,radio,*" signal. To support value change animation when
user interacts with radio. There is no way to distinguish the action in EDC.
This "elm,activate,radio,*" is a way which edc can make use to distinguish the state change signal
by the user action or due to api call.
Reviewers: Hermet, raster, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D2829
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Currently when user clicks on the checkbox, and when api state_check() called by
the developer we emit "elm,state,check,*" signal. To support state change animation when
user interacts with check box. There is no way to distinguish the action in EDC.
This "elm,activate,check,*" is a way which edc can make use to distinguish the stae change signal
by the user action or due to api call.
Reviewers: woohyun, raster, cedric, Hermet
Reviewed By: Hermet
Subscribers: id213sin
Differential Revision: https://phab.enlightenment.org/D2817
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Test Plan:
1. Install previous version of elementary
2. Remove config from homedir
3. Build new config with elemetnary_config app
4. Install patched version of elementary
5. run elementary_test Hoversel test
6. Space end Enter should open hovesel
Reviewers: seoz, jaehwan, singh.amitesh, cedric
Reviewed By: cedric
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D2787
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
SIG_CAHANGED notify user to
genlist is now changed their items and properties and all
calculation is finished, so user can get correct values in
that callback.
This SIG_CHANGED smart callback already supported in gengrid.
Test Plan:
N/A
This patch is addition of new smart callback.
Reviewers: raster, seoz, singh.amitesh
Subscribers: Hermet, cedric, eagleeye
Differential Revision: https://phab.enlightenment.org/D2773
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Entry has only number text when activated and value changed, Even user registered special value to each spinner value.
If the user registered special value, we should check then showing the special value instead of number text.
Its will more helpful to expect the result when user set a spinner value using spinner entry.
@fix
Test Plan:
There is a spinner sample in elementary_test.
Changing editable value as TRUE for the last spinner object.
Click the spinner to activated entry and check the result.
Reviewers: Hermet, Jaehyun, cedric
Reviewed By: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D2844
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
set scroller size in content_set.
Resolves: T2623
@fix
Test Plan:
1. run ecrire
2. Add some text in newfile
3. Close ecrire
4. a almost zero size popup.
Reviewers: tasn, herdsman, raster, SanghyeonLee, stefan_schmidt
Reviewed By: stefan_schmidt
Subscribers: stefan_schmidt, herb, seoz
Maniphest Tasks: T2623
Differential Revision: https://phab.enlightenment.org/D2901
Vaibhav Gupta
Amitesh Singh
Carsten Haitzler
Daniel Juyung Seo
Stefan Schmidt
Daniel Hirt
Cedric BAIL
Jaehwan Kim
Anand
Yeshwanth Reddivari
Mike Blumenkrantz
Jérémy Zurcher
Daniel Kolesa
Chris Michael
Davide Andreoli
Tom Hacohen
Jyotiprakash Sahoo
Vivek Ellur
woochan lee
Sung-Taek Hong
ChunEon Park
Youngbok Shin
jiin.moon
Stefan Schmidt
Jaehyun Cho
Daniel Zaoui
Shilpa Singh
j_yong.hwang
Jee-Yong Um
SangHyeon Lee
Subhransu Mohanty
Lukasz Stanislawski
SangHyeon Lee
Amitesh Singh
Nicolas Aguirre
Florent Revest
WooHyun Jung