Summary:
After genlist/genrid items are cleared, item highlight still
remains in blank space. This patch fixes this by updating highlight.
Test Plan:
elementary_test -to fileselector
enter blank directory and see highlight still remains
Reviewers: jpeg, SanghyeonLee, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3683
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Check for all error conditions case in elm_spinner_label_format_set
and set label format only if its valid.
Signed-off-by: Shilpa Singh <shilpa.singh@samsung.com>
@feature
Test Plan:
1. Launch elementary test spinner
2. Set invalid formats e.g. formats with out %, formats with more than
one format specifier "%d %s" etc:-
Reviewers: jpeg, cedric
Reviewed By: cedric
Subscribers: govi, buds, subodh6129
Differential Revision: https://phab.enlightenment.org/D3720
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
without size hints on the edje object, a list item will never be sized
accurately, meaning that the size hints set on subobjects (icon, end) are
ignored in nearly all cases, and any previous sizing which was accurate was,
in fact, merely coincidentally accurate
@fix
typecast const char * to void * and pass ptr to free() since it doesn't modify the value pointed to,
either conceptually or in practice, it merely looks up the memory block using the pointer and deallocates it.
@fix
if a content's size hints change, reapplying the list's size hints
to override existing hints is required to prevent some list items from
having a bad layout
@fix
Summary: In "compile with" comment, filenames are different from the actual ones.
Reviewers: cedric, Oleksander, Hermet
Reviewed By: Oleksander, Hermet
Differential Revision: https://phab.enlightenment.org/D3722
Summary:
move focus out of genlist by pressing "up" key when no item
is selected.
Test Plan: elementary_test -to fileselector
Reviewers: SanghyeonLee, cedric, Jaehyun_Cho, Hermet
Reviewed By: Hermet
Subscribers: Hermet
Differential Revision: https://phab.enlightenment.org/D3721
Summary:
fix the wrong operation of mirrored set.
when mirrored set is applied, notify change the theme using mirrored flag.
however, it is unnecessary operation.
@fix
Reviewers: Hermet, kimcinoo
Reviewed By: kimcinoo
Differential Revision: https://phab.enlightenment.org/D3700
Summary: No use of top object if not editable.
Reviewers: cedric, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D3719
Move declarations of types used in elm_widget.eo to elm_general.eot and
elm_widget.eo.
Give them a Eolian name and use it instead of the old ones.
Correct the type name of some other types used as method parameters, by
using the Eolian names instead of legacy/generated names.
Reorganize the positions of elm_widget.eo.h inclusion and
of callback type declarations in elm_widget.h.
This make a clearer distinction of the types in elm_widget.h that are
still required in elm_widget.eo.h.
using requested size may not be correct, so use real size. this should
solve issues in some wm's and actually also solved some kind of object
size lag in wayland too.
@fix - onward from 79b6edd1a6ad763258337b7aac5bd7799411bb44
Summary:
- icon param add an elm_icon and content set to icon part.
- entry's style is changing as other params are set and
icon part may not exist in certain condition(default has no icon part)
- checking icon param later than other params will set icon part
after the style is changed.
Reviewers: cedric, woohyun, jpeg, herdsman, tasn
Reviewed By: tasn
Subscribers: conr2d
Differential Revision: https://phab.enlightenment.org/D3693
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
when using a touchpad or frictionless mouse wheel, it becomes impossible
to accurately use a scroller which accelerates as scrollers on mobile devices
do. by setting this new option to 0, acceleration can be disabled and regular
behavior can be restored
ref 2ac2628612060114cf6e5205e5331044221178c6
@feature
when I scroll on a computer, I want my app to respond immediately. I don't
want to wait for it to finish scrolling and I don't want to have to guess
where the scroll will end.
ref 2ac2628612060114cf6e5205e5331044221178c6
@feature
we dont set this config by default so we dont see this - but a window
starts as withdrawn then becomes normal. this means the window starts
not rendering and may take 0.5 seconds to START because the eval is
deferred by 0.5 sec to avoid rapid switch to/from norender and other
states.
@fix
this fixes excess callbacks on window (and content) objhects resizing
down then back up again when windows are forcibly resized like
fullscreen, maximized and remembered windows.
@fix
Summary:
When there are no items in genlist/gengrid, highlight stays at one dot of
top-left corner. This patch makes genlist/gengrid itself highlighted
when there are no items.
Reviewers: jpeg, SanghyeonLee
Differential Revision: https://phab.enlightenment.org/D3701
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
elm.swallow.background part will be a default part for
widget's background image.
When entry widget's scrollable status is changed,
the background object will be moved to scr_edje or entry_edje.
Test Plan: N/A
Reviewers: kimcinoo, woohyun, cedric
Differential Revision: https://phab.enlightenment.org/D3677
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
elm.swallow.background part will be a default part for
widget's background image.
Test Plan: N/A
Reviewers: woohyun, kimcinoo, cedric, Hermet
Subscribers: Hermet
Differential Revision: https://phab.enlightenment.org/D3676
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Do not allow invalid input in to spinner.
Invalid Input can be:
1. '-' should not be inserted anywhere but the starting position, and no more than one '-' can be inputted.
2. No more than one '.' can be inserted.
Signed-off-by: Shilpa Singh <shilpa.singh@samsung.com>
@feature
Test Plan:
1. Launch elementary test
2. Run spinner demo
3. Enter invalid inputs like inserting more than one '.', '-' or insert '-' anywhere else part from 1st position.
Reviewers: raster, CHAN, subodh6129, cedric
Subscribers: govi, buds
Differential Revision: https://phab.enlightenment.org/D3664
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
this is unnecessary: every single engine unsets the cursor when the object
has been deleted
this deletes enlightenment's cursor object
ref 678437003f219f783ba14859a805ea27997470fd
@fix
this was previously disabled for internal list objects, and now
it is disabled for all subobjects of ctxpopup. applying focus here
invokes every possible focus bug in elementary and prevents the application
from being useful in any way
ref 974c8b05a4c97367b636593f5420ff01e8364aac
ref T3088
@fix
Jee-Yong Um
Minkyu Kang
Shilpa Singh
Tom Hacohen
Mike Blumenkrantz
Amitesh Singh
Hermet Park
Larry
Jaehwan Kim
taehyub
Subodh Kumar
Vitor Sousa
Carsten Haitzler
Stefan Schmidt
SungTaek Hong
Oleksandr Shcherbina
Vyacheslav Reutskiy
Youngbok Shin