Hello.
Just 3 small fixes to get our warning count down. The tempget one
should actually save us against wrong reads.
Also a small DSO fix reported and confirmed in IRC.
Please review and apply.
regards
Stefan Schmidt
Submitted-By-Off: Stefan Schmidt<stefan@datenfreihafen.org>
SVN revision: 70759
Complete support for keyboard events. Thank You :)
NB: This is a modified patch from what Rob originally sent. This fixes
formatting, uint32_t types, function name, and other such things ;)
SVN revision: 70672
Subject: [E-devel] [patch] missing doxygen files in release tarballs
This patch add to EXTRA_DIST essential files for doxygen
small build fix:
SVN revision: 70514
clients not moving or resizing properly with most recent git wayland.
Make use of wayland's new 'serial' stuff in place of timestamps (where
appropriate). Add code to handle new wayland 'ping' events.
SVN revision: 70443
Subject: Re: [E-devel] [Patch][Ecore][Win32] Checking control character
I missed the updating WinCE. and..
Mr. Vincent Torri enlighten me about ChangeLog and NEWS also. Thanks!
SVN revision: 70219
Subject: [E-devel] [Patch][Ecore][Win32] Checking control character
The control characters are generated by holding down the Control key while
you strike another letter or symbol key.
Because of this reason, The Evas_Event_Key_Down in the
EVAS_CALLBACK_KEY_DOWN callback does not have proper keyname.
So I have shifted the control character to printing character. Please
review the patch and give any feedbacks. Thanks.
SVN revision: 70186
People, when you go and change ecore_event_add() to
_ecore_event_add(), please NOTICE THAT THE FREE FUNCTION IS NOT
AUTOMATICALLY SPECIFIED!
So specify these functions to _ecore_event_add() to stop leaking every
signal we receive from system.
SVN revision: 70177
Subject: [E-devel] [patch] ecore doxygen doc (3)
Date: Thu, 12 Apr 2012 15:39:16 +0900
Some leftovers, fix:
/tmp/ecore/src/lib/ecore_x/xlib/ecore_x_randr_12.c:1202: warning: The following parameters of ecore_x_randr_crtc_pos_relative_set(Ecore_X_Window root, Ecore_X_Randr_Crtc crtc_r1, Ecore_X_Randr_Crtc crtc_r2, Ecore_X_Randr_Output_Policy policy, Ecore_X_Randr_Relative_Alignment alignment) are not documented:
parameter 'root'
/tmp/ecore/src/lib/ecore_x/xcb/ecore_xcb_randr.c:921: warning: The following parameters of ecore_x_randr_mode_size_get(Ecore_X_Window root, Ecore_X_Randr_Mode mode, int *w, int *h) are not documented:
parameter 'root'
/tmp/ecore/doc/examples.dox:242: warning: unable to resolve reference to `ecore_event_example.c' for \ref command
SVN revision: 70119
Subject: [E-devel] [patch] ecore doxygen doc (2)
Date: Thu, 12 Apr 2012 12:46:04 +0900
Hi,
This is a big patch. It fixes:
- undef #EINA_{TRUE,FALSE} links
- @c for NULL and EINA_{TRUE,FALSE}
- some formatting/spello
- several missing return types
SVN revision: 70117
pointer grabs, shm_pool interface. Rename fields of the
wl_event_mouse_in/out structures to match other ecore event structs.
Add API functions for getting a list of outputs, for getting a windows
shell_surface, and for setting a windows parent.
SVN revision: 69997
documentation.
I didn't add the API declaration into the header yet because the API
name/parameter might be changed before release.
SVN revision: 69990
Subject: [E-devel] [patch] ecore doxygen doc
Here is a patch to correct some problems in ecore doxygen doc.
It fixes:
/tmp/ecore/doc/examples.dox:1173: warning: Unsupported xml/html tag
<some_num> found
/tmp/ecore/doc/examples.dox:1174: warning: Unsupported xml/html tag
<some_path> found
/tmp/ecore/doc/examples.dox:1176: warning: Unsupported xml/html tag
<some_num> found
/tmp/ecore/src/lib/ecore_con/ecore_con_ssl.c:714: warning: The
following parameters of
ecore_con_ssl_server_privkey_add(Ecore_Con_Server *svr, const char
*key_file) are not documented:
parameter 'svr'
/tmp/ecore/src/lib/ecore_con/Ecore_Con.h:1360: warning: The
following parameters of ecore_con_url_http_version_set(Ecore_Con_Url
*url_con, Ecore_Con_Url_Http_Version version) are not documented:
parameter 'url_con'
/tmp/ecore/src/lib/ecore_evas/Ecore_Evas.h:530: warning: argument
'demand_attention' of command @param is not found in the argument list
of ecore_evas_demand_attention_set(Ecore_Evas *ee, Eina_Bool demand)
/tmp/ecore/src/lib/ecore_evas/Ecore_Evas.h:530: warning: The following
parameters of ecore_evas_demand_attention_set(Ecore_Evas *ee,
Eina_Bool demand) are not documented:
parameter 'demand'
/tmp/ecore/src/lib/ecore_x/xcb/ecore_xcb_damage.c:129: warning:
Unsupported xml/html tag <empty> found
There are more things to fix due to API change but it's not so obvious
for me. I will first continue to check/correct trivial things in the
others efl doxygen doc.
SVN revision: 69820
I found a bug in ecore main loop while debuging cpu 100% issue on RSS
application.
1. [RSS] RSS application register two io watch callbacks(for G_IO_IN,
G_IO_OUT seperately) for a GIOChannel with g_io_add_watch().
2. [ecore] In _ecore_glib_context_query() function, g_main_context_query()
returns a fd list, and it has 2 fd items for the GIOChannel (channel
id = 20).
itr[0] (16, 1, 0)
itr[1] (15, 1, 0)
itr[2] (20, 1, 0) (G_IO_IN, 0)
itr[3] (20, 4, 0) (G_IO_OUT, 0)
itr[4] (18, 1, 0)
3. [ecore] In _ecore_glib_context_poll_from() function, create read, write,
exception fd list according to the events flags of each fd item.
[6 15 16 18 20], [20], []
4. [ecore] in _ecore_glib_select__locked() function, get active fd number from
select() call
select(21, [6 15 16 18 20], [20], [], NULL) = 1 (out [20])
5. [ecore] In _ecore_glib_context_poll_to() function, there is a bug on
setting revents flag.
(because of incorrect condition check - currently, the logic of the
function cannot handle this case)
itr[0] (16, 1, 0)
itr[1] (15, 1, 0)
itr[2] (20, 1, 4) (set incorrectly)
itr[3] (20, 4, 0) => this should be set as (20, 4, 4)!!!!
itr[4] (18, 1, 0)
6. [ecore] In _ecore_glib_select__locked(), g_main_context_check() function
returns false because of the above bug, so g_main_context_dispatch()
function will not be called.
>> After this, the 2~6 flow is executed repeatedly on ecore main loop
(because 20 out is still active fd) and this makes cpu 100% problem.
SVN revision: 69739
Fix ecore_wl_window surface attach of the buffer for shm and egl types.
NB: This ensures that both efl/elm clients work under the Wayland
Compositor AND the E17 Compositor.
NB: The issue here is that clients (when run under the Wayland
compositor) need to make sure 'iterate' has
been called before creating surfaces so that the wl_compositor is
setup. However, the actual E17 Compositor will hang if 'iterate' is called
to early.
SVN revision: 69707
Handle 'axis' events from multi-touch devices (also handles mouse
wheel).
Remove wl_buffer_damage calls (obsolete in newest wayland).
NB: This will require the 'latest' wayland code from their git repo as
of 2012-03-27.
SVN revision: 69672
- Comment out display_iterate during intialize (hangs compositor
initialize).
- Simplify ecore_wl_flush routine and avoid possible hangs in
wl_display_roundtrip.
- Add function (for trip ;) ) to be able to return the screen dpi.
- Implement functions for input grab/ungrab.
- Set root.x/y in mouse events.
- Remove freeing of mouse_move event (already handled generically).
- Handle setting output mm width/height (for calc of dpi).
- Implement setting surface input & opaque regions.
- Implement popup windows.
- Implement ecore_wl_window_transparent_set function.
- Implement function to allow setting Ecore_Wl_Window type.
- Implement setting the wayland mouse pointer to an image (via
ecore_wl_window_pointer_set).
- Comment out wl_display_iterate during initialize (can cause hangs in
compositor).
- Simplify ecore_wl_flush (to avoid compositor hangs).
SVN revision: 69644
This works in linux and windows, and should fix shm_detection on BSD (including Mac)
BSD, Mac and solaris users : please check that it compiles and shm_open is detected
SVN revision: 69616
Subject: [E-devel] [PATCH] ecore/ecore_fb: Tweaks in _ecore_fb_size_get
As the width and height are defined as static, no need to initialize it
again to zero. Also removed checks for 'valid pointers' as it is redundant.
SVN revision: 69556
Subject: [E-devel] [Patch][ecore_con] Simple bug fix
Date: Mon, 12 Mar 2012 13:45:02 +0900
Hello,
This is patch to prevent a segfault if curlmsg == NULL.
Thanks.
SVN revision: 69217
(interfaces_bound) to be raised when ecore_wayland has everything it
needs to function properly. (Used in the e17 wayland only code).
SVN revision: 69032
NOTE: I am now all for removing this lock. They trigger crash,
are not implementing the feature they are advertising, are not
maintained and impossible to fix.
SVN revision: 68987
Subject: [E-devel] [Patch] Ecore, Elementary: Supporting indicator
opacity mode
This is Myoungwoon Roy Kim.
This patches are for supporting the indicator's opacity mode and made by
Jeonhoon Park(jh1979.park@samsung.com) who is responsible for Indicator
application.
Requirements:
- In mobile device, Indicator area should be displayed as Opacity,
Transparency, or sometimes Translucency according to the UX
requirements.
This requirement can be applied in case of fullscreen based menu and
fullscreen applications like video player etc.
Functional requirements:
1. User can set indicator's opacity mode as opacity, transparency, and
translucency
2. User can get the current indicator's opacity mode.
Currently there are no APIs for supporting the upper functional
requirements.
Thus, he added support for indicator's opacity mode.
It is designed for EFL developers easily to set the indicator's opacity
like the existing indicator's mode.
He added a Elm_Win_Indicator_Opacity_Mode structure variable into
Elm_Win
structure.
Meanwhile, new two APIs are implemented independently from the existing
source code.
Anybody please review this and apply it to upstream code.
SVN revision: 68958
things. Implement alpha_set, transparent_set, and ignore_events for
ecore_evas_wayland_EGL.
NB: Big fat warning ... don't try to use alpha_set for EE_Wayland_Egl.
It segfaults for some unknown reason. If anyone knows EGL code, please
feel free to have a look. Any help is appreciated here.
SVN revision: 68574
EFL applications as Wayland Clients.
NB: This (along with the ecore_evas changes) fixes most (if not all)
outstanding issues what I am aware of, including the nasty resize bug
with wayland_egl.
SVN revision: 68515
* use AC_COMPILE_IFELSE after AC_PROG_CC has been called
* use EFL_CHECK_TESTS after pkg-config has been checked
* enable ecore_evas_extn only if its dependencies are found
SVN revision: 68312
Subject: [E-devel][Patch][ecore_con] Fix invalid curl handle removal by valgrind
Date: Wed, 22 Feb 2012 19:57:36 +0900
Hello,
discomfitor reports bugs by valigrind. I checked it with valgrid and
I found the clues
curl_multi_remove_handle() should not be called when multi handles
being performed. So I removed curl_multi_remove_handle() code from
_ecore_con_url_info_read()
Now, curl_multi_remove_handle() is only called for all easy handles
when a multi-handle ended.
Please review this simple patch.
SVN revision: 68287
NB: These may not be entirely correct, but since I am the only one using
xcb (apparently), and I don't ever use the RandR stuff, they are
sufficient for now. I'll debug them later when I have more time.
SVN revision: 68219
NOTES: It is now safer and faster. I doubt I will have more time before the release to finish
ecore_thread_message_run, nor to make the shutdown nicer.
SVN revision: 68164
Subject: [E-devel] ecore_evas typedef patch src/lib
the attached patch adds
typedef void (*Ecore_Evas_Event_Cb) (Ecore_Evas *ee);
in Ecore_Evas.h and ecore_evas_private.h
Ecore_Evas_Event_Cb is then used within :
ecore_evas.c
ecore_evas_psl1ght.c
ecore_evas_win32.c
ecore_evas_wince.c
ecore_evas_x.c
SVN revision: 68140
SOCKS5 is different from SOCKS4 in that it supports password authentication mechanisms (GSSAPI is still on the todo) and IPV6, neither of which are possible with SOCKS4
NOTE THAT THE CMDLINE SYNTAX FOR AUTOSOCKSING HAS CHANGED!
* ECORE_CON_SOCKS_V4=[user@]server-port:lookup
* ECORE_CON_SOCKS_V5=[user@]server-port:lookup
also note that I did not implement autosocksing with password. it's just not safe.
SVN revision: 67959
Subject: Re: [E-devel] [Patch] ecore_ipc - remove potential risk in
ecore_ipc_shutdown
I found a problem this infinite loop case.
If server is deleted, then ECORE_IPC_EVENT_SERVER_DEL callback
function will be called in client side.
It will happen infinite loop in ecore_ipc_shutdown if
ecore_ipc_shutdown called in this ECORE_IPC_EVENT_SERVER_DEL callback
function.
For example,
server_del_handler =
ecore_event_handler_add(ECORE_IPC_EVENT_SERVER_DEL, _server_del_cb, NULL);
static Eina_Bool
_server_del_cb(void *data, int type, void *event)
{
ecore_ipc_shutdown();
return EINA_TRUE;
}
If server is deleted,
1. _ecore_ipc_event_server_del : svr->event_count++
2. _server_del_cb : ecore_ipc_shutdown called
3. ecore_ipc_shutdown : while (servers) ecore_ipc_server_del(eina_list_data_get(servers))
4. ecore_ipc_server_del : can't eina_list_remove(servers, svr) because event_count != 0
5. infinite loop
I think this while code is very dangerous whether user miss or not.
I modified EINA_LIST_FOREACH_SAFE instead of EINA_LIST_FOREACH refer
to ecore_con.
Please review this patch.
SVN revision: 67874
missing Logfn's. Add handler to free the mouse_move event when we're
done with it. Add a function to retrieve the 'last mouse button down
time' (needed for fixing surface move).
SVN revision: 67781
ecore_imf_context.c: In function ‘ecore_imf_context_event_callback_del’:
ecore_imf_context.c:1099:9: warning: ‘return’ with no value, in function returning non-void
ecore_imf_context.c:1109:26: warning: initialization discards qualifiers from pointer target type
SVN revision: 67585
Long time ago, in
http://www.mail-archive.com/enlightenment-devel@lists.sourceforge.net/msg32795.html
mail thread and IRC,
I talked with about problem of asynchronous event API such as
ecore_imf_context_commit_event_add,
ecore_imf_context_preedit_changed_event_add, so on.
In short, The problem is that key event and text_set APIs are processed
immediately, but commit event and preedit changed event is processed
asynchronously because those APIs add each event to ecore event queue.
To fix these problems, I've decided to create synchronous event APIs such
as ecore_imf_context_event_callback_add, del and call.
For considering compatibility, sync and async event callback functions are
used in xim and scim immodule.
SVN revision: 67290
Hello e people, i modified some comments to get less doxygen
warnings/errors.
Signed-Off-By: Guillaume Friloux <guillaume.friloux@asp64.com>
SVN revision: 67270
cannot depend on the order in which the interfaces are given to us, so
we cannot create the data_device until we have both the input device
and the data_device_manager. Fix that.
Add more dnd code (not complete yet because frankly, the way Wayland
handles dnd & selection code is crappy, stupid, and difficult to
implement).
SVN revision: 67247
divide each new functions to two part
which create ecore evas and create socket for upper layer.
socket: new and listen
plug: new and connect
SVN revision: 67238
Subject: [E-devel] [PATCH] fix build error of ecore_imf_xim when using --disable-xim option
Date: Mon, 9 Jan 2012 19:53:17 +0900
Hello, EFL developers.
When building ecore with --disable-xim option, build error occurs.
This patch will solve this build error problem.
Would you please review and apply in svn?
SVN revision: 67191
Add more work on dnd code (incomplete still).
NB: We will need to add a method to request non-argb surfaces. For
now, all surfaces are argb.
SVN revision: 67180
After we have set the new surface for the evas engine. Reason being:
The shell_surface_listener_configure event handles resizing the
ecore_evas. If that gets called Before we have set the new engine
surface, then bad crashes can happen.
SVN revision: 67161
Add a check for valid connection in ecore_xcb_icccm.c
NB: For some reason, XCB does not like ecore's timestamp which is
being passed in. Since all the calls to ecore_x_window_focus_at_time
are being passed the current timestamp anyway, just use
XCB_CURRENT_TIME until I have more available 'free time' to dig deeper
into this.
SVN revision: 67136
events).
Add big fat NB wrt potential 'hack' (works around screen garbage on
resize).
Add evas damage rectangle on resize.
Do surface_damage before surface_attach.
Prevent compositor crash on resize by checking width/height <= 0.
Don't do a resize of the ecore_evas unless the event matches.
SVN revision: 67013
Add variable to store what button was pressed (part of focus issue
fixes).
Fix focus handling (see comments about wayland pointer focus).
SVN revision: 66994
It is possible that several process want to show same canvas.
For support this, I changed Ecore buffer canvas to server(socket)
If some application want to show this canvas,
it create plug image object.
SVN revision: 66892
specific 'surface' and 'time'.
Add function (internal) to send a mouse_move (cleans up code).
Add event 'multi' stuff for mouse button down.
Fix handle_pointer_focus function to not send 'focus' events (handled
differently).
Fix handle_keyboard_focus function to actually send 'focus' to new
windows.
NB: This fixes most of the focus issues I was having earlier.
SVN revision: 66859
(_ecore_evas_mouse_move_process already feeds to evas).
Add variable to store the 'timestamp' of when mouse button gets
pressed (needed for 'moving' a surface).
SVN revision: 66808
Subject: [E-devel] [Patch][ecore_con] Fix return value checking
Date: Tue, 3 Jan 2012 10:01:17 +0900
Hi,
There is invalid return value checking of curl_multi_perform() in ecore_con_url.
Because CURLM_CALL_MULTI_PERFORM is also not CURLM_OK,
CURLM_CALL_MULTI_PERFORM checking should precede CURLM_OK checking.
It's simple fix. Please review this
--
BRs,
Kim.
SVN revision: 66771
Vincent Torri
ChunEon Park
Christopher Michael
Daniel Juyung Seo
Jérôme Pinot
Carsten Haitzler
Cedric BAIL
Sanjeev BA
Jonas M. Gastal
cnook
Jihoon Kim
Gustavo Sverzut Barbieri
이병우
Eric Schuele
Vikram Narayanan
Leif Middelschulte
Mike Blumenkrantz
Bluezery
Sebastian Dransfeld
myoungwoon kim
Samuel F. Baggen
Daniel Juyung Seo
Doyoun Kang
Jérémy Zurcher
윤정현
Rafael Fonseca
Tom Hacohen
Youness Alaoui
Guillaume Friloux
Jiyoun Park
Stefan Schmidt