Commit Graph

57519 Commits

Author SHA1 Message Date
Carsten Haitzler d26f2237f1 elm progressbar - fix val set
set initial min and max to 0 and 1 respectively so val set works at
the start...

fixes T6697

@fix
2018-02-10 16:44:35 +09:00
Carsten Haitzler 1d5de2e58e efl ui progressbar - no space between value and percent in default fmt
do you write 20 % or 20% ? :) no space by default. fix.
2018-02-10 16:44:03 +09:00
Carsten Haitzler dc8da37878 elm - make progress test code a little more solid and nice to read
use sizeof the buffer rather than constant in snprint and 0.5 rather
than .50 which almost looks like a typo... :) also use correct escape
for % (%%%% so it becoems %% which is correct for a fmt string yto
produce %)
2018-02-10 16:43:23 +09:00
Derek Foreman 712daf38db elm: Fix double shutdowns of ecore_x and ecore_wl2
This is now done elsewhere.  wayland clients were ERRing on shutdown.

ref 9cf61c2f6d
2018-02-09 11:25:41 -06:00
Derek Foreman 38d8ae0217 wayland_imf: Clear hide timer when deleting context
Otherwise the callback can fire after the module is unloaded leading to some
very entertaining to debug crashes at shutdown.
2018-02-09 11:12:07 -06:00
Stephen Houston a35d4a2cee Elm Progressbar test: Add in examples of efl regressions to progressbar. 2018-02-09 10:23:29 -06:00
Derek Foreman a221bec6d0 ecore_wl2: Destroy offscreen event handler in surface destroy
Or we can get the event after destroying the surface and crash.
2018-02-09 09:49:52 -06:00
Lauro Moura 9a4b8f3800 efl_mono: Distcheck fixes
- Export required sources
- Avoid generated sources being passed as static ones
2018-02-08 10:50:04 -03:00
Lauro Moura 17b9f00f7e eina_mono: Avoid calling eina_init directly from the modules.
They must be initialized from the eina.Config.Init() method.
2018-02-08 10:49:47 -03:00
Stefan Schmidt 22794846f4 ci: make sure we fail the build and pass on the non zero exit code
So far we just kept going on when one of the make targets failed with
the next one.
2018-02-08 11:45:15 +01:00
Sungtaek Hong b380e63b07 efl_part: call Efl.Text of each class' part
Summary:
Macro ELM_PART_TEXT_DEFAULT_IMPLEMENT calls
super class' Efl.Text interface, rather than this class.

Reviewers: jpeg, woohyun, Jaehyun_Cho, herdsman

Subscribers: cedric, id213sin

Differential Revision: https://phab.enlightenment.org/D5799
2018-02-08 11:37:51 +02:00
Sungtaek Hong 08d86d3941 efl_part: use efl_ui_widget's default_part_get
Summary:
efl_part macros are using each widget's internally defined
default_part_get() functions to get default part name.
This might potentially cause errors when future widgets
inherits the widget but not overriding Efl.Text.text and
Efl.Content.content.

Reviewers: jpeg, cedric, woohyun, Jaehyun_Cho

Differential Revision: https://phab.enlightenment.org/D5797
2018-02-08 14:53:59 +09:00
subhransu mohanty 48433efc43 ector: Updated the ector_buffer_pixels_set() api with stride info
Reviewers: jypark, jpeg

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D5795
2018-02-08 14:44:29 +09:00
Mike Blumenkrantz 80cc3f230d elm: remove ecore-x init from quicklaunch post-fork
this is invalid for basically every possible case. allow components
to naturally call this function as needed

@fix
2018-02-07 13:32:08 -05:00
Mike Blumenkrantz b7bec2ba9a elm: call ecore_app_args_set() after quicklaunch fork
ensure that apps get expected behavior when calling args_get()

@fix
2018-02-07 13:30:37 -05:00
Mike Blumenkrantz 49e47ac310 ecore-imf: do ecore-x init during ctx creation instead of module init
this avoids a number of issues with efl under wayland, msot notably the
automatic triggering of xwayland during every app startup

@fix
2018-02-07 12:12:22 -05:00
Mike Blumenkrantz 9cf61c2f6d elm: move ecore-x and ecore-wl2 connection init to selection manager
this seems to be the only place where the related components are
explicitly used

neither of these components have fork-safe connections, so there is no
benefit to calling them during quicklaunch init
2018-02-07 12:12:22 -05:00
Mike Blumenkrantz c4e5bbe441 elm: print error if setsid() fails during quicklaunch fork 2018-02-07 12:12:22 -05:00
Mike Blumenkrantz d55fc77cfa eio: remove broken pid-based monitor reset copied from ecore-file
this has no technical basis for existing and should be handled by
individual monitor backends

@fix
2018-02-07 12:12:22 -05:00
Mike Blumenkrantz 6a500331bd ecore: fix event flushing to not erase+leak events
stealing the message data here prevents events which aren't being flushed from
ever being usable again and is unnecessary since the free callback will be
automatically called during the destructor

ref 5dd52fd09b
2018-02-07 12:12:22 -05:00
Vincent Torri d54f0f66cf Evas: remove depth usage in GDI and DirectDraw engines
Test Plan: compilation and elementary_test

Reviewers: raster

Reviewed By: raster

Subscribers: cedric, raster

Differential Revision: https://phab.enlightenment.org/D5792
2018-02-07 22:20:20 +09:00
Jaehyun Cho 000d43b29e elm_part_helper: Fix to use registered default text part 2018-02-07 20:52:12 +09:00
Shinwoo Kim fd8e9f9c4e Efl.Ui.Nstate: do not call "changed" callback
Before solving following problem in Efl.Ui.Check

https://phab.enlightenment.org/T6673

The changed callback is called with opposite value,
if application is using Efl.Ui.Check with state pointer.

The reason is that the changed callback is called in
efl_ui_nstate_activate, and the value refered by state pointer
is changed only after the efl_ui_nstate_activate is called.

static void
_activate(Evas_Object *obj)
{
   EFL_UI_CHECK_DATA_GET(obj, sd);

   efl_ui_nstate_activate(obj);
   if (sd->statep) *sd->statep = efl_ui_nstate_value_get(obj);
2018-02-07 16:25:36 +09:00
WooHyun Jung d8aa950a38 evas_object_textblock: add null checks for EAPIs 2018-02-07 14:19:46 +09:00
Myoungwoon Roy, Kim b203ff1878 ecore_event: Fix a break of consistency of return data
Summary:
This patch fixes a break of consistency of return data from ecore_event_del.
Before EFL 1.20, when calling ecore_event_add(ECORE_EVENT_SIGNAL_USER, event_data, NULL, &data);
The user data(data) is saved at event->data. and when user calls ecore_event_del(event_handler),
ecore_event_del returns event->data. However, current ecore_event_del returns pd->ev.
I think it is ABI break.

Test Plan: Execute test suite

Reviewers: cedric, raster, stefan_schmidt, Jaehyun_Cho

Reviewed By: Jaehyun_Cho

Differential Revision: https://phab.enlightenment.org/D5786
2018-02-07 13:50:24 +09:00
Chris Michael e93f7bce30 ecore-drm2: Ensure output changed event is sent for removed outputs
If an output gets disconnected, we would still like to be notified of
that. In the _outputs_update function, we mark an output as
disconnected by setting output->connected and output->enabled to
FALSE. With this line in place (in the output_event_send function) we
would never get notified if an output was disconnected.

@fix

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2018-02-06 13:01:25 -05:00
Carsten Haitzler 8a296cb90f disable async mode (use sync mode) for ibus when keymap changes
so scenario:

1. use ibus
2. have at least english input and japanese input (or korean etc.)
3. have 2 kbd layouts (english and greek).
4. enable "use system keyboard layout" in ibus advanced settings
5. switch to english input mode
6. switch to greek key layout
7. type and get english, not greek input as you should

@fix for both terminology and elm/efl entry/ytext input.
2018-02-07 01:16:59 +09:00
Shinwoo Kim b1ee35e35c elm: do not call "changed" callback when setting style 2018-02-06 22:40:11 +09:00
Amitesh Singh 0aca43be23 efl.ui.progressbar: add checks for min & max value
this improves the validity check for min & max values
provided from user side.
2018-02-06 22:35:33 +09:00
Jean-Philippe Andre 27c0d53f9b efl_ui: Disable includes that don't compile
Efl.Ui.Text:
The EO file contains a lot of references to legacy Elm types, which are
defined in elm_general. They should be checked and moved over to
efl_ui.eot if necessary.

Efl.Ui.Multibuttonentry:
This class was originally supposed to be based on a Model Item but as of
now the API is still uncertain, so MBE itself hasn't been worked on
more. Disable this from EO-only apps until its API is fixed.

Ref T6666
2018-02-06 21:27:37 +09:00
Hosang Kim 24b0ae0df5 ecore/evas: add NULL checks to handle argument is NULL.
Summary:
ecore_pipe_read_fd/ecore_pipe_write_fd
evas_engine_info_set/get

Reviewers: woohyun, Jaehyun, Jaehyun_Cho, jpeg

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D5790
2018-02-06 17:58:44 +09:00
WooHyun Jung 1accec4ce1 evas: add null checks to handle when e->engine.func is not set yet 2018-02-05 22:19:44 +09:00
Shinwoo Kim bb5f4aa857 eina_tiler: fix typo of rect comparing 2018-02-05 20:02:06 +09:00
Mike Blumenkrantz 26d73cbae1 eio: make inotify monitors fork-safe
@fix
2018-02-02 16:59:44 -05:00
Mike Blumenkrantz 5760b3f335 eeze: simplify watch code and make it fork-safe
avoid reads from parent process's udev fds
2018-02-02 16:59:44 -05:00
Mike Blumenkrantz 7927cfefe3 ecore-file: make monitoring truly fork-safe
add a fork reset callback and attempt to preserve existing monitors
during reset

@fix
2018-02-02 16:59:44 -05:00
Mike Blumenkrantz 4e14ba3f48 elm: call ecore_event_init() during init
events from this component are used internally in elm, don't rely on
other components to do it

@fix
2018-02-02 16:59:44 -05:00
Mike Blumenkrantz edd0d75e03 ecore: make dbus-using modules fork-safe
reset dbus connections to ensure continued functionality
2018-02-02 16:59:44 -05:00
Mike Blumenkrantz 95a339733a eldbus: make connections fork-safe
after a fork, any existing connection objects can no longer be used,
but it's up to the user to destroy them. internally, this prevents
existing connections from ever being returned as valid connections
and creates new ones after a fork

also destroy fd handlers for connections to ensure that no data is
accidentally clobbered before the connections are cleaned up
2018-02-02 16:59:44 -05:00
Mike Blumenkrantz 10ce0cbd8a efreet: reset ipc connection after fork
ensure that existing connection is not reused
2018-02-02 16:59:44 -05:00
Mike Blumenkrantz aaf3659faf eldbus: do not require error return when adding/removing signal matches
this forces the functions to be synchronous and blocks (potentially forever)
2018-02-02 16:59:44 -05:00
Mike Blumenkrantz c0b3a0b562 quicklaunch: use XDG_RUNTIME_DIR instead of hardcoded /tmp 2018-02-02 16:59:44 -05:00
Mike Blumenkrantz 7f0a4154f5 efl-wl: add function for passing ecore-exe flags to launched exes
@feature
2018-02-02 16:59:44 -05:00
Mike Blumenkrantz 32c293bea4 efl-wl: no need to check exe tag on app del, just remove pid always 2018-02-02 16:59:44 -05:00
Mike Blumenkrantz e8d24596a6 efl-wl: add functions for managing allowed client pids
@feature
2018-02-02 16:59:44 -05:00
Shinwoo Kim 3c38071745 elm: fix typo - remove line to debug 2018-02-02 19:07:04 +09:00
Shinwoo Kim 610eee1e52 elm: use Dbus securely
The Efl.Access.Attribute is using key and value.
The value could be NULL. If the value is NULL, then following error occurs.

*error:
arguments to dbus_message_iter_append_basic() were incorrect,
assertion "_dbus_check_is_valid_utf8 (*string_p)" failed
in file ../../dbus/dbus-message.c line 2712.
This is normally a bug in some application using the D-Bus library.
Array or variant type requires that type string be written, but end_dict_entry
was written.
The overall signature expected here was 'a{ss}' and we are on byte 3 of that
signature.
2018-02-02 18:56:58 +09:00
Radoslaw Cybulski cc2e43cc4b elm: fix for invalid attribute matching
Summary:
Fixes invalid attribute matching in at-spi's collection interface's GetMatches***
functions.

Reviewers: stanluk

Reviewed By: stanluk

Subscribers: lukasz.stanislawski, cedric

Differential Revision: https://phab.enlightenment.org/D5774
2018-02-02 09:05:13 +01:00
Vincent Torri d4fcff7ed4 evil: final step : remove completely the binary, useless now that the unit test is theree
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2018-02-01 13:28:36 -08:00
Daniel Hirt a89c9e037a Ui layout: fix another text retrieval line of code
This is a follow-up to a44ae48df811ff2bd085da86db1688c0f387efc4.Need to
undo the markup_get call, so that the correct code path
(_efl_ui_layout_text_set) is used. Legacy checks are in that code path.

ref T6642
2018-02-01 19:24:44 +02:00