typecast const char * to void * and pass ptr to free() since it doesn't modify the value pointed to,
either conceptually or in practice, it merely looks up the memory block using the pointer and deallocates it.
@fix
if a content's size hints change, reapplying the list's size hints
to override existing hints is required to prevent some list items from
having a bad layout
@fix
Summary: In "compile with" comment, filenames are different from the actual ones.
Reviewers: cedric, Oleksander, Hermet
Reviewed By: Oleksander, Hermet
Differential Revision: https://phab.enlightenment.org/D3722
Summary:
move focus out of genlist by pressing "up" key when no item
is selected.
Test Plan: elementary_test -to fileselector
Reviewers: SanghyeonLee, cedric, Jaehyun_Cho, Hermet
Reviewed By: Hermet
Subscribers: Hermet
Differential Revision: https://phab.enlightenment.org/D3721
Summary:
fix the wrong operation of mirrored set.
when mirrored set is applied, notify change the theme using mirrored flag.
however, it is unnecessary operation.
@fix
Reviewers: Hermet, kimcinoo
Reviewed By: kimcinoo
Differential Revision: https://phab.enlightenment.org/D3700
Summary: No use of top object if not editable.
Reviewers: cedric, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D3719
Move declarations of types used in elm_widget.eo to elm_general.eot and
elm_widget.eo.
Give them a Eolian name and use it instead of the old ones.
Correct the type name of some other types used as method parameters, by
using the Eolian names instead of legacy/generated names.
Reorganize the positions of elm_widget.eo.h inclusion and
of callback type declarations in elm_widget.h.
This make a clearer distinction of the types in elm_widget.h that are
still required in elm_widget.eo.h.
using requested size may not be correct, so use real size. this should
solve issues in some wm's and actually also solved some kind of object
size lag in wayland too.
@fix - onward from 79b6edd1a6ad763258337b7aac5bd7799411bb44
Summary:
- icon param add an elm_icon and content set to icon part.
- entry's style is changing as other params are set and
icon part may not exist in certain condition(default has no icon part)
- checking icon param later than other params will set icon part
after the style is changed.
Reviewers: cedric, woohyun, jpeg, herdsman, tasn
Reviewed By: tasn
Subscribers: conr2d
Differential Revision: https://phab.enlightenment.org/D3693
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
when using a touchpad or frictionless mouse wheel, it becomes impossible
to accurately use a scroller which accelerates as scrollers on mobile devices
do. by setting this new option to 0, acceleration can be disabled and regular
behavior can be restored
ref 2ac2628612060114cf6e5205e5331044221178c6
@feature
when I scroll on a computer, I want my app to respond immediately. I don't
want to wait for it to finish scrolling and I don't want to have to guess
where the scroll will end.
ref 2ac2628612060114cf6e5205e5331044221178c6
@feature
we dont set this config by default so we dont see this - but a window
starts as withdrawn then becomes normal. this means the window starts
not rendering and may take 0.5 seconds to START because the eval is
deferred by 0.5 sec to avoid rapid switch to/from norender and other
states.
@fix
this fixes excess callbacks on window (and content) objhects resizing
down then back up again when windows are forcibly resized like
fullscreen, maximized and remembered windows.
@fix
Summary:
When there are no items in genlist/gengrid, highlight stays at one dot of
top-left corner. This patch makes genlist/gengrid itself highlighted
when there are no items.
Reviewers: jpeg, SanghyeonLee
Differential Revision: https://phab.enlightenment.org/D3701
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
elm.swallow.background part will be a default part for
widget's background image.
When entry widget's scrollable status is changed,
the background object will be moved to scr_edje or entry_edje.
Test Plan: N/A
Reviewers: kimcinoo, woohyun, cedric
Differential Revision: https://phab.enlightenment.org/D3677
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Do not allow invalid input in to spinner.
Invalid Input can be:
1. '-' should not be inserted anywhere but the starting position, and no more than one '-' can be inputted.
2. No more than one '.' can be inserted.
Signed-off-by: Shilpa Singh <shilpa.singh@samsung.com>
@feature
Test Plan:
1. Launch elementary test
2. Run spinner demo
3. Enter invalid inputs like inserting more than one '.', '-' or insert '-' anywhere else part from 1st position.
Reviewers: raster, CHAN, subodh6129, cedric
Subscribers: govi, buds
Differential Revision: https://phab.enlightenment.org/D3664
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
this is unnecessary: every single engine unsets the cursor when the object
has been deleted
this deletes enlightenment's cursor object
ref 678437003f219f783ba14859a805ea27997470fd
@fix
this was previously disabled for internal list objects, and now
it is disabled for all subobjects of ctxpopup. applying focus here
invokes every possible focus bug in elementary and prevents the application
from being useful in any way
ref 974c8b05a4c97367b636593f5420ff01e8364aac
ref T3088
@fix
Add elm_gengrid_item_all_contents_unset API for support content reuse
and unset. User can get back content objects in unrealized smart callback in item.
see elm_genlist_item_all_contents_unset also.
@feature
elm_transit_revert_go() sounds like it triggers animation on reverse way.
but this api acutally just change a current state.
It doesn't trigger the transtion.
when adding new methods to public interface structs (such as item class),
the version must be bumped and checked in the new interface method calls
in order to avoid breaking abi for previously-compiled apps
ref 4c86a66f28876b68e92a90c8f741eed1130dd034
Summary:
Set any illegal format, spinner crashes, the format set to spinner
has to be valid hence a check is added initially itself to check for validity of
label formats.
Signed-off-by: Shilpa Singh <shilpa.singh@samsung.com>
Test Plan:
1. Set illegal format to spinner for e.g: elm_spinner_label_format_set(sp, "d");
2. Run spinner demo
Crash is observed
Reviewers: cedric
Subscribers: govi, buds
Differential Revision: https://phab.enlightenment.org/D3668
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Fix vertical drag style and logic.
For vertical spinner graggable should move
in y direction and since drag value is inverse
of spinner increment and decrement so delta should be inversed.
@fix
Test Plan:
1. Elementary test
2. Vertical spinner
Reviewers: cedric
Projects: #elementary
Differential Revision: https://phab.enlightenment.org/D3662
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
- elm.swallow.background is a part reserved for customized bg.
- When default bg image is already set, default bg has to be hidden when customized bg is set.
- Emitting signal when a content is set to this part makes this hiding process a lot easier.
Reviewers: kimcinoo, cedric
Subscribers: cedric, kimcinoo
Differential Revision: https://phab.enlightenment.org/D3653
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
In spinner's entry allow numbers only with in min/max range
Signed-off-by: Shilpa Singh <shilpa.singh@samsung.com>
@feature
Test Plan:
1. Set min/max value to spinner
2. Enter numbers beyond min/max value
Reviewers: CHAN, cedric
Reviewed By: cedric
Subscribers: subodh6129, buds, govi, CHAN, cedric, raster, id213sin
Differential Revision: https://phab.enlightenment.org/D3265
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Add new Item Class function reusable_content_get for improve genlist
performance.
If user want to reuse specific part contents, return old content
which was passed by parameter of rreusable_content_get function.
genlist will automatically caching those contents when item unrealized,
and reusing it on item realizing.
reusable_content_get will be performed content_get with old object caching.
But if user return NULL in reusable_content_get, content_get is called to
get new object.
This feature is refered in Task T2813
@feature
Test Plan: add test in genlist 1 case.
Reviewers: raster, singh.amitesh, cedric
Reviewed By: cedric
Subscribers: smohanty, seoz, woohyun, Hermet, eagleeye
Differential Revision: https://phab.enlightenment.org/D3252
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Already, there is a way to set a selection region:
elm_entry_select_region_set()
The get() API also useful and there is needs for this
inside of elm_entry.c. Add the API and replace codes
in atspi_text_selection_get with the API.
@feature
Test Plan:
1. Run "elementary_test -to entry3"
2. Make a selection on text.
3. Press "Sel" button.
Reviewers: tasn, herdsman, cedric, woohyun, Jaehyun, Hermet
Subscribers: Hermet
Differential Revision: https://phab.enlightenment.org/D3639
Summary:
Although items' size hint align are not set to fill,
Elm.Box expands its items.
This patch fixes item sizing error.
Test Plan: attached sample
Reviewers: cedric, jpeg, Hermet, Jaehyun, Jaehyun_Cho
Differential Revision: https://phab.enlightenment.org/D3667
Move structs, enums and typedefs definitions from
elm_interface_atspi_accessible.h to elm_interface_atspi_accessible.eo.
Give them namespace names to conform with Eolian policies.
Replace all occurrences in elm_interface_atspi_accessible.eo with the
Eolian names.
Adjust include order in elm_interface_atspi_accessible.h to avoid
errors.
Move definition of Elm_Glob_Match_Flags from elm_gen.h to
elm_general.eot.
Use the Eolian name Elm.Glob.Match_Flags and replace the older name
by it in all .eo files.
Keep the legacy prefix "ELM_GLOB_MATCH".
Move the definition of Elm_Gen_Item_Class from elm_gen.h to
elm_general.eot.
Also move the definition of its aliases Elm_Gengrid_Item_Class and
Elm_Genlist_Item_Class from elm_gengrid_common.h and
elm_genlist_common.h to elm_general.eot.
Rename these types to Elm.Gen.Item.Class, Elm.Gengrid.Item.Class and
Elm.Genlist.Item.Class to follow Eolian standards. And rename all
occurrences in .eo files accordingly.
Put elm_gen.h include above elm_general.h to allow the callback fields
to be defined in elm_general.eot.
Move elm_calendar and elm_datetime struct tm typedefs to theirs
respective .eo files.
Use Ecore.Time, an alias to struct tm, to refer to this type in the
.eo files.
Use namespaced names for these typedefs, in order to follow Eolian
standards.
Move the definition of the enumeration Elm_App_View_State from
elm_app_common.h to elm_general.eot, and give it the the Eolian name:
Elm.App.View_State.
Replace Elm_App_View_State with Elm.App.View_State in
elm_app_client_view.eo and elm_app_server_view.eo.
Summary:
The enginelist[0] can be NULL in some very rare cases.
Then enginelist[0] will be used for strcmp and it make a crash.
@fix
Test Plan: N/A
Reviewers: raster, cedric, woohyun, jypark, jaehwan
Differential Revision: https://phab.enlightenment.org/D3649
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
When edje external parts add its content, edje object is added,
but it breaks elementary widget hierarchy.
In Elementary, edje external can use Elm.Layout to add its content.
Reviewers: cedric
Reviewed By: cedric
Subscribers: woohyun
Differential Revision: https://phab.enlightenment.org/D3655
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Currently the feature available in transit to reverse play a transition is
auto-reverse which will play a transition in reverse mode once a transition
is complete. This feature helps the user to revert a transition at any point
of time when transition is going on.
New API added.
@feature T3019
Use Case:
While doing pinch zoom, we will be doing zoom transit effect from one step to other, during that transit if user do the pinch in reverse direction this API can be called so that transition will be reverted easily.
Signed-off-by: godly.talias <godly.talias@samsung.com>
Test Plan: elementary_test Transit Resizing / Transit Zoom / Transit Bezier / Transit Custom / Transit Fade / Transit Flip
Reviewers: raster, prince.dubey, shilpasingh, Hermet, seoz, cedric
Subscribers: rajeshps, govi
Differential Revision: https://phab.enlightenment.org/D3567
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Existing key_action_move logic used elm_widget_focus_cycle on hover,
but only handled the first and last item to move focus circularly.
So if the first or last item is disabled, focus movement is blocked.
This patch makes hoversel handle focus movement by itself to handle
disabled item better.
Test Plan: elementary_test -to hoversel
Reviewers: Hermet, cedric, Jaehyun
Differential Revision: https://phab.enlightenment.org/D3640
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Hover dismiss animation takes 0.5 sec to complete. if the genlist item_count
becomes zero, empty swallow is shown in dismiss animation.
@fix T3124
Signed-off-by: divyesh purohit <div.purohit@samsung.com>
Test Plan:
please run combobox example from elementary_test.
Open hover by pressing on left side button of combobox or pressing "enter/space" key in entry
contained in combobox.
Type a char which is not in any genlist item , for example "a' is not presented in any genlist
item.
empty swallow shouldn't seen in dismiss animation.
Reviewers: shilpasingh, cedric, raster
Subscribers: rajeshps, govi
Maniphest Tasks: T3124
Differential Revision: https://phab.enlightenment.org/D3630
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Pressing "Delete" Key in MBE layout causes Segfault as MBE item is not deleted properly and also focus is not transferred back to MBE.
@fix
Signed-off-by: divyesh purohit <div.purohit@samsung.com>
Test Plan: Run MultibuttonEntry example from elementart_test . Add some MBE items, now press the delete key, it should delete items without causing segfaults and transfer focus to previous MBE item.
Reviewers: raster, cedric, CHAN, shilpasingh
Reviewed By: shilpasingh
Subscribers: rajeshps, govi
Differential Revision: https://phab.enlightenment.org/D3635
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
When magnifier is moved across corners and outside entry, working of magnifier
is not proper.
Magnifier is Restricted with in the window and to entry area and its position depends
on cursor.
Signed-off-by: Thiep Ha <thiepha@gmail.com>
Signed-off-by: Shilpa Singh <shilpa.singh@samsung.com>
@fix
Test Plan:
1. Enable Magnifier export ELM_MAGNIFIER_ENABLE=1
2. Launch elementary test and launch entry3 demo
3. Move magnifier on corners and outside of second entry
The contents of magnifiers are undefined when moved outside entry
and clipper moves in a different direction as magnifier.
Reviewers: cedric, raster, thiepha
Reviewed By: thiepha
Subscribers: buds, govi, rajeshps, subodh6129
Differential Revision: https://phab.enlightenment.org/D3586
Summary:
Its really weird to call same job for each item and deletes that job in
next iteration. Since item_update() deletes the old update_job ecore job
again so basically we call update job only for the last realized item in the list.
@fix
Reviewers: raster, jpeg, cedric, SanghyeonLee, tasn
Reviewed By: SanghyeonLee
Subscribers: seoz
Projects: #elementary
Differential Revision: https://phab.enlightenment.org/D3644
Summary:
Even MBE item lose focus, item state did not changed before.
So i send a signal to make item state as default when item lose own focus.
Signed-off By: Kumar Navneet <k.navneet@samsung.com>
@fix
Test Plan:
Run MBE sample.
Click any item.
Click out of MBE area.
See the item still got a highlight.
Reviewers: Hermet, cedric
Differential Revision: https://phab.enlightenment.org/D2994
Conflicts:
data/themes/edc/elm/multibuttonentry.edc
Summary: After today mark appear once on calendar, it never disappear when user change calendar's year or month
Test Plan: elementary_test calendar2
Reviewers: Hermet
Differential Revision: https://phab.enlightenment.org/D3612
Summary:
Add mark_del as a method in the Elm.Calendar class.
Move the elm_calendar_mark_del() function (which do not receive an Eo object)
to elm_calendar_legacy.h.
Move the declaration of Elm_Calendar_Mark to elm_calendar.eo as an opaque
struct.
Rename it to Elm.Calendar.Mark to follow eolian standards.
Update documentation to refer to mark_del method instead of the
elm_calendar_mark_del() function.
Reviewers: felipealmeida, vinipsmaker, larryolj, cedric, tasn
Reviewed By: tasn
Differential Revision: https://phab.enlightenment.org/D3582
Summary:
Fix item selection using selection handler
In case of selection using handler, there is a problem in case the entry
has the item, mouse down over handler consider the current down
coordinate to start selection and it becomes very difficult to select in the
situation shown in the test plan. So I consider the next/previous line
geometry to fix it.
@fix
Test Plan:
1.Enable selection handler
2. Have a look at the setup in the attached image
{F27396}
3. Start selecting from last item and extent to cover the last text.
4.Observe that its impossible to select the last text until you move mouse out of the window
So, in mobile device its almost impossible to select using handlers in this situation.
Please use the attached application to test it.
{F27402}
Reviewers: thiepha, herdsman, tasn
Reviewed By: tasn
Subscribers: shilpasingh
Differential Revision: https://phab.enlightenment.org/D3479
Summary: Use edje api and simplify empty check logic
Test Plan: NA
Reviewers: herdsman, tasn
Reviewed By: tasn
Subscribers: shilpasingh, cedric
Differential Revision: https://phab.enlightenment.org/D3505
This cleans up orphan icons being left in the UI if you call icon_set
after the toolbar has been displayed.
This was most noticable if the toolbar or buttons move first
@fix
Summary:
Continouous clicks on hover would need to ensure that variable
on_dismiss of combobox_vertical style in hover.edc should 0 when slot is being shown, otherwise events
would be disabled on hover even though swallow content is shown.
@fix
Signed-off-by: Divyesh Purohit <purohit.div@gmail.com>
Test Plan:
Click continouosly on combobox and events on hover would be
disabled.
Reviewers: cedric
Differential Revision: https://phab.enlightenment.org/D3601
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
This patch @fix this usage example:
0. image obj create
1. file_set(an animated gif)
2. animated_set(TRUE) + animated_play_set(TRUE) to make the gif play
3. file_set(a normal image)
... at this point elm_image is confused because it still think that the image is animated
4. file_set(an animated gif)
5. animated_set(TRUE) + animated_play_set(TRUE) to make the gif play
...this now do not work because elm think that the image is already animated
_elm_combobox_elm_genlist_filter_set function does not use the Eo *obj
parameter so mark it as EINA_UNUSED to remove compiler warning
Signed-off-by: Chris Michael <cpmichael@osg.samsung.com>
In the case of a genlist set as ELM_OBJECT_SELECT_MODE_ALWAYS the "selected" cb was called 2 times. This @fix that by skipping the selection code in case the click is not the first one (EVAS_BUTTON_NONE).
Also merge the conditions of two consecutive "if" in a single statement.
To reproduce:
* elm_test -to "GenGrid Focus"
* turn on the "Focus Highlight" checkbox
* double-click an item to show a popup that should have the focus
As you can see the mouse-up event on the gengrid item steal the focus from the popup.
When, instead, the item is activated with the keyboard the popup correctly keep the focus.
I have this problem in both genlist and gengrid, so probably the error is not in the gengrid code, but somewhere else that I cannot find.
...any help appreciated
Summary:
Initially combobox used hover's default style, this patch would make combobox use hoversel_vertical style.
@Fix T3075 for 2nd point.
Signed-off-by: divyesh purohit <div.purohit@samsung.com>
Test Plan: please run combobox example from elementary_test
Reviewers: shilpasingh, cedric, raster
Subscribers: rajeshps, govi
Maniphest Tasks: T3075
Differential Revision: https://phab.enlightenment.org/D3596
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Before this patch, the filter was set inside the combobox. This is confusing for the
user of the object as it can't define a custom filter except on strings. It is also
impossible to bind as binding require to know what was put in and they can't differentiate
between a genlist filter being set from the binding to one being set internally by
the combobox.
@fix
genlist item is flaoting upon the expanded item when homoegeneous mode
is enabled.
when item block is recalculated by tree expanding, new item didn't
update their properties and values becuase of size hash, but edc
actaully need to be recaculated after swallowing tree size padding.
solve the issue by adding expand depth check in size hash.
you can check the previous issue in T2708
elementary_test->genlist tree->homoegeneous check
@fix
This @fix three (yes 3!) errors from commit cafda5928f9bf8116564219dc03d12c3a6e131b3
1. the initial value in the standard config is wrong, causing ctx menu to be disabled for everyone!
2. the argument of the api should be named "disabled" (like all the other disable API in this context)
3. (minor) fixed doc for elm_config_context_menu_disabled_set
NOTE: there are no configuration gui for this option, if you cleared your elm config recently you probably now have the ctx menu disabled everywhere, only solution is to wipe your config (to let elm create a new correct one)
Big SPANK to the author, the commiter and all the reviewers of D2463!!!
Summary:
While applying scroller on hoversel, several lines for item size
calculation were added, but they failed to have item get proper size.
Now redundant codes are removed and some are fixed, and hoversel will
be shown more well-ordered.
Test Plan: elementary_test hoversel
Reviewers: jpeg, raster, cedric
Differential Revision: https://phab.enlightenment.org/D3589
Summary:
This patch will reduce duplicate codes and code depth for readability
Signed-off-by: Minkyu Kang <mk7.kang@samsung.com>
Reviewers: seoz, Hermet, cedric
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D3574
When using this function with wayland windows, we should be returning
the matching Ecore_Wl2_Window id, not the surface_id
ref T3058
@fix
Signed-off-by: Chris Michael <cpmichael@osg.samsung.com>
There is no need to recalc row and col position of the item, they are already stored in the item struct.
The old implementation was calculating wrong values and also was storing this wrong values in it->x and it->y, resulting in wrong results for the elm_gengrid_item_pos_get() function.
so, at the end, this is a @fix for the pos_get() function.
Also changed a bit the test to let the gengrid fill the window and thus testing behaviour on col/row changes.
I didn't find any regression in all the gengrid tests after this, let me know if it broke something for you.
Issue:
1. elementary_test -> slider
2. move mousewheel on slider and popup gets shown.
3. close the slider window very fast or increase the wheel_timeout to 4 seconds
4. observe crash
deleting subobjects here was occurring and triggering sizing eval
prior to removing the objects from the evas box, resulting in a failure
to accurately calculate and set size hints
also set delete_me to block sizing evals during subobj deletion loop
in order to avoid object thrashing during the time when nothing is happening
@fix
Mike Blumenkrantz
Amitesh Singh
Hermet Park
Larry
Jee-Yong Um
taehyub
Subodh Kumar
Minkyu Kang
Vitor Sousa
Carsten Haitzler
Stefan Schmidt
SungTaek Hong
Oleksandr Shcherbina
Vyacheslav Reutskiy
Youngbok Shin
Shilpa Singh
Vitalii Vorobiov
SangHyeon Lee
Jee-Yong Um
Prince Kumar Dubey
Cedric BAIL
Godly T Alias
divyesh purohit
Thiep Ha
Felipe Magno de Almeida
woochan lee
Jinyong Park
Jean-Philippe Andre
Andy Williams
Divyesh Purohit
Davide Andreoli
Chris Michael
Jaehyun Cho
Daniel Juyung Seo